[GitHub] [carbondata] akkio-97 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort compaction failure on timestamp column

2020-01-12 Thread GitBox
akkio-97 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort 
compaction failure on timestamp column
URL: https://github.com/apache/carbondata/pull/3515#issuecomment-573545146
 
 
   please review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert.

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later 
optimize insert.
URL: https://github.com/apache/carbondata/pull/3538#issuecomment-573543047
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1622/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort compaction failure on timestamp column

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort 
compaction failure on timestamp column
URL: https://github.com/apache/carbondata/pull/3515#issuecomment-573538051
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1621/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table

2020-01-12 Thread GitBox
Indhumathi27 commented on a change in pull request #3568: [CARBONDATA-3658] 
Prune and Cache only Matched partitioned segments for filter on Partitioned 
table
URL: https://github.com/apache/carbondata/pull/3568#discussion_r365667973
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/indexstore/SegmentPropertiesFetcher.java
 ##
 @@ -34,7 +35,7 @@
* @return
* @throws IOException
*/
-  SegmentProperties getSegmentProperties(Segment segment)
+  SegmentProperties getSegmentProperties(Segment segment, List 
partitionSpecs)
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table

2020-01-12 Thread GitBox
Indhumathi27 commented on a change in pull request #3568: [CARBONDATA-3658] 
Prune and Cache only Matched partitioned segments for filter on Partitioned 
table
URL: https://github.com/apache/carbondata/pull/3568#discussion_r365667992
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapFactory.java
 ##
 @@ -81,19 +82,20 @@ public abstract DataMapBuilder createBuilder(Segment 
segment, String shardName,
   /**
* Get the datamap for all segments
*/
-  public Map> getDataMaps(List 
segments)
-  throws IOException {
+  public Map> getDataMaps(List 
segments,
+  List partitions) throws IOException {
 Map> dataMaps = new HashMap<>();
 for (Segment segment : segments) {
-  dataMaps.put(segment, (List) 
this.getDataMaps(segment));
+  dataMaps.put(segment, (List) 
this.getDataMaps(segment, partitions));
 }
 return dataMaps;
   }
 
   /**
* Get the datamap for segmentId
*/
-  public abstract List getDataMaps(Segment segment) throws IOException;
+  public abstract List getDataMaps(Segment segment, List 
partitions)
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 
Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573534758
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1620/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3474: [CARBONDATA-3592] Fix query on bloom in 
case of multiple data files in one segment
URL: https://github.com/apache/carbondata/pull/3474#issuecomment-573532157
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1616/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3565: [CARBONDATA-3662]: Changes to show metacache command

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3565: [CARBONDATA-3662]: Changes to show 
metacache command
URL: https://github.com/apache/carbondata/pull/3565#issuecomment-573532037
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1615/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort compaction failure on timestamp column

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort 
compaction failure on timestamp column
URL: https://github.com/apache/carbondata/pull/3515#issuecomment-573518677
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1619/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server

2020-01-12 Thread GitBox
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 
Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573517893
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] akashrn5 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server

2020-01-12 Thread GitBox
akashrn5 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 
Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573515731
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] kunal642 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server

2020-01-12 Thread GitBox
kunal642 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 
Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573515669
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] akashrn5 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server

2020-01-12 Thread GitBox
akashrn5 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix 
query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573515731
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] kunal642 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server

2020-01-12 Thread GitBox
kunal642 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix 
query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573515669
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] vikramahuja1001 commented on issue #3565: [CARBONDATA-3662]: Changes to show metacache command

2020-01-12 Thread GitBox
vikramahuja1001 commented on issue #3565: [CARBONDATA-3662]: Changes to show 
metacache command
URL: https://github.com/apache/carbondata/pull/3565#issuecomment-573515090
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] kunal642 commented on issue #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment

2020-01-12 Thread GitBox
kunal642 commented on issue #3474: [CARBONDATA-3592] Fix query on bloom in case 
of multiple data files in one segment
URL: https://github.com/apache/carbondata/pull/3474#issuecomment-573514651
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort compaction failure on timestamp column

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort 
compaction failure on timestamp column
URL: https://github.com/apache/carbondata/pull/3515#issuecomment-573512950
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1614/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] zzcclp commented on a change in pull request #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-12 Thread GitBox
zzcclp commented on a change in pull request #3576: [CARBONDATA-3514] Support 
spark 2.4 integration
URL: https://github.com/apache/carbondata/pull/3576#discussion_r365590190
 
 

 ##
 File path: build/README.md
 ##
 @@ -25,11 +25,9 @@
 * [Apache Thrift 0.9.3](http://archive.apache.org/dist/thrift/0.9.3/)
 
 ## Build command
-Build with different supported versions of Spark, by default using Spark 2.2.1 
to build
+Build with different supported versions of Spark, by default using Spark 2.4.4
 
 Review comment:
   default version is spark 2.3.4. will it use spark 2.4 as default version?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] zzcclp commented on a change in pull request #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-12 Thread GitBox
zzcclp commented on a change in pull request #3576: [CARBONDATA-3514] Support 
spark 2.4 integration
URL: https://github.com/apache/carbondata/pull/3576#discussion_r365590114
 
 

 ##
 File path: build/README.md
 ##
 @@ -25,11 +25,9 @@
 * [Apache Thrift 0.9.3](http://archive.apache.org/dist/thrift/0.9.3/)
 
 Review comment:
   currently it requires JDK 8, please modify too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3576: [CARBONDATA-3514] Support spark 2.4 
integration
URL: https://github.com/apache/carbondata/pull/3576#issuecomment-573414073
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1613/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-12 Thread GitBox
jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize 
Carbon SparkExtensions
URL: https://github.com/apache/carbondata/pull/3574#discussion_r365581997
 
 

 ##
 File path: pom.xml
 ##
 @@ -103,7 +103,6 @@
 integration/spark-datasource
 integration/spark2
 integration/spark-common-test
-integration/spark-carbon-common-test
 
 Review comment:
   Are all the testcases moved to spark-common-test module?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-12 Thread GitBox
jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize 
Carbon SparkExtensions
URL: https://github.com/apache/carbondata/pull/3574#discussion_r365581850
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonExtensionSpark2SqlParser.scala
 ##
 @@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.parser
+
+import scala.language.implicitConversions
+
+import org.apache.spark.sql.catalyst.plans.logical._
+import org.apache.spark.sql.catalyst.CarbonParserUtil
+import org.apache.spark.sql.execution.command._
+import org.apache.spark.sql.execution.command.management.CarbonLoadDataCommand
+import 
org.apache.spark.sql.execution.command.schema.{CarbonAlterTableAddColumnCommand,
 CarbonAlterTableColRenameDataTypeChangeCommand, 
CarbonAlterTableDropColumnCommand}
+
+import 
org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException
+import org.apache.carbondata.core.constants.CarbonCommonConstants
+
+/**
+ * TODO remove the duplicate code and add the common methods to common class.
 
 Review comment:
   Is this TODO required?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-12 Thread GitBox
jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize 
Carbon SparkExtensions
URL: https://github.com/apache/carbondata/pull/3574#discussion_r365581701
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonExplainCommand.scala
 ##
 @@ -42,16 +43,37 @@ case class CarbonExplainCommand(
 if (explainCommand.logicalPlan.isStreaming || isCommand) {
   explainCommand.run(sparkSession)
 } else {
-  collectProfiler(sparkSession) ++ explainCommand.run(sparkSession)
+  CarbonExplainCommand.collectProfiler(explainCommand, sparkSession) ++
+  explainCommand.run(sparkSession)
 }
   }
 
-  private def collectProfiler(sparkSession: SparkSession): Seq[Row] = {
+  override protected def opName: String = "EXPLAIN"
+}
+
+case class CarbonInternalExplainCommand(
 
 Review comment:
   Is this required?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-12 Thread GitBox
jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize 
Carbon SparkExtensions
URL: https://github.com/apache/carbondata/pull/3574#discussion_r365581648
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala
 ##
 @@ -140,11 +140,31 @@ case class CarbonCreateTableCommand(
   s"Dictionary include cannot be applied on partition columns")
   }
   s" PARTITIONED BY 
(${partitionInfo.getColumnSchemaList.asScala.map(
-_.getColumnName).mkString(",")})"
+_.getColumnName.toLowerCase).mkString(",")})"
 } else {
   ""
 }
 
+  val repeatedPropKeys =
 
 Review comment:
   add comment to describe the logic here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-12 Thread GitBox
jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize 
Carbon SparkExtensions
URL: https://github.com/apache/carbondata/pull/3574#discussion_r365581555
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DatabaseDMSchemaStorageProvider.java
 ##
 @@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.metadata.schema.table;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.carbondata.common.exceptions.sql.NoSuchDataMapException;
+
+/**
+ * Stores datamap schema in database
+ */
+public class DatabaseDMSchemaStorageProvider implements 
DataMapSchemaStorageProvider {
 
 Review comment:
   This class does nothing, is it required?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-12 Thread GitBox
jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize 
Carbon SparkExtensions
URL: https://github.com/apache/carbondata/pull/3574#discussion_r365581470
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/metadata/DatabaseLocationProvider.java
 ##
 @@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.metadata;
+
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
+import org.apache.carbondata.core.util.CarbonProperties;
+
+public abstract class DatabaseLocationProvider {
 
 Review comment:
   add comment for this class


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-12 Thread GitBox
jackylk commented on a change in pull request #3574: [CARBONDATA-3503] Optimize 
Carbon SparkExtensions
URL: https://github.com/apache/carbondata/pull/3574#discussion_r365581444
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ##
 @@ -191,6 +191,12 @@ private CarbonCommonConstants() {
 
   public static final String LOCK_PATH_DEFAULT = "";
 
+  /**
+   * Specifies the lock implement class.
 
 Review comment:
   please mention what are the options for this property


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3576: [CARBONDATA-3514] Support spark 2.4 
integration
URL: https://github.com/apache/carbondata/pull/3576#issuecomment-573412253
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1612/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3576: [CARBONDATA-3514] Support spark 2.4 
integration
URL: https://github.com/apache/carbondata/pull/3576#issuecomment-573410959
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1611/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk opened a new pull request #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-12 Thread GitBox
jackylk opened a new pull request #3576: [CARBONDATA-3514] Support spark 2.4 
integration
URL: https://github.com/apache/carbondata/pull/3576
 
 
### Why is this PR needed?
   CarbonData integration with Spark 2.4 is a long expected feature from 
community

### What changes were proposed in this PR?
   1. Support integration with Spark 2.4
   2. Removing support of Spark 2.1 and 2.2
   
### Does this PR introduce any user interface change?
- Yes. New API from Spark 2.4 can be used to access CarbonData
   
### Is any new testcase added?
- No
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3479: [ CARBONDATA-3271] Integrating deep 
learning framework TensorFlow
URL: https://github.com/apache/carbondata/pull/3479#issuecomment-573396887
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1610/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3526: [CARBONDATA-3627] C++ SDK support write data withSchemaFile

2020-01-12 Thread GitBox
CarbonDataQA1 commented on issue #3526: [CARBONDATA-3627] C++ SDK support write 
data withSchemaFile
URL: https://github.com/apache/carbondata/pull/3526#issuecomment-573394550
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1609/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services