[GitHub] [carbondata] akashrn5 commented on pull request #3963: [CARBONDATA-4018]Fix CSV header validation not contains dimension columns
akashrn5 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-704035745 @Indhumathi27 @VenuReddy2103 i have added test case for this, please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-704033411 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2559/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-704032242 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4308/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] ShreelekhyaG commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
ShreelekhyaG commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-704031435 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage
Indhumathi27 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-704030233 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue
Indhumathi27 commented on pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#issuecomment-704028143 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3967: [WIP] Read after update command
CarbonDataQA1 commented on pull request #3967: URL: https://github.com/apache/carbondata/pull/3967#issuecomment-703877351 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2557/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3967: [WIP] Read after update command
CarbonDataQA1 commented on pull request #3967: URL: https://github.com/apache/carbondata/pull/3967#issuecomment-703872936 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4306/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] akkio-97 opened a new pull request #3967: [WIP] Read after update command
akkio-97 opened a new pull request #3967: URL: https://github.com/apache/carbondata/pull/3967 ### Why is this PR needed? During vector filling, due to missing implementation of putAllByteArray() method in sliceStreamReader.java, implementation in parent class CarbonColumnVectorImpl was called. Hence on select query expected data never showed up. ### What changes were proposed in this PR? Implemented the missing method. ### Does this PR introduce any user interface change? - No - Yes. (please explain the change and update document) ### Is any new testcase added? - No - Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-703745843 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4302/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-703745225 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2554/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3961: [CARBONDATA-4019]Fix CDC merge failure join expression made of AND/OR expressions.
CarbonDataQA1 commented on pull request #3961: URL: https://github.com/apache/carbondata/pull/3961#issuecomment-703704746 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4301/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-703702198 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4305/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-703701614 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2556/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3961: [CARBONDATA-4019]Fix CDC merge failure join expression made of AND/OR expressions.
CarbonDataQA1 commented on pull request #3961: URL: https://github.com/apache/carbondata/pull/3961#issuecomment-703699501 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2553/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-703699054 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4304/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (CARBONDATA-4023) Create MV failed on table with geospatial index
SHREELEKHYA GAMPA created CARBONDATA-4023: - Summary: Create MV failed on table with geospatial index Key: CARBONDATA-4023 URL: https://issues.apache.org/jira/browse/CARBONDATA-4023 Project: CarbonData Issue Type: Bug Reporter: SHREELEKHYA GAMPA Create MV failed on the table with geospatial index using carbonsession. Failed with, java.lang.ClassNotFoundException: org.apache.carbondata.geo.geohashindex -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] ShreelekhyaG commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
ShreelekhyaG commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-703697498 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-703696017 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4303/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-703695301 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2555/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on a change in pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage
marchpure commented on a change in pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#discussion_r499649070
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##
@@ -96,20 +100,38 @@ object CarbonStore {
* Read stage files and return input files
*/
def readStageInput(
+ tableStagePath: String,
stageFiles: Seq[CarbonFile],
status: StageInput.StageStatus): Seq[StageInput] = {
val gson = new Gson()
val output = Collections.synchronizedList(new util.ArrayList[StageInput]())
-stageFiles.map { stage =>
- val filePath = stage.getAbsolutePath
- val stream = FileFactory.getDataInputStream(filePath)
+stageFiles.foreach { stage =>
+ val filePath = tableStagePath + CarbonCommonConstants.FILE_SEPARATOR +
stage.getName
+ var stream: DataInputStream = null
try {
-val stageInput = gson.fromJson(new InputStreamReader(stream),
classOf[StageInput])
-stageInput.setCreateTime(stage.getLastModifiedTime)
-stageInput.setStatus(status)
-output.add(stageInput)
+stream = FileFactory.getDataInputStream(filePath)
+var retry = READ_FILE_RETRY_TIMES
+breakable {
+ while (retry > 0) {
+try {
+ val stageInput = gson.fromJson(new InputStreamReader(stream),
classOf[StageInput])
+ stageInput.setCreateTime(stage.getLastModifiedTime)
+ stageInput.setStatus(status)
+ output.add(stageInput)
+ break()
+} catch {
+ case _ : FileNotFoundException =>
+LOGGER.warn("The stage file: " + filePath + " does not exist")
+break()
+ case _ => retry -= 1
+Thread.sleep(READ_FILE_RETRY_INTERVAL)
Review comment:
I have modified code according to your suggestion
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3959: [CARBONDATA-4010] Doc changes for long strings.
CarbonDataQA1 commented on pull request #3959: URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703666164 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2552/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3959: [CARBONDATA-4010] Doc changes for long strings.
CarbonDataQA1 commented on pull request #3959: URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703659762 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4300/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3966: [WIP] Create MV failed on table with geospatial index using carbonsession.
CarbonDataQA1 commented on pull request #3966: URL: https://github.com/apache/carbondata/pull/3966#issuecomment-703634101 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2551/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] brijoobopanna commented on pull request #3961: [CARBONDATA-4019]Fix CDC merge failure join expression made of AND/OR expressions.
brijoobopanna commented on pull request #3961: URL: https://github.com/apache/carbondata/pull/3961#issuecomment-703629980 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3966: [WIP] Create MV failed on table with geospatial index using carbonsession.
CarbonDataQA1 commented on pull request #3966: URL: https://github.com/apache/carbondata/pull/3966#issuecomment-703626820 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4299/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3959: [CARBONDATA-4010] Doc changes for long strings.
nihal0107 commented on pull request #3959: URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703596141 restest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] kunal642 commented on a change in pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage
kunal642 commented on a change in pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#discussion_r499551395
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##
@@ -96,20 +100,38 @@ object CarbonStore {
* Read stage files and return input files
*/
def readStageInput(
+ tableStagePath: String,
stageFiles: Seq[CarbonFile],
status: StageInput.StageStatus): Seq[StageInput] = {
val gson = new Gson()
val output = Collections.synchronizedList(new util.ArrayList[StageInput]())
-stageFiles.map { stage =>
- val filePath = stage.getAbsolutePath
- val stream = FileFactory.getDataInputStream(filePath)
+stageFiles.foreach { stage =>
+ val filePath = tableStagePath + CarbonCommonConstants.FILE_SEPARATOR +
stage.getName
+ var stream: DataInputStream = null
try {
-val stageInput = gson.fromJson(new InputStreamReader(stream),
classOf[StageInput])
-stageInput.setCreateTime(stage.getLastModifiedTime)
-stageInput.setStatus(status)
-output.add(stageInput)
+stream = FileFactory.getDataInputStream(filePath)
+var retry = READ_FILE_RETRY_TIMES
+breakable {
+ while (retry > 0) {
+try {
+ val stageInput = gson.fromJson(new InputStreamReader(stream),
classOf[StageInput])
+ stageInput.setCreateTime(stage.getLastModifiedTime)
+ stageInput.setStatus(status)
+ output.add(stageInput)
+ break()
+} catch {
+ case _ : FileNotFoundException =>
+LOGGER.warn("The stage file: " + filePath + " does not exist")
+break()
+ case _ => retry -= 1
+Thread.sleep(READ_FILE_RETRY_INTERVAL)
Review comment:
Why are you not throwing the original exception when retry count is 1
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##
@@ -96,20 +100,38 @@ object CarbonStore {
* Read stage files and return input files
*/
def readStageInput(
+ tableStagePath: String,
stageFiles: Seq[CarbonFile],
status: StageInput.StageStatus): Seq[StageInput] = {
val gson = new Gson()
val output = Collections.synchronizedList(new util.ArrayList[StageInput]())
-stageFiles.map { stage =>
- val filePath = stage.getAbsolutePath
- val stream = FileFactory.getDataInputStream(filePath)
+stageFiles.foreach { stage =>
+ val filePath = tableStagePath + CarbonCommonConstants.FILE_SEPARATOR +
stage.getName
+ var stream: DataInputStream = null
try {
-val stageInput = gson.fromJson(new InputStreamReader(stream),
classOf[StageInput])
-stageInput.setCreateTime(stage.getLastModifiedTime)
-stageInput.setStatus(status)
-output.add(stageInput)
+stream = FileFactory.getDataInputStream(filePath)
+var retry = READ_FILE_RETRY_TIMES
+breakable {
+ while (retry > 0) {
+try {
+ val stageInput = gson.fromJson(new InputStreamReader(stream),
classOf[StageInput])
+ stageInput.setCreateTime(stage.getLastModifiedTime)
+ stageInput.setStatus(status)
+ output.add(stageInput)
+ break()
+} catch {
+ case _ : FileNotFoundException =>
+LOGGER.warn("The stage file: " + filePath + " does not exist")
+break()
+ case _ => retry -= 1
+Thread.sleep(READ_FILE_RETRY_INTERVAL)
Review comment:
Why are you not throwing the original exception when retry count is 1?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-703587097 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4298/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-703585852 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2550/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] ShreelekhyaG opened a new pull request #3966: [WIP] Create MV failed on table with geospatial index using carbonsession.
ShreelekhyaG opened a new pull request #3966: URL: https://github.com/apache/carbondata/pull/3966 ### Why is this PR needed? Create MV failed on the table with geospatial index using carbonsession. Failed with, java.lang.ClassNotFoundException: org.apache.carbondata.geo.geohashindex ### What changes were proposed in this PR? When geo table is created with carbon session, the spatial properties are normalized and converted to lower case. Added spatial index class into `noConverterList`. ### Does this PR introduce any user interface change? - No ### Is any new testcase added? - No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage
marchpure commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-703533290 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-703531276 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4297/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-703530776 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2549/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3959: [CARBONDATA-4010] Doc changes for long strings.
CarbonDataQA1 commented on pull request #3959: URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703459809 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4296/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3959: [CARBONDATA-4010] Doc changes for long strings.
CarbonDataQA1 commented on pull request #3959: URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703456259 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2548/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] kunal642 commented on a change in pull request #3914: [CARBONDATA-3979] Added Hive local dictionary support example
kunal642 commented on a change in pull request #3914:
URL: https://github.com/apache/carbondata/pull/3914#discussion_r499389123
##
File path:
integration/hive/src/test/java/org/apache/carbondata/hive/HiveCarbonTest.java
##
@@ -211,6 +248,85 @@ public void testStructType() throws Exception {
checkAnswer(carbonResult, hiveResult);
}
+ private ArrayList getDimRawChunk(Integer blockindex)
+ throws IOException {
+File rootPath = new File(HiveTestUtils.class.getResource("/").getPath() +
"../../../..");
+String storePath = rootPath.getAbsolutePath() +
"/integration/hive/target/warehouse/warehouse/hive_carbon_table/";
+CarbonFile[] dataFiles = FileFactory.getCarbonFile(storePath)
+.listFiles(new CarbonFileFilter() {
+ @Override
+ public boolean accept(CarbonFile file) {
+if (file.getName().endsWith(CarbonCommonConstants.FACT_FILE_EXT)) {
+ return true;
+} else {
+ return false;
+}
+ }
+});
+ArrayList dimensionRawColumnChunks =
read(dataFiles[0].getAbsolutePath(),
+blockindex);
+return dimensionRawColumnChunks;
+ }
+
+ private ArrayList read(String filePath, Integer
blockIndex) throws IOException {
Review comment:
If this code to verify LocalDictionary is same as the other
LocalDictionaryTest cases, please move to a common Util class and use at both
places.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [CARBONDATA-4018]Fix CSV header validation not contains dimension columns
CarbonDataQA1 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-703443744 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2547/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [CARBONDATA-4018]Fix CSV header validation not contains dimension columns
CarbonDataQA1 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-703442305 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4295/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
