[GitHub] carbondata issue #3049: [CARBONDATA-3226] Remove duplicated and useless file...

[runzhliu]

Github user runzhliu commented on the issue:

https://github.com/apache/carbondata/pull/3049
  
@xubo245 I have checked the whole projects, there are those two duplicated 
files.


---

[GitHub] carbondata pull request #3049: [CARBONDATA-3226] Remove duplicated and usele...

[runzhliu]

GitHub user runzhliu opened a pull request:

https://github.com/apache/carbondata/pull/3049

[CARBONDATA-3226] Remove duplicated and useless files

Remove duplicated and useless files from the project.

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [x] Any interfaces changed?
 
 - [x] Any backward compatibility impacted?
 
 - [x] Document update required?

 - [x] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/runzhliu/carbondata dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/3049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3049


commit 1e20d6a217eddd93bd70e8f6be1547e362f2cd7f
Author: Oscar 
Date:   2019-01-03T14:20:16Z

[CARBONDATA-3226] Remove duplicated and useless files

Remove duplicated and useless files from the project.




---

[GitHub] carbondata pull request #3036: [CARBONDATA-3208] Remove unused parameters, i...

[runzhliu]

Github user runzhliu commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/3036#discussion_r244537813
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
 ---
@@ -287,31 +287,31 @@ private void 
fillDimensionAndMeasureDetails(List columnsInTable,
   // if it is a columnar dimension participated in mdkey then added
   // key ordinal and dimension ordinal
   carbonDimension =
-  new CarbonDimension(columnSchema, dimensonOrdinal++, 
keyOrdinal++, -1);
+  new CarbonDimension(columnSchema, dimensionOrdinal++, 
keyOrdinal++, -1);
 }
 // as complex type will be stored at last so once complex type 
started all the dimension
 // will be added to complex type
 else if (isComplexDimensionStarted || 
columnSchema.getDataType().isComplexType()) {
   cardinalityIndexForComplexDimensionColumn.add(tableOrdinal);
   carbonDimension =
-  new CarbonDimension(columnSchema, dimensonOrdinal++, -1, 
++complexTypeOrdinal);
+  new CarbonDimension(columnSchema, dimensionOrdinal++, -1, 
++complexTypeOrdinal);
   
carbonDimension.initializeChildDimensionsList(columnSchema.getNumberOfChild());
   complexDimensions.add(carbonDimension);
   isComplexDimensionStarted = true;
-  int previouseOrdinal = dimensonOrdinal;
-  dimensonOrdinal =
-  readAllComplexTypeChildren(dimensonOrdinal, 
columnSchema.getNumberOfChild(),
+  int previouseOrdinal = dimensionOrdinal;
--- End diff --

Thanks to point it out! I have fixed it :)


---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

[runzhliu]

Github user runzhliu commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
@xubo245 Done.


---

[GitHub] carbondata pull request #3036: [CARBONDATA-3208]Remove unused parameters and...

[runzhliu]

Github user runzhliu commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/3036#discussion_r244462598
  
--- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala
 ---
@@ -483,12 +483,12 @@ class CarbonGlobalDictionaryGenerateRDD(
 }
 
 /**
- * Set column dictionry patition format
--- End diff --

OK


---

[GitHub] carbondata pull request #3036: [CARBONDATA-3208]Remove unused parameters and...

[runzhliu]

Github user runzhliu commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/3036#discussion_r244462534
  
--- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/PartitionFactory.scala
 ---
@@ -32,7 +32,7 @@ object PartitionFactory {
   case PartitionType.LIST => new ListPartitioner(partitionInfo)
   case PartitionType.RANGE => new RangePartitioner(partitionInfo)
   case partitionType =>
-throw new CarbonDataLoadingException(s"Unsupport partition type: 
$partitionType")
+throw new CarbonDataLoadingException(s"Unsupported partition type: 
$partitionType")
--- End diff --

Sure, I got another three.


---

[GitHub] carbondata issue #3036: [CARBONDATA-3208]Remove unused parameters and import...

[runzhliu]

Github user runzhliu commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
Hi @xubo245 , can you please take a look?


---

[GitHub] carbondata pull request #3036: [CARBONDATA-3208]Remove unused parameters and...

[runzhliu]

GitHub user runzhliu opened a pull request:

https://github.com/apache/carbondata/pull/3036

[CARBONDATA-3208]Remove unused parameters and imports from code

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [x] Any interfaces changed?
 
 - [x] Any backward compatibility impacted?
 
 - [x] Document update required?

 - [x] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/runzhliu/carbondata runzhliu

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/3036.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3036


commit 4213886534fdf68a143060776afa47d269fac782
Author: Oscar 
Date:   2018-12-27T23:24:06Z

[CARBONDATA-3208]Remove unused parameters and imports from code




---