[GitHub] [carbondata] nihal0107 commented on a change in pull request #3959: [CARBONDATA-4010] Doc changes for long strings.

2020-10-07 Thread GitBox


nihal0107 commented on a change in pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#discussion_r501158701



##
File path: docs/ddl-of-carbondata.md
##
@@ -812,7 +813,19 @@ Users can specify which columns to include and exclude for 
local dictionary gene
```
ALTER TABLE tablename UNSET TBLPROPERTIES('SORT_SCOPE')
```
+ - # Long String Columns
+   Example to SET Long String Columns:
+   ```
+   ALTER TABLE tablename SET TBLPROPERTIES('LONG_STRING_COLUMNS'='column1')
+   ```
+   **NOTE:** Only string columns can be set to long string columns. Cannot 
set sort columns to long string columns.
 
+   Example to UNSET Long String Columns:
+   ```
+   ALTER TABLE tablename UNSET TBLPROPERTIES('LONG_STRING_COLUMNS')
+   ```
+   **NOTE:** On unset long string columns are set to their original 
datatypes.

Review comment:
   done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] nihal0107 commented on a change in pull request #3959: [CARBONDATA-4010] Doc changes for long strings.

2020-10-06 Thread GitBox


nihal0107 commented on a change in pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#discussion_r500254558



##
File path: docs/ddl-of-carbondata.md
##
@@ -426,7 +426,8 @@ CarbonData DDL statements are documented here,which 
includes:
- # String longer than 32000 characters
 
  In common scenarios, the length of string is less than 32000,
- so carbondata stores the length of content using Short to reduce memory 
and space consumption.
+ so carbondata stores the length of content using Short to reduce memory 
and space consumption, and it handles the strings
+ which length greater than 32000 as bad record. Refer [bad record 
handling](https://github.com/apache/carbondata/blob/master/docs/dml-of-carbondata.md#bad-records-handling)
 section for better understanding.

Review comment:
   done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org