[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[pawanmalwal]

Github user pawanmalwal commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Duplicate PR - univocity jar changes done in PR 
https://github.com/apache/carbondata/pull/1532


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[pawanmalwal]

Github user pawanmalwal commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
retest this please


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[pawanmalwal]

Github user pawanmalwal commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
retest this please


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[sraghunandan]

Github user sraghunandan commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
retest this please


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[pawanmalwal]

Github user pawanmalwal commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Yes thats right. This PR also has some code change to avoid 1 more string 
object creation in the same method and another chanage to update 
univocity-parsers jar version to 2.2.1 in processing/pom.xml. Please review.


---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[sraghunandan]

Github user sraghunandan commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Master already has stringbuffer implementation

On 24-Aug-2017 4:54 PM, "Pawan Malwal"  wrote:

> *@pawanmalwal* commented on this pull request.
> --
>
> In core/src/main/java/org/apache/carbondata/core/scan/filter/
> FilterExpressionProcessor.java
> :
>
> > @@ -163,17 +163,17 @@ public FilterResolverIntf 
getFilterResolver(Expression expressionTree,
>}
>
>private String joinByteArray(byte[] bytes, char delimiter) {
> -StringBuffer byteArrayAsString = new StringBuffer();
> -byteArrayAsString.append("");
> +String byteArrayAsString = "";
>
> Changed to StringBuffer per your suggestion.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1281
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---