[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-14 Thread ravipesala 
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
LGTM


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-13 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-13 Thread ravipesala 
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-12 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-12 Thread ravipesala 
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-07 Thread SangeetaGulia 
Github user SangeetaGulia commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
@jackylk CARBON_TIMESTAMP_MILLIS is more precise in terms of time as 
compared to  CARBON_TIMESTAMP_DEFAULT_FORMAT. 

Also, there were three formats defined for TIMESTAMP in 
CarbonCommonConstants 
1) String CARBON_TIMESTAMP_DEFAULT_FORMAT = "-MM-dd HH:mm:ss"; (It has 
maximum occurences in the project currently)
2) String CARBON_TIMESTAMP = "dd-MM- HH:mm:ss";
3) String CARBON_TIMESTAMP_MILLIS = "dd-MM- HH:mm:ss:SSS";

Do you want to use one format at all places? If yes, please suggest me one 
format from the three available formats.


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-06 Thread jackylk 
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
I think it is not good to have both `CARBON_TIMESTAMP_MILLIS` and 
`CARBON_TIMESTAMP_DEFAULT_FORMAT` in CarbonCommonConstants. Why not using 
`CARBON_TIMESTAMP_DEFAULT_FORMAT` only and delete `CARBON_TIMESTAMP_MILLIS`?


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-06 Thread SangeetaGulia 
Github user SangeetaGulia commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
retest this please


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-04 Thread SangeetaGulia 
Github user SangeetaGulia commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
retest this please.


---

[GitHub] carbondata issue #1316: [CARBONDATA-1412] - Fixed bug related to incorrect b...

2017-09-04 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1316
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---