[GitHub] carbondata issue #2595: [Documentation] [Unsafe Configuration] Added carbon....

2018-08-02 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2595
  
LGTM


---


[GitHub] carbondata issue #2595: [Documentation] [Unsafe Configuration] Added carbon....

2018-08-01 Thread manishgupta88
Github user manishgupta88 commented on the issue:

https://github.com/apache/carbondata/pull/2595
  
@xuchuanyin Usually in production scenarios driver memory will be less 
than the executor memory. Now we are using unsafe for caching block/blocklet 
dataMap in driver.  Current unsafe memory configured fo executor is getting 
used for driver also which is not a good idea.
Therefore it is required to separate out driver and executor unsafe memory.
You can observe the same in spark configuration also that spark has given 
different parameters for configuring driver and executor memory overhead to 
control the unsafe memory usage.
spark.yarn.driver.memoryOverhead and spark.yarn.executor.memoryOverhead


---


[GitHub] carbondata issue #2595: [Documentation] [Unsafe Configuration] Added carbon....

2018-08-01 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2595
  
Why driver needs this unsafe memory?


---


[GitHub] carbondata issue #2595: [Documentation] [Unsafe Configuration] Added carbon....

2018-08-01 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2595
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/6103/



---


[GitHub] carbondata issue #2595: [Documentation] [Unsafe Configuration] Added carbon....

2018-08-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2595
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6436/



---


[GitHub] carbondata issue #2595: [Documentation] [Unsafe Configuration] Added carbon....

2018-08-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2595
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7710/



---