[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-18 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
LGTM


---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/503/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8573/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/327/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/499/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8569/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/323/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
@xuchuanyin ...please check my reply on the mailing list

http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Optimizing-the-writing-of-min-max-for-a-column-td62515.html


---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
@manishgupta88 Hi, actually I have another idea on the implementation for 
this requirement. I'd like to use an unique fake value to store the minmax for 
those columns. 
While judging the filter value with the fake minmax, we know that is a fake 
minmax, so the filter procedure just returns true.
In this way, we do not need to modify the metadata and can reduce many code 
changes.


---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8566/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/496/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/493/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8563/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/320/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/317/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
@ravipesala ..Fixed review comments. Kindly review


---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8557/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/487/



---


[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2725
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/311/



---