[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-13 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
LGTM


---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-12 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9632/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-12 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1584/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-12 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1374/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-12 Thread akashrn5
Github user akashrn5 commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
retest this please


---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9618/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1570/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1360/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-11 Thread akashrn5
Github user akashrn5 commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
@ravipesala please review the documentation commit added


---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1359/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-06 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
LGTM


---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9543/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1282/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1494/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1275/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread akashrn5
Github user akashrn5 commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
2.2.1 and 2.3.1 failed test cases, which are not related and these are 
random


---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread akashrn5
Github user akashrn5 commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
retest this please


---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9533/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1484/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1269/



---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
ok, its fine


---


[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...

2018-11-05 Thread akashrn5
Github user akashrn5 commented on the issue:

https://github.com/apache/carbondata/pull/2886
  
@ravipesala
in existing flow, all the sort columns and dimensions will have inverted 
index and,
 in current implementation, if measure columns are given in inverted_index 
property, then i ll not set it as inverted index. Basically i wont throw any 
exception. Do we need to throw exception?
and currently im allowing the inverted index for all dimension columns and 
not restricting to sort columns only. 
So basically, user can mention columns in inverted_index columns 
(dimensions), i am setting those as inverted index. it is correct right


---