[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
LGTM @QiangCai I feel it is better to keep in tableproprties as it is not 
supposed changed for each load. We can further discuss and raise another PR if 
needed, I am merging this now. Thanks for working on it. 


---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-07 Thread QiangCai
Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
@ravipesala 
In my opinion, it is unnecessary to restrict changing.
The users will keep the range_column as unchanged as possible.
So I only add this option into loading command.


---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
@QiangCai we should restrict changing that property from table properties. 
I am just explaining about how we can do the compaction on range column 
since there are similarities with partitioning I mentioned it here. 
I feel range boundaries can be recalculated during the compaction using 
min/max of range column and go for the merge sort.


---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-06 Thread QiangCai
Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
@ravipesala 
I agree with you to add it to the table properties.
Even if it becomes the table property, maybe the user also can change it. 
right?
Range_column is different from the partition table. 
For range_column, the range boundaries are different for all segments. 
(Global_SORT also)
For the partition table, the range boundaries are the same for all segments.



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-06 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
@QiangCai My question how the user can benefit if he chooses a different 
range column for each load. I feel range column should be at the table level 
not at the load level.
And regarding compaction, yes currently after compaction it becomes local 
sort but there is a way we can support range column compaction like how we do 
compaction for partitions. This work can be done in future. But if you allow 
the user to choose range column at each load level then this type of compaction 
cannot be done.


---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-04 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10418/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-04 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2377/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-04 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2164/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-04 Thread QiangCai
Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
@ravipesala @kumarvishal09 
please review again.


---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-04 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10413/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-04 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2372/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-04 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2159/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-04 Thread QiangCai
Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
@ravipesala 
After the compaction, it will become local_sort.
In my opinion, we can use Range_column to partition the input data.
So it can reduce the scope of sorting during data loading to improve data 
loading performance.
In some case, it also can improve the query performance (like Global_sort).




---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10412/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2371/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2158/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2370/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10411/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2157/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10407/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2153/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2366/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10396/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2347/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-03 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2141/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10387/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2339/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2133/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2338/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10386/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2132/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10377/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2121/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2327/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
@QiangCai @jackylk Adding a `RANGE_COLUMN` at each load level does not 
create an issue? If user selects different range column for each load how you 
are going to compact when you support it in future?
what is the background of giving the range_column in load level instead of 
create table level?


---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10359/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2310/



---


[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2971
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2105/



---