[GitHub] carbondata pull request #1164: [CARBONDATA-1303] Update CarbonContext.scala

2017-07-12 Thread chenerlu 
Github user chenerlu commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1164#discussion_r126979658
  
--- Diff: 
integration/spark/src/main/scala/org/apache/spark/sql/CarbonContext.scala ---
@@ -37,6 +37,7 @@ import org.apache.carbondata.core.stats.{QueryStatistic, 
QueryStatisticsConstant
 import org.apache.carbondata.core.util.{CarbonProperties, 
CarbonTimeStatisticsFactory}
 
 class CarbonContext(
+@transient
--- End diff --

Why you add this annotation ?
I think is unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #1164: [CARBONDATA-1303] Update CarbonContext.scala

2017-07-12 Thread sehriff 
GitHub user sehriff opened a pull request:

https://github.com/apache/carbondata/pull/1164

[CARBONDATA-1303] Update CarbonContext.scala

to skip serilize this two not-serializable class while apply mapPartitions 
function to dataframe create from CarbonContext

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[CARBONDATA-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
 - [ ] Testing done
 
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- What manual testing you have done?
- Any additional information to help reviewers in testing this 
change.
 
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
 
---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sehriff/carbondata patch-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1164


commit 9887a62c05ee0bf8a9e26971c9ab311f000cc956
Author: sehriff <1360496...@qq.com>
Date:   2017-07-12T10:30:32Z

Update CarbonContext.scala

to skip serilize this two not-serializable class while apply mapPartitions 
function to dataframe create from CarbonContext




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---