[GitHub] carbondata pull request #1291: [CARBONDATA-1343] Hive can't query data when ...

[anubhav100]

Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1291#discussion_r139315604
  
--- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -133,7 +133,7 @@ public static void setTableInfo(Configuration 
configuration, TableInfo tableInfo
   /**
* Get TableInfo object from `configuration`
*/
-  private TableInfo getTableInfo(Configuration configuration) throws 
IOException {
+  public TableInfo getTableInfo(Configuration configuration) throws 
IOException {
--- End diff --

@cenyuhai change in this file is not required now  because 
MapredCarbonInputFormat now extends CarbonTableInputFormat 


---

[GitHub] carbondata pull request #1291: [CARBONDATA-1343] Hive can't query data when ...

[chenliang613]

Github user chenliang613 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1291#discussion_r135560774
  
--- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -133,7 +133,7 @@ public static void setTableInfo(Configuration 
configuration, TableInfo tableInfo
   /**
* Get TableInfo object from `configuration`
*/
-  private TableInfo getTableInfo(Configuration configuration) throws 
IOException {
+  public TableInfo getTableInfo(Configuration configuration) throws 
IOException {
--- End diff --

In the future,  carbondata will use CarbonTableInputFormat to replace 
CarbonInputFormat, so please use CarbonTableInputFormat.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #1291: [CARBONDATA-1343] Hive can't query data when ...

[cenyuhai]

GitHub user cenyuhai opened a pull request:

https://github.com/apache/carbondata/pull/1291

[CARBONDATA-1343] Hive can't query data when the carbon table info is store 
in hive metastore

add tableInfo to CarbonHiveInputSplit and no need to get schema from file 
in map process.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cenyuhai/incubator-carbondata CARBONDATA-1343

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1291


commit 97b103d162120bc1f9be52b807da6063b4ce398e
Author: CenYuhai 
Date:   2017-08-27T07:37:29Z

add tableInfo to CarbonHiveInputSplit and no need to get schema from file 
in map process.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---