[GitHub] carbondata pull request #1356: [CARBONDATA-1477] Corrected the Bug For Wrong...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1356


---

[GitHub] carbondata pull request #1356: [CARBONDATA-1477] corrected the bug for wrong...

[anubhav100]

Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1356#discussion_r138659199
  
--- Diff: 
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java
 ---
@@ -228,9 +229,13 @@ private Writable createWritablePrimitive(Object obj, 
CarbonColumn carbonColumn)
   case LONG:
 return new LongWritable((long) obj);
   case SHORT:
-return new ShortWritable((Short) obj);
+return new ShortWritable((short) obj);
   case DATE:
-return new DateWritable(new Date(((Integer) obj).longValue()));
+Calendar c = Calendar.getInstance();
+c.setTime(new Date(0));
--- End diff --

There are changes in master code for date so these changes are required for 
getting the right values at hive side


---

[GitHub] carbondata pull request #1356: [CARBONDATA-1477] corrected the bug for wrong...

[anubhav100]

Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1356#discussion_r138656706
  
--- Diff: 
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java
 ---
@@ -228,9 +229,13 @@ private Writable createWritablePrimitive(Object obj, 
CarbonColumn carbonColumn)
   case LONG:
 return new LongWritable((long) obj);
   case SHORT:
-return new ShortWritable((Short) obj);
+return new ShortWritable((short) obj);
   case DATE:
-return new DateWritable(new Date(((Integer) obj).longValue()));
+Calendar c = Calendar.getInstance();
+c.setTime(new Date(0));
--- End diff --

Yup


---

[GitHub] carbondata pull request #1356: [CARBONDATA-1477] corrected the bug for wrong...

[cenyuhai]

Github user cenyuhai commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1356#discussion_r138654019
  
--- Diff: 
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java
 ---
@@ -228,9 +229,13 @@ private Writable createWritablePrimitive(Object obj, 
CarbonColumn carbonColumn)
   case LONG:
 return new LongWritable((long) obj);
   case SHORT:
-return new ShortWritable((Short) obj);
+return new ShortWritable((short) obj);
   case DATE:
-return new DateWritable(new Date(((Integer) obj).longValue()));
+Calendar c = Calendar.getInstance();
+c.setTime(new Date(0));
--- End diff --

Does it mean current time? and then reset the year to current year?


---

[GitHub] carbondata pull request #1356: [CARBONDATA-1477] corrected the bug for wrong...

[anubhav100]

GitHub user anubhav100 opened a pull request:

https://github.com/apache/carbondata/pull/1356

[CARBONDATA-1477] corrected the bug for wrong values of date data type

https://issues.apache.org/jira/browse/CARBONDATA-1477

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anubhav100/incubator-carbondata 
CARBONDATA-1477

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1356


commit d9d7eb8fbda99e4627589df19684ebd8a8c8ee89
Author: anubhav100 
Date:   2017-09-13T12:20:19Z

corrected the bug for wrong values of date data type




---