[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1713 ---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178455504
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
--- End diff --
ok
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178455501
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
+--master yarn \
+--deploy-mode client \
+--driver-memory 16g \
+--executor-cores 4g \
+--executor-memory 24g \
+--num-executors 3 \
+concurrencyTest.jar \
+totalNum threadNum taskNum resultIsEmpty runInLocal generateFile
deleteFile
+ * details in initParameters method of this benchmark
+ */
+object ConcurrentQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 10 * 1000
+ // the number of thread pool
+ var threadNum = 16
+ // task number of spark sql query
+ var taskNum = 100
+ // whether is result empty, if true then result is empty
+ var resultIsEmpty = true
+ // the store path of task details
+ var path: String = "/tmp/carbondata"
+ // whether run in local or cluster
+ var runInLocal = true
+ // whether generate new file
+ var generateFile = true
+ // whether delete file
+ var deleteFile = true
+
+ val cardinalityId = 100 * 1000 * 1000
+ val cardinalityCity = 6
+
+ def parquetTableName: String = "Num" + totalNum + "_" +
"comparetest_parquet"
+
+ def orcTableName: String = "Num" + totalNum + "_" + "comparetest_orc"
+
+ def carbonTableName(version: String): String =
+"Num" + totalNum + "_" + s"comparetest_carbonV$version"
+
+
--- End diff --
ok
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178455498
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/GenerateData.scala
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import org.apache.spark.sql.{DataFrame, Row, SparkSession}
+import org.apache.spark.sql.types._
+
+object GenerateData {
--- End diff --
ok
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178438050
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/GenerateData.scala
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import org.apache.spark.sql.{DataFrame, Row, SparkSession}
+import org.apache.spark.sql.types._
+
+object GenerateData {
--- End diff --
Rename to `DataGenerator`
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178438035
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
+--master yarn \
+--deploy-mode client \
+--driver-memory 16g \
+--executor-cores 4g \
+--executor-memory 24g \
+--num-executors 3 \
+concurrencyTest.jar \
+totalNum threadNum taskNum resultIsEmpty runInLocal generateFile
deleteFile
+ * details in initParameters method of this benchmark
+ */
+object ConcurrentQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 10 * 1000
+ // the number of thread pool
+ var threadNum = 16
+ // task number of spark sql query
+ var taskNum = 100
+ // whether is result empty, if true then result is empty
+ var resultIsEmpty = true
+ // the store path of task details
+ var path: String = "/tmp/carbondata"
+ // whether run in local or cluster
+ var runInLocal = true
+ // whether generate new file
+ var generateFile = true
+ // whether delete file
+ var deleteFile = true
+
+ val cardinalityId = 100 * 1000 * 1000
+ val cardinalityCity = 6
+
+ def parquetTableName: String = "Num" + totalNum + "_" +
"comparetest_parquet"
+
+ def orcTableName: String = "Num" + totalNum + "_" + "comparetest_orc"
+
+ def carbonTableName(version: String): String =
+"Num" + totalNum + "_" + s"comparetest_carbonV$version"
+
+
--- End diff --
remove empty line
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178438033
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
--- End diff --
add `*`, otherwise stylecheck will fail
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178429058
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,631 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
+--master yarn \
+--deploy-mode client \
+--driver-memory 16g \
+--executor-cores 4g \
+--executor-memory 24g \
+--num-executors 3 \
+concurrencyTest.jar \
+totalNum threadNum taskNum resultIsEmpty runInLocal generateFile
deleteFile
+ * details in initParameters method of this benchmark
+ */
+object ConcurrentQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 1000 * 1000
+ // the number of thread pool
+ var threadNum = 16
+ // task number of spark sql query
+ var taskNum = 100
+ // whether is result empty, if true then result is empty
+ var resultIsEmpty = true
+ // the store path of task details
+ var path: String = "/tmp/carbondata"
+ // whether run in local or cluster
+ var runInLocal = true
+ // whether generate new file
+ var generateFile = true
+ // whether delete file
+ var deleteFile = true
+
+ val cardinalityId = 100 * 1000 * 1000
+ val cardinalityCity = 6
+
+ def parquetTableName: String = "Num" + totalNum + "_" +
"comparetest_parquet"
+
+ def orcTableName: String = "Num" + totalNum + "_" + "comparetest_orc"
+
+ def carbonTableName(version: String): String =
+"Num" + totalNum + "_" + s"comparetest_carbonV$version"
+
+ // Table schema:
+ // +-+---+-+-++
+ // | Column name | Data type | Cardinality | Column type | Dictionary |
+ // +-+---+-+-++
+ // | id | string| 100,000,000 | dimension | no |
+ // +-+---+-+-++
+ // | city| string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | country | string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | planet | string| 10,007 | dimension | yes|
+ // +-+---+-+-++
+ // | m1 | short | NA | measure | no |
+ // +-+---+-+-++
+ // | m2 | int | NA | measure | no |
+ // +-+---+-+-++
+ // | m3 | bi
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178429053
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,631 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
+--master yarn \
+--deploy-mode client \
+--driver-memory 16g \
+--executor-cores 4g \
+--executor-memory 24g \
+--num-executors 3 \
+concurrencyTest.jar \
+totalNum threadNum taskNum resultIsEmpty runInLocal generateFile
deleteFile
+ * details in initParameters method of this benchmark
+ */
+object ConcurrentQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 1000 * 1000
+ // the number of thread pool
+ var threadNum = 16
+ // task number of spark sql query
+ var taskNum = 100
+ // whether is result empty, if true then result is empty
+ var resultIsEmpty = true
+ // the store path of task details
+ var path: String = "/tmp/carbondata"
+ // whether run in local or cluster
+ var runInLocal = true
+ // whether generate new file
+ var generateFile = true
+ // whether delete file
+ var deleteFile = true
+
+ val cardinalityId = 100 * 1000 * 1000
+ val cardinalityCity = 6
+
+ def parquetTableName: String = "Num" + totalNum + "_" +
"comparetest_parquet"
+
+ def orcTableName: String = "Num" + totalNum + "_" + "comparetest_orc"
+
+ def carbonTableName(version: String): String =
+"Num" + totalNum + "_" + s"comparetest_carbonV$version"
+
+ // Table schema:
+ // +-+---+-+-++
+ // | Column name | Data type | Cardinality | Column type | Dictionary |
+ // +-+---+-+-++
+ // | id | string| 100,000,000 | dimension | no |
+ // +-+---+-+-++
+ // | city| string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | country | string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | planet | string| 10,007 | dimension | yes|
+ // +-+---+-+-++
+ // | m1 | short | NA | measure | no |
+ // +-+---+-+-++
+ // | m2 | int | NA | measure | no |
+ // +-+---+-+-++
+ // | m3 | bi
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178247348
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,631 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
+--master yarn \
+--deploy-mode client \
+--driver-memory 16g \
+--executor-cores 4g \
+--executor-memory 24g \
+--num-executors 3 \
+concurrencyTest.jar \
+totalNum threadNum taskNum resultIsEmpty runInLocal generateFile
deleteFile
+ * details in initParameters method of this benchmark
+ */
+object ConcurrentQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 1000 * 1000
+ // the number of thread pool
+ var threadNum = 16
+ // task number of spark sql query
+ var taskNum = 100
+ // whether is result empty, if true then result is empty
+ var resultIsEmpty = true
+ // the store path of task details
+ var path: String = "/tmp/carbondata"
+ // whether run in local or cluster
+ var runInLocal = true
+ // whether generate new file
+ var generateFile = true
+ // whether delete file
+ var deleteFile = true
+
+ val cardinalityId = 100 * 1000 * 1000
+ val cardinalityCity = 6
+
+ def parquetTableName: String = "Num" + totalNum + "_" +
"comparetest_parquet"
+
+ def orcTableName: String = "Num" + totalNum + "_" + "comparetest_orc"
+
+ def carbonTableName(version: String): String =
+"Num" + totalNum + "_" + s"comparetest_carbonV$version"
+
+ // Table schema:
+ // +-+---+-+-++
+ // | Column name | Data type | Cardinality | Column type | Dictionary |
+ // +-+---+-+-++
+ // | id | string| 100,000,000 | dimension | no |
+ // +-+---+-+-++
+ // | city| string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | country | string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | planet | string| 10,007 | dimension | yes|
+ // +-+---+-+-++
+ // | m1 | short | NA | measure | no |
+ // +-+---+-+-++
+ // | m2 | int | NA | measure | no |
+ // +-+---+-+-++
+ // | m3 | bi
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178246812
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,631 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
+--master yarn \
+--deploy-mode client \
+--driver-memory 16g \
+--executor-cores 4g \
+--executor-memory 24g \
+--num-executors 3 \
+concurrencyTest.jar \
+totalNum threadNum taskNum resultIsEmpty runInLocal generateFile
deleteFile
+ * details in initParameters method of this benchmark
+ */
+object ConcurrentQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 1000 * 1000
+ // the number of thread pool
+ var threadNum = 16
+ // task number of spark sql query
+ var taskNum = 100
+ // whether is result empty, if true then result is empty
+ var resultIsEmpty = true
+ // the store path of task details
+ var path: String = "/tmp/carbondata"
+ // whether run in local or cluster
+ var runInLocal = true
+ // whether generate new file
+ var generateFile = true
+ // whether delete file
+ var deleteFile = true
+
+ val cardinalityId = 100 * 1000 * 1000
+ val cardinalityCity = 6
+
+ def parquetTableName: String = "Num" + totalNum + "_" +
"comparetest_parquet"
+
+ def orcTableName: String = "Num" + totalNum + "_" + "comparetest_orc"
+
+ def carbonTableName(version: String): String =
+"Num" + totalNum + "_" + s"comparetest_carbonV$version"
+
+ // Table schema:
+ // +-+---+-+-++
+ // | Column name | Data type | Cardinality | Column type | Dictionary |
+ // +-+---+-+-++
+ // | id | string| 100,000,000 | dimension | no |
+ // +-+---+-+-++
+ // | city| string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | country | string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | planet | string| 10,007 | dimension | yes|
+ // +-+---+-+-++
+ // | m1 | short | NA | measure | no |
+ // +-+---+-+-++
+ // | m2 | int | NA | measure | no |
+ // +-+---+-+-++
+ // | m3 | bi
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r178245698
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrentQueryBenchmark.scala
---
@@ -0,0 +1,631 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.benchmark
+
+import java.io.File
+import java.text.SimpleDateFormat
+import java.util
+import java.util.Date
+import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
+
+import scala.util.Random
+
+import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
+import org.apache.spark.sql.types._
+
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
+import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
+
+// scalastyle:off println
+/**
+ * Test concurrent query performance of CarbonData
+ *
+ * This benchmark will print out some information:
+ * 1.Environment information
+ * 2.Parameters information
+ * 3.concurrent query performance result using parquet format
+ * 4.concurrent query performance result using CarbonData format
+ *
+ * This benchmark default run in local model,
+ * user can change 'runInLocal' to false if want to run in cluster,
+ * user can change variables like:
+ *
+ * spark-submit \
+--class org.apache.carbondata.benchmark.ConcurrentQueryBenchmark \
+--master yarn \
+--deploy-mode client \
+--driver-memory 16g \
+--executor-cores 4g \
+--executor-memory 24g \
+--num-executors 3 \
+concurrencyTest.jar \
+totalNum threadNum taskNum resultIsEmpty runInLocal generateFile
deleteFile
+ * details in initParameters method of this benchmark
+ */
+object ConcurrentQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 1000 * 1000
+ // the number of thread pool
+ var threadNum = 16
+ // task number of spark sql query
+ var taskNum = 100
+ // whether is result empty, if true then result is empty
+ var resultIsEmpty = true
+ // the store path of task details
+ var path: String = "/tmp/carbondata"
+ // whether run in local or cluster
+ var runInLocal = true
+ // whether generate new file
+ var generateFile = true
+ // whether delete file
+ var deleteFile = true
+
+ val cardinalityId = 100 * 1000 * 1000
+ val cardinalityCity = 6
+
+ def parquetTableName: String = "Num" + totalNum + "_" +
"comparetest_parquet"
+
+ def orcTableName: String = "Num" + totalNum + "_" + "comparetest_orc"
+
+ def carbonTableName(version: String): String =
+"Num" + totalNum + "_" + s"comparetest_carbonV$version"
+
+ // Table schema:
+ // +-+---+-+-++
+ // | Column name | Data type | Cardinality | Column type | Dictionary |
+ // +-+---+-+-++
+ // | id | string| 100,000,000 | dimension | no |
+ // +-+---+-+-++
+ // | city| string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | country | string| 6 | dimension | yes|
+ // +-+---+-+-++
+ // | planet | string| 10,007 | dimension | yes|
+ // +-+---+-+-++
+ // | m1 | short | NA | measure | no |
+ // +-+---+-+-++
+ // | m2 | int | NA | measure | no |
+ // +-+---+-+-++
+ // | m3 | bi
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r164938810
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrencyQueryBenchmark.scala
---
@@ -15,47 +15,63 @@
* limitations under the License.
*/
-package org.apache.carbondata.examples
+package org.apache.carbondata.benchmark
import java.io.File
+import java.text.SimpleDateFormat
import java.util
+import java.util.Date
import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
import scala.util.Random
import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
import org.apache.spark.sql.types._
-import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
// scalastyle:off println
-object ConcurrencyTest {
-
- var totalNum = 100 * 1000 * 1000
- var ThreadNum = 16
- var TaskNum = 100
- var ResultIsEmpty = true
- val cardinalityId = 1 * 1
+object ConcurrencyQueryBenchmark {
--- End diff --
ok, I add some annotation for ConcurrentQueryBenchmark
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r164933914
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrencyQueryBenchmark.scala
---
@@ -15,47 +15,63 @@
* limitations under the License.
*/
-package org.apache.carbondata.examples
+package org.apache.carbondata.benchmark
import java.io.File
+import java.text.SimpleDateFormat
import java.util
+import java.util.Date
import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
import scala.util.Random
import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
import org.apache.spark.sql.types._
-import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
// scalastyle:off println
-object ConcurrencyTest {
-
- var totalNum = 100 * 1000 * 1000
- var ThreadNum = 16
- var TaskNum = 100
- var ResultIsEmpty = true
- val cardinalityId = 1 * 1
+object ConcurrencyQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 1000 * 1000
--- End diff --
now the class is 'org.apache.carbondata.benchmark.ConcurrentQueryBenchmark'
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r164929882
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrencyQueryBenchmark.scala
---
@@ -15,47 +15,63 @@
* limitations under the License.
*/
-package org.apache.carbondata.examples
+package org.apache.carbondata.benchmark
import java.io.File
+import java.text.SimpleDateFormat
import java.util
+import java.util.Date
import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
import scala.util.Random
import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
import org.apache.spark.sql.types._
-import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
// scalastyle:off println
-object ConcurrencyTest {
-
- var totalNum = 100 * 1000 * 1000
- var ThreadNum = 16
- var TaskNum = 100
- var ResultIsEmpty = true
- val cardinalityId = 1 * 1
+object ConcurrencyQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 1000 * 1000
--- End diff --
Because user can change the variable in shell script, like:
xubo # cat query3.sh
#!/bin/bash
for j in 1
do
for k in {1..32}
do
for l in true
do
for i in {1..8}
do
echo 'num,executors,resultIsEmpty,times'
echo $j
echo $k
echo $l
echo $i
spark-submit \
--class org.apache.carbondata.examples.ConcurrencyTest \
--master yarn \
--deploy-mode client \
--driver-memory 16g \
--executor-cores $k \
--executor-memory 24g \
--num-executors 3 \
concurrencyTest.jar \
$j 16 100 $l '/tmp/carbondata' false false false
done
done
done
done
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r164735414
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrencyQueryBenchmark.scala
---
@@ -15,47 +15,63 @@
* limitations under the License.
*/
-package org.apache.carbondata.examples
+package org.apache.carbondata.benchmark
import java.io.File
+import java.text.SimpleDateFormat
import java.util
+import java.util.Date
import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
import scala.util.Random
import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
import org.apache.spark.sql.types._
-import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
// scalastyle:off println
-object ConcurrencyTest {
-
- var totalNum = 100 * 1000 * 1000
- var ThreadNum = 16
- var TaskNum = 100
- var ResultIsEmpty = true
- val cardinalityId = 1 * 1
+object ConcurrencyQueryBenchmark {
--- End diff --
Can you explain in comment what will print out in this benchmark
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r164735139
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrencyQueryBenchmark.scala
---
@@ -15,47 +15,63 @@
* limitations under the License.
*/
-package org.apache.carbondata.examples
+package org.apache.carbondata.benchmark
import java.io.File
+import java.text.SimpleDateFormat
import java.util
+import java.util.Date
import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
import scala.util.Random
import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
import org.apache.spark.sql.types._
-import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
// scalastyle:off println
-object ConcurrencyTest {
-
- var totalNum = 100 * 1000 * 1000
- var ThreadNum = 16
- var TaskNum = 100
- var ResultIsEmpty = true
- val cardinalityId = 1 * 1
+object ConcurrencyQueryBenchmark {
+
+ // generate number of data
+ var totalNum = 1 * 1000 * 1000
--- End diff --
For all these variable, why not use val
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r164734978
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/ConcurrencyQueryBenchmark.scala
---
@@ -15,47 +15,63 @@
* limitations under the License.
*/
-package org.apache.carbondata.examples
+package org.apache.carbondata.benchmark
import java.io.File
+import java.text.SimpleDateFormat
import java.util
+import java.util.Date
import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
import scala.util.Random
import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
import org.apache.spark.sql.types._
-import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
// scalastyle:off println
-object ConcurrencyTest {
-
- var totalNum = 100 * 1000 * 1000
- var ThreadNum = 16
- var TaskNum = 100
- var ResultIsEmpty = true
- val cardinalityId = 1 * 1
+object ConcurrencyQueryBenchmark {
--- End diff --
Change to ConcurrentQueryBenchmark
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r164718273
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/ConcurrencyTest.scala
---
@@ -18,44 +18,60 @@
package org.apache.carbondata.examples
import java.io.File
+import java.text.SimpleDateFormat
import java.util
+import java.util.Date
import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
import scala.util.Random
import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
import org.apache.spark.sql.types._
-import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
// scalastyle:off println
object ConcurrencyTest {
--- End diff --
ok, done
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1713#discussion_r164676060
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/ConcurrencyTest.scala
---
@@ -18,44 +18,60 @@
package org.apache.carbondata.examples
import java.io.File
+import java.text.SimpleDateFormat
import java.util
+import java.util.Date
import java.util.concurrent.{Callable, Executors, Future, TimeUnit}
import scala.util.Random
import org.apache.spark.sql.{DataFrame, Row, SaveMode, SparkSession}
import org.apache.spark.sql.types._
-import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.constants.{CarbonCommonConstants,
CarbonVersionConstants}
import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
// scalastyle:off println
object ConcurrencyTest {
--- End diff --
please make a benchmark package and move it there, rename the class to
`ConcurrencyBenchmark`
---
[GitHub] carbondata pull request #1713: [CARBONDATA-1899] Optimize CarbonData concurr...
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/1713 [CARBONDATA-1899] Optimize CarbonData concurrency test case 1.add different select and filter 2.add result count 3.add min, max time 4.add task start time and end time for graph 5.add environment information 6.change task time to total executor time Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? No - [ ] Any backward compatibility impacted? No - [ ] Document update required? No - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. No You can merge this pull request into a Git repository by running: $ git pull https://github.com/xubo245/carbondata concurrentTestOptimize Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1713.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1713 commit 8dc86b440b6676b2eb91ad6cb37dee84333eb375 Author: xubo245 <601450868@...> Date: 2017-12-22T08:55:01Z [CARBONDATA-1899] Optimize CarbonData concurrency test case 1.add different select and filter 2.add result count 3.add min, max time 4.add task start time and end time for graph 5.add environment information 6.change task time to total executor time ---
