[GitHub] carbondata pull request #2227: [CARBONDATA-2401] Date and Timestamp options ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2227


---

[GitHub] carbondata pull request #2227: [CARBONDATA-2401] Date and Timestamp options ...

[BJangir]

Github user BJangir commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2227#discussion_r187087122
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
 ---
@@ -81,9 +81,8 @@ public CarbonLoadModel build(Map options, 
long UUID, String task
 build(options, optionsFinal, model, null);
 
 
-// set default values
-
model.setTimestampformat(CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT);
-model.setDateFormat(CarbonCommonConstants.CARBON_DATE_DEFAULT_FORMAT);
+// set default values other than time format
--- End diff --

OK.Fixed


---

[GitHub] carbondata pull request #2227: [CARBONDATA-2401] Date and Timestamp options ...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2227#discussion_r186276999
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
 ---
@@ -81,9 +81,8 @@ public CarbonLoadModel build(Map options, 
long UUID, String task
 build(options, optionsFinal, model, null);
 
 
-// set default values
-
model.setTimestampformat(CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT);
-model.setDateFormat(CarbonCommonConstants.CARBON_DATE_DEFAULT_FORMAT);
+// set default values other than time format
--- End diff --

This comment can be removed


---

[GitHub] carbondata pull request #2227: [CARBONDATA-2401] Date and Timestamp options ...

[BJangir]

GitHub user BJangir opened a pull request:

https://github.com/apache/carbondata/pull/2227

[CARBONDATA-2401] Date and Timestamp options are not working in SDK

Issue:- Date and Timestamp format is passed in options of SDK but data load 
is failed even correct data is set as per format .
Cause:- Load model is getting overwritten with default .
Fix :- if user has passed the options then Load model should use from 
Options otherwise from Default. 


 - [ ] Any interfaces changed?
NO 
 - [ ] Any backward compatibility impacted?
 No
 - [ ] Document update required?
No
 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
 --UT is added   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
NA


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2401

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2227


commit 5b33b6c44cb86de54af8c021a5b5fc5c6948d2a9
Author: BJangir 
Date:   2018-04-25T12:57:58Z

[CARBONDATA-2401] Date and Timestamp options are not working in SDK




---