[GitHub] carbondata pull request #2372: [CARBONDATA-2609] Change RPC implementation t...

[jackylk]

Github user jackylk closed the pull request at:

https://github.com/apache/carbondata/pull/2372


---

[GitHub] carbondata pull request #2372: [CARBONDATA-2609] Change RPC implementation t...

[xubo245]

Github user xubo245 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2372#discussion_r197431627
  
--- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/SearchModeTestCase.scala
 ---
@@ -137,7 +149,7 @@ class SearchModeTestCase extends QueryTest with 
BeforeAndAfterAll {
 sql("DROP DATAMAP if exists dm3 ON TABLE main")
   }
 
-  test("start search mode twice") {
+  ignore("start search mode twice") {
--- End diff --

Why ignore it? 


---

[GitHub] carbondata pull request #2372: [CARBONDATA-2609] Change RPC implementation t...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2372#discussion_r196823447
  
--- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
@@ -80,7 +80,7 @@ public void initialize(InputSplit inputSplit, 
TaskAttemptContext context)
 }
 // It should use the exists tableBlockInfos if tableBlockInfos of 
queryModel is not empty
 // otherwise the prune is no use before this method
-if (!queryModel.isFG()) {
+if (queryModel.getTableBlockInfos().isEmpty()) {
--- End diff --

I have added a new RecordReader called `IndexedRecordReader`, I am using 
this one in search mode now. So this problem will not come. I will remove line 
83.


---

[GitHub] carbondata pull request #2372: [CARBONDATA-2609] Change RPC implementation t...

[xubo245]

Github user xubo245 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2372#discussion_r196633489
  
--- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
@@ -80,7 +80,7 @@ public void initialize(InputSplit inputSplit, 
TaskAttemptContext context)
 }
 // It should use the exists tableBlockInfos if tableBlockInfos of 
queryModel is not empty
 // otherwise the prune is no use before this method
-if (!queryModel.isFG()) {
+if (queryModel.getTableBlockInfos().isEmpty()) {
--- End diff --

If use  (queryModel.getTableBlockInfos().isEmpty()),  when the prune result 
is empty by FG in search mode, it will use the original TableBlockInfos and 
execute again, it mean the FG no use in this scenario. So we cannot change it 
to queryModel.getTableBlockInfos().isEmpty()


---