[GitHub] carbondata pull request #2507: [CABONDATA-2741]Fix for fetching random query...

2018-07-16 Thread ravipesala 
Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2507#discussion_r202634979
  
--- Diff: 
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
 ---
@@ -709,6 +710,18 @@ test("test alter command for boolean data type with 
correct default measure valu
   Seq(Row(1))
 )
   }
+
+  test("Alter table selection in random order"){
+sql("create table restructure_random_select (imei string,channelsId 
string,gamePointId double,deviceInformationId double," +
+" deliverycharge double) STORED BY 'org.apache.carbondata.format' 
TBLPROPERTIES('table_blocksize'='2000','sort_columns'='imei')")
+sql("insert into restructure_random_select 
values('abc','def',50.5,30.2,40.6) ")
+sql("Alter table restructure_random_select add columns (age int,name 
String)")
+checkAnswer(
+  sql("select gamePointId,deviceInformationId,age,name from 
restructure_random_select where name is NULL or channelsId=4"),
--- End diff --

Try query `select age,name,gamePointId,deviceInformationId from 
restructure_random_select where name is NULL or channelsId=4` , it still fails 
so the fix should not be order problem, I think the fix should be core package 
not in integration.


---

[GitHub] carbondata pull request #2507: [CABONDATA-2741]Fix for fetching random query...

2018-07-15 Thread manishgupta88 
Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2507#discussion_r202576343
  
--- Diff: 
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
 ---
@@ -709,6 +709,22 @@ test("test alter command for boolean data type with 
correct default measure valu
   Seq(Row(1))
 )
   }
+
+  test("Alter table selection in random order"){
+sql("drop database if exists carbon cascade")
+sql(s"create database carbon location '$dblocation'")
+sql("use carbon")
+sql("create table brinjal (imei string,channelsId string,gamePointId 
double,deviceInformationId double," +
--- End diff --

No need to create database in the test case. Use default database and also 
use a unique tableName...


---

[GitHub] carbondata pull request #2507: [CABONDATA-2741]Fix for fetching random query...

2018-07-13 Thread jatin9896 
GitHub user jatin9896 opened a pull request:

https://github.com/apache/carbondata/pull/2507

[CABONDATA-2741]Fix for fetching random query order by set in case of 
restructure

Description : 
Using AttributeSet changes the order id of the query, as a set does not 
maintain order. so, changes the same with Sequence.
Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed? No
 
 - [ ] Any backward compatibility impacted? No
 
 - [ ] Document update required? No

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required? yes
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.  Na



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jatin9896/incubator-carbondata CARBONDATA-2741

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2507


commit d4fd5ef44b2528b00456f19f02cee73cd9d427c2
Author: Jatin 
Date:   2018-07-13T15:30:33Z

Fix for fetching random query order by set in case of restructure




---