[GitHub] carbondata pull request #2521: [CARBONDATA-2751] Fixed Thread leak issue in ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2521


---

[GitHub] carbondata pull request #2521: [CARBONDATA-2751] Fixed Thread leak issue in ...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2521#discussion_r203603034
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterProcessorStepImpl.java
 ---
@@ -80,6 +85,7 @@ public 
DataWriterProcessorStepImpl(CarbonDataLoadConfiguration configuration) {
   @Override public void initialize() throws IOException {
 super.initialize();
 child.initialize();
+this.carbonFactHandlers = new CopyOnWriteArrayList<>();
--- End diff --

Please do similar handing for `DataWriterBatchProcessorStepImpl` as well


---

[GitHub] carbondata pull request #2521: [CARBONDATA-2751] Fixed Thread leak issue in ...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2521#discussion_r203602958
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterProcessorStepImpl.java
 ---
@@ -184,12 +190,14 @@ private void processRange(Iterator 
insideRangeIterator,
 dataHandler = CarbonFactHandlerFactory
 .createCarbonFactHandler(model);
 dataHandler.initialise();
+carbonFactHandlers.add(dataHandler);
--- End diff --

Better add before initialize, so can you move this line above.


---