[GitHub] carbondata pull request #2698: [HOTFIX] Fixed LRU cache bug to invalidate th...

2018-09-10 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2698


---

[GitHub] carbondata pull request #2698: [HOTFIX] Fixed LRU cache bug to invalidate th...

2018-09-07 Thread manishgupta88 
Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2698#discussion_r215984873
  
--- Diff: 
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCacheKeyValue.java
 ---
@@ -100,6 +100,10 @@ public long getMemorySize() {
   return size;
 }
 
+@Override public void invalidate() {
--- End diff --

Made bloomFilters object to null


---

[GitHub] carbondata pull request #2698: [HOTFIX] Fixed LRU cache bug to invalidate th...

2018-09-07 Thread xuchuanyin 
Github user xuchuanyin commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2698#discussion_r215970191
  
--- Diff: 
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCacheKeyValue.java
 ---
@@ -100,6 +100,10 @@ public long getMemorySize() {
   return size;
 }
 
+@Override public void invalidate() {
--- End diff --

bloomfileter datamap will do nothing?


---

[GitHub] carbondata pull request #2698: [HOTFIX] Fixed LRU cache bug to invalidate th...

2018-09-06 Thread manishgupta88 
GitHub user manishgupta88 opened a pull request:

https://github.com/apache/carbondata/pull/2698

[HOTFIX] Fixed LRU cache bug to invalidate the cacheable object to clean up 
the resources

This PR contains the fix for LRU cache bug to invalidate the Cacheable 
object while removing it from LRU cache. This will help in clearing the unsafe 
memory for cacheable objects like BlockDataMaps

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manishgupta88/carbondata lru_cache_bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2698.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2698


commit ba4221cc18700b1c22866dbd86055065aefdb1d4
Author: manishgupta88 
Date:   2018-09-06T17:26:49Z

Fixed LRU cache of bug to invalidate the Cacheable object while removing it 
from LRU cache. This will help in clearing the unsafe memory for cacheable 
objects like BlockDataMaps




---