[GitHub] carbondata pull request #2714: [CARBONDATA-2875]Two different threads overwr...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2714#discussion_r217737112
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ---
@@ -708,7 +708,7 @@ public static boolean isBlockInvalid(SegmentStatus 
blockStatus) {
* @return
*/
   public static long readCurrentTime() {
-return System.currentTimeMillis();
+return System.nanoTime();
--- End diff --

This will impact the complete system if you change to nano here. try 
changing the task number to nao instead of here


---

[GitHub] carbondata pull request #2714: [CARBONDATA-2875]Two different threads overwr...

[shardul-cr7]

GitHub user shardul-cr7 opened a pull request:

https://github.com/apache/carbondata/pull/2714

[CARBONDATA-2875]Two different threads overwriting the same carbondatafile.

Problem :- During concurrent load through two different threads in a 
external table for non transactional tables , two different threads were 
overwriting the same carbondata file.

Solution : This was happening because both the threads were assigning the 
same filename for the carbondata files so one was overwriting the other.This 
problem chances is  reduced by changing the timestamp attached to the filename 
from millisecond to nanosecond. 



Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [x] Testing done
Manually.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shardul-cr7/carbondata concurrent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2714.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2714


commit a7fec5bbc8355aaa73f87af7152b3947b8fa9acd
Author: shardul-cr7 
Date:   2018-09-12T12:41:37Z

concurent load




---