[GitHub] carbondata pull request #2726: [CARBONDATA-2948] Float and Byte DataType sup...

2018-09-21 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2726


---

[GitHub] carbondata pull request #2726: [CARBONDATA-2948] Float and Byte DataType sup...

2018-09-19 Thread kunal642 
Github user kunal642 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2726#discussion_r218800702
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -61,7 +61,7 @@
 
   protected static final boolean unsafe = 
Boolean.parseBoolean(CarbonProperties.getInstance()
   .getProperty(CarbonCommonConstants.ENABLE_UNSAFE_COLUMN_PAGE,
-  CarbonCommonConstants.ENABLE_UNSAFE_COLUMN_PAGE_DEFAULT));
+  "false"));
--- End diff --

reverted


---