[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...
Github user ffpeng90 closed the pull request at: https://github.com/apache/incubator-carbondata/pull/738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...
GitHub user ffpeng90 opened a pull request: https://github.com/apache/incubator-carbondata/pull/738 [CARBONDATA-872] Fix comment issues of integration/presto for easier reading Fix comment issues of integration/presto for easier reading You can merge this pull request into a Git repository by running: $ git pull https://github.com/ffpeng90/incubator-carbondata fix_comment Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/738.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #738 commit 9f8f4d31778378adf0a1c3e64de88975bc83d4ec Author: ffpeng90 Date: 2017-04-05T15:00:50Z [CARBONDATA-872] Fix comment issues of integration/presto for easier reading --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #711: [CARBONDATA-834] Fixed Describe Table for P...
Github user ffpeng90 commented on the issue: https://github.com/apache/incubator-carbondata/pull/711 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #712: [CARBONDATA-835] Fixed NullPointerException...
Github user ffpeng90 commented on the issue: https://github.com/apache/incubator-carbondata/pull/712 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [WIP] add intergation with presto
Github user ffpeng90 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 as your wish --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [WIP] add intergation with presto
Github user ffpeng90 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 I'm focusing on two things. 1. let user can debug presto-carbondata in his IDE. 2. use new presto API to support lazy decode. They will be ok soon. At 2017-03-15 10:52:01, "å½" wrote: Hi: 1. This version only suppport DML, All tables for test are created by spark-sql(DML part), and i submit queries to presto to get results. I only tested the "Select" Case , like where, group , sum , join. 2. I use APIs like createQueryPlan, resolveFilter from class "CarbonInputFormatUtil". To read carbon formatted table, i make the read process into several steps: a). load table metadata b). get splits from table (pushing down filtering to filter datablocks of one segment @CarbonTableReader.getInputSplits2 ) c). parse records ( pushing down column projection and filtering into QueryModel @CarbondataRecordSetProvider.getRecordSet ) 3. As i described in partC "parse records", I use QueryModel to get decoded records. For lazy decoding, I will keep on exploring a better solution. Maybe we can get inspiration from module presto-orc, presto-parquet. At 2017-03-15 09:11:19, "Jacky Li" wrote: Thanks for working on this. Can you describe what feature is added in term of: What SQL syntax is supported? DDL &DML? I think it uses CarbonInputFormat to read, so are you pushing down column projection and filtering by setting the configuration in CarbonInputFormat? Is there any SQL optimization integration with Presto's optimizer? like leveraging carbon's global dictionary to do lazy decode? â You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [WIP] add intergation with presto
Github user ffpeng90 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 Hi: 1. This version only suppport DML, All tables for test are created by spark-sql(DML part), and i submit queries to presto to get results. I only tested the "Select" Case , like where, group , sum , join. 2. I use APIs like createQueryPlan, resolveFilter from class "CarbonInputFormatUtil". To read carbon formatted table, i make the read process into several steps: a). load table metadata b). get splits from table (pushing down filtering to filter datablocks of one segment @CarbonTableReader.getInputSplits2 ) c). parse records ( pushing down column projection and filtering into QueryModel @CarbondataRecordSetProvider.getRecordSet ) 3. As i described in partC "parse records", I use QueryModel to get decoded records. For lazy decoding, I will keep on exploring a better solution. Maybe we can get inspiration from module presto-orc, presto-parquet. At 2017-03-15 09:11:19, "Jacky Li" wrote: Thanks for working on this. Can you describe what feature is added in term of: What SQL syntax is supported? DDL &DML? I think it uses CarbonInputFormat to read, so are you pushing down column projection and filtering by setting the configuration in CarbonInputFormat? Is there any SQL optimization integration with Presto's optimizer? like leveraging carbon's global dictionary to do lazy decode? â You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #650: [CARBONDATA-](WIP) a...
GitHub user ffpeng90 opened a pull request: https://github.com/apache/incubator-carbondata/pull/650 [CARBONDATA-](WIP) add intergation with presto Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[CARBONDATA-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - What manual testing you have done? - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/ffpeng90/incubator-carbondata add_presto Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/650.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #650 commit 82168f48a07b1757160147551332bb456df2e65a Author: ffpeng90 Date: 2017-03-12T12:27:32Z add presto integration 0.0.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
