[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 @Sephiroth-Lin Yes you are right, but I feel it is not required to create dictionary while doing codegen, so better avoid dictionary creation while doing codegen. just create only at executor side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user Sephiroth-Lin commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 @ravipesala Yes, inside the code gen, then it will clear for executor side, but for driver side after code gen we also need to clear the access count. From my test, if we don't clear it, then we can't remove it from memory if we don't have enough memory to load another cache. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 @Sephiroth-Lin Actually clearing the cache at the time of codegen generation does not help as it just returns the code string to spark , Spark compiles it and executes as part of WholeCodeGen. We need to find a way to clear inside the code gen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1493/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user Sephiroth-Lin commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 @kumarvishal09 @QiangCai @watermen Please help review, tks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
