[GitHub] incubator-carbondata issue #802: [CARBONDATA-926] Changed max columns from s...

2017-04-17 Thread gvramana
Github user gvramana commented on the issue:

https://github.com/apache/incubator-carbondata/pull/802
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #802: [CARBONDATA-926] Changed max columns from s...

2017-04-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/incubator-carbondata/pull/802
  
Build Success with Spark 1.6.2, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1663/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #802: [CARBONDATA-926] Changed max columns from s...

2017-04-15 Thread gvramana
Github user gvramana commented on the issue:

https://github.com/apache/incubator-carbondata/pull/802
  
Handle all the validation in driver and remove from executor.
parameters: csvheadercolumns, maxcolumns(default 2000), Threashold(2).
1) User configures both  csvheadercolumns, maxcolumns, 
- if csvheadercolumns >= maxcolumns, give error " csvheadercolumns should 
be less than max columns "
- if maxcolumns > threashold, give error "max columns cannot be more than 
threashold(20,000)"
2) User configures csvheadercolumns 
- if csvheadercolumns >= maxcolumns(default)
maxcolumns = csvheadercolumns+1
- if csvheadercolumns >= threashold, give error  " csvheadercolumns should 
be less than max threashold(20,000)"
3) User configures nothing
- if csvheadercolumns >= maxcolumns(default)
maxcolumns = csvheadercolumns+1
- if csvheadercolumns >= threashold, give error  " csvheadercolumns should 
be less than max threashold(20,000)"



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #802: [CARBONDATA-926] Changed max columns from s...

2017-04-15 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/incubator-carbondata/pull/802
  
Build Failed  with Spark 1.6.2, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1647/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #802: [CARBONDATA-926] Changed max columns from s...

2017-04-15 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/802
  
retest this please



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---