[GitHub] incubator-carbondata pull request #432: [CARBONDATA-531] remove spark depend...

2017-01-16 Thread jackylk
Github user jackylk closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/432


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #432: [CARBONDATA-531] remove spark depend...

2016-12-14 Thread jackylk
Github user jackylk commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/432#discussion_r92554824
  
--- Diff: 
integration/spark/src/main/scala/org/apache/spark/sql/CarbonScan.scala ---
@@ -151,8 +153,15 @@ case class CarbonScan(
 
 override def next(): InternalRow = {
   val value = iter.next
+  val converted = value.map {
--- End diff --

understood, I will wait for the performance check in cluster environment 
before reworking on this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---