[GitHub] incubator-carbondata pull request #678: [CARBONDATA-798] Added support to re...

2017-03-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/678


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #678: [CARBONDATA-798] Added support to re...

2017-03-21 Thread gvramana
Github user gvramana commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/678#discussion_r107334090
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommands.scala
 ---
@@ -198,6 +200,27 @@ private[sql] case class 
AlterTableRenameTable(alterTableRenameModel: AlterTableR
 }
 Seq.empty
   }
+
+  private def renameBadRecords(oldTableName: String,
+  newTableName: String,
+  dataBaseName: String) = {
+val badRecordsLocation = CarbonProperties.getInstance()
+  .getProperty(CarbonCommonConstants.CARBON_BADRECORDS_LOC,
+CarbonCommonConstants.CARBON_BADRECORDS_LOC_DEFAULT_VAL)
+val badRecordsDatabase = badRecordsLocation + 
CarbonCommonConstants.FILE_SEPARATOR +
--- End diff --

Use a common function to get bad records location


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---