[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...

[ffpeng90]

Github user ffpeng90 closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/738


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...

[chenliang613]

Github user chenliang613 commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/738#discussion_r110118287
  
--- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataSplitManager.java
 ---
@@ -106,6 +110,12 @@ public ConnectorSplitSource 
getSplits(ConnectorTransactionHandle transactionHand
 return constraintBuilder.build();
   }
 
+  /**
+   * Convert presto-TupleDomain predication into Carbon scan express 
condition
+   * @param originalConstraint  presto-TupleDomain
+   * @param carbonTable
+   * @return
+ */
--- End diff --

please change the comment format.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...

[chenliang613]

Github user chenliang613 commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/738#discussion_r110118360
  
--- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataSplitManager.java
 ---
@@ -249,6 +250,11 @@ public Expression 
parseFilterExpression(TupleDomain originalConstr
 return finalFilters;
   }
 
+  /**
+   * Convert presto spi Type into Carbondata Type
+   * @param colType
+   * @return
+ */
--- End diff --

please change the comment format


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...

[chenliang613]

Github user chenliang613 commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/738#discussion_r110116629
  
--- Diff: integration/presto/src/checkstyle/checks.xml ---
@@ -0,0 +1,7 @@
+
+http://www.puppycrawl.com/dtds/configuration_1_3.dtd;>
--- End diff --

Please remove this file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...

[chenliang613]

Github user chenliang613 commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/738#discussion_r110117100
  
--- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordCursor.java
 ---
@@ -78,6 +78,10 @@ public 
CarbondataRecordCursor(CarbonReadSupport readSupport,
 return columnHandles.get(field).getColumnType();
   }
 
+  /**
+   * get next Row/Page
+   * @return
+ */
--- End diff --

please change format the comment as below : 
/**
 * get next Row/Page
 * @return
 */


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...

[ffpeng90]

GitHub user ffpeng90 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/738

[CARBONDATA-872] Fix comment issues of integration/presto for easier reading

 Fix comment issues of integration/presto for easier reading

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ffpeng90/incubator-carbondata fix_comment

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #738


commit 9f8f4d31778378adf0a1c3e64de88975bc83d4ec
Author: ffpeng90 
Date:   2017-04-05T15:00:50Z

[CARBONDATA-872] Fix comment issues of integration/presto for easier reading




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---