[GitHub] incubator-carbondata pull request #769: [CARBONDATA-888] Added include and e...

[sanoj-mg]

Github user sanoj-mg closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/769


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #769: [CARBONDATA-888] Added include and e...

[jackylk]

Github user jackylk commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/769#discussion_r110798836
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonDataFrameWriter.scala
 ---
@@ -175,13 +175,17 @@ class CarbonDataFrameWriter(val dataFrame: DataFrame) 
{
   }
 
   private def makeCreateTableString(schema: StructType, options: 
CarbonOption): String = {
+val properties = Map("DICTIONARY_INCLUDE" -> options.dictionaryInclude,
+  "DICTIONARY_EXCLUDE" -> 
options.dictionaryExclude).filter(_._2.isDefined)
+  .map(p => s"'${p._1}' = '${p._2.get}'").mkString(",")
--- End diff --

please format it as in spark2 below


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #769: [CARBONDATA-888] Added include and e...

[sanoj-mg]

GitHub user sanoj-mg opened a pull request:

https://github.com/apache/incubator-carbondata/pull/769

[CARBONDATA-888] Added include and exclude dictionary columns in dataframe 
writer

Added options dictionary_include and dictionary_exclude in dataframe 
writer. 

Tested successfully in spark 2.6 / HDP 2.5 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanoj-mg/incubator-carbondata 
CARBONDATA-888-dictionary-incl-excl-dataframe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/769.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #769


commit c1b1fb47fed5f9323cc28c6e95b663827a6bf86a
Author: Sanoj MG 
Date:   2017-04-08T21:38:09Z

Added options to include and exclude dictionary columns in dataframe writer.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---