[jira] [Commented] (CLOUDSTACK-8581) Make S3 TCP KeepAlive and ConnectionTtl configureable
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597769#comment-14597769 ] ASF subversion and git services commented on CLOUDSTACK-8581: - Commit ba18252c5f8f0a8ce44ba2d6586c587f6a964135 in cloudstack's branch refs/heads/CLOUDSTACK-8581 from [~widodh] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ba18252 ] CLOUDSTACK-8581: S3, make connection TTL and TCP KeepAlive configureable Make S3 TCP KeepAlive and ConnectionTtl configureable - Key: CLOUDSTACK-8581 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8581 Project: CloudStack Issue Type: Improvement Security Level: Public(Anyone can view this level - this is the default.) Components: SystemVM Reporter: Wido den Hollander Assignee: Wido den Hollander Fix For: 4.6.0 Currently we can not set the TCP KeepAlive and ConnectionTtl settings for the Amazon S3 ClientConfiguration class: http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/ClientConfiguration.html Our S3Util doesn't set these values so it defaults to what Amazon configures. This doesn't work in all situations and we want to make this configurable. For example the ConnectionTtl should be lowered in cases where the Object Store closes a HTTP connection after a very short period. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CLOUDSTACK-8580) Users should be able to expunge VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lennert den Teuling updated CLOUDSTACK-8580: Description: When automating deployments of CloudStack (with for example Terraform) there are situations where VMs get recreated with the same name (and hostname). When VMs are destroyed by a user, the name will be reserved on the network until the VM truly gets expunged (depending on expunge.delay). Because of this, some automation tools cannot work because a new deployment with the same name gives an error. Users do not have the ability to directly expunge VMs (Only admin and domain-admins can), but they can destroy them and the admin can configure the expunge.delay where VMs truly get removed (expunged). Working with the expunge delay is very safe in case users accidentally remove a VM, but in some cases (when users know what they are doing) there should also be a option to completely remove the VM when destroying it (expunge). Ideally the admin should be able to configure this behavior trough the global settings, cause i believe the admin deliberately needs to turn it on (off by default). We have looked into making our clients domain-admin by default, but that gives them abilities we do not want to give, so we see no other way then just enabling expunge for the user. was: When automating deployments of CloudStack (with for example Terraform) there are situations where VMs get recreated with the same name (and hostname). When VMs are destroyed by a user, the name will be reserved on the network until the VM truly gets expunged (depending on expunge.delay). Users do not have the ability to directly expunge VMs (Only admin and domain-admins can), but they can destroy them and the admin can configure the expunge.delay where VMs truly get removed (expunged). Working with the expunge delay is very safe in case users accidentally remove a VM, but in some cases (when users know what they are doing) there should also be a option to completely remove the VM when destroying it (expunge). Ideally the admin should be able to configure this behavior trough the global settings, cause i believe the admin deliberately needs to turn it on (off by default). We have looked into making our clients domain-admin by default, but that gives them abilities we do not want to give, so we see no other way then just enabling expunge for the user. Users should be able to expunge VMs --- Key: CLOUDSTACK-8580 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8580 Project: CloudStack Issue Type: Improvement Security Level: Public(Anyone can view this level - this is the default.) Reporter: Lennert den Teuling Priority: Minor When automating deployments of CloudStack (with for example Terraform) there are situations where VMs get recreated with the same name (and hostname). When VMs are destroyed by a user, the name will be reserved on the network until the VM truly gets expunged (depending on expunge.delay). Because of this, some automation tools cannot work because a new deployment with the same name gives an error. Users do not have the ability to directly expunge VMs (Only admin and domain-admins can), but they can destroy them and the admin can configure the expunge.delay where VMs truly get removed (expunged). Working with the expunge delay is very safe in case users accidentally remove a VM, but in some cases (when users know what they are doing) there should also be a option to completely remove the VM when destroying it (expunge). Ideally the admin should be able to configure this behavior trough the global settings, cause i believe the admin deliberately needs to turn it on (off by default). We have looked into making our clients domain-admin by default, but that gives them abilities we do not want to give, so we see no other way then just enabling expunge for the user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597628#comment-14597628 ] ASF GitHub Bot commented on CLOUDSTACK-8578: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114495407 @resmo can you send a doc PR so at least we can document this in release notes? listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597626#comment-14597626 ] ASF GitHub Bot commented on CLOUDSTACK-8578: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114495233 this can potentially break clients depending on the behaviour when zoneid is passed listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597606#comment-14597606 ] ASF subversion and git services commented on CLOUDSTACK-8578: - Commit 82ecc1aa06e75bb15fe5d0bd8628f7acc6b61623 in cloudstack's branch refs/heads/master from Rene Moser [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=82ecc1a ] CLOUDSTACK-8578: fix listVirtualMachines does not return deleted machines when zone is specified Signed-off-by: Daan Hoogland daan.hoogl...@gmail.com This closes #510 listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597607#comment-14597607 ] ASF GitHub Bot commented on CLOUDSTACK-8578: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/510 listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597685#comment-14597685 ] ASF GitHub Bot commented on CLOUDSTACK-8578: GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/513 CLOUDSTACK-8578: implement old behaviour for listing only non-destroy… …ed VMs using state=present Also see https://github.com/apache/cloudstack/pull/510#issuecomment-114502611 RFC @bhaisaab You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/CLOUDSTACK-8578-extend Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/513.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #513 commit bf67382521e6df3e12b311fd11f21569564e3920 Author: Rene Moser re...@apache.org Date: 2015-06-23T13:47:06Z CLOUDSTACK-8578: implement old behaviour for listing only non-destroyed VMs using state=present listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597640#comment-14597640 ] ASF GitHub Bot commented on CLOUDSTACK-8578: Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114502611 @bhaisaab Ok. I'll make a doc PR. We could probably think about extending the list API to a state e.g. `present` which returns all VMs in states `starting, running, stopped, stopping'. So the *old* behaviour could be used as well in a proper way. Any thoughts? listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-8581) Make S3 TCP KeepAlive and ConnectionTtl configureable
Wido den Hollander created CLOUDSTACK-8581: -- Summary: Make S3 TCP KeepAlive and ConnectionTtl configureable Key: CLOUDSTACK-8581 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8581 Project: CloudStack Issue Type: Improvement Security Level: Public (Anyone can view this level - this is the default.) Components: SystemVM Reporter: Wido den Hollander Assignee: Wido den Hollander Fix For: 4.6.0 Currently we can not set the TCP KeepAlive and ConnectionTtl settings for the Amazon S3 ClientConfiguration class: http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/ClientConfiguration.html Our S3Util doesn't set these values so it defaults to what Amazon configures. This doesn't work in all situations and we want to make this configurable. For example the ConnectionTtl should be lowered in cases where the Object Store closes a HTTP connection after a very short period. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-8580) Users should be able to expunge VMs
Lennert den Teuling created CLOUDSTACK-8580: --- Summary: Users should be able to expunge VMs Key: CLOUDSTACK-8580 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8580 Project: CloudStack Issue Type: Improvement Security Level: Public (Anyone can view this level - this is the default.) Reporter: Lennert den Teuling Priority: Minor When automating deployments of CloudStack (with for example Terraform) there are situations where VMs get recreated with the same name (and hostname). When VMs are destroyed by a user, the name will be reserved on the network until the VM truly gets expunged (depending on expunge.delay). Users do not have the ability to directly expunge VMs (Only admin and domain-admins can), but they can destroy them and the admin can configure the expunge.delay where VMs truly get removed (expunged). Working with the expunge delay is very safe in case users accidentally remove a VM, but in some cases (when users know what they are doing) there should also be a option to completely remove the VM when destroying it (expunge). Ideally the admin should be able to configure this behavior trough the global settings, cause i believe the admin deliberately needs to turn it on (off by default). We have looked into making our clients domain-admin by default, but that gives them abilities we do not want to give, so we see no other way then just enabling expunge for the user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597605#comment-14597605 ] ASF GitHub Bot commented on CLOUDSTACK-8578: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114486026 good point so backwards compatibility is a glass eye anyway;) will merge listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8559) Source address spoofing prevention in Basic Networking only done for DNS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597671#comment-14597671 ] Wido den Hollander commented on CLOUDSTACK-8559: I already backported this to our production cloud and it works fine there. Source address spoofing prevention in Basic Networking only done for DNS Key: CLOUDSTACK-8559 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8559 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Reporter: Wido den Hollander Assignee: Wido den Hollander Fix For: 4.6.0, 4.5.2 Looking at the security group rules being programmed for Instances it seems that we only drop spoofed traffic when it's for DNS: if vm_ip is not None: execute(iptables -A + vmchain_default + -m physdev --physdev-is-bridged --physdev-in + vif + -m set --set + vmipsetName + src -p udp --dport 53 -j RETURN ) execute(iptables -A + vmchain_default + -m physdev --physdev-is-bridged --physdev-in + vif + -m set --set + vmipsetName + src -j + vmchain_egress) I think that we can drop ALL packets which do not match any of the IPs in the list. I don't see a valid reason why we only do this for DNS/UDP 53. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598382#comment-14598382
]
ASF GitHub Bot commented on CLOUDSTACK-8578:
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/513#discussion_r33093929
--- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java ---
@@ -968,7 +968,11 @@
}
if (state != null) {
-sc.setParameters(stateEQ, state);
+if (state.equalsIgnoreCase(present)) {
--- End diff --
Not sure if this make sense but is Expunged not !Present as well?
listVirtualMachines does not return deleted machines when zone is specified
---
Key: CLOUDSTACK-8578
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578
Project: CloudStack
Issue Type: Bug
Security Level: Public(Anyone can view this level - this is the
default.)
Components: API
Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1
Reporter: René Moser
Priority: Minor
A REST API query command=listVirtualMachineszoneid=zone-uuid does not
return destroyed virtual machines in the response.
There was a similar issue reported in #284 and fixed but in accidentally
re-implemented in
https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597525#comment-14597525 ] ASF GitHub Bot commented on CLOUDSTACK-8578: Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114465874 @DaanHoogland We already do :). User permissions API is **not affected** of this change however. The API does already return VMs `listVirtualMacines` in `destroyed` state if you have *admin* permissions. But if you provide `zoneid` in `listVirtualMacines` with *admin* permissions, it does not return VMs in `destroyed` state. This makes no sense to me. The bug was already fixed in CLOUDSTACK-284 but then the bug was reimplemented by accident. listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8579) Fix cleanup in few test cases
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597539#comment-14597539 ] ASF GitHub Bot commented on CLOUDSTACK-8579: GitHub user gauravaradhye opened a pull request: https://github.com/apache/cloudstack/pull/511 CLOUDSTACK-8579: Fix cleanup operation in few test cases Cleanup list should be declared before returning from setUpClass() so that tearDownClass() works properly. Currently the test cases are failing with Class does not have cleanup attribute. Tested with passing LXC as hypervisor and test cases skipped successfully without giving any error. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gauravaradhye/cloudstack 8579 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 commit d7feb1a54027b73cba3e1ffc3d09d97b072335e2 Author: Gaurav Aradhye gaurav.arad...@clogeny.com Date: 2015-06-23T11:54:05Z CLOUDSTACK-8579: Fix cleanup operation in few test cases Fix cleanup in few test cases - Key: CLOUDSTACK-8579 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8579 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 cleanup list should be declared before returning from setUpClass() so that tearDownClass() works properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8579) Fix cleanup in few test cases
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597544#comment-14597544 ] ASF GitHub Bot commented on CLOUDSTACK-8579: Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/511#issuecomment-114467280 LGTM...Please commit Fix cleanup in few test cases - Key: CLOUDSTACK-8579 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8579 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 cleanup list should be declared before returning from setUpClass() so that tearDownClass() works properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8579) Fix cleanup in few test cases
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597552#comment-14597552 ] ASF subversion and git services commented on CLOUDSTACK-8579: - Commit c841d6850ec591d3545d922dbb469a7e9b9ec4de in cloudstack's branch refs/heads/master from [~gauravaradhye] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c841d68 ] CLOUDSTACK-8579: Fix cleanup operation in few test cases Signed-off-by: Gaurav Aradhye gaurav.arad...@clogeny.com This closes #511 Fix cleanup in few test cases - Key: CLOUDSTACK-8579 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8579 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 cleanup list should be declared before returning from setUpClass() so that tearDownClass() works properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8579) Fix cleanup in few test cases
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597553#comment-14597553 ] ASF GitHub Bot commented on CLOUDSTACK-8579: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/511 Fix cleanup in few test cases - Key: CLOUDSTACK-8579 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8579 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 cleanup list should be declared before returning from setUpClass() so that tearDownClass() works properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8577) [Automation] fixing script test/integration/component/maint/testpath_disable_enable_zone.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598883#comment-14598883 ] ASF subversion and git services commented on CLOUDSTACK-8577: - Commit 49451750a965a0b37409e9661cf4e65090c3047c in cloudstack's branch refs/heads/master from nitt10prashant [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4945175 ] CLOUDSTACK-8577: fixing script testpath_disable_enable_zone [Automation] fixing script test/integration/component/maint/testpath_disable_enable_zone.py Key: CLOUDSTACK-8577 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8577 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: marvin Affects Versions: 4.5.1 Reporter: prashant kumar mishra Assignee: prashant kumar mishra Fix For: 4.5.1 All four test cases was failling , so modified accordingly . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8574) Skip testcases including data disk creation for LXC if storagePool type is not RBD
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597223#comment-14597223 ] ASF GitHub Bot commented on CLOUDSTACK-8574: Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/488#discussion_r33011867 --- Diff: test/integration/component/test_stopped_vm.py --- @@ -53,6 +54,13 @@ def setUpClass(cls): cls.domain = get_domain(cls.api_client) cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) +cls.hypervisor = cls.testClient.getHypervisorInfo() + +if cls.hypervisor.lower() == 'lxc': +if not find_storage_pool_type(cls.apiclient, storagetype='rbd'): +raise unittest.SkipTest(RBD storage type is required for data volumes for LXC) --- End diff -- Done with the review changes. Skip testcases including data disk creation for LXC if storagePool type is not RBD -- Key: CLOUDSTACK-8574 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8574 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.5.1 Reporter: Priti Sarap Fix For: 4.5.1 As LXC DATA disk is supported only on RBD StoragePool skip the testcases where storagepool type is other than RBD -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
René Moser created CLOUDSTACK-8578: -- Summary: listVirtualMachines does not return deleted machines when zone is specified Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: API Affects Versions: 4.5.1, 4.4.3, 4.3.1, 4.2.1, 4.1.1 Reporter: René Moser Priority: Minor Fix For: 4.6.0, 4.4.4, 4.5.2 A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597326#comment-14597326 ] ASF GitHub Bot commented on CLOUDSTACK-8578: GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/510 CLOUDSTACK-8578: fix listVirtualMachines does not return deleted mach… …ines when zone is specified You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/CLOUDSTACK-8578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/510.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #510 commit 477fdef6d6b07de8f0b8c4fd2a99315be054264b Author: Rene Moser re...@apache.org Date: 2015-06-23T08:17:25Z CLOUDSTACK-8578: fix listVirtualMachines does not return deleted machines when zone is specified listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor Fix For: 4.6.0, 4.4.4, 4.5.2 A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-8579) Fix cleanup in few test cases
Gaurav Aradhye created CLOUDSTACK-8579: -- Summary: Fix cleanup in few test cases Key: CLOUDSTACK-8579 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8579 Project: CloudStack Issue Type: Test Security Level: Public (Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Fix For: 4.6.0 cleanup list should be declared before returning from setUpClass() so that tearDownClass() works properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597447#comment-14597447 ] ASF GitHub Bot commented on CLOUDSTACK-8578: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114432879 why should we return machines that no longer exist? listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor Fix For: 4.6.0, 4.4.4, 4.5.2 A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597455#comment-14597455 ] Daan Hoogland commented on CLOUDSTACK-8578: --- Rene, your proposed fix will result in the UI showing destroyed machines as well. You can explicitaly search for state=DESTROYED and get them. If you need them in one call you'll have to create a new call. This will break existing behavior. listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CLOUDSTACK-8578) listVirtualMachines does not return deleted machines when zone is specified
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daan Hoogland updated CLOUDSTACK-8578: -- Fix Version/s: (was: 4.5.2) (was: 4.4.4) (was: 4.6.0) listVirtualMachines does not return deleted machines when zone is specified --- Key: CLOUDSTACK-8578 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8578 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.1.1, 4.2.1, 4.3.1, 4.4.3, 4.5.1 Reporter: René Moser Priority: Minor A REST API query command=listVirtualMachineszoneid=zone-uuid does not return destroyed virtual machines in the response. There was a similar issue reported in #284 and fixed but in accidentally re-implemented in https://github.com/apache/cloudstack/commit/c167ad45e3480160c086e5bf532a72d9704c072b#diff-20f157170d9a50e3010375d071fd4db5R747 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
