[jira] [Commented] (CLOUDSTACK-5822) ssh keypairs are removed after rebooting vm

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980365#comment-14980365
 ] 

Wei Zhou commented on CLOUDSTACK-5822:
--

Kirk,
thanks. indeed it is fixed by the commit 
6f244f3eac5201bef26c29e57f316378aed18953 by Wido.



> ssh keypairs are removed after rebooting vm
> ---
>
> Key: CLOUDSTACK-5822
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5822
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.3.0
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>
> For a ssh keypair-enabled vm, the keys in /root/.ssh/authorized_keys will be 
> reset after rebooting the vm. Only the keypair specified in cloudstack will 
> be added. We should keep the keypairs added by users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CLOUDSTACK-8958) add dedicated ips to domain

[Wei Zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei Zhou updated CLOUDSTACK-8958:
-
Status: Reviewable  (was: In Progress)

> add dedicated ips to domain
> ---
>
> Key: CLOUDSTACK-8958
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8958
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>
> add dedicated ips to domain 
> ips are dedicated to Account for now, so other customers and projects in the 
> same domain will use the system ip. this is not what we need.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8964) Can't create template or volume from snapshot - "Are you sure you got the right type of server?"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980459#comment-14980459
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8964:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/975#issuecomment-152189257
  
Ping @remibergsma @snuf 

I did not test any OVM3 specifics, but @snuf did. The PR doesn't break 
existing functionality.

Although the "hardware required=false" tests are still running, I would 
like to give my LGTM! :+1: 

Tests results:

* Hardware required: true
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* Agent and Common RPMs built from source

```
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
--
Ran 27 tests in 13849.872s

OK
(END)
```

Cheers,
Wilder


> Can't create template or volume from snapshot - "Are you sure you got the 
> right type of server?"
> 
>
> Key: CLOUDSTACK-8964
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8964
> Project: CloudStack
>  Issue Type: Bug
>  

[jira] [Closed] (CLOUDSTACK-8941) NPE when migrate vm to other zone-wide pools the second time

[Wei Zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei Zhou closed CLOUDSTACK-8941.

Resolution: Fixed

> NPE when migrate vm to other zone-wide pools the second time
> 
>
> Key: CLOUDSTACK-8941
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8941
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>
> when I migrate vm to another zone wide pool, and migrate it again back or to 
> another pool, it will fail with the following NPE:
> 2015-10-06 12:29:11,114 ERROR [cloud.async.AsyncJobManagerImpl] 
> (Job-Executor-2:job-1587 = [ 72393be7-bc02-4974-b89d-53cbaa98916c ]) 
> Unexpected exception while executing 
> org.apache.cloudstack.api.command.admin.vm.MigrateVMCmd
> java.lang.NullPointerException
> at 
> com.cloud.vm.VirtualMachineManagerImpl.orchestrateStorageMigration(VirtualMachineManagerImpl.java:1783)
> at 
> com.cloud.vm.VirtualMachineManagerImpl.storageMigration(VirtualMachineManagerImpl.java:1734)
> at 
> com.cloud.vm.UserVmManagerImpl.vmStorageMigration(UserVmManagerImpl.java:4342)
> at 
> org.apache.cloudstack.api.command.admin.vm.MigrateVMCmd.execute(MigrateVMCmd.java:166)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
> at 
> com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:97)
> at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:507)
> This is because the pod_id is set to NULL at the first time when I migrate 
> the instance to a zone-wide pool (not cluster-wide).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980395#comment-14980395
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8977:


Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152176166
  
Hi @k0zka are you saying it might be specific to tomcat6? Reverting the the 
change works fine.
 Do you think we should revert this until we find a solution which also 
works on tomcat6?


> cloudstack UI creates a session for users not yet logged in
> ---
>
> Key: CLOUDSTACK-8977
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.5.2
>Reporter: Laszlo Hornyak
>Assignee: Laszlo Hornyak
> Fix For: Future
>
>   Original Estimate: 0.1h
>  Remaining Estimate: 0.1h
>
> The cloudstack UI always creates a session. By executing a command like 'ab 
> -n 20 -c 32' the server can be killed reqlly quick.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980452#comment-14980452
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8984:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152187750
  
Ping  @remibergsma @DaanHoogland @borisroman @wido @miguelaferreira  

Thanks, @karuturi!  :) LGTM :+1: 

Test results:

* Hardware required: false
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common RPMs built from source

```
Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: 
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980487#comment-14980487
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152193618
  
by the way, for user vms, I think it is better to add the field in 
vm_instance/user_vm or zone/cluster/global setting to determine if the vm is 
qemu guest agent enabled.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8958) add dedicated ips to domain

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980401#comment-14980401
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8958:


GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1007

CLOUDSTACK-8958: add dedicated ips to domain (account for now)

For now, we dedicate ip pool to account, however, other accounts in the 
same domain cannot fetch the ip from this ip pool.
By dedicating ip pool to domain, accounts in the domain can fetch the 
public ip from same ip pool.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack dedicated-ip-for-domain

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1007


commit cf39ff300e476a565c73ddf159ff836d52b6ae44
Author: Wei Zhou 
Date:   2015-08-10T13:05:04Z

CLOUDSTACK-8958: add dedicated ips to domain (account for now)




> add dedicated ips to domain
> ---
>
> Key: CLOUDSTACK-8958
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8958
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>
> add dedicated ips to domain 
> ips are dedicated to Account for now, so other customers and projects in the 
> same domain will use the system ip. this is not what we need.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980424#comment-14980424
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user serbaut commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152180011
  
Thank you, that would have taken me days to write.


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980446#comment-14980446
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152183473
  
I have same issue with Remi,
there are two virtio-serial in the vm definition.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980496#comment-14980496
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1002#discussion_r43389852
  
--- Diff: test/integration/component/test_router_dhcphosts.py ---
@@ -0,0 +1,381 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Import Local Modules
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (stopVirtualMachine,
+  stopRouter,
+  startRouter)
+from marvin.lib.utils import (cleanup_resources,
+  get_process_status)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ ServiceOffering,
+ NATRule,
+ NetworkACL,
+ FireWallRule,
+ PublicIPAddress,
+ NetworkOffering,
+ Network,
+ Router)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_virtual_machines,
+   list_networks,
+   list_configurations,
+   list_routers,
+   list_nat_rules,
+   list_publicIP,
+   list_firewall_rules,
+   list_hosts)
+
+# Import System modules
+import time
+import logging
+
+
+class TestRouterDHCPHosts(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+cls.logger = logging.getLogger('TestRouterDHCPHosts')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDHCPHosts, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+  

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980461#comment-14980461
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152189749
  
@remibergsma @karuturi 

All green... Do you have some time to review/merge this PR? It's a test, no 
code - neither on the routers nor the java side - was changed.

Cheers,
Wilder


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8964) Can't create template or volume from snapshot - "Are you sure you got the right type of server?"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980497#comment-14980497
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8964:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/975#issuecomment-152195378
  
@snuf Can you respond to the comment by @dahn? Then we can proceed to merge 
this. Thanks!


> Can't create template or volume from snapshot - "Are you sure you got the 
> right type of server?"
> 
>
> Key: CLOUDSTACK-8964
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8964
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Secondary Storage
>Affects Versions: 4.6.0
> Environment: CentOS 6 HVs & mgmt
>Reporter: Nux
>Assignee: Wei Zhou
>Priority: Blocker
> Fix For: 4.6.0
>
>
> I have a couple of snapshots left-over from by  now deleted instances. Trying 
> to turn them into volumes fails with (UI/cloudmonkey shows this):
> "Failed to create templateUnsupported command issued: 
> org.apache.cloudstack.storage.command.CopyCommand. Are you sure you got the 
> right type of server?"
> mgmt server logs for when trying to create template:
> "2015-10-18 09:15:58,437 DEBUG [c.c.a.ApiServlet] 
> (catalina-exec-5:ctx-84b2a9be) ===START===  192.168.192.198 -- GET  
> command=createTemplate=json=da79387b-ecae-4d5c-b414-3942d29ad821=testsnap1=testsnap1=ba03db1c-7359-11e5-b4d0-f2a3ece198a5=false=false=false&_=1445156157698
> 2015-10-18 09:15:58,459 DEBUG [c.c.t.TemplateManagerImpl] 
> (catalina-exec-5:ctx-84b2a9be ctx-921b9b20) This template is getting created 
> from other template, setting source template Id to: 201
> 2015-10-18 09:15:58,500 INFO  [o.a.c.f.j.i.AsyncJobMonitor] 
> (API-Job-Executor-33:ctx-f566f6af job-135) Add job-135 into job monitoring
> 2015-10-18 09:15:58,506 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (catalina-exec-5:ctx-84b2a9be ctx-921b9b20) submit async job-135, details: 
> AsyncJobVO {id:135, userId: 2, accountId: 2, instanceType: Template, 
> instanceId: 207, cmd: 
> org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin, 
> cmdInfo: 
> {"cmdEventType":"TEMPLATE.CREATE","ctxUserId":"2","httpmethod":"GET","osTypeId":"ba03db1c-7359-11e5-b4d0-f2a3ece198a5","isPublic":"false","isdynamicallyscalable":"false","response":"json","id":"207","ctxDetails":"{\"interface
>  
> com.cloud.template.VirtualMachineTemplate\":\"9c045e56-2463-47f8-a257-840656e1c0bd\",\"interface
>  
> com.cloud.storage.Snapshot\":\"da79387b-ecae-4d5c-b414-3942d29ad821\",\"interface
>  
> com.cloud.storage.GuestOS\":\"ba03db1c-7359-11e5-b4d0-f2a3ece198a5\"}","displayText":"testsnap1","snapshotid":"da79387b-ecae-4d5c-b414-3942d29ad821","passwordEnabled":"false","name":"testsnap1","_":"1445156157698","uuid":"9c045e56-2463-47f8-a257-840656e1c0bd","ctxAccountId":"2","ctxStartEventId":"253"},
>  cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
> null, initMsid: 266785867798693, completeMsid: null, lastUpdated: null, 
> lastPolled: null, created: null}
> 2015-10-18 09:15:58,506 DEBUG [c.c.a.ApiServlet] 
> (catalina-exec-5:ctx-84b2a9be ctx-921b9b20) ===END===  192.168.192.198 -- GET 
>  
> command=createTemplate=json=da79387b-ecae-4d5c-b414-3942d29ad821=testsnap1=testsnap1=ba03db1c-7359-11e5-b4d0-f2a3ece198a5=false=false=false&_=1445156157698
> 2015-10-18 09:15:58,507 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (API-Job-Executor-33:ctx-f566f6af job-135) Executing AsyncJobVO {id:135, 
> userId: 2, accountId: 2, instanceType: Template, instanceId: 207, cmd: 
> org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin, 
> cmdInfo: 
> {"cmdEventType":"TEMPLATE.CREATE","ctxUserId":"2","httpmethod":"GET","osTypeId":"ba03db1c-7359-11e5-b4d0-f2a3ece198a5","isPublic":"false","isdynamicallyscalable":"false","response":"json","id":"207","ctxDetails":"{\"interface
>  
> com.cloud.template.VirtualMachineTemplate\":\"9c045e56-2463-47f8-a257-840656e1c0bd\",\"interface
>  
> com.cloud.storage.Snapshot\":\"da79387b-ecae-4d5c-b414-3942d29ad821\",\"interface
>  
> com.cloud.storage.GuestOS\":\"ba03db1c-7359-11e5-b4d0-f2a3ece198a5\"}","displayText":"testsnap1","snapshotid":"da79387b-ecae-4d5c-b414-3942d29ad821","passwordEnabled":"false","name":"testsnap1","_":"1445156157698","uuid":"9c045e56-2463-47f8-a257-840656e1c0bd","ctxAccountId":"2","ctxStartEventId":"253"},
>  cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
> null, initMsid: 266785867798693, completeMsid: null, lastUpdated: null, 
> lastPolled: null, created: null}
> 2015-10-18 09:15:58,531 DEBUG 

[jira] [Commented] (CLOUDSTACK-8940) Wrong value is inserted into nics table netmask field when creating a VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980289#comment-14980289
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8940:


Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/916#issuecomment-152152422
  
@remibergsma @bhaisaab The above changes were made as the part of DHCP/DNS 
offload feature. The related ticket is 
https://issues.apache.org/jira/browse/CLOUDSTACK-8324 
As we can see that the fix version is 4.6.0, so I guess no update script is 
needed. Am I correct?


> Wrong value is inserted into nics table netmask field when creating a VM
> 
>
> Key: CLOUDSTACK-8940
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8940
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Kshitij Kansal
>Priority: Critical
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980458#comment-14980458
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152188711
  
Hmm, ok. That should be allowed. Since we want the Guest tools also to be 
supported on SSVMs to control them properly.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980451#comment-14980451
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152187084
  
succeed after the following change:

diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingReso
index 4ce1889..59b0c3c 100755
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -1994,13 +1994,13 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv
 final SerialDef serial = new SerialDef("pty", null, (short)0);
 devices.addDevice(serial);

-/* Add a VirtIO channel for the Qemu Guest Agent tools */
-devices.addDevice(new ChannelDef("org.qemu.guest_agent.0", 
ChannelDef.ChannelType.UNIX));
-
 /* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
 if (vmTO.getType() != VirtualMachine.Type.User) {
 devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
  "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".agent"));
+} else {
+/* Add a VirtIO channel for the Qemu Guest Agent tools */
+devices.addDevice(new ChannelDef("org.qemu.guest_agent.0", 
ChannelDef.ChannelType.UNIX));
 }

 final VideoDef videoCard = new VideoDef(_videoHw, _videoRam);



> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980477#comment-14980477
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152191665
  
that is good idea. then we need to rebuild systemvm template with 
qemu-guest-agent


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980495#comment-14980495
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152194820
  
@wilderrodrigues Testing this now


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (CLOUDSTACK-8990) start a stopped machine on a specific determinable host on UI

[Wei Zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei Zhou closed CLOUDSTACK-8990.

   Resolution: Fixed
Fix Version/s: 4.6.0

> start a stopped machine on a specific determinable host on UI
> -
>
> Key: CLOUDSTACK-8990
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8990
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>Priority: Minor
> Fix For: 4.6.0
>
>
> This is already implemented in API ,but not on UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980392#comment-14980392
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8993:


Github user serbaut commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152175108
  
Sorry, been busy. Running tests now.



> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>Priority: Critical
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the 
> same IP address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980431#comment-14980431
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user serbaut commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1002#discussion_r43384431
  
--- Diff: test/integration/component/test_router_dhcphosts.py ---
@@ -0,0 +1,381 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Import Local Modules
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (stopVirtualMachine,
+  stopRouter,
+  startRouter)
+from marvin.lib.utils import (cleanup_resources,
+  get_process_status)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ ServiceOffering,
+ NATRule,
+ NetworkACL,
+ FireWallRule,
+ PublicIPAddress,
+ NetworkOffering,
+ Network,
+ Router)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_virtual_machines,
+   list_networks,
+   list_configurations,
+   list_routers,
+   list_nat_rules,
+   list_publicIP,
+   list_firewall_rules,
+   list_hosts)
+
+# Import System modules
+import time
+import logging
+
+
+class TestRouterDHCPHosts(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+cls.logger = logging.getLogger('TestRouterDHCPHosts')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDHCPHosts, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+  

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980319#comment-14980319
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152157162
  
@borisroman Could you give this PR a spin?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (CLOUDSTACK-5822) ssh keypairs are removed after rebooting vm

[Wei Zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei Zhou closed CLOUDSTACK-5822.

Resolution: Fixed

> ssh keypairs are removed after rebooting vm
> ---
>
> Key: CLOUDSTACK-5822
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5822
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.3.0
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>
> For a ssh keypair-enabled vm, the keys in /root/.ssh/authorized_keys will be 
> reset after rebooting the vm. Only the keypair specified in cloudstack will 
> be added. We should keep the keypairs added by users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980411#comment-14980411
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8977:


Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152178160
  
@K0zka @karuturi I am using tomcat 6 as well. agree with Rajani


> cloudstack UI creates a session for users not yet logged in
> ---
>
> Key: CLOUDSTACK-8977
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.5.2
>Reporter: Laszlo Hornyak
>Assignee: Laszlo Hornyak
> Fix For: Future
>
>   Original Estimate: 0.1h
>  Remaining Estimate: 0.1h
>
> The cloudstack UI always creates a session. By executing a command like 'ab 
> -n 20 -c 32' the server can be killed reqlly quick.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980329#comment-14980329
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152161769
  
@wido I will also test it again today.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980589#comment-14980589
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152208845
  
@serbaut If you think this should go into master, please comment LGTM 
(Looks Good To Me) with any testing / verification you did. We need 2 LGTMs 
before we can merge.


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980539#comment-14980539
 ] 

ASF subversion and git services commented on CLOUDSTACK-8984:
-

Commit d9f614cea22efb454b34572576ff59c01e694dce in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d9f614c ]

CLOUDSTACK-8984: VPC Network offerings tab missing from UI

This is a regression from commit af2f21894ce061faadc8cec29b901719303a29dc

added vpcofferings to the select list


> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980542#comment-14980542
 ] 

ASF subversion and git services commented on CLOUDSTACK-8984:
-

Commit 73c6c6c96b227ec2843c0c6bc5ce7f6d7205ee4f in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=73c6c6c ]

Merge pull request #996 from karuturi/CLOUDSTACK-8984

[4.6] CLOUDSTACK-8984: VPC Network offerings tab missing from UIThis is a 
regression from commit af2f21894ce061faadc8cec29b901719303a29dc

added vpcofferings to the select list

Before the change (from the bug):
![offerings_46](https://cloud.githubusercontent.com/assets/186833/10781847/34ae9bc4-7d71-11e5-8159-b90422ef34f6.png)

After the change:
![screen shot 2015-10-28 at 12 32 59 
pm](https://cloud.githubusercontent.com/assets/186833/10781850/3ef96500-7d71-11e5-84c5-34589ec10bf9.png)

* pr/996:
  CLOUDSTACK-8984: VPC Network offerings tab missing from UI

Signed-off-by: Remi Bergsma 


> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980543#comment-14980543
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8984:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/996


> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980548#comment-14980548
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8984:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152202839
  
Ping @bhaisaab you may want to backport this small fix to 4.5


> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980586#comment-14980586
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8977:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152208509
  
@K0zka If you know of a fix for Tomcat6 we can merge that. Otherwise I 
think we should consider reverting. We can wait a bit but if there is no 
solution at the time we're about to cut a RC we better revert.

Do you guys install RPMs?

@miguelaferreira Can you please test this against Tomcat7?


> cloudstack UI creates a session for users not yet logged in
> ---
>
> Key: CLOUDSTACK-8977
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.5.2
>Reporter: Laszlo Hornyak
>Assignee: Laszlo Hornyak
> Fix For: Future
>
>   Original Estimate: 0.1h
>  Remaining Estimate: 0.1h
>
> The cloudstack UI always creates a session. By executing a command like 'ab 
> -n 20 -c 32' the server can be killed reqlly quick.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980554#comment-14980554
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152203550
  
LGTM

Run this:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true 
test/integration/component/test_router_dhcphosts.py
```

Result:
```
[root@cs1 cloudstack]# cat 
/tmp//MarvinLogs/test_router_dhcphosts_7W9M1B/results.txt 
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok

--
Ran 1 test in 481.194s

OK
```



> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980568#comment-14980568
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8984:


Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152205902
  
@remibergsma just checked this does not apply for 4.5, 4.5 has no prefilter 
in that section
(see screenshot on 4.5)

![screen shot 2015-10-29 at 8 25 52 
pm](https://cloud.githubusercontent.com/assets/95203/10822074/8253e96e-7e7b-11e5-8e12-d1fdd2fbc629.png)



> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980571#comment-14980571
 ] 

ASF subversion and git services commented on CLOUDSTACK-8993:
-

Commit f413f69985edff722bf33d43ca0f57560bb8516d in cloudstack's branch 
refs/heads/master from [~serbaut]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f413f69 ]

CLOUDSTACK-8993: DHCP fails with "no address available" when an IP is reused

Repopulate /etc/dhcphosts.txt to remove old entries with the same IP address.


> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>Priority: Critical
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the 
> same IP address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980573#comment-14980573
 ] 

ASF subversion and git services commented on CLOUDSTACK-8993:
-

Commit 323a2aaa2af2f9dd6dff5860b58f4c590e01819b in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=323a2aa ]

Merge pull request #981 from serbaut/repopulate-dhcphost

CLOUDSTACK-8993: DHCP fails with "no address available" when an IP is reused

Repopulate /etc/dhcphosts.txt to remove old entries with the same IP address.

* pr/981:
  CLOUDSTACK-8993: DHCP fails with "no address available" when an IP is reused

Signed-off-by: Remi Bergsma 


> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>Priority: Critical
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the 
> same IP address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980572#comment-14980572
 ] 

ASF subversion and git services commented on CLOUDSTACK-8993:
-

Commit 323a2aaa2af2f9dd6dff5860b58f4c590e01819b in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=323a2aa ]

Merge pull request #981 from serbaut/repopulate-dhcphost

CLOUDSTACK-8993: DHCP fails with "no address available" when an IP is reused

Repopulate /etc/dhcphosts.txt to remove old entries with the same IP address.

* pr/981:
  CLOUDSTACK-8993: DHCP fails with "no address available" when an IP is reused

Signed-off-by: Remi Bergsma 


> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>Priority: Critical
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the 
> same IP address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980574#comment-14980574
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8993:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/981


> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>Priority: Critical
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the 
> same IP address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980536#comment-14980536
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8984:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152201239
  
LGTM as well!

![screen shot 2015-10-29 at 15 41 
17](https://cloud.githubusercontent.com/assets/1630096/10821620/8e8cd2ae-7e53-11e5-94ca-9ef5b251da5d.png)



> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980558#comment-14980558
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8984:


Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152203911
  
@remibergsma good idea, will do thanks


> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8919) Slow UI response while loading the list of networks in network tab.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980629#comment-14980629
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8919:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/897#issuecomment-152214761
  
@nitin-maharana I looked at this, seems good. What is the best way to test 
this or see the difference?


> Slow UI response while loading the list of networks in network tab.
> ---
>
> Key: CLOUDSTACK-8919
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8919
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Reporter: Nitin Kumar Maharana
>
> Root cause of this Issue: Invokes 3 APIs, the 2nd API to check whether any 
> network is having security group service, this consumes 90% of the time. API 
> fetches network list and for each network calls DB to get services associated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980540#comment-14980540
 ] 

ASF subversion and git services commented on CLOUDSTACK-8984:
-

Commit 73c6c6c96b227ec2843c0c6bc5ce7f6d7205ee4f in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=73c6c6c ]

Merge pull request #996 from karuturi/CLOUDSTACK-8984

[4.6] CLOUDSTACK-8984: VPC Network offerings tab missing from UIThis is a 
regression from commit af2f21894ce061faadc8cec29b901719303a29dc

added vpcofferings to the select list

Before the change (from the bug):
![offerings_46](https://cloud.githubusercontent.com/assets/186833/10781847/34ae9bc4-7d71-11e5-8159-b90422ef34f6.png)

After the change:
![screen shot 2015-10-28 at 12 32 59 
pm](https://cloud.githubusercontent.com/assets/186833/10781850/3ef96500-7d71-11e5-84c5-34589ec10bf9.png)

* pr/996:
  CLOUDSTACK-8984: VPC Network offerings tab missing from UI

Signed-off-by: Remi Bergsma 


> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8984) VPC Network offerings tab missing from UI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980541#comment-14980541
 ] 

ASF subversion and git services commented on CLOUDSTACK-8984:
-

Commit 73c6c6c96b227ec2843c0c6bc5ce7f6d7205ee4f in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=73c6c6c ]

Merge pull request #996 from karuturi/CLOUDSTACK-8984

[4.6] CLOUDSTACK-8984: VPC Network offerings tab missing from UIThis is a 
regression from commit af2f21894ce061faadc8cec29b901719303a29dc

added vpcofferings to the select list

Before the change (from the bug):
![offerings_46](https://cloud.githubusercontent.com/assets/186833/10781847/34ae9bc4-7d71-11e5-8159-b90422ef34f6.png)

After the change:
![screen shot 2015-10-28 at 12 32 59 
pm](https://cloud.githubusercontent.com/assets/186833/10781850/3ef96500-7d71-11e5-84c5-34589ec10bf9.png)

* pr/996:
  CLOUDSTACK-8984: VPC Network offerings tab missing from UI

Signed-off-by: Remi Bergsma 


> VPC Network offerings tab missing from UI
> -
>
> Key: CLOUDSTACK-8984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8984
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Rajani Karuturi
>Priority: Critical
> Attachments: offerings_44.png, offerings_46.png
>
>
> Home - Service Offerings - Network Offerings
> There used to be a tab to display the VPC offerings, but it's no longer 
> there. See difference in screenshots. It was there in 4.4.4.
> Please add it again as you cannot add VPC offerings now (only through the 
> API).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8956) NSX/Nicira Plugin does not support NSX v4.2.1

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980519#comment-14980519
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8956:


Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/935#issuecomment-152197682
  
@nvazquez I havent' forgotten your PR. I'm having some trouble with the 
automation to re-create a NSX cluster with a KVM host in our test environment. 
As soon as it is fixed, I will test.
In any case, this PR can only be merged after 4.6 because of feature freeze.

I'll keep you posted.


> NSX/Nicira Plugin does not support NSX v4.2.1
> -
>
> Key: CLOUDSTACK-8956
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8956
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VMware
>Affects Versions: 4.4.0, 4.5.0, 4.4.1, 4.4.2, 4.4.3, 4.5.1, 4.4.4
> Environment: OS: RHEL 6.6
>Reporter: Nicolas Vazquez
> Fix For: 4.5.1, 4.6.0
>
>
> h3. Description of the problem:
> Prior to version 4.2. Nicira/VmWare NSX used a variation of Open vSwitch as 
> means of integrating SDN into hypervisor layer. Cloudstack NiciraNVP plugin 
> was written to support OVS as a bridge to NSX.
> In version 4.2 VMware introduced NSX vSwitch as a replacement for OVS in ESX 
> hypervisors. It is a fork of distributed vSwitch leveraging one of the recent 
> features of ESX called opaque networks. Because of that change the current 
> version of NiciraNVP plugin doesn’t support versions of NSX-MH above 4.2 
> specifically in Vsphere environment. Proposed fix will analyze a version of 
> NVP/NSX API and use proper support for ESX hypervisors.
> vSphere hypervisor mode operations when NV is deployed onto NSX managed 
> network changes:
> * Current mode. A portgroup = UUID of CS VM NIC is created on a local 
> standard switch of the Hypervisor where VM is starting. VM nic is attached to 
> that port group.
> * New mode. No additional port group is created on a HW. No port group 
> cleanup is needed after VM/NIC is destroyed. VM is attached to 1st port group 
> having the following attributes:
> ** opaqueNetworkId string "br-int”
> ** opaqueNetworkType string "nsx.network"
> If portgroup with such attributes is not found a deployment should fail with 
> exception.
> h3. VMware vSphere API version from 5.1 to 5.5:
> Since vSphere API version 5.5, 
> [OpaqueNetworks|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.OpaqueNetwork.html]
>  are introduced. 
> Its description says: 
> bq. This interface defines an opaque network, in the sense that the detail 
> and configuration of the network is unknown to vShpere and is managed by a 
> management plane outside of vSphere. However, the identifier and name of 
> these networks is made available to vSphere so that host and virtual machine 
> virtual ethernet device can connect to them.
> In order to connect a vm's virtual ethernet device to the proper opaque 
> network when deploying a vm into a NSX managed network, we first need to look 
> for a particular opaque network on hosts. This opaque network's id has to be 
> *"br-int"* and its type *"nsx.network"*.
> Since vSphere API version 5.5 
> [HostNetworkInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.host.NetworkInfo.html#opaqueNetwork]
>  introduces a list of available opaque networks for each host. 
> If NSX API version >= 4.2 we look for a 
> [OpaqueNetworkInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.host.OpaqueNetworkInfo.html]
>  which satisfies:
> * opaqueNetworkId = "br-int"
> * opaqueNetworkType = "nsx.netork"
> If that opaque network is found, then we need to attach vm's NIC to a virtual 
> ethernet device which support this, so we use 
> [VirtualEthernetCardOpaqueNetworkBackingInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.vm.device.VirtualEthernetCard.OpaqueNetworkBackingInfo.html]
>  setting:
> * opaqueNetworkId = "br-int"
> * opaqueNetworkType = "nsx.netork"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980659#comment-14980659
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152220381
  
It says test failures 0. I have no idea why it's red! In addition, no Java 
code was changed!


![image](https://cloud.githubusercontent.com/assets/5129209/10823481/2c2d2d30-7e5c-11e5-9c23-a1cd6c5aa1fd.png)

Not related, please merge once it get a second LGTM.

Cheers,
Wilder


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980909#comment-14980909
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152264912
  
@remibergsma @wilderrodrigues Also ran the test against PR #981 => LGTM 
:+1: 

```
=== TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
```


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980933#comment-14980933
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8977:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152269280
  
@remibergsma  this doesn't work in tomcat7 either. We ran tests on centos7 
and only half a page is loaded.


> cloudstack UI creates a session for users not yet logged in
> ---
>
> Key: CLOUDSTACK-8977
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.5.2
>Reporter: Laszlo Hornyak
>Assignee: Laszlo Hornyak
> Fix For: Future
>
>   Original Estimate: 0.1h
>  Remaining Estimate: 0.1h
>
> The cloudstack UI always creates a session. By executing a command like 'ab 
> -n 20 -c 32' the server can be killed reqlly quick.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980950#comment-14980950
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8977:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152271301
  
@karuturi @K0zka @ustcweizhou @DaanHoogland @miguelaferreira I just 
reverted the commit.


> cloudstack UI creates a session for users not yet logged in
> ---
>
> Key: CLOUDSTACK-8977
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.5.2
>Reporter: Laszlo Hornyak
>Assignee: Laszlo Hornyak
> Fix For: Future
>
>   Original Estimate: 0.1h
>  Remaining Estimate: 0.1h
>
> The cloudstack UI always creates a session. By executing a command like 'ab 
> -n 20 -c 32' the server can be killed reqlly quick.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8793) Project Site-2-Site VPN Connection Fails to Register Correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980718#comment-14980718
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8793:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/879#issuecomment-152234419
  
code reviewed. nothing strange. lgtm


> Project Site-2-Site VPN Connection Fails to Register Correctly
> --
>
> Key: CLOUDSTACK-8793
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8793
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Projects
>Affects Versions: 4.5.2
> Environment: Clean install of ACS 4.5.2 on CentOS 6.6
>Reporter: Geoff Higgibottom
>Assignee: Patrick D.
>  Labels: project, vpc, vpn
>
> When trying to create a new Site-2-Site VPN Connection for a Project using 
> the UI the following error message is presented.
> "VPN connection can only be esitablished between same account's VPN gateway 
> and customer gateway!"
> Apart from the spelling mistake in the error message, the main issue is that 
> the VPN Connection fails to create as the VPN Customer Gateway is linked to 
> the Logged in user account, and not the Project.
> The VPN Gateway is correctly linked to the Project, as this was fixed in 
> CLOUDSTACK-5409.
> Manually updating the ‘domain_id’ and ‘account_id’ values in the 
> ‘s2s_vpn_connection’ table in the DB will result in the successful creation 
> of the VPN Connection, but this connection will not display in the UI or when 
> querying via the API.
> The same error exists when using only the API so it is not a UI issue.
> This prevents the use of Site-2Site VPNs for VPCs belonging to Projects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980945#comment-14980945
 ] 

ASF subversion and git services commented on CLOUDSTACK-8977:
-

Commit c60a8a80566ca26157981d7848943b16076b9e54 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c60a8a8 ]

Revert "Merge pull request #961 from K0zka/CLOUDSTACK-8977"

This reverts commit 29d42c7174f90bfeda91aa9ad9fca7deb985911b, reversing
changes made to 5cacd995700a915d239a45b23bd8ea8e5a4fca8f.


> cloudstack UI creates a session for users not yet logged in
> ---
>
> Key: CLOUDSTACK-8977
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.5.2
>Reporter: Laszlo Hornyak
>Assignee: Laszlo Hornyak
> Fix For: Future
>
>   Original Estimate: 0.1h
>  Remaining Estimate: 0.1h
>
> The cloudstack UI always creates a session. By executing a command like 'ab 
> -n 20 -c 32' the server can be killed reqlly quick.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8919) Slow UI response while loading the list of networks in network tab.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980966#comment-14980966
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8919:


Github user sudhansu7 commented on the pull request:

https://github.com/apache/cloudstack/pull/897#issuecomment-152273822
  
@remibergsma  @runseb 
I have below performance analysis, which I did some time back. I trying to 
find out the dbdump to do a real test. But below analysis will may help to 
understand the issue and the solution.

Clicking 'Network' tab invokes 3 api as mentioned below.
 

http://localhost:8080/client/api?command=listZones=json=1ddeSxQjc604bdnHJegYqkM6EgA%3D=Advanced&_=1436356355027
 -- 371ms
this is to enable vpc, vpnCustomerGateway menu option.
 

http://localhost:8080/client/api?command=listNetworks=json=1ddeSxQjc604bdnHJegYqkM6EgA%3D=SecurityGroup=true=min&_=1436356355424
 -- 18.97s
this is to enable securityGroups menu option. 



http://localhost:8080/client/api?command=listNetworks=json=1ddeSxQjc604bdnHJegYqkM6EgA%3D=true=1=20&_=1436356374437
 -- 1.54s
to list networks
 
Second API call is taking 90% of the total response time.This api fetches 
all networks and interates over each network and for each network it makes an 
db call to fetch the services associated with the network. This is an expensive 
operation. 
 
Solution: 

![image006](https://cloud.githubusercontent.com/assets/1062642/10827976/dbc6e066-7e97-11e5-8aec-09e0a84c1dc2.png)
We can fetch listZones of type basic, if present then we can enable 
securityGroups menu option. For advanced zone with securitygroup service we can 
reuse first api call and can check "securitygroupsenabled" attribute in 
response. If present we will enable securityGroups menu option.
 

http://localhost:8080/client/api?command=listZones=json=JwxpVL74Wk6ZS7MvzSw0u6%2FA9eU%3D=Advanced&_=1436357831259
 --256ms
 

http://localhost:8080/client/api?command=listZones=json=JwxpVL74Wk6ZS7MvzSw0u6%2FA9eU%3D=Basic&_=1436357831901
 --11ms
 

http://localhost:8080/client/api?command=listNetworks=json=JwxpVL74Wk6ZS7MvzSw0u6%2FA9eU%3D=true=1=20&_=1436357831968
 --868s
 
total : 1.19s





> Slow UI response while loading the list of networks in network tab.
> ---
>
> Key: CLOUDSTACK-8919
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8919
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Reporter: Nitin Kumar Maharana
>
> Root cause of this Issue: Invokes 3 APIs, the 2nd API to check whether any 
> network is having security group service, this consumes 90% of the time. API 
> fetches network list and for each network calls DB to get services associated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8969) VPN customer gateway can't be registered with hostname

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980987#comment-14980987
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8969:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/955#issuecomment-152275904
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 27 tests in 11457.297s

OK

```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py 

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981051#comment-14981051
 ] 

ASF subversion and git services commented on CLOUDSTACK-9007:
-

Commit d8f9c235e9a7bae1c92519a66c7adcc50d94f7b7 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d8f9c23 ]

Merge pull request #1002 from ekholabs/test/dhcphosts-CLOUDSTACK-9007

CLOUDSTACK-9007 - Write test to check that the /etc/dhcphosts.txt doesn't 
contain duplicate IPsThis PR contains a test that will cover the fix on PR #981

The tests does the following:

* Creates account, service offering, network offering, network
* Deploys two virtual machines
  - Each machine with a pre-assigned IP
* Creates two FW and PF rules
* Checks that SSH into the VMs works
* Checks default routes from both VMs
* Checks that the /etc/dhcphosts.txt contains 1 entry per VM IP
* Destroys/Expunges 1 VM
* Creates a new VM with the same IP as the destroyed one
* Checks that the /etc/dhcphosts.txt contains 1 entry per VM IP

* pr/1002:
  CLOUDSTACK-9007 - Add test check that /etc/dhcphosts.txt doesn't contain 
duplicate IPs

Signed-off-by: Remi Bergsma 


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981054#comment-14981054
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1002


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981052#comment-14981052
 ] 

ASF subversion and git services commented on CLOUDSTACK-9007:
-

Commit d8f9c235e9a7bae1c92519a66c7adcc50d94f7b7 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d8f9c23 ]

Merge pull request #1002 from ekholabs/test/dhcphosts-CLOUDSTACK-9007

CLOUDSTACK-9007 - Write test to check that the /etc/dhcphosts.txt doesn't 
contain duplicate IPsThis PR contains a test that will cover the fix on PR #981

The tests does the following:

* Creates account, service offering, network offering, network
* Deploys two virtual machines
  - Each machine with a pre-assigned IP
* Creates two FW and PF rules
* Checks that SSH into the VMs works
* Checks default routes from both VMs
* Checks that the /etc/dhcphosts.txt contains 1 entry per VM IP
* Destroys/Expunges 1 VM
* Creates a new VM with the same IP as the destroyed one
* Checks that the /etc/dhcphosts.txt contains 1 entry per VM IP

* pr/1002:
  CLOUDSTACK-9007 - Add test check that /etc/dhcphosts.txt doesn't contain 
duplicate IPs

Signed-off-by: Remi Bergsma 


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981049#comment-14981049
 ] 

ASF subversion and git services commented on CLOUDSTACK-9007:
-

Commit bf3c894fb98acdcdaffdceb6e228daf4cfdda912 in cloudstack's branch 
refs/heads/master from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bf3c894 ]

CLOUDSTACK-9007 - Add test check that /etc/dhcphosts.txt doesn't contain 
duplicate IPs


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[Wilder Rodrigues (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wilder Rodrigues resolved CLOUDSTACK-9007.
--
Resolution: Fixed

Fixed, tested and merged!

> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8962) Dedicated cluster is used for virtual routers that belong to non-dedicated account

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981084#comment-14981084
 ] 

ASF subversion and git services commented on CLOUDSTACK-8962:
-

Commit 093cccfce293531560fabe532c6648d92f84b7a3 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=093cccf ]

Merge pull request #945 from nitin-maharana/CloudStack-Nitin11

CLOUDSTACK-8962: Dedicated cluster is used for virtual routers that belong to 
non-dedicated account
Earlier the deployment planner was not handling the case of virtual routers.(In 
Explicit Dedication)
It was only handling for all instance VMs/user VMs.
Added code for checking the case of Virtual Routers.

* pr/945:
  CLOUDSTACK-8962: Dedicated cluster is used for virtual routers that belong to 
non-dedicated account

Signed-off-by: Remi Bergsma 


> Dedicated cluster is used for virtual routers that belong to non-dedicated 
> account
> --
>
> Key: CLOUDSTACK-8962
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8962
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.5.2
>Reporter: Nitin Kumar Maharana
>Priority: Blocker
>
> ISSUE
> ==
> A dedicated cluster is being populated with Virtual Routers from 
> domains/accounts to which the cluster is not dedicated.
> The VR belongs to a non-dedicated account should not go to a dedicated 
> cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8940) Wrong value is inserted into nics table netmask field when creating a VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981087#comment-14981087
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8940:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/916#issuecomment-152290835
  
code lgtm @remibergsma can you retest? A newer commit is in since your lgtm


> Wrong value is inserted into nics table netmask field when creating a VM
> 
>
> Key: CLOUDSTACK-8940
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8940
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Kshitij Kansal
>Priority: Critical
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8872) Replace all occurrences Charset.forName(UTF-8) with StringUtils.getPreferredCharset().

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981145#comment-14981145
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8872:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/832#issuecomment-152300766
  
@borisroman Can you force push this PR please and rebase it with current 
master? Then we can run some tests! Pinging @dahn to look at the code.


> Replace all occurrences Charset.forName(UTF-8) with 
> StringUtils.getPreferredCharset().
> --
>
> Key: CLOUDSTACK-8872
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8872
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Boris Schrijver
>Assignee: Boris Schrijver
>Priority: Minor
> Fix For: 4.6.0
>
>
> To make encoding consistent across all ACS components it is better to define 
> the encoding charset in one place. StringUtils.getPreferredCharset() has this 
> functionality. The only thing left is update all places which define a 
> charset on there own.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981156#comment-14981156
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8746:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-152302260
  
@wido @sateesh-chodapuneedi @bhaisaab can you please see if you are 
satisfied with the present state (with respect to your comments)?


> VM Snapshotting implementation for KVM
> --
>
> Key: CLOUDSTACK-8746
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8746
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>
> Currently it is not supported.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8969) VPN customer gateway can't be registered with hostname

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981009#comment-14981009
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8969:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/955#issuecomment-152279403
  
@SudharmaJain Your change looks good at first sight. Did you verify that 
your intended behaviour actually happens? and how? The name of the vpn is now 
containing a domainname instead of an ip address. Do you know what other side 
effects this may have?


>  VPN customer gateway can't be registered with hostname
> ---
>
> Key: CLOUDSTACK-8969
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8969
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> When we have VPN customer gateway which is resolved by a hostname , we should 
> be able to register the VPN customer gateway with its hostname instead of the 
> IP address, this would be useful in case where the remote device IP is 
> dynamically assigned , where customers use DDNS to resolve it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981050#comment-14981050
 ] 

ASF subversion and git services commented on CLOUDSTACK-9007:
-

Commit d8f9c235e9a7bae1c92519a66c7adcc50d94f7b7 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d8f9c23 ]

Merge pull request #1002 from ekholabs/test/dhcphosts-CLOUDSTACK-9007

CLOUDSTACK-9007 - Write test to check that the /etc/dhcphosts.txt doesn't 
contain duplicate IPsThis PR contains a test that will cover the fix on PR #981

The tests does the following:

* Creates account, service offering, network offering, network
* Deploys two virtual machines
  - Each machine with a pre-assigned IP
* Creates two FW and PF rules
* Checks that SSH into the VMs works
* Checks default routes from both VMs
* Checks that the /etc/dhcphosts.txt contains 1 entry per VM IP
* Destroys/Expunges 1 VM
* Creates a new VM with the same IP as the destroyed one
* Checks that the /etc/dhcphosts.txt contains 1 entry per VM IP

* pr/1002:
  CLOUDSTACK-9007 - Add test check that /etc/dhcphosts.txt doesn't contain 
duplicate IPs

Signed-off-by: Remi Bergsma 


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8793) Project Site-2-Site VPN Connection Fails to Register Correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981099#comment-14981099
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8793:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/879#issuecomment-152293339
  
Will run the tests again since the commit changed.


> Project Site-2-Site VPN Connection Fails to Register Correctly
> --
>
> Key: CLOUDSTACK-8793
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8793
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Projects
>Affects Versions: 4.5.2
> Environment: Clean install of ACS 4.5.2 on CentOS 6.6
>Reporter: Geoff Higgibottom
>Assignee: Patrick D.
>  Labels: project, vpc, vpn
>
> When trying to create a new Site-2-Site VPN Connection for a Project using 
> the UI the following error message is presented.
> "VPN connection can only be esitablished between same account's VPN gateway 
> and customer gateway!"
> Apart from the spelling mistake in the error message, the main issue is that 
> the VPN Connection fails to create as the VPN Customer Gateway is linked to 
> the Logged in user account, and not the Project.
> The VPN Gateway is correctly linked to the Project, as this was fixed in 
> CLOUDSTACK-5409.
> Manually updating the ‘domain_id’ and ‘account_id’ values in the 
> ‘s2s_vpn_connection’ table in the DB will result in the successful creation 
> of the VPN Connection, but this connection will not display in the UI or when 
> querying via the API.
> The same error exists when using only the API so it is not a UI issue.
> This prevents the use of Site-2Site VPNs for VPCs belonging to Projects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8793) Project Site-2-Site VPN Connection Fails to Register Correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981144#comment-14981144
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8793:


Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/879#issuecomment-152300355
  
@remibergsma The commit didn't change, I just rebased


> Project Site-2-Site VPN Connection Fails to Register Correctly
> --
>
> Key: CLOUDSTACK-8793
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8793
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Projects
>Affects Versions: 4.5.2
> Environment: Clean install of ACS 4.5.2 on CentOS 6.6
>Reporter: Geoff Higgibottom
>Assignee: Patrick D.
>  Labels: project, vpc, vpn
>
> When trying to create a new Site-2-Site VPN Connection for a Project using 
> the UI the following error message is presented.
> "VPN connection can only be esitablished between same account's VPN gateway 
> and customer gateway!"
> Apart from the spelling mistake in the error message, the main issue is that 
> the VPN Connection fails to create as the VPN Customer Gateway is linked to 
> the Logged in user account, and not the Project.
> The VPN Gateway is correctly linked to the Project, as this was fixed in 
> CLOUDSTACK-5409.
> Manually updating the ‘domain_id’ and ‘account_id’ values in the 
> ‘s2s_vpn_connection’ table in the DB will result in the successful creation 
> of the VPN Connection, but this connection will not display in the UI or when 
> querying via the API.
> The same error exists when using only the API so it is not a UI issue.
> This prevents the use of Site-2Site VPNs for VPCs belonging to Projects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981154#comment-14981154
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8993:


Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152302053
  
is 4.5 also affected by this issue?


> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>Priority: Critical
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the 
> same IP address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981046#comment-14981046
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152286968
  
Agree that the Jenkins failure is unrelated. Will soon merge.


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8962) Dedicated cluster is used for virtual routers that belong to non-dedicated account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981073#comment-14981073
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8962:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/945#issuecomment-152290121
  
based on code review LGTM. @nitin-maharana makes sense to write a marvin 
test for this. could you?


> Dedicated cluster is used for virtual routers that belong to non-dedicated 
> account
> --
>
> Key: CLOUDSTACK-8962
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8962
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.5.2
>Reporter: Nitin Kumar Maharana
>Priority: Blocker
>
> ISSUE
> ==
> A dedicated cluster is being populated with Virtual Routers from 
> domains/accounts to which the cluster is not dedicated.
> The VR belongs to a non-dedicated account should not go to a dedicated 
> cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8962) Dedicated cluster is used for virtual routers that belong to non-dedicated account

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981082#comment-14981082
 ] 

ASF subversion and git services commented on CLOUDSTACK-8962:
-

Commit adcd23d15aec9c5cee37d8b1ec031eb57660d605 in cloudstack's branch 
refs/heads/master from [~nitin.maharana]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=adcd23d ]

CLOUDSTACK-8962: Dedicated cluster is used for virtual routers that belong to 
non-dedicated account

Earlier the deployment planner was not handling the case of virtual routers.(In 
Explicit Dedication)
It was only handling for all instance VMs/user VMs.
Added code for checking the case of Virtual Routers.


> Dedicated cluster is used for virtual routers that belong to non-dedicated 
> account
> --
>
> Key: CLOUDSTACK-8962
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8962
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.5.2
>Reporter: Nitin Kumar Maharana
>Priority: Blocker
>
> ISSUE
> ==
> A dedicated cluster is being populated with Virtual Routers from 
> domains/accounts to which the cluster is not dedicated.
> The VR belongs to a non-dedicated account should not go to a dedicated 
> cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8962) Dedicated cluster is used for virtual routers that belong to non-dedicated account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981086#comment-14981086
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8962:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/945


> Dedicated cluster is used for virtual routers that belong to non-dedicated 
> account
> --
>
> Key: CLOUDSTACK-8962
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8962
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.5.2
>Reporter: Nitin Kumar Maharana
>Priority: Blocker
>
> ISSUE
> ==
> A dedicated cluster is being populated with Virtual Routers from 
> domains/accounts to which the cluster is not dedicated.
> The VR belongs to a non-dedicated account should not go to a dedicated 
> cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8962) Dedicated cluster is used for virtual routers that belong to non-dedicated account

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981083#comment-14981083
 ] 

ASF subversion and git services commented on CLOUDSTACK-8962:
-

Commit 093cccfce293531560fabe532c6648d92f84b7a3 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=093cccf ]

Merge pull request #945 from nitin-maharana/CloudStack-Nitin11

CLOUDSTACK-8962: Dedicated cluster is used for virtual routers that belong to 
non-dedicated account
Earlier the deployment planner was not handling the case of virtual routers.(In 
Explicit Dedication)
It was only handling for all instance VMs/user VMs.
Added code for checking the case of Virtual Routers.

* pr/945:
  CLOUDSTACK-8962: Dedicated cluster is used for virtual routers that belong to 
non-dedicated account

Signed-off-by: Remi Bergsma 


> Dedicated cluster is used for virtual routers that belong to non-dedicated 
> account
> --
>
> Key: CLOUDSTACK-8962
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8962
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.5.2
>Reporter: Nitin Kumar Maharana
>Priority: Blocker
>
> ISSUE
> ==
> A dedicated cluster is being populated with Virtual Routers from 
> domains/accounts to which the cluster is not dedicated.
> The VR belongs to a non-dedicated account should not go to a dedicated 
> cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8961) Making the VPN user management more intutive

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981112#comment-14981112
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8961:


Github user milamberspace commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/941#discussion_r43433493
  
--- Diff: ui/scripts/network.js ---
@@ -6504,7 +6432,123 @@
 }
 }
 }
-}
+},
+vpnuser: {
+type: 'select',
+title: 'VPN Users',
--- End diff --

Would be better to use a new localization key and put the text in 
messages.properties file. Thanks.


> Making the VPN user management more intutive
> 
>
> Key: CLOUDSTACK-8961
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8961
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Kshitij Kansal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8961) Making the VPN user management more intutive

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1498#comment-1498
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8961:


Github user milamberspace commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/941#discussion_r43433480
  
--- Diff: ui/scripts/network.js ---
@@ -4495,99 +4511,11 @@
 
$('').addClass('psk').html(_l('message.enabled.vpn.ip.sec') + ' ')
 
.append($('').html(psk))
 )
-).multiEdit({
-context: args.context,
-noSelect: true,
-fields: {
-'username': {
-edit: true,
-label: 'label.username'
-},
-'password': {
-edit: true,
-isPassword: true,
-label: 'label.password'
-},
-'add-user': {
-addButton: true,
-label: 'label.add.user'
-}
-},
-add: {
-label: 'label.add.user',
-action: function(args) {
-$.ajax({
-url: 
createURL('addVpnUser'),
-data: 
$.extend(args.data, {
-domainid: 
args.context.ipAddresses[0].domainid,
-account: 
args.context.ipAddresses[0].account
-}),
-dataType: 'json',
-type: "POST",
-success: 
function(data) {
-
args.response.success({
-_custom: {
-jobId: 
data.addvpnuserresponse.jobid
-},
-notification: {
-label: 
'label.add.vpn.user',
-poll: 
pollAsyncJobResult
-}
-});
-},
-error: function(data) {
-
args.response.error(parseXMLHttpResponse(data));
-}
-});
-}
-},
-actions: {
-destroy: {
-label: 
'label.action.delete.user',
-action: function(args) {
-$.ajax({
-url: 
createURL('removeVpnUser'),
-data: {
-domainid: 
args.context.multiRule[0].domainid,
-account: 
args.context.multiRule[0].account,
-username: 
args.context.multiRule[0].username
-},
-dataType: 'json',
-  

[jira] [Commented] (CLOUDSTACK-8961) Making the VPN user management more intutive

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981113#comment-14981113
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8961:


Github user milamberspace commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/941#discussion_r43433516
  
--- Diff: ui/scripts/network.js ---
@@ -6504,7 +6432,123 @@
 }
 }
 }
-}
+},
+vpnuser: {
+type: 'select',
+title: 'VPN Users',
+
+listView: {
+id: 'vpnUsers',
+fields: {
+username: { label: 'label.name' },
+domain: { label: 'label.domain' },
+state: { label: 'label.state',
+indicator: {
+'Active': 'on',
+}
+}
+},
+dataProvider: function(args) {
+var data = {};
+listViewDataProvider(args, data);
+$.ajax({
+url: createURL('listVpnUsers'),
+data: data,
+dataType: 'json',
+async: true,
+success: function(data) {
+args.response.success({
+data: 
data.listvpnusersresponse.vpnuser
+});
+}
+});
+},
+actions:{
+destroy: {
+label: 'label.action.delete.user',
+messages: {
+confirm: function(args) { return 'Are 
you sure you want to delete the VPN user'},
--- End diff --

Would be better to use a new localization key and put the text in 
messages.properties file. Thanks.


> Making the VPN user management more intutive
> 
>
> Key: CLOUDSTACK-8961
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8961
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Kshitij Kansal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981307#comment-14981307
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152332158
  
uservm can not start







2015-10-29 21:04:38,017 WARN  [resource.wrapper.LibvirtStartCommandWrapper] 
(agentRequest-Handler-5:null) LibvirtException
org.libvirt.LibvirtException: internal error Missing source path attribute 
for char device




> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-7984) Collect network statistics for VMs on shared network

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981179#comment-14981179
 ] 

ASF GitHub Bot commented on CLOUDSTACK-7984:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/926#issuecomment-152306229
  
ran 
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
resulting in
```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 27 tests in 12295.891s
```
and
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
smoke/test_network.py \
component/test_vpc_offerings.py \

[jira] [Commented] (CLOUDSTACK-4858) Disable copy snapshot to secondary storage snapshot.backup.rightafter

[JIRA]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981192#comment-14981192
 ] 

Özhan Rüzgar Karaman commented on CLOUDSTACK-4858:
--

Hi;
Did any one find any solution or workaround to completely disable copying 
snapshot file to secondary storage problem?  ping [~mozg31337] [~gerolamo] ?

Thanks
Özhan

> Disable copy snapshot to secondary storage snapshot.backup.rightafter
> -
>
> Key: CLOUDSTACK-4858
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4858
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.2.0
> Environment: kvm, rbd
>Reporter: Sebastian Igerl
>
> "snapshot.backup.rightafterbackup"  is set to false but still the snapshot is 
> copied to secondary storage.
> Primary storage is Ceph/RDB, Secondary is NFS. I restarted both the 
> management server and the nodes.
> see : 
> http://www.marshut.com/wpviz/disable-copy-snapshot-to-secondary-storage-in-cs-4-2.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8872) Replace all occurrences Charset.forName(UTF-8) with StringUtils.getPreferredCharset().

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981353#comment-14981353
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8872:


Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/832#issuecomment-152337266
  
@remibergsma @wilderrodrigues @DaanHoogland Done.


> Replace all occurrences Charset.forName(UTF-8) with 
> StringUtils.getPreferredCharset().
> --
>
> Key: CLOUDSTACK-8872
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8872
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Boris Schrijver
>Assignee: Boris Schrijver
>Priority: Minor
> Fix For: 4.6.0
>
>
> To make encoding consistent across all ACS components it is better to define 
> the encoding charset in one place. StringUtils.getPreferredCharset() has this 
> functionality. The only thing left is update all places which define a 
> charset on there own.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979975#comment-14979975
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8993:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152101614
  
ping @serbaut @remibergsma 

Can you please do a force push to see if we get Jenkins green? I know is a 
pain in the ass to depend on Jenkins/Travis that sometimes simply avoids us - 
believe me, I had the same with my latest PR. However, getting both of them 
green is kinda cool.

If it fails again after you force push, I will suggest to ignore it and get 
your PR merged!

Cheers,
Wilder


> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the 
> same IP address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[Wilder Rodrigues (JIRA)]

Wilder Rodrigues created CLOUDSTACK-9007:


 Summary: Write test to check that the /etc/dhcphosts.txt doesn't 
contain duplicate IPs
 Key: CLOUDSTACK-9007
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
 Project: CloudStack
  Issue Type: Test
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: Virtual Router
Reporter: Wilder Rodrigues
Assignee: Wilder Rodrigues
 Fix For: 4.6.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8957) VR password server broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1498#comment-1498
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8957:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-152106800
  
Will merge when Travis and Jenkins are green.


> VR password server broken
> -
>
> Key: CLOUDSTACK-8957
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
> Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt
>Reporter: Nux
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Hello,
> When deploying instances from password enabled templates, the instances do 
> not get the generated passwords.
> The VR logs show something like this:
> 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested 
> password not found for 10.1.1.33'
> In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is 
> not, I can see the passwords there.
> Symlinking "passwords-10.1.1.1" to "passwords" and restarting the 
> passwd_server_ip script gets the feature working again, though I am not sure 
> how correct this approach is.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980003#comment-14980003
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8993:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152106955
  
@serbaut Will merge when Travis and Jenkins are green.


> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the 
> same IP address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CLOUDSTACK-9006) ListTemplates API returns result in inconsistent order when called concurrently

[Ramamurti Subramanian (JIRA)]

Ramamurti Subramanian created CLOUDSTACK-9006:
-

 Summary: ListTemplates API returns result in inconsistent order 
when called concurrently
 Key: CLOUDSTACK-9006
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9006
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: API
Reporter: Ramamurti Subramanian
Assignee: Ramamurti Subramanian






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8957) VR password server broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979890#comment-14979890
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8957:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-152087954
  
Ping @remibergsma @karuturi @miguelaferreira

Test results

* Hardware required: false
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common built from source

```
Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: 
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with 

[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979897#comment-14979897
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8993:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152089236
  
Ping @serbaut and @remibergsma

Tests results

* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common RPMs built from source

Three tests failed, but those are irrelevant since the PR #989 which fixes 
it is not part of this PR.

So, based on all the test done, this PR LGTM :+1: 

```
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
```

Cheers,
Wilder


> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates 
> 

[jira] [Commented] (CLOUDSTACK-8957) VR password server broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979906#comment-14979906
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8957:


Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/998#discussion_r43352356
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -41,27 +41,37 @@
 from cs.CsMonitor import CsMonitor
 from cs.CsLoadBalancer import CsLoadBalancer
 from cs.CsConfig import CsConfig
+from cs.CsProcess import CsProcess
 
 
 class CsPassword(CsDataBag):
-"""
-  Update the password cache
-
-  A stupid step really as we should just rewrite the password server to
-  use the databag
-"""
-cache = "/var/cache/cloud/passwords"
-
+
+TOKEN_FILE="/tmp/passwdsrvrtoken"
+
 def process(self):
-file = CsFile(self.cache)
 for item in self.dbag:
 if item == "id":
 continue
-self.__update(file, item, self.dbag[item])
-file.commit()
+self.__update(item, self.dbag[item])
 
-def __update(self, file, ip, password):
-file.search("%s=" % ip, "%s=%s" % (ip, password))
+def __update(self, vm_ip, password):
+token = ""
+try:
+tokenFile = open(self.TOKEN_FILE)
+token = tokenFile.read()
+except IOError:
+logging.debug("File %s does not exist" % self.TOKEN_FILE)
+
+ips_cmd = "ip addr show | grep inet | awk '{print $2}'"
+ips = CsHelper.execute(ips_cmd)
+for ip in ips:
+server_ip = ip.split('/')[0]
+proc = CsProcess(['/opt/cloud/bin/passwd_server_ip.py', 
server_ip])
+if proc.find():
+update_command = 'curl --header "DomU_Request: 
save_password" "http://{SERVER_IP}:8080/; -F "ip={VM_IP}" -F 
"password={PASSWORD}" ' \
--- End diff --

Hi @bhaisaab,

I will create an improvement ticket to tackle your point. After 4.6 we are 
planning to rewrite it in a proper way and get rid of all those things that 
mixes bash/python code. So, adding few lines now is not going to add to the 
whole picture as they will also been removed afterwards.

My personal goal for 4.7/5.0, which is also the goal of my colleagues, is 
to rip ou the whole Python code and also the bash scripts - no longer used - 
from the ACS.

It cannot be done right in a few lines. It would be like a drop in an ocean.

Cheers,
Wilder


> VR password server broken
> -
>
> Key: CLOUDSTACK-8957
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
> Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt
>Reporter: Nux
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Hello,
> When deploying instances from password enabled templates, the instances do 
> not get the generated passwords.
> The VR logs show something like this:
> 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested 
> password not found for 10.1.1.33'
> In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is 
> not, I can see the passwords there.
> Symlinking "passwords-10.1.1.1" to "passwords" and restarting the 
> passwd_server_ip script gets the feature working again, though I am not sure 
> how correct this approach is.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8994) Activity of the password server isn't logged.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980057#comment-14980057
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8994:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/983#issuecomment-152113648
  
@borisroman FYI: I already started a test on this branch (which I rebased 
myself first) and it doesn't look too good:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : EXCEPTION ===
ERROR
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
=== TestName: test_01_single_VPC_iptables_policies | Status : EXCEPTION ===
ERROR
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : EXCEPTION ===
ERROR
=== TestName: test_RVR_Network_FW_PF_SSH_default_routes | Status : 
EXCEPTION ===
ERROR
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
=== TestName: test_02_VPC_default_routes | Status : EXCEPTION ===
ERROR
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
=== TestName: test_10_destroy_cpvm | Status : EXCEPTION ===
ERROR
Test for reboot router ... === TestName: test_reboot_router | Status : 
EXCEPTION ===
ERROR
=== TestName: test_reboot_router | Status : EXCEPTION ===
ERROR
--
Ran 18 tests in 33683.484s

FAILED (errors=8)
```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:

```
=== TestName: None | Status : EXCEPTION ===
ERROR
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : EXCEPTION ===
ERROR
=== TestName: test_privategw_acl | Status : EXCEPTION ===
ERROR
=== TestName: test_privategw_acl | Status : EXCEPTION ===
ERROR
=== TestName: test_privategw_acl | Status : EXCEPTION ===
ERROR
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : 

[jira] [Commented] (CLOUDSTACK-8994) Activity of the password server isn't logged.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980061#comment-14980061
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8994:


Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/983#issuecomment-152114469
  
@karuturi How is it possible that "All the tests in BVT tests pass on 
xenserver 6.5 host" and "I started seeing below error messages on console and 
VR doesnt start"?


> Activity of the password server isn't logged.
> -
>
> Key: CLOUDSTACK-8994
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8994
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
>Reporter: Boris Schrijver
>Assignee: Boris Schrijver
> Fix For: Future
>
>
> Activity of the password server in the virtual router isn't logged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8991) IP address is not removed from VR even after disabling static NAT

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980065#comment-14980065
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8991:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/927#issuecomment-152116250
  
Results of set of tests that I run on this branch (which I rebased myself 
first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Stat
us : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_route
s | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
--
Ran 27 tests in 12196.996s

FAILED (failures=3)
```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \

[jira] [Commented] (CLOUDSTACK-8951) UI is not throwing any error message to user when "remote.access.vpn.psk.length" is set to less than minimum value (min8)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980073#comment-14980073
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8951:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/929#issuecomment-152117456
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
--
Ran 27 tests in 11374.491s

FAILED (failures=3)
```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests 

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980114#comment-14980114
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152127063
  
Ping @serbaut

I just executed the test against Master and got the following error:

```
cat /etc/dhcphosts.txt | grep 10.1.1.50 | sed 's/\,/ /g' | awk '{print $2}' 
RESULT IS ==> [u'10.1.1.50', u'10.1.1.50']
=== TestName: test_router_dhcphosts | Status : FAILED ===

Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : FAILED ===
FAIL

==
FAIL: Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
--
```

It proves that @serbaut's fix is more than fine!

@remibergsma we need to get PR #981 merged. 

Cheers,
Wilder


> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8964) Can't create template or volume from snapshot - "Are you sure you got the right type of server?"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980120#comment-14980120
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8964:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/975#issuecomment-152127664
  
Ping @remibergsma @snuf 

Just started testing this PR.

Cheers,
Wilder


> Can't create template or volume from snapshot - "Are you sure you got the 
> right type of server?"
> 
>
> Key: CLOUDSTACK-8964
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8964
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Secondary Storage
>Affects Versions: 4.6.0
> Environment: CentOS 6 HVs & mgmt
>Reporter: Nux
>Assignee: Wei Zhou
>Priority: Blocker
> Fix For: 4.6.0
>
>
> I have a couple of snapshots left-over from by  now deleted instances. Trying 
> to turn them into volumes fails with (UI/cloudmonkey shows this):
> "Failed to create templateUnsupported command issued: 
> org.apache.cloudstack.storage.command.CopyCommand. Are you sure you got the 
> right type of server?"
> mgmt server logs for when trying to create template:
> "2015-10-18 09:15:58,437 DEBUG [c.c.a.ApiServlet] 
> (catalina-exec-5:ctx-84b2a9be) ===START===  192.168.192.198 -- GET  
> command=createTemplate=json=da79387b-ecae-4d5c-b414-3942d29ad821=testsnap1=testsnap1=ba03db1c-7359-11e5-b4d0-f2a3ece198a5=false=false=false&_=1445156157698
> 2015-10-18 09:15:58,459 DEBUG [c.c.t.TemplateManagerImpl] 
> (catalina-exec-5:ctx-84b2a9be ctx-921b9b20) This template is getting created 
> from other template, setting source template Id to: 201
> 2015-10-18 09:15:58,500 INFO  [o.a.c.f.j.i.AsyncJobMonitor] 
> (API-Job-Executor-33:ctx-f566f6af job-135) Add job-135 into job monitoring
> 2015-10-18 09:15:58,506 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (catalina-exec-5:ctx-84b2a9be ctx-921b9b20) submit async job-135, details: 
> AsyncJobVO {id:135, userId: 2, accountId: 2, instanceType: Template, 
> instanceId: 207, cmd: 
> org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin, 
> cmdInfo: 
> {"cmdEventType":"TEMPLATE.CREATE","ctxUserId":"2","httpmethod":"GET","osTypeId":"ba03db1c-7359-11e5-b4d0-f2a3ece198a5","isPublic":"false","isdynamicallyscalable":"false","response":"json","id":"207","ctxDetails":"{\"interface
>  
> com.cloud.template.VirtualMachineTemplate\":\"9c045e56-2463-47f8-a257-840656e1c0bd\",\"interface
>  
> com.cloud.storage.Snapshot\":\"da79387b-ecae-4d5c-b414-3942d29ad821\",\"interface
>  
> com.cloud.storage.GuestOS\":\"ba03db1c-7359-11e5-b4d0-f2a3ece198a5\"}","displayText":"testsnap1","snapshotid":"da79387b-ecae-4d5c-b414-3942d29ad821","passwordEnabled":"false","name":"testsnap1","_":"1445156157698","uuid":"9c045e56-2463-47f8-a257-840656e1c0bd","ctxAccountId":"2","ctxStartEventId":"253"},
>  cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
> null, initMsid: 266785867798693, completeMsid: null, lastUpdated: null, 
> lastPolled: null, created: null}
> 2015-10-18 09:15:58,506 DEBUG [c.c.a.ApiServlet] 
> (catalina-exec-5:ctx-84b2a9be ctx-921b9b20) ===END===  192.168.192.198 -- GET 
>  
> command=createTemplate=json=da79387b-ecae-4d5c-b414-3942d29ad821=testsnap1=testsnap1=ba03db1c-7359-11e5-b4d0-f2a3ece198a5=false=false=false&_=1445156157698
> 2015-10-18 09:15:58,507 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (API-Job-Executor-33:ctx-f566f6af job-135) Executing AsyncJobVO {id:135, 
> userId: 2, accountId: 2, instanceType: Template, instanceId: 207, cmd: 
> org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin, 
> cmdInfo: 
> {"cmdEventType":"TEMPLATE.CREATE","ctxUserId":"2","httpmethod":"GET","osTypeId":"ba03db1c-7359-11e5-b4d0-f2a3ece198a5","isPublic":"false","isdynamicallyscalable":"false","response":"json","id":"207","ctxDetails":"{\"interface
>  
> com.cloud.template.VirtualMachineTemplate\":\"9c045e56-2463-47f8-a257-840656e1c0bd\",\"interface
>  
> com.cloud.storage.Snapshot\":\"da79387b-ecae-4d5c-b414-3942d29ad821\",\"interface
>  
> com.cloud.storage.GuestOS\":\"ba03db1c-7359-11e5-b4d0-f2a3ece198a5\"}","displayText":"testsnap1","snapshotid":"da79387b-ecae-4d5c-b414-3942d29ad821","passwordEnabled":"false","name":"testsnap1","_":"1445156157698","uuid":"9c045e56-2463-47f8-a257-840656e1c0bd","ctxAccountId":"2","ctxStartEventId":"253"},
>  cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
> null, initMsid: 266785867798693, completeMsid: null, lastUpdated: null, 
> lastPolled: null, created: null}
> 2015-10-18 09:15:58,531 DEBUG 

[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980059#comment-14980059
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8832:


Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-152114217
  
@jburwell thanks for intensive review. How does it look like? :) thanks


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> --
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for 
> this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8994) Activity of the password server isn't logged.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980063#comment-14980063
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8994:


Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/983#issuecomment-152114882
  
@remibergsma Thanks for the effort. This was what also caused my vr to not 
reboot... Knowing that I closed the PR yesterday. Will look into it  and test 
more properly.


> Activity of the password server isn't logged.
> -
>
> Key: CLOUDSTACK-8994
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8994
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
>Reporter: Boris Schrijver
>Assignee: Boris Schrijver
> Fix For: Future
>
>
> Activity of the password server in the virtual router isn't logged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9007) Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980089#comment-14980089
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9007:


GitHub user wilderrodrigues opened a pull request:

https://github.com/apache/cloudstack/pull/1002

CLOUDSTACK-9007 - Write test to check that the /etc/dhcphosts.txt doesn't 
contain duplicate IPs

This PR contains a test that will cover the fix on PR #981 

The tests does the following:

* Creates account, service offering, network offering, network
* Deploys two virtual machines
  - Each machine with a pre-assigned IP
* Creates two FW and PF rules
* Checks that SSH into the VMs works
* Checks default routes from both VMs
* Checks that the /etc/dhcphosts.txt contains 1 entry per VM IP
* Destroys/Expunges 1 VM
* Creates a new VM with the same IP as the destroyed one
* Checks that the /etc/dhcphosts.txt contains 1 entry per VM IP

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekholabs/cloudstack 
test/dhcphosts-CLOUDSTACK-9007

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1002.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1002


commit a1eeac08efbbffd038a2e656c57e7211c0cc076b
Author: Wilder Rodrigues 
Date:   2015-10-29T09:05:49Z

CLOUDSTACK-9007 - Add test check that /etc/dhcphosts.txt doesn't contain 
duplicate IPs




> Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs
> -
>
> Key: CLOUDSTACK-9007
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9007
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8957) VR password server broken

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980048#comment-14980048
 ] 

ASF subversion and git services commented on CLOUDSTACK-8957:
-

Commit eabf11c99d4bda086133dc33050ec383ebb65e01 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eabf11c ]

Merge pull request #998 from ekholabs/fix/vr_passwd_server-CLOUDSTACK-8957

CLOUDSTACK-8957 - VR password server feature is brokenThis PR implements the 
update of the password as it use to be done with the bash file, but using the 
Python code for it.

A new integration test was added in order to cover the fix. The test can be 
found at component/test_password_server.py and does the following:

* Creates an Account
* Creates a Service Offering
* Creates a Network Offering
* Creates a Network
* Creates two Virtual Machines
* Creates two FW rules
* Creates two PF rules
* SSH into each VM and checks the default routes (by pinging 8.8.8.8)
* SSH to the host and executes a command in the router to check the 
password-[gateway] file
  - The file is under /var/cache/cloud/passwords-[gateway]

The [gateway] is replaced by the gateway from each virtual machine NIC.

* pr/998:
  CLOUDSTACK-8957 - Add integration test that cheks if the password file is 
present and not empty
  CLOUDSTACK-8957 - Implement password server in configure.py

Signed-off-by: Remi Bergsma 


> VR password server broken
> -
>
> Key: CLOUDSTACK-8957
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
> Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt
>Reporter: Nux
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Hello,
> When deploying instances from password enabled templates, the instances do 
> not get the generated passwords.
> The VR logs show something like this:
> 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested 
> password not found for 10.1.1.33'
> In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is 
> not, I can see the passwords there.
> Symlinking "passwords-10.1.1.1" to "passwords" and restarting the 
> passwd_server_ip script gets the feature working again, though I am not sure 
> how correct this approach is.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8957) VR password server broken

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980047#comment-14980047
 ] 

ASF subversion and git services commented on CLOUDSTACK-8957:
-

Commit eabf11c99d4bda086133dc33050ec383ebb65e01 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eabf11c ]

Merge pull request #998 from ekholabs/fix/vr_passwd_server-CLOUDSTACK-8957

CLOUDSTACK-8957 - VR password server feature is brokenThis PR implements the 
update of the password as it use to be done with the bash file, but using the 
Python code for it.

A new integration test was added in order to cover the fix. The test can be 
found at component/test_password_server.py and does the following:

* Creates an Account
* Creates a Service Offering
* Creates a Network Offering
* Creates a Network
* Creates two Virtual Machines
* Creates two FW rules
* Creates two PF rules
* SSH into each VM and checks the default routes (by pinging 8.8.8.8)
* SSH to the host and executes a command in the router to check the 
password-[gateway] file
  - The file is under /var/cache/cloud/passwords-[gateway]

The [gateway] is replaced by the gateway from each virtual machine NIC.

* pr/998:
  CLOUDSTACK-8957 - Add integration test that cheks if the password file is 
present and not empty
  CLOUDSTACK-8957 - Implement password server in configure.py

Signed-off-by: Remi Bergsma 


> VR password server broken
> -
>
> Key: CLOUDSTACK-8957
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
> Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt
>Reporter: Nux
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Hello,
> When deploying instances from password enabled templates, the instances do 
> not get the generated passwords.
> The VR logs show something like this:
> 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested 
> password not found for 10.1.1.33'
> In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is 
> not, I can see the passwords there.
> Symlinking "passwords-10.1.1.1" to "passwords" and restarting the 
> passwd_server_ip script gets the feature working again, though I am not sure 
> how correct this approach is.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (CLOUDSTACK-8957) VR password server broken

[Remi Bergsma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Remi Bergsma closed CLOUDSTACK-8957.


> VR password server broken
> -
>
> Key: CLOUDSTACK-8957
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
> Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt
>Reporter: Nux
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Hello,
> When deploying instances from password enabled templates, the instances do 
> not get the generated passwords.
> The VR logs show something like this:
> 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested 
> password not found for 10.1.1.33'
> In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is 
> not, I can see the passwords there.
> Symlinking "passwords-10.1.1.1" to "passwords" and restarting the 
> passwd_server_ip script gets the feature working again, though I am not sure 
> how correct this approach is.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8957) VR password server broken

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980045#comment-14980045
 ] 

ASF subversion and git services commented on CLOUDSTACK-8957:
-

Commit b2aa1f8417138797dddf3813fcaed9b5ea4ba611 in cloudstack's branch 
refs/heads/master from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b2aa1f8 ]

CLOUDSTACK-8957 - Implement password server in configure.py


> VR password server broken
> -
>
> Key: CLOUDSTACK-8957
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
> Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt
>Reporter: Nux
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Hello,
> When deploying instances from password enabled templates, the instances do 
> not get the generated passwords.
> The VR logs show something like this:
> 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested 
> password not found for 10.1.1.33'
> In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is 
> not, I can see the passwords there.
> Symlinking "passwords-10.1.1.1" to "passwords" and restarting the 
> passwd_server_ip script gets the feature working again, though I am not sure 
> how correct this approach is.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CLOUDSTACK-8957) VR password server broken

[Remi Bergsma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Remi Bergsma resolved CLOUDSTACK-8957.
--
Resolution: Fixed

PR 998 is merged

> VR password server broken
> -
>
> Key: CLOUDSTACK-8957
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
> Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt
>Reporter: Nux
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Hello,
> When deploying instances from password enabled templates, the instances do 
> not get the generated passwords.
> The VR logs show something like this:
> 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested 
> password not found for 10.1.1.33'
> In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is 
> not, I can see the passwords there.
> Symlinking "passwords-10.1.1.1" to "passwords" and restarting the 
> passwd_server_ip script gets the feature working again, though I am not sure 
> how correct this approach is.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8957) VR password server broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980051#comment-14980051
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8957:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/998


> VR password server broken
> -
>
> Key: CLOUDSTACK-8957
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.6.0
> Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt
>Reporter: Nux
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Hello,
> When deploying instances from password enabled templates, the instances do 
> not get the generated passwords.
> The VR logs show something like this:
> 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested 
> password not found for 10.1.1.33'
> In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is 
> not, I can see the passwords there.
> Symlinking "passwords-10.1.1.1" to "passwords" and restarting the 
> passwd_server_ip script gets the feature working again, though I am not sure 
> how correct this approach is.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)