[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312652#comment-16312652 ] ASF GitHub Bot commented on CLOUDSTACK-9889: DaanHoogland commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355494141 @yvsubhash it has merge conflicts again. Can you resolve them again? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Dedicate guest vlan range to a domain > -- > > Key: CLOUDSTACK-9889 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: subhash yedugundla > > List of scenarios covered > *Dedication of guest Vlan range* > Admin should be allowed dedicate guest vlan ranges to a domain > While dedicating a guest Vlan range > If the range overlaps with any of the existing dedicated range then extend > the existing dedicated range > Otherwise add it as a new dedicated guest Vlan range > If the range doesn’t exist in the system then the request should fail > If any of the vlan in the range is in use by a network that belongs to a > different account of different domain then the request should fail > *Releasing guest Vlan range* > Admin should be allowed to release a dedicated guest vlan range that is > dedicated to a domain back to the system pool > If the range is not dedicated to the domain then the request should fail > Even If one/more of the Vlans belonging to the range is in use by a network > the range should be released back to the system pool > The vlans that are in use should continue to be in use by the network > *Network implementation* > If the network belongs to an account that has a dedicated range of Vlans then > a Vlan from the account's dedicated range should be allocated to the network > If an account uses up all of its dedicated Vlan’s the next network being > created for the account should be assigned a Vlan that belongs to the domain > pool > Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range > belonging to the zone > *Network creation* > If a Vlan id is specified and if this id belongs to a dedicated Vlan range of > a different account/domain then the creation should fail > If a Vlan id is specified and if this id belongs to the system pool but the > network owner has a range of dedicated range of vlans then the creation > should fail > *Domain deletion* > Guest Ip ranges and vlans dedicated to the domain should be released back to > the free pool > *Account deletion* > When an account is deleted, the IP ranges and vlans associated with the > account should be moved to system pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312648#comment-16312648 ] ASF GitHub Bot commented on CLOUDSTACK-9025: DaanHoogland commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if … URL: https://github.com/apache/cloudstack/pull/2317#issuecomment-355493056 @anshul1886 do you agree to close this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to deploy VM instance from template if template spin from linked clone > snapshot > -- > > Key: CLOUDSTACK-9025 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Affects Versions: 4.5.2 > Environment: XenServer 6.5 >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar >Priority: Critical > Fix For: 4.6.0 > > > As default, CloudStack create linked clone snapshot for VM instance . When we > take a snapshot for the VM, and create a template based on such snapshot, > CloudStack only download incremental VHD as template file, as a result, the > VM instance fail to deploy as it is incomplete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10126) Separate Subnet for CPVM and SSVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312647#comment-16312647 ] ASF subversion and git services commented on CLOUDSTACK-10126: -- Commit bf4f1bbb90a7ac05c7d40b1e5667186a646a25f7 in cloudstack's branch refs/heads/master from [~nicolas.vazquez] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=bf4f1bb ] CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM (#2368) This extends work presented on #2048 on which the ability to extend the management range is provided. Aim This PR allows separating the management network subnet on which SSVM and CPVM are from the virtual routers management subnet. Detailed use case PCI compliance requires that network elements are defined as ‘in scope’ or ‘out of scope’, for compliance purposes. The SSVM and CPVM are both in scope as they allow public HTTP or HTTPS connections. The virtual routers have been defined as out of scope as they have been placed entirely in a firewalled network's segment. However, all of the system VM types share management network. As SSVM and CPVM are both in scope this would bring the virtual routers into scope as well, requiring individual audits of every virtual router. As this is not practical, the ‘management network’ which the SSVM and CPVM are on, and the management network which the virtual routers are on, must be separated by a firewall. Description By this feature it is possible to dedicate a created range for SSVM and CPVM (system vms) and provide a VLAN ID for its range. A new boolean global configuration is added: system.vm.management.ip.reservation.mode.strictness. If enabled, the use of System VMs management IP reservation is strict, preferred if not. Default value is false (preferred). Strict reservation: System VMs should try to get a private IP from a range marked for system vms. If not available, deployment fails Preferred reservation: System VMS will try to get a private IP from a range marked for system vms. If not available, IP for range not marked for system vms is taken. > Separate Subnet for CPVM and SSVM > - > > Key: CLOUDSTACK-10126 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > > Separate Management Subnet for CPVM and SSVM -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10126) Separate Subnet for CPVM and SSVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312646#comment-16312646 ] ASF GitHub Bot commented on CLOUDSTACK-10126: - rhtyd closed pull request #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2368 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java b/api/src/org/apache/cloudstack/api/ApiConstants.java index 0e275b5de15..8b632be4fd5 100644 --- a/api/src/org/apache/cloudstack/api/ApiConstants.java +++ b/api/src/org/apache/cloudstack/api/ApiConstants.java @@ -125,6 +125,7 @@ public static final String FORCED_DESTROY_LOCAL_STORAGE = "forcedestroylocalstorage"; public static final String FORMAT = "format"; public static final String FOR_VIRTUAL_NETWORK = "forvirtualnetwork"; +public static final String FOR_SYSTEM_VMS = "forsystemvms"; public static final String GATEWAY = "gateway"; public static final String IP6_GATEWAY = "ip6gateway"; public static final String GROUP = "group"; diff --git a/api/src/org/apache/cloudstack/api/command/admin/network/CreateManagementNetworkIpRangeCmd.java b/api/src/org/apache/cloudstack/api/command/admin/network/CreateManagementNetworkIpRangeCmd.java index e5bfc07c699..f7957469cd1 100644 --- a/api/src/org/apache/cloudstack/api/command/admin/network/CreateManagementNetworkIpRangeCmd.java +++ b/api/src/org/apache/cloudstack/api/command/admin/network/CreateManagementNetworkIpRangeCmd.java @@ -85,6 +85,16 @@ description = "The ending IP address.") private String endIp; +@Parameter(name = ApiConstants.FOR_SYSTEM_VMS, +type = CommandType.BOOLEAN, +description = "Specify if range is dedicated for CPVM and SSVM.") +private Boolean forSystemVms; + +@Parameter(name = ApiConstants.VLAN, +type = CommandType.STRING, +description = "Optional. The vlan id the ip range sits on, default to Null when it is not specificed which means you network is not on any Vlan") +private String vlan; + / /// Accessors /// / @@ -109,6 +119,17 @@ public String getEndIp() { return endIp; } +public Boolean isForSystemVms() { +return forSystemVms == null ? Boolean.FALSE : forSystemVms; +} + +public String getVlan() { +if (vlan == null || vlan.isEmpty()) { +vlan = "untagged"; +} +return vlan; +} + @Override public String getEventType() { return EventTypes.EVENT_MANAGEMENT_IP_RANGE_CREATE; diff --git a/api/src/org/apache/cloudstack/api/command/admin/network/DeleteManagementNetworkIpRangeCmd.java b/api/src/org/apache/cloudstack/api/command/admin/network/DeleteManagementNetworkIpRangeCmd.java index acb9e7a4678..d6481846f43 100644 --- a/api/src/org/apache/cloudstack/api/command/admin/network/DeleteManagementNetworkIpRangeCmd.java +++ b/api/src/org/apache/cloudstack/api/command/admin/network/DeleteManagementNetworkIpRangeCmd.java @@ -72,6 +72,12 @@ validations = ApiArgValidator.NotNullOrEmpty) private String endIp; +@Parameter(name = ApiConstants.VLAN, +type = CommandType.STRING, +required = true, +description = "The vlan id the ip range sits on") +private String vlan; + / /// Accessors /// / @@ -88,6 +94,10 @@ public String getEndIp() { return endIp; } +public String getVlan() { +return vlan; +} + @Override public String getEventType() { return EventTypes.EVENT_MANAGEMENT_IP_RANGE_DELETE; diff --git a/api/src/org/apache/cloudstack/api/response/PodResponse.java b/api/src/org/apache/cloudstack/api/response/PodResponse.java index c5c700ef5df..27ebf71a994 100644 --- a/api/src/org/apache/cloudstack/api/response/PodResponse.java +++ b/api/src/org/apache/cloudstack/api/response/PodResponse.java @@ -61,6 +61,14 @@ @Param(description = "the ending IP for the Pod") private List endIp; +@SerializedName("forsystemvms") +@Param(description = "indicates if range is dedicated for CPVM and SSVM") +private List forSystemVms; + +@SerializedName("vlanid") +@Param(description = "indicates Vlan ID for the range") +private List vlanId; + @SerializedName("allocationstate")
[jira] [Commented] (CLOUDSTACK-10126) Separate Subnet for CPVM and SSVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312643#comment-16312643 ] ASF GitHub Bot commented on CLOUDSTACK-10126: - rhtyd commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-355492845 Merging this based on code reviews and test results. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Separate Subnet for CPVM and SSVM > - > > Key: CLOUDSTACK-10126 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > > Separate Management Subnet for CPVM and SSVM -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312645#comment-16312645 ] ASF GitHub Bot commented on CLOUDSTACK-9025: DaanHoogland commented on a change in pull request #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. URL: https://github.com/apache/cloudstack/pull/2315#discussion_r159822245 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ## @@ -167,35 +170,62 @@ public boolean trackVmHostChange() { @Override public PairgetCommandHostDelegation(long hostId, Command cmd) { Review comment: in terms of cyclic complexity this method doesn't improve This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to deploy VM instance from template if template spin from linked clone > snapshot > -- > > Key: CLOUDSTACK-9025 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Affects Versions: 4.5.2 > Environment: XenServer 6.5 >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar >Priority: Critical > Fix For: 4.6.0 > > > As default, CloudStack create linked clone snapshot for VM instance . When we > take a snapshot for the VM, and create a template based on such snapshot, > CloudStack only download incremental VHD as template file, as a result, the > VM instance fail to deploy as it is incomplete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312638#comment-16312638 ] ASF GitHub Bot commented on CLOUDSTACK-10146: - blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355492378 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bypass Secondary Storage for KVM templates > -- > > Key: CLOUDSTACK-10146 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312637#comment-16312637 ] ASF GitHub Bot commented on CLOUDSTACK-10146: - rhtyd commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355492347 @blueorangutan package @rafaelweingartner @marcaurele can you re-review the changes/lgtm is okay? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bypass Secondary Storage for KVM templates > -- > > Key: CLOUDSTACK-10146 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312631#comment-16312631 ] ASF GitHub Bot commented on CLOUDSTACK-9813: blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355491535 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use configdrive for userdata, metadata & password > -- > > Key: CLOUDSTACK-9813 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Network Controller, Secondary Storage, SystemVM, > VMware >Affects Versions: Future >Reporter: Eric Waegeman >Assignee: Kris Sterckx > > To avoid the use of an extra VM for the virtual router we implement > configdrive for userdata, metadata & password. > The configdrive ISO is created on the secondary store and the KVM & VMware > plugins are adapted to accept the configdrive ISO as second cdrom. > Is applicable for isolated, VPC and shared networks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312629#comment-16312629 ] ASF GitHub Bot commented on CLOUDSTACK-10207: - rhtyd commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option… URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-355491508 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > updateVpnCustomerGateway: unexpected changes on optional keys > - > > Key: CLOUDSTACK-10207 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: René Moser >Assignee: René Moser >Priority: Minor > Fix For: 4.11.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312628#comment-16312628 ] ASF GitHub Bot commented on CLOUDSTACK-9813: rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355491478 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use configdrive for userdata, metadata & password > -- > > Key: CLOUDSTACK-9813 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Network Controller, Secondary Storage, SystemVM, > VMware >Affects Versions: Future >Reporter: Eric Waegeman >Assignee: Kris Sterckx > > To avoid the use of an extra VM for the virtual router we implement > configdrive for userdata, metadata & password. > The configdrive ISO is created on the secondary store and the KVM & VMware > plugins are adapted to accept the configdrive ISO as second cdrom. > Is applicable for isolated, VPC and shared networks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312630#comment-16312630 ] ASF GitHub Bot commented on CLOUDSTACK-10207: - blueorangutan commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option… URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-355491530 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > updateVpnCustomerGateway: unexpected changes on optional keys > - > > Key: CLOUDSTACK-10207 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: René Moser >Assignee: René Moser >Priority: Minor > Fix For: 4.11.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312626#comment-16312626 ] ASF GitHub Bot commented on CLOUDSTACK-9813: blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355491124 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1586 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use configdrive for userdata, metadata & password > -- > > Key: CLOUDSTACK-9813 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Network Controller, Secondary Storage, SystemVM, > VMware >Affects Versions: Future >Reporter: Eric Waegeman >Assignee: Kris Sterckx > > To avoid the use of an extra VM for the virtual router we implement > configdrive for userdata, metadata & password. > The configdrive ISO is created on the secondary store and the KVM & VMware > plugins are adapted to accept the configdrive ISO as second cdrom. > Is applicable for isolated, VPC and shared networks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (CLOUDSTACK-10211) test_nuage_public_sharednetwork_userdata fails due to errortext changed
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Yadav closed CLOUDSTACK-10211. > test_nuage_public_sharednetwork_userdata fails due to errortext changed > --- > > Key: CLOUDSTACK-10211 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10211 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Test >Affects Versions: 4.11.0.0 > Environment: Nuagevsp only >Reporter: Raf Smeets > > In > test/integration/plugins/nuagevsp/test_nuage_public_sharednetwork_userdata.py > , there are 4 failing tests as in master upstream the errortext in case of VM > deployment failure changed from errortext "Failed to deploy VM" has changed > to "Unable to start VM instance" > This failing test is nuagespecific and can only run in a NuageVSP environment. > Following tests are failing and need adapting. > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_06_verify_different_gateway_subnet_fails_sharednetwork_all | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_07_different_gateway_subnet_fails_sharednetwork_domain | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_08_different_gateway_subnet_fails_sharednetwork_nosubdomain | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_09_different_gateway_subnet_fails_sharednetwork_account | > Status : FAILED === > FAIL > All above tests fails due to an AssertionError: correct exception is not > raised. > Solution is that errortext "Failed to deploy VM" needs to changed to "Unable > to start VM instance" > This bug is written to get this change in upstream master. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312624#comment-16312624 ] ASF GitHub Bot commented on CLOUDSTACK-10207: - blueorangutan commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option… URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-355491102 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1585 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > updateVpnCustomerGateway: unexpected changes on optional keys > - > > Key: CLOUDSTACK-10207 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: René Moser >Assignee: René Moser >Priority: Minor > Fix For: 4.11.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312610#comment-16312610 ] ASF GitHub Bot commented on CLOUDSTACK-9620: rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355490723 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improvements for Managed Storage > > > Key: CLOUDSTACK-9620 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Management Server, VMware, XenServer >Affects Versions: 4.11.0.0 > Environment: KVM, vSphere, and XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski > Fix For: 4.11.0.0 > > > Allowed zone-wide primary storage based on a custom plug-in to be added via > the GUI in a KVM-only environment (previously this only worked for XenServer > and VMware) > Added support for root disks on managed storage with KVM > Added support for volume snapshots with managed storage on KVM > Enabled creating a template directly from a volume (i.e. without having to go > through a volume snapshot) on KVM with managed storage > Only allowed the resizing of a volume for managed storage on KVM if the > volume in question is either not attached to a VM or is attached to a VM in > the Stopped state > Included support for Reinstall VM on KVM with managed storage > Enabled offline migration on KVM from non-managed storage to managed storage > and vice versa > Included support for online storage migration on KVM with managed storage > (NFS and Ceph to managed storage) > Added support to download (extract) a managed-storage volume to a QCOW2 file > When uploading a file from outside of CloudStack to CloudStack, set the min > and max IOPS, if applicable. > Included support for the KVM auto-convergence feature > The compression flag was actually added in version 1.0.3 (103) as opposed > to version 1.3.0 (1003000) (changed this to reflect the correct version) > On KVM when using iSCSI-based managed storage, if the user shuts a VM down > from the guest OS (as opposed to doing so from CloudStack), we need to pass > to the KVM agent a list of applicable iSCSI volumes that need to be > disconnected. > Added a new Global Setting: kvm.storage.live.migration.wait > For XenServer, added a check to enforce that only volumes from zone-wide > managed storage can be storage motioned from a host in one cluster to a host > in another cluster (cannot do so at the time being with volumes from > cluster-scoped managed storage) > Don’t allow Storage XenMotion on a VM that has any managed-storage volume > with one or more snapshots. > Enabled for managed storage with VMware: Template caching, create snapshot, > delete snapshot, create volume from snapshot, and create template from > snapshot > Added an SIOC API plug-in to support VMware SIOC > When starting a VM that uses managed storage in a cluster other than the one > it last was running in, we need to remove the reference to the iSCSI volume > from the original cluster. > Added the ability to revert a volume to a snapshot > Enabled cluster-scoped managed storage > Added support for VMware dynamic discovery -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312612#comment-16312612 ] ASF GitHub Bot commented on CLOUDSTACK-9620: blueorangutan commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355490750 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improvements for Managed Storage > > > Key: CLOUDSTACK-9620 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Management Server, VMware, XenServer >Affects Versions: 4.11.0.0 > Environment: KVM, vSphere, and XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski > Fix For: 4.11.0.0 > > > Allowed zone-wide primary storage based on a custom plug-in to be added via > the GUI in a KVM-only environment (previously this only worked for XenServer > and VMware) > Added support for root disks on managed storage with KVM > Added support for volume snapshots with managed storage on KVM > Enabled creating a template directly from a volume (i.e. without having to go > through a volume snapshot) on KVM with managed storage > Only allowed the resizing of a volume for managed storage on KVM if the > volume in question is either not attached to a VM or is attached to a VM in > the Stopped state > Included support for Reinstall VM on KVM with managed storage > Enabled offline migration on KVM from non-managed storage to managed storage > and vice versa > Included support for online storage migration on KVM with managed storage > (NFS and Ceph to managed storage) > Added support to download (extract) a managed-storage volume to a QCOW2 file > When uploading a file from outside of CloudStack to CloudStack, set the min > and max IOPS, if applicable. > Included support for the KVM auto-convergence feature > The compression flag was actually added in version 1.0.3 (103) as opposed > to version 1.3.0 (1003000) (changed this to reflect the correct version) > On KVM when using iSCSI-based managed storage, if the user shuts a VM down > from the guest OS (as opposed to doing so from CloudStack), we need to pass > to the KVM agent a list of applicable iSCSI volumes that need to be > disconnected. > Added a new Global Setting: kvm.storage.live.migration.wait > For XenServer, added a check to enforce that only volumes from zone-wide > managed storage can be storage motioned from a host in one cluster to a host > in another cluster (cannot do so at the time being with volumes from > cluster-scoped managed storage) > Don’t allow Storage XenMotion on a VM that has any managed-storage volume > with one or more snapshots. > Enabled for managed storage with VMware: Template caching, create snapshot, > delete snapshot, create volume from snapshot, and create template from > snapshot > Added an SIOC API plug-in to support VMware SIOC > When starting a VM that uses managed storage in a cluster other than the one > it last was running in, we need to remove the reference to the iSCSI volume > from the original cluster. > Added the ability to revert a volume to a snapshot > Enabled cluster-scoped managed storage > Added support for VMware dynamic discovery -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312613#comment-16312613 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - blueorangutan commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355490792 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1584 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312608#comment-16312608 ] ASF GitHub Bot commented on CLOUDSTACK-9620: mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355490641 @DaanHoogland Ideally, yes, 4.11 (I have several customers looking for this to go into a LTS release). As for support: I don't plan on going anywhere anytime soon. :) Also, I have a bunch of new integration tests (as part of this PR) to test out the new features (as well as whatever tests @rhtyd runs as part of the PR process). Feel free to change white space as you see fit. :) I do that kind of thing when I'm looking through existing code, too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improvements for Managed Storage > > > Key: CLOUDSTACK-9620 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Management Server, VMware, XenServer >Affects Versions: 4.11.0.0 > Environment: KVM, vSphere, and XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski > Fix For: 4.11.0.0 > > > Allowed zone-wide primary storage based on a custom plug-in to be added via > the GUI in a KVM-only environment (previously this only worked for XenServer > and VMware) > Added support for root disks on managed storage with KVM > Added support for volume snapshots with managed storage on KVM > Enabled creating a template directly from a volume (i.e. without having to go > through a volume snapshot) on KVM with managed storage > Only allowed the resizing of a volume for managed storage on KVM if the > volume in question is either not attached to a VM or is attached to a VM in > the Stopped state > Included support for Reinstall VM on KVM with managed storage > Enabled offline migration on KVM from non-managed storage to managed storage > and vice versa > Included support for online storage migration on KVM with managed storage > (NFS and Ceph to managed storage) > Added support to download (extract) a managed-storage volume to a QCOW2 file > When uploading a file from outside of CloudStack to CloudStack, set the min > and max IOPS, if applicable. > Included support for the KVM auto-convergence feature > The compression flag was actually added in version 1.0.3 (103) as opposed > to version 1.3.0 (1003000) (changed this to reflect the correct version) > On KVM when using iSCSI-based managed storage, if the user shuts a VM down > from the guest OS (as opposed to doing so from CloudStack), we need to pass > to the KVM agent a list of applicable iSCSI volumes that need to be > disconnected. > Added a new Global Setting: kvm.storage.live.migration.wait > For XenServer, added a check to enforce that only volumes from zone-wide > managed storage can be storage motioned from a host in one cluster to a host > in another cluster (cannot do so at the time being with volumes from > cluster-scoped managed storage) > Don’t allow Storage XenMotion on a VM that has any managed-storage volume > with one or more snapshots. > Enabled for managed storage with VMware: Template caching, create snapshot, > delete snapshot, create volume from snapshot, and create template from > snapshot > Added an SIOC API plug-in to support VMware SIOC > When starting a VM that uses managed storage in a cluster other than the one > it last was running in, we need to remove the reference to the iSCSI volume > from the original cluster. > Added the ability to revert a volume to a snapshot > Enabled cluster-scoped managed storage > Added support for VMware dynamic discovery -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312605#comment-16312605 ] ASF GitHub Bot commented on CLOUDSTACK-10109: - blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355490179 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable dedication of public IPs to SSVM and CPVM > > > Key: CLOUDSTACK-10109 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > Attachments: public01.png, public02.png, public03.png > > > It is required to dedicate a public IP range for SSVM and CPVM in order to > apply firewall rules to control inbound access. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312606#comment-16312606 ] ASF GitHub Bot commented on CLOUDSTACK-9620: DaanHoogland commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355490203 @mike-tutkowski @rafaelweingartner the questions are: Are we comfortable with this code as is? Do we want to go with it in 4.11? How much effort do we put in after releasing this? I can not fully assess this as it is so big. And the argument of cyclic complexity of both methods and classes is weighing heavily. btw @mike-tutkowski I'll stop bugging you about the noisy whitelines but I will remove a lot of them at my next chance ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improvements for Managed Storage > > > Key: CLOUDSTACK-9620 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Management Server, VMware, XenServer >Affects Versions: 4.11.0.0 > Environment: KVM, vSphere, and XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski > Fix For: 4.11.0.0 > > > Allowed zone-wide primary storage based on a custom plug-in to be added via > the GUI in a KVM-only environment (previously this only worked for XenServer > and VMware) > Added support for root disks on managed storage with KVM > Added support for volume snapshots with managed storage on KVM > Enabled creating a template directly from a volume (i.e. without having to go > through a volume snapshot) on KVM with managed storage > Only allowed the resizing of a volume for managed storage on KVM if the > volume in question is either not attached to a VM or is attached to a VM in > the Stopped state > Included support for Reinstall VM on KVM with managed storage > Enabled offline migration on KVM from non-managed storage to managed storage > and vice versa > Included support for online storage migration on KVM with managed storage > (NFS and Ceph to managed storage) > Added support to download (extract) a managed-storage volume to a QCOW2 file > When uploading a file from outside of CloudStack to CloudStack, set the min > and max IOPS, if applicable. > Included support for the KVM auto-convergence feature > The compression flag was actually added in version 1.0.3 (103) as opposed > to version 1.3.0 (1003000) (changed this to reflect the correct version) > On KVM when using iSCSI-based managed storage, if the user shuts a VM down > from the guest OS (as opposed to doing so from CloudStack), we need to pass > to the KVM agent a list of applicable iSCSI volumes that need to be > disconnected. > Added a new Global Setting: kvm.storage.live.migration.wait > For XenServer, added a check to enforce that only volumes from zone-wide > managed storage can be storage motioned from a host in one cluster to a host > in another cluster (cannot do so at the time being with volumes from > cluster-scoped managed storage) > Don’t allow Storage XenMotion on a VM that has any managed-storage volume > with one or more snapshots. > Enabled for managed storage with VMware: Template caching, create snapshot, > delete snapshot, create volume from snapshot, and create template from > snapshot > Added an SIOC API plug-in to support VMware SIOC > When starting a VM that uses managed storage in a cluster other than the one > it last was running in, we need to remove the reference to the iSCSI volume > from the original cluster. > Added the ability to revert a volume to a snapshot > Enabled cluster-scoped managed storage > Added support for VMware dynamic discovery -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312603#comment-16312603 ] ASF GitHub Bot commented on CLOUDSTACK-10109: - rhtyd commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355490159 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable dedication of public IPs to SSVM and CPVM > > > Key: CLOUDSTACK-10109 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > Attachments: public01.png, public02.png, public03.png > > > It is required to dedicate a public IP range for SSVM and CPVM in order to > apply firewall rules to control inbound access. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312600#comment-16312600 ] ASF GitHub Bot commented on CLOUDSTACK-9620: mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355490015 @rhtyd @DaanHoogland I have refactored the createAsync method in StorageSystemDataMotionStrategy.java. I still need to make use of the ConfigKey class instead of the Config class, as Daan requested. I should be able to do this tomorrow (well, technically, later today. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improvements for Managed Storage > > > Key: CLOUDSTACK-9620 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Management Server, VMware, XenServer >Affects Versions: 4.11.0.0 > Environment: KVM, vSphere, and XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski > Fix For: 4.11.0.0 > > > Allowed zone-wide primary storage based on a custom plug-in to be added via > the GUI in a KVM-only environment (previously this only worked for XenServer > and VMware) > Added support for root disks on managed storage with KVM > Added support for volume snapshots with managed storage on KVM > Enabled creating a template directly from a volume (i.e. without having to go > through a volume snapshot) on KVM with managed storage > Only allowed the resizing of a volume for managed storage on KVM if the > volume in question is either not attached to a VM or is attached to a VM in > the Stopped state > Included support for Reinstall VM on KVM with managed storage > Enabled offline migration on KVM from non-managed storage to managed storage > and vice versa > Included support for online storage migration on KVM with managed storage > (NFS and Ceph to managed storage) > Added support to download (extract) a managed-storage volume to a QCOW2 file > When uploading a file from outside of CloudStack to CloudStack, set the min > and max IOPS, if applicable. > Included support for the KVM auto-convergence feature > The compression flag was actually added in version 1.0.3 (103) as opposed > to version 1.3.0 (1003000) (changed this to reflect the correct version) > On KVM when using iSCSI-based managed storage, if the user shuts a VM down > from the guest OS (as opposed to doing so from CloudStack), we need to pass > to the KVM agent a list of applicable iSCSI volumes that need to be > disconnected. > Added a new Global Setting: kvm.storage.live.migration.wait > For XenServer, added a check to enforce that only volumes from zone-wide > managed storage can be storage motioned from a host in one cluster to a host > in another cluster (cannot do so at the time being with volumes from > cluster-scoped managed storage) > Don’t allow Storage XenMotion on a VM that has any managed-storage volume > with one or more snapshots. > Enabled for managed storage with VMware: Template caching, create snapshot, > delete snapshot, create volume from snapshot, and create template from > snapshot > Added an SIOC API plug-in to support VMware SIOC > When starting a VM that uses managed storage in a cluster other than the one > it last was running in, we need to remove the reference to the iSCSI volume > from the original cluster. > Added the ability to revert a volume to a snapshot > Enabled cluster-scoped managed storage > Added support for VMware dynamic discovery -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9730) [VMware] Unable to add a host with space in its name to existing VMware cluster
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312585#comment-16312585 ] ASF GitHub Bot commented on CLOUDSTACK-9730: blueorangutan commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#issuecomment-355486154 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1581 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [VMware] Unable to add a host with space in its name to existing VMware > cluster > --- > > Key: CLOUDSTACK-9730 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9730 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.1.0 > > > ISSUE > == > Unable to add a host with space in the name to existing VMware cluster. > While adding host, CloudStack tries to persist the validated inventory url > path in database, which inserts encoded url into database which means > whitespace would be stored as '+' symbols. Url from API parameter string is > being converted to URI object as part of validation, where the url path is > getting encoded. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312584#comment-16312584 ] ASF GitHub Bot commented on CLOUDSTACK-10109: - blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355486153 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1583 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable dedication of public IPs to SSVM and CPVM > > > Key: CLOUDSTACK-10109 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > Attachments: public01.png, public02.png, public03.png > > > It is required to dedicate a public IP range for SSVM and CPVM in order to > apply firewall rules to control inbound access. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312586#comment-16312586 ] ASF GitHub Bot commented on CLOUDSTACK-9889: blueorangutan commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355486152 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1582 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Dedicate guest vlan range to a domain > -- > > Key: CLOUDSTACK-9889 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: subhash yedugundla > > List of scenarios covered > *Dedication of guest Vlan range* > Admin should be allowed dedicate guest vlan ranges to a domain > While dedicating a guest Vlan range > If the range overlaps with any of the existing dedicated range then extend > the existing dedicated range > Otherwise add it as a new dedicated guest Vlan range > If the range doesn’t exist in the system then the request should fail > If any of the vlan in the range is in use by a network that belongs to a > different account of different domain then the request should fail > *Releasing guest Vlan range* > Admin should be allowed to release a dedicated guest vlan range that is > dedicated to a domain back to the system pool > If the range is not dedicated to the domain then the request should fail > Even If one/more of the Vlans belonging to the range is in use by a network > the range should be released back to the system pool > The vlans that are in use should continue to be in use by the network > *Network implementation* > If the network belongs to an account that has a dedicated range of Vlans then > a Vlan from the account's dedicated range should be allocated to the network > If an account uses up all of its dedicated Vlan’s the next network being > created for the account should be assigned a Vlan that belongs to the domain > pool > Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range > belonging to the zone > *Network creation* > If a Vlan id is specified and if this id belongs to a dedicated Vlan range of > a different account/domain then the creation should fail > If a Vlan id is specified and if this id belongs to the system pool but the > network owner has a range of dedicated range of vlans then the creation > should fail > *Domain deletion* > Guest Ip ranges and vlans dedicated to the domain should be released back to > the free pool > *Account deletion* > When an account is deleted, the IP ranges and vlans associated with the > account should be moved to system pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10087) Template registration errors out when template URL is https
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312564#comment-16312564 ] ASF GitHub Bot commented on CLOUDSTACK-10087: - blueorangutan commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i… URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355482702 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Template registration errors out when template URL is https > --- > > Key: CLOUDSTACK-10087 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10087 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > > *Management server logs:* > 2017-08-23 08:55:36,706 DEBUG [c.c.a.t.Request] (AgentManager-Handler-5:null) > (logid:) Seq 4-7842174326135586819: Processing: { Ans: , MgmtId: 4278190080, > via: 4, Ver: v1, Flags: 110, > [{"com.cloud.agent.api.Answer":{"result":false,"details":"com.amazonaws.SdkClientException: > Unable to execute HTTP request: sun.security.validator.ValidatorException: > PKIX path building failed: > sun.security.provider.certpath.SunCertPathBuilderException: unable to find > valid certification path to requested target\n\tat > com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:972)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:676)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:650)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:633)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$300(AmazonHttpClient.java:601)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:583)\n\tat > com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:447)\n\tat > com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.getBucketRegionViaHeadRequest(AmazonS3Client.java:4856)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.fetchRegionFromCache(AmazonS3Client.java:4830)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4122)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4079)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:819)\n\tat > com.cloud.utils.storage.S3.S3Utils.listDirectory(S3Utils.java:179)\n\tat > org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.s3ListVolume(NfsSecondaryStorageResource.java:1667)\n\tat > > org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.execute(NfsSecondaryStorageResource.java:1721)\n\tat > > org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.executeRequest(NfsSecondaryStorageResource.java:277)\n\tat > > com.cloud.storage.resource.PremiumSecondaryStorageResource.defaultAction(PremiumSecondaryStorageResource.java:64)\n\tat > > com.cloud.storage.resource.PremiumSecondaryStorageResource.executeRequest(PremiumSecondaryStorageResource.java:60)\n\tat > com.cloud.agent.Agent.processRequest(Agent.java:525)\n\tat > com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:833)\n\tat > com.cloud.utils.nio.Task.call(Task.java:83)\n\tat > com.cloud.utils.nio.Task.call(Task.java:29)\n\tat > java.util.concurrent.FutureTask.run(FutureTask.java:266)\n\tat > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\n\tat > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\n\tat > java.lang.Thread.run(Thread.java:745)\nCaused by: > javax.net.ssl.SSLHandshakeException: > sun.security.validator.ValidatorException: PKIX path building failed: > sun.security.provider.certpath.SunCertPathBuilderException: unable to find > valid certification path to requested target\n\tat > sun.security.ssl.Alerts.getSSLException(Alerts.java:192)\n\tat > sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1949)\n\tat > sun.security.ssl.Handshaker.fatalSE(Handshaker.java:302)\n\tat > sun.security.ssl.Handshaker.fatalSE(Handshaker.java:296)\n\tat > sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1509)\n\tat > >
[jira] [Commented] (CLOUDSTACK-9976) Redirect saml2 failed login message to a configurable URL
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312566#comment-16312566 ] ASF GitHub Bot commented on CLOUDSTACK-9976: rhtyd commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-355482714 Removing this from 4.11 due to lack of engagement from the PR author. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Redirect saml2 failed login message to a configurable URL > - > > Key: CLOUDSTACK-9976 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9976 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Gabriel Beims Bräscher >Assignee: Gabriel Beims Bräscher >Priority: Minor > Fix For: 4.10.1.0 > > Attachments: samlLoginResponse.png > > > When a user fails to authenticate with SAML2, it returns an error page > showing the content of the attached image. > To make it more user-friendly and customizable, one could configure a > desirable URL to redirect when such authentication failure happens. > This ticket proposes a global settings variable > (saml2.failed.login.redirect.url). If null, the SAML2 authentication flow > does not change from the current; however, if the user configures an URL then > ACS redirects to that URL. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10087) Template registration errors out when template URL is https
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312562#comment-16312562 ] ASF GitHub Bot commented on CLOUDSTACK-10087: - rhtyd commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i… URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355482630 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Template registration errors out when template URL is https > --- > > Key: CLOUDSTACK-10087 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10087 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > > *Management server logs:* > 2017-08-23 08:55:36,706 DEBUG [c.c.a.t.Request] (AgentManager-Handler-5:null) > (logid:) Seq 4-7842174326135586819: Processing: { Ans: , MgmtId: 4278190080, > via: 4, Ver: v1, Flags: 110, > [{"com.cloud.agent.api.Answer":{"result":false,"details":"com.amazonaws.SdkClientException: > Unable to execute HTTP request: sun.security.validator.ValidatorException: > PKIX path building failed: > sun.security.provider.certpath.SunCertPathBuilderException: unable to find > valid certification path to requested target\n\tat > com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:972)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:676)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:650)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:633)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$300(AmazonHttpClient.java:601)\n\tat > > com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:583)\n\tat > com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:447)\n\tat > com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.getBucketRegionViaHeadRequest(AmazonS3Client.java:4856)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.fetchRegionFromCache(AmazonS3Client.java:4830)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4122)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4079)\n\tat > > com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:819)\n\tat > com.cloud.utils.storage.S3.S3Utils.listDirectory(S3Utils.java:179)\n\tat > org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.s3ListVolume(NfsSecondaryStorageResource.java:1667)\n\tat > > org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.execute(NfsSecondaryStorageResource.java:1721)\n\tat > > org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.executeRequest(NfsSecondaryStorageResource.java:277)\n\tat > > com.cloud.storage.resource.PremiumSecondaryStorageResource.defaultAction(PremiumSecondaryStorageResource.java:64)\n\tat > > com.cloud.storage.resource.PremiumSecondaryStorageResource.executeRequest(PremiumSecondaryStorageResource.java:60)\n\tat > com.cloud.agent.Agent.processRequest(Agent.java:525)\n\tat > com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:833)\n\tat > com.cloud.utils.nio.Task.call(Task.java:83)\n\tat > com.cloud.utils.nio.Task.call(Task.java:29)\n\tat > java.util.concurrent.FutureTask.run(FutureTask.java:266)\n\tat > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\n\tat > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\n\tat > java.lang.Thread.run(Thread.java:745)\nCaused by: > javax.net.ssl.SSLHandshakeException: > sun.security.validator.ValidatorException: PKIX path building failed: > sun.security.provider.certpath.SunCertPathBuilderException: unable to find > valid certification path to requested target\n\tat > sun.security.ssl.Alerts.getSSLException(Alerts.java:192)\n\tat > sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1949)\n\tat > sun.security.ssl.Handshaker.fatalSE(Handshaker.java:302)\n\tat > sun.security.ssl.Handshaker.fatalSE(Handshaker.java:296)\n\tat > sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1509)\n\tat > > sun.security.ssl.ClientHandshaker.processMessage(ClientHandshaker.java:216)\n\tat >
[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312560#comment-16312560 ] ASF GitHub Bot commented on CLOUDSTACK-9813: blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355482611 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use configdrive for userdata, metadata & password > -- > > Key: CLOUDSTACK-9813 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Network Controller, Secondary Storage, SystemVM, > VMware >Affects Versions: Future >Reporter: Eric Waegeman >Assignee: Kris Sterckx > > To avoid the use of an extra VM for the virtual router we implement > configdrive for userdata, metadata & password. > The configdrive ISO is created on the secondary store and the KVM & VMware > plugins are adapted to accept the configdrive ISO as second cdrom. > Is applicable for isolated, VPC and shared networks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312557#comment-16312557 ] ASF GitHub Bot commented on CLOUDSTACK-10207: - rhtyd commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option… URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-355482484 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > updateVpnCustomerGateway: unexpected changes on optional keys > - > > Key: CLOUDSTACK-10207 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: René Moser >Assignee: René Moser >Priority: Minor > Fix For: 4.11.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312558#comment-16312558 ] ASF GitHub Bot commented on CLOUDSTACK-10207: - blueorangutan commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option… URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-355482496 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > updateVpnCustomerGateway: unexpected changes on optional keys > - > > Key: CLOUDSTACK-10207 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: René Moser >Assignee: René Moser >Priority: Minor > Fix For: 4.11.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312559#comment-16312559 ] ASF GitHub Bot commented on CLOUDSTACK-9813: rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355482507 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use configdrive for userdata, metadata & password > -- > > Key: CLOUDSTACK-9813 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Network Controller, Secondary Storage, SystemVM, > VMware >Affects Versions: Future >Reporter: Eric Waegeman >Assignee: Kris Sterckx > > To avoid the use of an extra VM for the virtual router we implement > configdrive for userdata, metadata & password. > The configdrive ISO is created on the secondary store and the KVM & VMware > plugins are adapted to accept the configdrive ISO as second cdrom. > Is applicable for isolated, VPC and shared networks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10211) test_nuage_public_sharednetwork_userdata fails due to errortext changed
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312555#comment-16312555 ] ASF GitHub Bot commented on CLOUDSTACK-10211: - rhtyd commented on issue #2385: CLOUDSTACK-10211 Fixed test_nuage_public_sharednetwork_userdata tests URL: https://github.com/apache/cloudstack/pull/2385#issuecomment-355482328 Merged this based on test results from nuage/vendor specific test results. The changes are also entirely in the nuage specific marvin test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > test_nuage_public_sharednetwork_userdata fails due to errortext changed > --- > > Key: CLOUDSTACK-10211 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10211 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Test >Affects Versions: 4.11.0.0 > Environment: Nuagevsp only >Reporter: Raf Smeets > > In > test/integration/plugins/nuagevsp/test_nuage_public_sharednetwork_userdata.py > , there are 4 failing tests as in master upstream the errortext in case of VM > deployment failure changed from errortext "Failed to deploy VM" has changed > to "Unable to start VM instance" > This failing test is nuagespecific and can only run in a NuageVSP environment. > Following tests are failing and need adapting. > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_06_verify_different_gateway_subnet_fails_sharednetwork_all | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_07_different_gateway_subnet_fails_sharednetwork_domain | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_08_different_gateway_subnet_fails_sharednetwork_nosubdomain | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_09_different_gateway_subnet_fails_sharednetwork_account | > Status : FAILED === > FAIL > All above tests fails due to an AssertionError: correct exception is not > raised. > Solution is that errortext "Failed to deploy VM" needs to changed to "Unable > to start VM instance" > This bug is written to get this change in upstream master. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312553#comment-16312553 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - blueorangutan commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355482277 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10211) test_nuage_public_sharednetwork_userdata fails due to errortext changed
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312552#comment-16312552 ] ASF subversion and git services commented on CLOUDSTACK-10211: -- Commit b26d798868f120567252753e27915a73ea9dac6b in cloudstack's branch refs/heads/master from [~smeetsr] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b26d798 ] CLOUDSTACK-10211: Fixed test_nuage_public_sharednetwork_userdata tests (#2385) > test_nuage_public_sharednetwork_userdata fails due to errortext changed > --- > > Key: CLOUDSTACK-10211 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10211 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Test >Affects Versions: 4.11.0.0 > Environment: Nuagevsp only >Reporter: Raf Smeets > > In > test/integration/plugins/nuagevsp/test_nuage_public_sharednetwork_userdata.py > , there are 4 failing tests as in master upstream the errortext in case of VM > deployment failure changed from errortext "Failed to deploy VM" has changed > to "Unable to start VM instance" > This failing test is nuagespecific and can only run in a NuageVSP environment. > Following tests are failing and need adapting. > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_06_verify_different_gateway_subnet_fails_sharednetwork_all | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_07_different_gateway_subnet_fails_sharednetwork_domain | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_08_different_gateway_subnet_fails_sharednetwork_nosubdomain | > Status : FAILED === > FAIL > Validate that Different gateway subnet fail as it is not supported ... === > TestName: test_09_different_gateway_subnet_fails_sharednetwork_account | > Status : FAILED === > FAIL > All above tests fails due to an AssertionError: correct exception is not > raised. > Solution is that errortext "Failed to deploy VM" needs to changed to "Unable > to start VM instance" > This bug is written to get this change in upstream master. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10211) test_nuage_public_sharednetwork_userdata fails due to errortext changed
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312551#comment-16312551 ] ASF GitHub Bot commented on CLOUDSTACK-10211: - rhtyd closed pull request #2385: CLOUDSTACK-10211 Fixed test_nuage_public_sharednetwork_userdata tests URL: https://github.com/apache/cloudstack/pull/2385 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/test/integration/plugins/nuagevsp/test_nuage_public_sharednetwork_userdata.py b/test/integration/plugins/nuagevsp/test_nuage_public_sharednetwork_userdata.py index d33d076aab0..554741b1a98 100644 --- a/test/integration/plugins/nuagevsp/test_nuage_public_sharednetwork_userdata.py +++ b/test/integration/plugins/nuagevsp/test_nuage_public_sharednetwork_userdata.py @@ -409,8 +409,8 @@ def test_01_verify_deployvm_fail_startip_sharednetwork_scope_all(self): except Exception as e: self.debug("Deploy vm fails as expected with exception %s" % e) self.debug("Going to verify the exception message") -excetionmsg = "it is reserved for the VR in network" -if excetionmsg in str(e): +exceptionmsg = "it is reserved for the VR in network" +if exceptionmsg in str(e): self.debug("correct exception is raised") else: self.fail("correct exception is not raised") @@ -705,8 +705,8 @@ def test_06_verify_different_gateway_subnet_fails_sharednetwork_all(self): "fails as expected with exception %s" % e) self.debug("Going to verify the exception message") self.delete_subnet_verify(self.shared_network_all, subnet2) -excetionmsg = "Failed to deploy VM" -if excetionmsg in str(e): +exceptionmsg = "Unable to start VM instance" +if exceptionmsg in str(e): self.debug("correct exception is raised") else: self.fail("correct exception is not raised") @@ -739,8 +739,8 @@ def test_07_different_gateway_subnet_fails_sharednetwork_domain(self): self.debug("Going to verify the exception message") self.delete_subnet_verify( self.shared_network_domain_with_subdomain_d11, subnet2) -excetionmsg = "Failed to deploy VM" -if excetionmsg in str(e): +exceptionmsg = "Unable to start VM instance" +if exceptionmsg in str(e): self.debug("correct exception is raised") else: self.fail("correct exception is not raised") @@ -772,8 +772,8 @@ def test_08_different_gateway_subnet_fails_sharednetwork_nosubdomain(self): self.debug("Going to verify the exception message") self.delete_subnet_verify( self.shared_network_domain_d11, subnet2) -excetionmsg = "Failed to deploy VM" -if excetionmsg in str(e): +exceptionmsg = "Unable to start VM instance" +if exceptionmsg in str(e): self.debug("correct exception is raised") else: self.fail("correct exception is not raised") @@ -805,8 +805,8 @@ def test_09_different_gateway_subnet_fails_sharednetwork_account(self): self.debug("Going to verify the exception message") self.delete_subnet_verify( self.shared_network_account_d111a, subnet2) -excetionmsg = "Failed to deploy VM" -if excetionmsg in str(e): +exceptionmsg = "Unable to start VM instance" +if exceptionmsg in str(e): self.debug("correct exception is raised") else: self.fail("correct exception is not raised") This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > test_nuage_public_sharednetwork_userdata fails due to errortext changed > --- > > Key: CLOUDSTACK-10211 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10211 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Test >Affects Versions: 4.11.0.0 > Environment: Nuagevsp only >Reporter: Raf Smeets > > In >
[jira] [Commented] (CLOUDSTACK-9906) Create snapshot after volume resize for the volume with existing snapshot(s)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312549#comment-16312549 ] ASF GitHub Bot commented on CLOUDSTACK-9906: rhtyd commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s) URL: https://github.com/apache/cloudstack/pull/2079#issuecomment-355482161 Additional review requested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create snapshot after volume resize for the volume with existing snapshot(s) > > > Key: CLOUDSTACK-9906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9906 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot, Volumes > Environment: XenServer >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > > Snapshot of a volume fails if the volume has an existing snapshot(s) taken > before resizing of the volume. This behavior needs to be improved so that > taking snapshot would be successful when there is an existing snapshot(s) > before volume resizing. > REPRO STEPS > = > - Create a volume with 10 GB and attach to any VM. > - Take snapshot of the volume. > - Change volume size from 10GB to 15 GB. > - Take snapshot of the volume after resizing it. > - Create a volume from the snapshot taken after resizing volume. > - Attach the volume (created above) to any VM and check the size. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312550#comment-16312550 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - rhtyd commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355482187 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312546#comment-16312546 ] ASF GitHub Bot commented on CLOUDSTACK-9025: rhtyd commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355481939 @rafaelweingartner can you fix the conflicts? @DaanHoogland @mike-tutkowski can you help review this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to deploy VM instance from template if template spin from linked clone > snapshot > -- > > Key: CLOUDSTACK-9025 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Affects Versions: 4.5.2 > Environment: XenServer 6.5 >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar >Priority: Critical > Fix For: 4.6.0 > > > As default, CloudStack create linked clone snapshot for VM instance . When we > take a snapshot for the VM, and create a template based on such snapshot, > CloudStack only download incremental VHD as template file, as a result, the > VM instance fail to deploy as it is incomplete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312547#comment-16312547 ] ASF GitHub Bot commented on CLOUDSTACK-9025: rhtyd commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355481939 @rafaelweingartner can you fix the conflicts? @DaanHoogland @mike-tutkowski @anshul1886 can you help review this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to deploy VM instance from template if template spin from linked clone > snapshot > -- > > Key: CLOUDSTACK-9025 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Affects Versions: 4.5.2 > Environment: XenServer 6.5 >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar >Priority: Critical > Fix For: 4.6.0 > > > As default, CloudStack create linked clone snapshot for VM instance . When we > take a snapshot for the VM, and create a template based on such snapshot, > CloudStack only download incremental VHD as template file, as a result, the > VM instance fail to deploy as it is incomplete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312545#comment-16312545 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-355481846 Tests LGTM, the failure is env related. One more code lgtm is needed to get this merged, additional review requested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312543#comment-16312543 ] ASF GitHub Bot commented on CLOUDSTACK-10109: - rhtyd commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355481666 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable dedication of public IPs to SSVM and CPVM > > > Key: CLOUDSTACK-10109 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > Attachments: public01.png, public02.png, public03.png > > > It is required to dedicate a public IP range for SSVM and CPVM in order to > apply firewall rules to control inbound access. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312544#comment-16312544 ] ASF GitHub Bot commented on CLOUDSTACK-10109: - blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355481694 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable dedication of public IPs to SSVM and CPVM > > > Key: CLOUDSTACK-10109 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > Attachments: public01.png, public02.png, public03.png > > > It is required to dedicate a public IP range for SSVM and CPVM in order to > apply firewall rules to control inbound access. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312542#comment-16312542 ] ASF GitHub Bot commented on CLOUDSTACK-9620: rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355481636 @mike-tutkowski can you resolve the conflicts, also see any outstanding issue @DaanHoogland @rafaelweingartner are you lgtm on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improvements for Managed Storage > > > Key: CLOUDSTACK-9620 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Management Server, VMware, XenServer >Affects Versions: 4.11.0.0 > Environment: KVM, vSphere, and XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski > Fix For: 4.11.0.0 > > > Allowed zone-wide primary storage based on a custom plug-in to be added via > the GUI in a KVM-only environment (previously this only worked for XenServer > and VMware) > Added support for root disks on managed storage with KVM > Added support for volume snapshots with managed storage on KVM > Enabled creating a template directly from a volume (i.e. without having to go > through a volume snapshot) on KVM with managed storage > Only allowed the resizing of a volume for managed storage on KVM if the > volume in question is either not attached to a VM or is attached to a VM in > the Stopped state > Included support for Reinstall VM on KVM with managed storage > Enabled offline migration on KVM from non-managed storage to managed storage > and vice versa > Included support for online storage migration on KVM with managed storage > (NFS and Ceph to managed storage) > Added support to download (extract) a managed-storage volume to a QCOW2 file > When uploading a file from outside of CloudStack to CloudStack, set the min > and max IOPS, if applicable. > Included support for the KVM auto-convergence feature > The compression flag was actually added in version 1.0.3 (103) as opposed > to version 1.3.0 (1003000) (changed this to reflect the correct version) > On KVM when using iSCSI-based managed storage, if the user shuts a VM down > from the guest OS (as opposed to doing so from CloudStack), we need to pass > to the KVM agent a list of applicable iSCSI volumes that need to be > disconnected. > Added a new Global Setting: kvm.storage.live.migration.wait > For XenServer, added a check to enforce that only volumes from zone-wide > managed storage can be storage motioned from a host in one cluster to a host > in another cluster (cannot do so at the time being with volumes from > cluster-scoped managed storage) > Don’t allow Storage XenMotion on a VM that has any managed-storage volume > with one or more snapshots. > Enabled for managed storage with VMware: Template caching, create snapshot, > delete snapshot, create volume from snapshot, and create template from > snapshot > Added an SIOC API plug-in to support VMware SIOC > When starting a VM that uses managed storage in a cluster other than the one > it last was running in, we need to remove the reference to the iSCSI volume > from the original cluster. > Added the ability to revert a volume to a snapshot > Enabled cluster-scoped managed storage > Added support for VMware dynamic discovery -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312538#comment-16312538 ] ASF GitHub Bot commented on CLOUDSTACK-9892: rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using … URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355481471 @blueorangutan test centos7 xenserver-65sp1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Primary storage resource check is broken when using root disk size override > to deploy VM > > > Key: CLOUDSTACK-9892 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 >Reporter: Koushik Das >Assignee: Koushik Das >Priority: Critical > Fix For: 4.11.0.0 > > > Primary storage resource check for account/domain is broken when using root > disk size override to deploy VM -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312540#comment-16312540 ] ASF GitHub Bot commented on CLOUDSTACK-9892: blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using … URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355481506 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Primary storage resource check is broken when using root disk size override > to deploy VM > > > Key: CLOUDSTACK-9892 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 >Reporter: Koushik Das >Assignee: Koushik Das >Priority: Critical > Fix For: 4.11.0.0 > > > Primary storage resource check for account/domain is broken when using root > disk size override to deploy VM -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9730) [VMware] Unable to add a host with space in its name to existing VMware cluster
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312531#comment-16312531 ] ASF GitHub Bot commented on CLOUDSTACK-9730: rhtyd commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#issuecomment-355481341 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [VMware] Unable to add a host with space in its name to existing VMware > cluster > --- > > Key: CLOUDSTACK-9730 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9730 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.1.0 > > > ISSUE > == > Unable to add a host with space in the name to existing VMware cluster. > While adding host, CloudStack tries to persist the validated inventory url > path in database, which inserts encoded url into database which means > whitespace would be stored as '+' symbols. Url from API parameter string is > being converted to URI object as part of validation, where the url path is > getting encoded. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312534#comment-16312534 ] ASF GitHub Bot commented on CLOUDSTACK-9606: rhtyd commented on issue #1775: CLOUDSTACK-9606: While IP address is released, tag are not deleted. URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355481364 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > While IP address is released, tag are not deleted > - > > Key: CLOUDSTACK-9606 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priyank Parihar >Assignee: Priyank Parihar > > IP address release API call (disassociateIpAddress) does not have any > mechanism to remove the tags. > All though the IP address is not allocated, corresponding tag still exists. > REPRO STEPS > == > 1. Acquire an IP address by Domain-Admin account A. > 2. Add tag to the target IP address by Domain-Admin account A. > 3. Release the target IP address without deleting the tag. > ⇒We found out that the state of the IP address is "Free" at this point, > but the tag which added by Domain-Admin account A still remains. > 4. Acquire the target IP address by Domain-Admin account B. > ⇒The tag still remains without change. > If account B tries to delete the tag, in our lab we can delete the tag as > domain admin. Although customer reported that they can't complete it because > of authority error. > EXPECTED BEHAVIOR > == > When we release an IP address, the corresponding tags should be removed from > related tables > ACTUAL BEHAVIOR > == > When we release an IP address, the corresponding tags are not removed from > related tables -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9730) [VMware] Unable to add a host with space in its name to existing VMware cluster
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312536#comment-16312536 ] ASF GitHub Bot commented on CLOUDSTACK-9730: blueorangutan commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#issuecomment-355481399 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [VMware] Unable to add a host with space in its name to existing VMware > cluster > --- > > Key: CLOUDSTACK-9730 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9730 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.1.0 > > > ISSUE > == > Unable to add a host with space in the name to existing VMware cluster. > While adding host, CloudStack tries to persist the validated inventory url > path in database, which inserts encoded url into database which means > whitespace would be stored as '+' symbols. Url from API parameter string is > being converted to URI object as part of validation, where the url path is > getting encoded. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312535#comment-16312535 ] ASF GitHub Bot commented on CLOUDSTACK-9606: blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is released, tag are not deleted. URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355481395 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > While IP address is released, tag are not deleted > - > > Key: CLOUDSTACK-9606 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priyank Parihar >Assignee: Priyank Parihar > > IP address release API call (disassociateIpAddress) does not have any > mechanism to remove the tags. > All though the IP address is not allocated, corresponding tag still exists. > REPRO STEPS > == > 1. Acquire an IP address by Domain-Admin account A. > 2. Add tag to the target IP address by Domain-Admin account A. > 3. Release the target IP address without deleting the tag. > ⇒We found out that the state of the IP address is "Free" at this point, > but the tag which added by Domain-Admin account A still remains. > 4. Acquire the target IP address by Domain-Admin account B. > ⇒The tag still remains without change. > If account B tries to delete the tag, in our lab we can delete the tag as > domain admin. Although customer reported that they can't complete it because > of authority error. > EXPECTED BEHAVIOR > == > When we release an IP address, the corresponding tags should be removed from > related tables > ACTUAL BEHAVIOR > == > When we release an IP address, the corresponding tags are not removed from > related tables -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312537#comment-16312537 ] ASF GitHub Bot commented on CLOUDSTACK-9889: blueorangutan commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355481402 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Dedicate guest vlan range to a domain > -- > > Key: CLOUDSTACK-9889 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: subhash yedugundla > > List of scenarios covered > *Dedication of guest Vlan range* > Admin should be allowed dedicate guest vlan ranges to a domain > While dedicating a guest Vlan range > If the range overlaps with any of the existing dedicated range then extend > the existing dedicated range > Otherwise add it as a new dedicated guest Vlan range > If the range doesn’t exist in the system then the request should fail > If any of the vlan in the range is in use by a network that belongs to a > different account of different domain then the request should fail > *Releasing guest Vlan range* > Admin should be allowed to release a dedicated guest vlan range that is > dedicated to a domain back to the system pool > If the range is not dedicated to the domain then the request should fail > Even If one/more of the Vlans belonging to the range is in use by a network > the range should be released back to the system pool > The vlans that are in use should continue to be in use by the network > *Network implementation* > If the network belongs to an account that has a dedicated range of Vlans then > a Vlan from the account's dedicated range should be allocated to the network > If an account uses up all of its dedicated Vlan’s the next network being > created for the account should be assigned a Vlan that belongs to the domain > pool > Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range > belonging to the zone > *Network creation* > If a Vlan id is specified and if this id belongs to a dedicated Vlan range of > a different account/domain then the creation should fail > If a Vlan id is specified and if this id belongs to the system pool but the > network owner has a range of dedicated range of vlans then the creation > should fail > *Domain deletion* > Guest Ip ranges and vlans dedicated to the domain should be released back to > the free pool > *Account deletion* > When an account is deleted, the IP ranges and vlans associated with the > account should be moved to system pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312530#comment-16312530 ] ASF GitHub Bot commented on CLOUDSTACK-9889: rhtyd commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355481292 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Dedicate guest vlan range to a domain > -- > > Key: CLOUDSTACK-9889 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: subhash yedugundla > > List of scenarios covered > *Dedication of guest Vlan range* > Admin should be allowed dedicate guest vlan ranges to a domain > While dedicating a guest Vlan range > If the range overlaps with any of the existing dedicated range then extend > the existing dedicated range > Otherwise add it as a new dedicated guest Vlan range > If the range doesn’t exist in the system then the request should fail > If any of the vlan in the range is in use by a network that belongs to a > different account of different domain then the request should fail > *Releasing guest Vlan range* > Admin should be allowed to release a dedicated guest vlan range that is > dedicated to a domain back to the system pool > If the range is not dedicated to the domain then the request should fail > Even If one/more of the Vlans belonging to the range is in use by a network > the range should be released back to the system pool > The vlans that are in use should continue to be in use by the network > *Network implementation* > If the network belongs to an account that has a dedicated range of Vlans then > a Vlan from the account's dedicated range should be allocated to the network > If an account uses up all of its dedicated Vlan’s the next network being > created for the account should be assigned a Vlan that belongs to the domain > pool > Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range > belonging to the zone > *Network creation* > If a Vlan id is specified and if this id belongs to a dedicated Vlan range of > a different account/domain then the creation should fail > If a Vlan id is specified and if this id belongs to the system pool but the > network owner has a range of dedicated range of vlans then the creation > should fail > *Domain deletion* > Guest Ip ranges and vlans dedicated to the domain should be released back to > the free pool > *Account deletion* > When an account is deleted, the IP ranges and vlans associated with the > account should be moved to system pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9755) download URL SSVM to be configurable
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312529#comment-16312529 ] Ernie Janse van Rensburg commented on CLOUDSTACK-9755: -- investigating > download URL SSVM to be configurable > > > Key: CLOUDSTACK-9755 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9755 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Reporter: René Moser >Assignee: Ernie Janse van Rensburg >Priority: Critical > Fix For: Future > > Attachments: Selection_020.jpg > > > similar to the configuration "consoleproxy.url.domain", allow a configuration > option for the SSVM download URLs (template/snapshot volume) > "secstorage.url.domain" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (CLOUDSTACK-9755) download URL SSVM to be configurable
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernie Janse van Rensburg reassigned CLOUDSTACK-9755: Assignee: Ernie Janse van Rensburg > download URL SSVM to be configurable > > > Key: CLOUDSTACK-9755 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9755 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Reporter: René Moser >Assignee: Ernie Janse van Rensburg >Priority: Critical > Fix For: Future > > Attachments: Selection_020.jpg > > > similar to the configuration "consoleproxy.url.domain", allow a configuration > option for the SSVM download URLs (template/snapshot volume) > "secstorage.url.domain" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9865) New OStype improperly mapped for XenServer 6.5
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312527#comment-16312527 ] ASF GitHub Bot commented on CLOUDSTACK-9865: rhtyd commented on issue #2050: CLOUDSTACK-9865: improper os types for xenserver 6.5 URL: https://github.com/apache/cloudstack/pull/2050#issuecomment-355480492 I've removed this from 4.11 milestone due to lack of engagement from the author @pdion891 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > New OStype improperly mapped for XenServer 6.5 > -- > > Key: CLOUDSTACK-9865 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9865 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Install and Setup, XenServer >Affects Versions: 4.10.0.0 >Reporter: Pierre-Luc Dion >Assignee: Pierre-Luc Dion > > New OS type defined in the upgrade path of 4.10 > - CoreOS > - Windows 2017 > - Windows 10 > - Centos 7.x > are not properly mapped for XenServer 6.5 so template with those OS types > fail to start. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312518#comment-16312518 ] ASF GitHub Bot commented on CLOUDSTACK-10065: - rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-355479023 Tests LGTM, they are environment related. Merging this based on code reviews and test results. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize SQL queries in listTemplate API to improve performance. > - > > Key: CLOUDSTACK-10065 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Pranali Mande > > *Description*: > The db queries could be optimized to get unique results from the database > which could help in reducing the listTemplate API response time. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312519#comment-16312519 ] ASF GitHub Bot commented on CLOUDSTACK-10065: - rhtyd closed pull request #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/framework/db/src/com/cloud/utils/db/GenericDao.java b/framework/db/src/com/cloud/utils/db/GenericDao.java index 121d65d6501..63047e7c699 100644 --- a/framework/db/src/com/cloud/utils/db/GenericDao.java +++ b/framework/db/src/com/cloud/utils/db/GenericDao.java @@ -276,4 +276,6 @@ PairsearchAndDistinctCount(final SearchCriteria sc, final Filter filter); Map
getAllAttributes(); + +Pair searchAndDistinctCount(final SearchCriteria sc, final Filter filter, final String[] distinctColumns); } diff --git a/framework/db/src/com/cloud/utils/db/GenericDaoBase.java b/framework/db/src/com/cloud/utils/db/GenericDaoBase.java index c5a4cd85dd8..304a122a0b7 100644 --- a/framework/db/src/com/cloud/utils/db/GenericDaoBase.java +++ b/framework/db/src/com/cloud/utils/db/GenericDaoBase.java @@ -44,7 +44,7 @@ import java.util.TimeZone; import java.util.UUID; import java.util.concurrent.ConcurrentHashMap; - +import com.google.common.base.Strings; import javax.naming.ConfigurationException; import javax.persistence.AttributeOverride; import javax.persistence.Column; @@ -1326,6 +1326,14 @@ protected void addJoins(StringBuilder str, Collection
(objects, count); } +@Override +@DB() +public Pair searchAndDistinctCount(final SearchCriteria sc, final Filter filter, final String[] distinctColumns) { +List objects = search(sc, filter, null, false); +Integer count = getDistinctCount(sc, distinctColumns); +return new Pair
(objects, count); +} + @Override @DB() public List search(final SearchCriteria sc, final Filter filter, final boolean enableQueryCache) { @@ -1927,6 +1935,52 @@ public Integer getDistinctCount(SearchCriteria sc) { } } +public Integer getDistinctCount(SearchCriteria sc, String[] distinctColumns) { +String clause = sc != null ? sc.getWhereClause() : null; +if (Strings.isNullOrEmpty(clause)) { +clause = null; +} + +final StringBuilder str = createDistinctSelect(sc, clause != null, distinctColumns); +if (clause != null) { +str.append(clause); +} + +Collection
> joins = null; +if (sc != null) { +joins = sc.getJoins(); +if (joins != null) { +addJoins(str, joins); +} +} + +final TransactionLegacy txn = TransactionLegacy.currentTxn(); +final String sql = "SELECT COUNT(*) FROM (" + str.toString() + ") AS tmp"; + +try (PreparedStatement pstmt = txn.prepareAutoCloseStatement(sql)) { +int i = 1; +if (clause != null) { +for (final Pair value : sc.getValues()) { +prepareAttribute(i++, pstmt, value.first(), value.second()); +} +} + +if (joins != null) { +i = addJoinAttributes(i, pstmt, joins); +} + +final ResultSet rs = pstmt.executeQuery(); +while (rs.next()) { +return rs.getInt(1); +} +return 0; +} catch (final SQLException e) { +throw new CloudRuntimeException("DB Exception in executing: " + sql, e); +} catch (final Throwable e) { +throw new CloudRuntimeException("Caught exception in : " + sql, e); +} +} + public Integer getCount(SearchCriteria sc) { String clause = sc != null ? sc.getWhereClause() : null; if (clause != null && clause.length() == 0) { @@ -2013,4 +2067,18 @@ protected StringBuilder createDistinctIdSelect(SearchCriteria sc, final boole Integer count = getCount(sc); return new Pair (objects, count); } + +@DB() +protected StringBuilder createDistinctSelect(SearchCriteria sc, final boolean whereClause, String[] distinctColumns) { +final SqlGenerator generator = new SqlGenerator(_entityBeanType); +String distinctSql = generator.buildDistinctSql(distinctColumns); + +StringBuilder sql = new StringBuilder(distinctSql); + +if (!whereClause) { +
[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312520#comment-16312520 ] ASF subversion and git services commented on CLOUDSTACK-10065: -- Commit 72539690882490d44c23bef5412e3bccd93df258 in cloudstack's branch refs/heads/master from [~pranalim] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=7253969 ] CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance (#2260) The db queries in listTemplateAPI could be optimized to get unique results from the database which could help in reducing the listTemplate API response time. > Optimize SQL queries in listTemplate API to improve performance. > - > > Key: CLOUDSTACK-10065 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Pranali Mande > > *Description*: > The db queries could be optimized to get unique results from the database > which could help in reducing the listTemplate API response time. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312517#comment-16312517 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - rhtyd commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355478850 @khos2ow can you address outstanding issues? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312513#comment-16312513 ] ASF GitHub Bot commented on CLOUDSTACK-10108: - rhtyd closed pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua… URL: https://github.com/apache/cloudstack/pull/2292 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/engine/orchestration/resources/META-INF/cloudstack/core/spring-engine-orchestration-core-context.xml b/engine/orchestration/resources/META-INF/cloudstack/core/spring-engine-orchestration-core-context.xml index df885b22573..3ded395bb66 100644 --- a/engine/orchestration/resources/META-INF/cloudstack/core/spring-engine-orchestration-core-context.xml +++ b/engine/orchestration/resources/META-INF/cloudstack/core/spring-engine-orchestration-core-context.xml @@ -59,6 +59,7 @@ + diff --git a/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java b/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java index 7815c76a54e..b7357756c4c 100644 --- a/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java +++ b/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java @@ -38,6 +38,7 @@ import javax.naming.ConfigurationException; import org.apache.cloudstack.ca.CAManager; +import com.cloud.configuration.ManagementServiceConfiguration; import org.apache.cloudstack.framework.config.ConfigKey; import org.apache.cloudstack.framework.config.Configurable; import org.apache.cloudstack.framework.config.dao.ConfigurationDao; @@ -180,13 +181,12 @@ @Inject ResourceManager _resourceMgr; +@Inject +ManagementServiceConfiguration mgmtServiceConf; + protected final ConfigKey Workers = new ConfigKey("Advanced", Integer.class, "workers", "5", "Number of worker threads handling remote agent connections.", false); protected final ConfigKey Port = new ConfigKey("Advanced", Integer.class, "port", "8250", "Port to listen on for remote agent connections.", false); -protected final ConfigKey PingInterval = new ConfigKey("Advanced", Integer.class, "ping.interval", "60", -"Interval to send application level pings to make sure the connection is still working", false); -protected final ConfigKey PingTimeout = new ConfigKey("Advanced", Float.class, "ping.timeout", "2.5", -"Multiplier to ping.interval before announcing an agent has timed out", true); protected final ConfigKey AlertWait = new ConfigKey("Advanced", Integer.class, "alert.wait", "1800", "Seconds to wait before alerting on a disconnected agent", true); protected final ConfigKey DirectAgentLoadSize = new ConfigKey("Advanced", Integer.class, "direct.agent.load.size", "16", @@ -206,14 +206,14 @@ @Override public boolean configure(final String name, final Mapparams) throws ConfigurationException { -s_logger.info("Ping Timeout is " + PingTimeout.value()); +s_logger.info("Ping Timeout is " + mgmtServiceConf.getPingTimeout()); final int threads = DirectAgentLoadSize.value(); _nodeId = ManagementServerNode.getManagementServerId(); s_logger.info("Configuring AgentManagerImpl. management server node id(msid): " + _nodeId); -final long lastPing = (System.currentTimeMillis() >> 10) - getTimeout(); +final long lastPing = (System.currentTimeMillis() >> 10) - mgmtServiceConf.getTimeout(); _hostDao.markHostsAsDisconnected(_nodeId, lastPing); registerForHostEvents(new BehindOnPingListener(), true, true, false); @@ -241,13 +241,6 @@ public boolean configure(final String name, final Map params) th return true; } -protected int getPingInterval() { -return PingInterval.value(); -} - -protected long getTimeout() { -return (long) (Math.ceil(PingTimeout.value() * PingInterval.value())); -} @Override public Task create(final Task.Type type, final Link link, final byte[] data) { @@ -623,7 +616,7 @@ public boolean start() { } } -_monitorExecutor.scheduleWithFixedDelay(new MonitorTask(), getPingInterval(), getPingInterval(), TimeUnit.SECONDS); +_monitorExecutor.scheduleWithFixedDelay(new MonitorTask(), mgmtServiceConf.getPingInterval(), mgmtServiceConf.getPingInterval(), TimeUnit.SECONDS); return true; } @@ -1192,7 +1185,7 @@ protected void connectAgent(final Link link, final Command[] cmds, final Request cmd = cmds[i];
[jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312514#comment-16312514 ] ASF subversion and git services commented on CLOUDSTACK-10108: -- Commit ebb7a5279d0bf5d538081e6ec34fa46d76d40b8f in cloudstack's branch refs/heads/master from mrunalinikankariya [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=ebb7a52 ] CLOUDSTACK-10108: ConfigKey based approach for reading 'ping' configuaration (#2292) In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using configdao which involves direct reading of DB. So, replaced it with ConfigKey based approach. > ConfigKey based approach for reading 'ping' configuaration for Management > Server > > > Key: CLOUDSTACK-10108 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: mrunalini >Priority: Minor > > In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using > configdao which involves direct reading of DB. So, replace it with ConfigKey > based approach -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312511#comment-16312511 ] ASF GitHub Bot commented on CLOUDSTACK-10108: - rhtyd commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua… URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355478630 Tests LGTM, the failure was env/intermittent issue. Merging this based on code reviews and test results. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ConfigKey based approach for reading 'ping' configuaration for Management > Server > > > Key: CLOUDSTACK-10108 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: mrunalini >Priority: Minor > > In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using > configdao which involves direct reading of DB. So, replace it with ConfigKey > based approach -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312512#comment-16312512 ] ASF GitHub Bot commented on CLOUDSTACK-10096: - blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch… URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355478637 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't reset api.integration.port and usage.sanity.check.interval back to null > - > > Key: CLOUDSTACK-10096 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > > Fix for CLOUDSTACK-7931 enforces a value to be configured for > api.integration.port and usage.sanity.check.interval. These global configs > can't be reset back to null(default). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9886) After restarting cloudstack-management , It takes time to connect hosts
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312515#comment-16312515 ] ASF subversion and git services commented on CLOUDSTACK-9886: - Commit ebb7a5279d0bf5d538081e6ec34fa46d76d40b8f in cloudstack's branch refs/heads/master from mrunalinikankariya [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=ebb7a52 ] CLOUDSTACK-10108: ConfigKey based approach for reading 'ping' configuaration (#2292) In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using configdao which involves direct reading of DB. So, replaced it with ConfigKey based approach. > After restarting cloudstack-management , It takes time to connect hosts > --- > > Key: CLOUDSTACK-9886 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9886 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: mrunalini > > More the value of 'ping.interval' and 'ping.timeout' , more the time taken > for host reconnection after management server restart. > Solution : There is a timer task which connect to host based on values from > ping timeout and ping interval. > (System.currentTimeMillis() >> 10) - (ping.timeout * ping.interval) > So if this values are large, host will not be connected immediately after > restart. > After management server restart, host should be connected irrespective of > ping intervals. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates
[ https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312509#comment-16312509 ] ASF GitHub Bot commented on CLOUDSTACK-4757: rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355478470 @nvazquez please check/fix the volume related errors. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support OVA files with multiple disks for templates > --- > > Key: CLOUDSTACK-4757 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Reporter: Likitha Shetty >Assignee: Nicolas Vazquez >Priority: Minor > Fix For: Future > > > CloudStack volumes and templates are one single virtual disk in case of > XenServer/XCP and KVM hypervisors since the files used for templates and > volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates > are in OVA format, which are archives that can contain a complete VM > including multiple VMDKs and other files such as ISOs. And currently, > Cloudstack only supports Template creation based on OVA files containing a > single disk. If a user creates a template from a OVA file containing more > than 1 disk and launches an instance using this template, only the first disk > is attached to the new instance and other disks are ignored. > Similarly with uploaded volumes, attaching an uploaded volume that contains > multiple disks to a VM will result in only one VMDK to being attached to the > VM. > This behavior needs to be improved in VMWare to support OVA files with > multiple disks for both uploaded volumes and templates. i.e. If a user > creates a template from a OVA file containing more than 1 disk and launches > an instance using this template, the first disk should be attached to the new > instance as the ROOT disk and volumes should be created based on other VMDK > disks in the OVA file and should be attached to the instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312510#comment-16312510 ] ASF GitHub Bot commented on CLOUDSTACK-10096: - rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch… URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355478528 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't reset api.integration.port and usage.sanity.check.interval back to null > - > > Key: CLOUDSTACK-10096 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > > Fix for CLOUDSTACK-7931 enforces a value to be configured for > api.integration.port and usage.sanity.check.interval. These global configs > can't be reset back to null(default). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312507#comment-16312507 ] ASF subversion and git services commented on CLOUDSTACK-9572: - Commit 8eca04e1f6bbe5410dfd657588a67b2b2f71a411 in cloudstack's branch refs/heads/master from [~yvsubhash] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8eca04e ] CLOUDSTACK-9572: Snapshot on primary storage not cleaned up after Storage migration (#1740) Snapshot on primary storage not cleaned up after Storage migration. This happens in the following scenario: Steps To Reproduce Create an instance on the local storage on any host Create a scheduled snapshot of the volume: Wait until ACS created the snapshot. ACS is creating a snapshot on local storage and is transferring this snapshot to secondary storage. But the latest snapshot on local storage will stay there. This is as expected. Migrate the instance to another XenServer host with ACS UI and Storage Live Migration The Snapshot on the old host on local storage will not be cleaned up and is staying on local storage. So local storage will fill up with unneeded snapshots. > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312504#comment-16312504 ] ASF GitHub Bot commented on CLOUDSTACK-9572: rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-355478202 Merging this based on test results and code reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9908) Primary Storage allocated capacity goes very high after VM snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312502#comment-16312502 ] ASF GitHub Bot commented on CLOUDSTACK-9908: rhtyd closed pull request #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java index 00298cedc75..103765b9e11 100644 --- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java +++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java @@ -1306,11 +1306,12 @@ private void setVolumeToPathAndSize(List volumeTOs, MapPrimary Storage allocated capacity goes very high after VM snapshot > --- > > Key: CLOUDSTACK-9908 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9908 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.9.0 >Reporter: jay > Fix For: 4.10.1.0 > > > Take a VM snapshot, the primary storage allocated capacity goes very high > causing the other deployments to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9908) Primary Storage allocated capacity goes very high after VM snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312503#comment-16312503 ] ASF subversion and git services commented on CLOUDSTACK-9908: - Commit 053b12c813f72f2bce3934f7ac757c752d5e2666 in cloudstack's branch refs/heads/master from [~jay_accelerite] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=053b12c ] CLOUDSTACK-9908: Primary Storage allocated capacity goes very high after VM snapshot (#2104) Added '-' chracter while reading Filenames so that filename match exactly with VM name. > Primary Storage allocated capacity goes very high after VM snapshot > --- > > Key: CLOUDSTACK-9908 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9908 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.9.0 >Reporter: jay > Fix For: 4.10.1.0 > > > Take a VM snapshot, the primary storage allocated capacity goes very high > causing the other deployments to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312506#comment-16312506 ] ASF GitHub Bot commented on CLOUDSTACK-9572: rhtyd closed pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotDataFactory.java b/engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotDataFactory.java index 59e59a60662..6bbeb85d5f9 100644 --- a/engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotDataFactory.java +++ b/engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotDataFactory.java @@ -29,6 +29,8 @@ SnapshotInfo getSnapshot(long snapshotId, DataStoreRole role); +List getSnapshots(long volumeId, DataStoreRole store); + List listSnapshotOnCache(long snapshotId); SnapshotInfo getReadySnapshotOnCache(long snapshotId); diff --git a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotDataFactoryImpl.java b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotDataFactoryImpl.java index 5dd63e38976..ad58f42a97a 100644 --- a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotDataFactoryImpl.java +++ b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotDataFactoryImpl.java @@ -64,6 +64,24 @@ public SnapshotInfo getSnapshot(DataObject obj, DataStore store) { return so; } +@Override +public List getSnapshots(long volumeId, DataStoreRole role) { + +SnapshotDataStoreVO snapshotStore = snapshotStoreDao.findByVolume(volumeId, role); +if (snapshotStore == null) { +return new ArrayList<>(); +} +DataStore store = storeMgr.getDataStore(snapshotStore.getDataStoreId(), role); +List volSnapShots = snapshotDao.listByVolumeId(volumeId); +List infos = new ArrayList<>(); +for(SnapshotVO snapshot: volSnapShots) { +SnapshotObject info = SnapshotObject.getSnapshotObject(snapshot, store); +infos.add(info); +} +return infos; +} + + @Override public SnapshotInfo getSnapshot(long snapshotId, DataStoreRole role) { SnapshotVO snapshot = snapshotDao.findById(snapshotId); diff --git a/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java index 8818724e722..ad0418f5c9d 100644 --- a/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java +++ b/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java @@ -1543,6 +1543,7 @@ protected Void migrateVolumeCallBack(AsyncCallbackDispatcherentry : volumeToPool.entrySet()) { VolumeInfo volume = entry.getKey(); +snapshotMgr.cleanupSnapshotsByVolume(volume.getId()); volume.processEvent(Event.OperationSuccessed); } future.complete(res); diff --git a/server/src/com/cloud/storage/snapshot/SnapshotManager.java b/server/src/com/cloud/storage/snapshot/SnapshotManager.java index c27c6992dcb..f3557d0a670 100644 --- a/server/src/com/cloud/storage/snapshot/SnapshotManager.java +++ b/server/src/com/cloud/storage/snapshot/SnapshotManager.java @@ -74,6 +74,8 @@ boolean canOperateOnVolume(Volume volume); +void cleanupSnapshotsByVolume(Long volumeId); + Answer sendToPool(Volume vol, Command cmd); SnapshotVO getParentSnapshot(VolumeInfo volume); diff --git a/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java b/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java index f074c332e3c..94726bea445 100755 --- a/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java +++ b/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java @@ -1331,6 +1331,21 @@ public boolean canOperateOnVolume(Volume volume) {
[jira] [Commented] (CLOUDSTACK-9908) Primary Storage allocated capacity goes very high after VM snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312501#comment-16312501 ] ASF GitHub Bot commented on CLOUDSTACK-9908: rhtyd commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-355478141 Test LGTM. Merging this based on test results and 2 code review lgtms. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Primary Storage allocated capacity goes very high after VM snapshot > --- > > Key: CLOUDSTACK-9908 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9908 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.9.0 >Reporter: jay > Fix For: 4.10.1.0 > > > Take a VM snapshot, the primary storage allocated capacity goes very high > causing the other deployments to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312481#comment-16312481 ] ASF GitHub Bot commented on CLOUDSTACK-10108: - mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua… URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355473885 Test failure are due to unable to ssh and is not related to the change and can be ignored This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ConfigKey based approach for reading 'ping' configuaration for Management > Server > > > Key: CLOUDSTACK-10108 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: mrunalini >Priority: Minor > > In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using > configdao which involves direct reading of DB. So, replace it with ConfigKey > based approach -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312480#comment-16312480 ] ASF GitHub Bot commented on CLOUDSTACK-10108: - mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua… URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355473885 Test failure are due tounable to ssh and is not related to the change and can be ignored This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ConfigKey based approach for reading 'ping' configuaration for Management > Server > > > Key: CLOUDSTACK-10108 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: mrunalini >Priority: Minor > > In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using > configdao which involves direct reading of DB. So, replace it with ConfigKey > based approach -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312455#comment-16312455 ] ASF GitHub Bot commented on CLOUDSTACK-10117: - blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355467907 Trillian test result (tid-2014) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34026 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2381-t2014-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestDeployVirtioSCSIVM>:teardown | `Error` | 38.78 | test_deploy_virtio_scsi_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > LDAP mapping on domain level > > > Key: CLOUDSTACK-10117 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Daan Hoogland > > see FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312440#comment-16312440 ] ASF GitHub Bot commented on CLOUDSTACK-10096: - SudharmaJain commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch… URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355466172 Test failures are not related to my changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't reset api.integration.port and usage.sanity.check.interval back to null > - > > Key: CLOUDSTACK-10096 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > > Fix for CLOUDSTACK-7931 enforces a value to be configured for > api.integration.port and usage.sanity.check.interval. These global configs > can't be reset back to null(default). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312228#comment-16312228 ] ASF GitHub Bot commented on CLOUDSTACK-10096: - blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch… URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355433705 Trillian test result (tid-2013) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50598 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2274-t2013-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 61 look OK, 6 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_deploy_vm_from_iso | `Error` | 1522.60 | test_deploy_vm_iso.py test_01_1_create_iso_with_checksum_sha1_negative | `Error` | 70.99 | test_iso.py test_01_create_iso_with_checksum_sha1 | `Error` | 65.69 | test_iso.py test_01_create_iso_with_checksum_sha1 | `Error` | 70.81 | test_iso.py test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 70.82 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 65.78 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 70.97 | test_iso.py test_03_1_create_iso_with_checksum_md5_negative | `Error` | 71.24 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 66.04 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 71.20 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 65.85 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 70.96 | test_iso.py test_01_create_iso | `Failure` | 1527.07 | test_iso.py ContextSuite context=TestISO>:setup | `Error` | 3053.09 | test_iso.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 218.73 | test_privategw_acl.py test_07_resize_fail | `Failure` | 15.43 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 368.05 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Failure` | 127.46 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 511.25 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 122.48 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 163.34 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't reset api.integration.port and usage.sanity.check.interval back to null > - > > Key: CLOUDSTACK-10096 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > > Fix for CLOUDSTACK-7931 enforces a value to be configured for > api.integration.port and usage.sanity.check.interval. These global configs > can't be reset back to null(default). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10126) Separate Subnet for CPVM and SSVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312143#comment-16312143 ] ASF GitHub Bot commented on CLOUDSTACK-10126: - blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-355420807 Trillian test result (tid-2010) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48858 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2368-t2010-xenserver-65sp1.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 65 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_edit_template | `Failure` | 90.06 | test_templates.py test_07_resize_fail | `Failure` | 50.49 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Separate Subnet for CPVM and SSVM > - > > Key: CLOUDSTACK-10126 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > > Separate Management Subnet for CPVM and SSVM -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9743) ODL plugin responds to deleteHost causing other plugin in the chain to be ignored
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312087#comment-16312087 ] ASF GitHub Bot commented on CLOUDSTACK-9743: blueorangutan commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored URL: https://github.com/apache/cloudstack/pull/1906#issuecomment-355409605 Trillian test result (tid-2012) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43681 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1906-t2012-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_accounts.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 60 look OK, 7 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py test_DeleteDomain | `Error` | 1.04 | test_accounts.py test_forceDeleteDomain | `Error` | 1.50 | test_accounts.py ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 7.18 | test_accounts.py ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_deploy_vm_from_iso | `Error` | 1516.56 | test_deploy_vm_iso.py test_01_1_create_iso_with_checksum_sha1_negative | `Error` | 70.65 | test_iso.py test_01_create_iso_with_checksum_sha1 | `Error` | 65.42 | test_iso.py test_01_create_iso_with_checksum_sha1 | `Error` | 70.51 | test_iso.py test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 70.49 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 65.40 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 70.48 | test_iso.py test_03_1_create_iso_with_checksum_md5_negative | `Error` | 70.50 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 65.49 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 70.59 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 65.46 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 70.55 | test_iso.py test_01_create_iso | `Failure` | 1514.16 | test_iso.py ContextSuite context=TestISO>:setup | `Error` | 3037.45 | test_iso.py test_05_rvpc_multi_tiers | `Failure` | 341.17 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 381.85 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ODL plugin responds to deleteHost causing other plugin in the chain to be > ignored > - > > Key: CLOUDSTACK-9743 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9743 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent, Network Controller >Reporter: Syed Ahmed > > ODL plugin responds to deleteHost causing other plugin in the chain to be > ignored -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312050#comment-16312050 ] ASF GitHub Bot commented on CLOUDSTACK-9892: blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using … URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355401738 Trillian test result (tid-2007) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44666 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2088-t2007-vmware-55u3.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Smoke tests completed. 65 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_00_deploy_vm_root_resize | `Error` | 0.04 | test_deploy_vm_root_resize.py test_02_deploy_vm_root_resize | `Failure` | 0.00 | test_deploy_vm_root_resize.py test_08_migrate_vm | `Error` | 55.94 | test_vm_life_cycle.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Primary storage resource check is broken when using root disk size override > to deploy VM > > > Key: CLOUDSTACK-9892 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 >Reporter: Koushik Das >Assignee: Koushik Das >Priority: Critical > Fix For: 4.11.0.0 > > > Primary storage resource check for account/domain is broken when using root > disk size override to deploy VM -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312022#comment-16312022 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - blueorangutan commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355396495 Trillian test result (tid-2003) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44235 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2365-t2003-xenserver-65sp1.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 65 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_edit_template | `Failure` | 90.15 | test_templates.py test_07_resize_fail | `Failure` | 61.21 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates
[ https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311986#comment-16311986 ] ASF GitHub Bot commented on CLOUDSTACK-4757: blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355391105 Trillian test result (tid-2002) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48665 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t2002-vmware-55u3.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 63 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_3d_gpu_support | `Failure` | 333.10 | test_deploy_vgpu_enabled_vm.py test_00_deploy_vm_root_resize | `Error` | 0.09 | test_deploy_vm_root_resize.py test_08_migrate_vm | `Error` | 55.67 | test_vm_life_cycle.py test_01_create_volume | `Failure` | 197.30 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support OVA files with multiple disks for templates > --- > > Key: CLOUDSTACK-4757 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Reporter: Likitha Shetty >Assignee: Nicolas Vazquez >Priority: Minor > Fix For: Future > > > CloudStack volumes and templates are one single virtual disk in case of > XenServer/XCP and KVM hypervisors since the files used for templates and > volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates > are in OVA format, which are archives that can contain a complete VM > including multiple VMDKs and other files such as ISOs. And currently, > Cloudstack only supports Template creation based on OVA files containing a > single disk. If a user creates a template from a OVA file containing more > than 1 disk and launches an instance using this template, only the first disk > is attached to the new instance and other disks are ignored. > Similarly with uploaded volumes, attaching an uploaded volume that contains > multiple disks to a VM will result in only one VMDK to being attached to the > VM. > This behavior needs to be improved in VMWare to support OVA files with > multiple disks for both uploaded volumes and templates. i.e. If a user > creates a template from a OVA file containing more than 1 disk and launches > an instance using this template, the first disk should be attached to the new > instance as the ROOT disk and volumes should be created based on other VMDK > disks in the OVA file and should be attached to the instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9906) Create snapshot after volume resize for the volume with existing snapshot(s)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311927#comment-16311927 ] ASF GitHub Bot commented on CLOUDSTACK-9906: blueorangutan commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s) URL: https://github.com/apache/cloudstack/pull/2079#issuecomment-355379809 Trillian test result (tid-2008) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38682 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2079-t2008-xenserver-65sp1.zip Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 65 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_edit_template | `Failure` | 90.14 | test_templates.py test_07_resize_fail | `Failure` | 45.67 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create snapshot after volume resize for the volume with existing snapshot(s) > > > Key: CLOUDSTACK-9906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9906 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot, Volumes > Environment: XenServer >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > > Snapshot of a volume fails if the volume has an existing snapshot(s) taken > before resizing of the volume. This behavior needs to be improved so that > taking snapshot would be successful when there is an existing snapshot(s) > before volume resizing. > REPRO STEPS > = > - Create a volume with 10 GB and attach to any VM. > - Take snapshot of the volume. > - Change volume size from 10GB to 15 GB. > - Take snapshot of the volume after resizing it. > - Create a volume from the snapshot taken after resizing volume. > - Attach the volume (created above) to any VM and check the size. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311899#comment-16311899 ] ASF GitHub Bot commented on CLOUDSTACK-10108: - blueorangutan commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua… URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355375194 Trillian test result (tid-2011) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36636 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2292-t2011-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 367.05 | test_internal_lb.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ConfigKey based approach for reading 'ping' configuaration for Management > Server > > > Key: CLOUDSTACK-10108 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: mrunalini >Priority: Minor > > In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using > configdao which involves direct reading of DB. So, replace it with ConfigKey > based approach -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311887#comment-16311887 ] ASF GitHub Bot commented on CLOUDSTACK-9620: mike-tutkowski commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159733930 ## File path: server/src/com/cloud/configuration/Config.java ## @@ -191,6 +191,22 @@ "10800", "In second, timeout for download template to primary storage", null), +KvmStorageOfflineMigrationWait( Review comment: Sounds good, @DaanHoogland. I can migrate to the ConfigKey approach for that key. I'll handle that and refactor the copyAsync method. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improvements for Managed Storage > > > Key: CLOUDSTACK-9620 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Management Server, VMware, XenServer >Affects Versions: 4.11.0.0 > Environment: KVM, vSphere, and XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski > Fix For: 4.11.0.0 > > > Allowed zone-wide primary storage based on a custom plug-in to be added via > the GUI in a KVM-only environment (previously this only worked for XenServer > and VMware) > Added support for root disks on managed storage with KVM > Added support for volume snapshots with managed storage on KVM > Enabled creating a template directly from a volume (i.e. without having to go > through a volume snapshot) on KVM with managed storage > Only allowed the resizing of a volume for managed storage on KVM if the > volume in question is either not attached to a VM or is attached to a VM in > the Stopped state > Included support for Reinstall VM on KVM with managed storage > Enabled offline migration on KVM from non-managed storage to managed storage > and vice versa > Included support for online storage migration on KVM with managed storage > (NFS and Ceph to managed storage) > Added support to download (extract) a managed-storage volume to a QCOW2 file > When uploading a file from outside of CloudStack to CloudStack, set the min > and max IOPS, if applicable. > Included support for the KVM auto-convergence feature > The compression flag was actually added in version 1.0.3 (103) as opposed > to version 1.3.0 (1003000) (changed this to reflect the correct version) > On KVM when using iSCSI-based managed storage, if the user shuts a VM down > from the guest OS (as opposed to doing so from CloudStack), we need to pass > to the KVM agent a list of applicable iSCSI volumes that need to be > disconnected. > Added a new Global Setting: kvm.storage.live.migration.wait > For XenServer, added a check to enforce that only volumes from zone-wide > managed storage can be storage motioned from a host in one cluster to a host > in another cluster (cannot do so at the time being with volumes from > cluster-scoped managed storage) > Don’t allow Storage XenMotion on a VM that has any managed-storage volume > with one or more snapshots. > Enabled for managed storage with VMware: Template caching, create snapshot, > delete snapshot, create volume from snapshot, and create template from > snapshot > Added an SIOC API plug-in to support VMware SIOC > When starting a VM that uses managed storage in a cluster other than the one > it last was running in, we need to remove the reference to the iSCSI volume > from the original cluster. > Added the ability to revert a volume to a snapshot > Enabled cluster-scoped managed storage > Added support for VMware dynamic discovery -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9896) ListDedicatedXXX doesn't respect pagination
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311837#comment-16311837 ] ASF GitHub Bot commented on CLOUDSTACK-9896: blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-355364356 Trillian test result (tid-2009) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34717 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2073-t2009-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 258.22 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 346.76 | test_internal_lb.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ListDedicatedXXX doesn't respect pagination > --- > > Key: CLOUDSTACK-9896 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9896 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Minor > > The listDedicatedZones, listDedicatedPods, listDedicatedClusters, > listDedicatedHosts are not using the pagination filter to return the results. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311828#comment-16311828 ] ASF GitHub Bot commented on CLOUDSTACK-10117: - DaanHoogland commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355362165 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > LDAP mapping on domain level > > > Key: CLOUDSTACK-10117 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Daan Hoogland > > see FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311829#comment-16311829 ] ASF GitHub Bot commented on CLOUDSTACK-10117: - blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355362209 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > LDAP mapping on domain level > > > Key: CLOUDSTACK-10117 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Daan Hoogland > > see FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311798#comment-16311798 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159720475 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ## @@ -2630,6 +2631,22 @@ public VDI getIsoVDIByURL(final Connection conn, final String vmName, final Stri } } +private String actualIsoTemplate(final Connection conn) throws BadServerResponse, XenAPIException, XmlRpcException { Review comment: We do not need a real host. We only want to test the logic. Therefore, you can mock the method calls. PowerMockito and Mockito are there for this kind of job. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311787#comment-16311787 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159719752 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ## @@ -2630,6 +2631,22 @@ public VDI getIsoVDIByURL(final Connection conn, final String vmName, final Stri } } +private String actualIsoTemplate(final Connection conn) throws BadServerResponse, XenAPIException, XmlRpcException { Review comment: I will add the documentation, but I really don't think unit testing on this specific method will be possible. Because it needs a live XenServer Host for the method to connect to (both `Host.getByUuid(conn, _host.getUuid());` and `host.getRecord(conn);`) and I'm not sure if they can be Mocked in some way. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311785#comment-16311785 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159719752 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ## @@ -2630,6 +2631,22 @@ public VDI getIsoVDIByURL(final Connection conn, final String vmName, final Stri } } +private String actualIsoTemplate(final Connection conn) throws BadServerResponse, XenAPIException, XmlRpcException { Review comment: I will the documentation, but I really don't think unit testing on this specific method will be possible. Because it needs a live XenServer Host for the method to connect to (both `Host.getByUuid(conn, _host.getUuid());` and `host.getRecord(conn);`) and I'm not sure if they can be Mocked in some way. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311699#comment-16311699 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159707924 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java ## @@ -536,7 +536,7 @@ private void createXsToolsISO() { id = _tmpltDao.getNextInSequence(Long.class, "id"); VMTemplateVO template = VMTemplateVO.createPreHostIso(id, isoName, isoName, ImageFormat.ISO, true, true, TemplateType.PERHOST, null, null, true, 64, Account.ACCOUNT_ID_SYSTEM, -null, "xen-pv-drv-iso", false, 1, false, HypervisorType.XenServer); +null, "XenServer Tools Installer ISO (xen-pv-drv-iso)", false, 1, false, HypervisorType.XenServer); Review comment: I think this is the right thing to do, so we get consistency. You have to save the `tmplt` as well right? So, you update the data in the database This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311697#comment-16311697 ] ASF GitHub Bot commented on CLOUDSTACK-9572: blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-355343182 Trillian test result (tid-1995) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42502 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1740-t1995-xenserver-65sp1.zip Smoke tests completed. 67 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311695#comment-16311695 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159707625 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ## @@ -2592,9 +2592,10 @@ public VDI getIsoVDIByURL(final Connection conn, final String vmName, final Stri String mountpoint = null; if (isoURL.startsWith("xs-tools")) { Review comment: Yes it did. I had an idea to change the iso name (url here refers to _name_) to something general - like `xenserver-tools` and manage the same thing in `actualIsoTemplate`, but _xs-tools.iso_ is used in some many places (specially in some test cases) which I ended up not changing this. Potentially it only needs a wiki/user guide doc only. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311692#comment-16311692 ] ASF GitHub Bot commented on CLOUDSTACK-10197: - khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159707056 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java ## @@ -536,7 +536,7 @@ private void createXsToolsISO() { id = _tmpltDao.getNextInSequence(Long.class, "id"); VMTemplateVO template = VMTemplateVO.createPreHostIso(id, isoName, isoName, ImageFormat.ISO, true, true, TemplateType.PERHOST, null, null, true, 64, Account.ACCOUNT_ID_SYSTEM, -null, "xen-pv-drv-iso", false, 1, false, HypervisorType.XenServer); +null, "XenServer Tools Installer ISO (xen-pv-drv-iso)", false, 1, false, HypervisorType.XenServer); Review comment: That is correct, I can explicitly add `tmplt.setDisplayText("XenServer Tools Installer ISO (xen-pv-drv-iso)");` at line 544 (couple lines down here) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ >Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311599#comment-16311599 ] ASF GitHub Bot commented on CLOUDSTACK-10117: - blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355329971 Trillian test result (tid-1996) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39325 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2381-t1996-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 65 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_oobm_issue_power_soft | `Error` | 22.50 | test_outofbandmanagement.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.96 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > LDAP mapping on domain level > > > Key: CLOUDSTACK-10117 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Daan Hoogland > > see FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9908) Primary Storage allocated capacity goes very high after VM snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311563#comment-16311563 ] ASF GitHub Bot commented on CLOUDSTACK-9908: blueorangutan commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-355322603 Trillian test result (tid-1998) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36781 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2104-t1998-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 67 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Primary Storage allocated capacity goes very high after VM snapshot > --- > > Key: CLOUDSTACK-9908 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9908 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.9.0 >Reporter: jay > Fix For: 4.10.1.0 > > > Take a VM snapshot, the primary storage allocated capacity goes very high > causing the other deployments to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-8855) Improve Error Message for Host Alert State
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311533#comment-16311533 ] ASF GitHub Bot commented on CLOUDSTACK-8855: rafaelweingartner commented on a change in pull request #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2380#discussion_r159683766 ## File path: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ## @@ -994,33 +980,29 @@ public Answer easySend(final Long hostId, final Command cmd) { } @Override -public boolean reconnect(final long hostId) { -HostVO host; +public void reconnect(final long hostId) throws AgentUnavailableException { +HostVO host = _hostDao.findById(hostId); +if (host == null) { +throw new CloudRuntimeException("Unable to find host: " + hostId); +} -host = _hostDao.findById(hostId); -if (host == null || host.getRemoved() != null) { -s_logger.warn("Unable to find host " + hostId); -return false; +if (host.getRemoved() != null) { +throw new CloudRuntimeException("Host has already been removed: " + hostId); } if (host.getStatus() == Status.Disconnected) { -s_logger.info("Host is already disconnected, no work to be done"); -return true; +s_logger.debug("Host is already disconnected, no work to be done: " + hostId); Review comment: @DaanHoogland I made a mistake here. Can you fix it for me? You need to add a `return;`, right after line 994 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve Error Message for Host Alert State > -- > > Key: CLOUDSTACK-8855 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.6.0 >Reporter: Bharat Kumar >Assignee: Bharat Kumar > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-8855) Improve Error Message for Host Alert State
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311500#comment-16311500 ] ASF GitHub Bot commented on CLOUDSTACK-8855: rafaelweingartner commented on issue #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2380#issuecomment-355311377 @marcaurele thanks for your feedback here. I already created a PR to Daan's branch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve Error Message for Host Alert State > -- > > Key: CLOUDSTACK-8855 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.6.0 >Reporter: Bharat Kumar >Assignee: Bharat Kumar > -- This message was sent by Atlassian JIRA (v6.4.14#64029)