[jira] [Created] (CLOUDSTACK-10235) Removing Port Forwarding rule deletes public interface on VR (redundant VPC only)
Alexander Conn created CLOUDSTACK-10235: --- Summary: Removing Port Forwarding rule deletes public interface on VR (redundant VPC only) Key: CLOUDSTACK-10235 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10235 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: VPC Affects Versions: 4.9.3.0 Environment: XenServer 6.2 Reporter: Alexander Conn Steps I've taken to reproduce in my environment on a redundant VPC (no issue on normal VPC): # Acquire public IP and create a port forwarding rule on it # Remove that port forwarding rule # You'll see on the MASTER VR, the public interface (eth1) gets removed incorrectly. Causing all sorts of issues, including issues with VRRP. # Add a port forwarding rule back, and eth1 gets recreated. But now your stuck with needing at least 1 PF rule to be there in order to keep eth1 connected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9885) VPC RVR: On deleting first tier and configuring Private GW both VRs becoming MASTER
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328347#comment-16328347 ] Alexander Conn commented on CLOUDSTACK-9885: As I needed a fix for this sooner rather than later, I modified the required python scripts on VR myself. Fortunately the private gateways we use are all part of the same subnet so this was fixed as per below. My added code in *bold* +File: /opt/cloud/bin/cs/CsRedundant.py+ def _redundant_on(self): guest = self.address.get_guest_if() # No redundancy if there is no guest network if guest is None: self.set_backup() self._redundant_off() return interfaces = [interface for interface in self.address.get_interfaces() if interface.is_guest()] isDeviceReady = False dev = '' for interface in interfaces: if dev == interface.get_device(): continue *int_ip = interface.get_ip()* *if int_ip.startswith('10.200.200.'):* *continue* dev = interface.get_device() logging.info("Wait for devices to be configured so we can start keepalived") devConfigured = CsDevice(dev, self.config).waitfordevice() if devConfigured: command = "ip link show %s | grep 'state UP'" % dev devUp = CsHelper.execute(command) if devUp: logging.info("Device %s is present, let's start keepalive now." % dev) isDeviceReady = True +File: /opt/cloud/bin/cs/CsAddress.py+ def get_guest_if(self): """ Return CsInterface object for the lowest in use guest interface """ guest_interface = None lowest_device = 1000 for interface in self.get_interfaces(): *int_ip = interface.get_ip()* *if int_ip.startswith('10.200.200.'):* *continue* if interface.is_guest() and interface.is_added(): device = interface.get_device() device_suffix = int(''.join([digit for digit in device if digit.isdigit()])) if device_suffix < lowest_device: lowest_device = device_suffix guest_interface = interface logging.debug("Guest interface will be set on device '%s' and IP '%s'" % (guest_interface.get_device(), guest_interface.get_ip())) return guest_interface Also add this code to all instances of the needs_vrrp function in CsAddress.py, example below: def needs_vrrp(self, o): """ Returns if the ip needs to be managed by keepalived or not """ *int_ip = self.get_ip()* *if int_ip.startswith('10.200.200.'):* *return False* if "nw_type" in o and o['nw_type'] in VRRP_TYPES: return True return False Hopefully this helps you guys with your bug fix and anyone else experiencing this issue. > VPC RVR: On deleting first tier and configuring Private GW both VRs becoming > MASTER > > > Key: CLOUDSTACK-9885 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9885 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0 >Reporter: Jayapal Reddy >Assignee: Jayapal Reddy >Priority: Critical > Fix For: 4.10.1.0 > > > - Configure two tier networks t1 and t2. Delete the t1 network. Both VRs are > getting into MASTER state. > r-269-QA - was BACKUP VR. On deleting t1 network it became MASTER. > {noformat} > root@r-269-QA:~# ip a > 1: lo:mtu 16436 qdisc noqueue state UNKNOWN > link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 > inet 127.0.0.1/8 scope host lo > 2: eth0: mtu 1500 qdisc pfifo_fast state UP > qlen 1000 > link/ether 0e:00:a9:fe:01:dc brd ff:ff:ff:ff:ff:ff > inet 169.254.1.220/16 brd 169.254.255.255 scope global eth0 > 3: eth1: mtu 1500 qdisc pfifo_fast state DOWN qlen 1000 > link/ether 06:e4:c8:00:00:0e brd ff:ff:ff:ff:ff:ff > inet 10.147.46.102/24 brd 10.147.46.255 scope global eth1 > 4: eth2: mtu 1500 qdisc pfifo_fast state UP > qlen 1000 > link/ether 02:00:5d:a4:00:03 brd ff:ff:ff:ff:ff:ff > inet 10.1.1.33/24 brd 10.1.1.255 scope global eth2 > 5: eth3: mtu 1500 qdisc pfifo_fast state UP > qlen 1000 > link/ether 06:de:fc:00:00:29 brd ff:ff:ff:ff:ff:ff > inet 10.147.52.200/24 brd
[jira] [Commented] (CLOUDSTACK-10105) Follow maven standard for all modules
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327896#comment-16327896 ] ASF GitHub Bot commented on CLOUDSTACK-10105: - khos2ow commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-358126411 Strong +1 from me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Follow maven standard for all modules > - > > Key: CLOUDSTACK-10105 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10105 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Minor > > The goal is to remove the custom module layout used and follow maven standard > structures for all. This will remove one module. It's only a matter of moving > files around to their correct location. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CLOUDSTACK-10234) HA fails in cases of PSU failure.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nux updated CLOUDSTACK-10234: - Description: To simulate PSU failure I pulled the power from the server physically, HA fails to do the right thing and move the affected VMs to other HVs. I waited a good while, but alas nothing happened. The VM and VR running on the affected hypervisor were never moved to another one (I have another 2 running). Is there any way to at least force the system to mark that HV as bad/offline? This is what I see in the management server logs: {code:java} Caused by: com.cloud.utils.exception.CloudRuntimeException: Out-of-band Management action (OFF) on host (57bf86e0-e1cd-484e-a4f1-78b3ca2da125) failed with error: Get Auth Capabilities error Error issuing Get Channel Authentication Capabilities request Error: Unable to establish IPMI v2 / RMCP+ session at org.apache.cloudstack.outofbandmanagement.OutOfBandManagementServiceImpl.executePowerOperation(OutOfBandManagementServiceImpl.java:423) at sun.reflect.GeneratedMethodAccessor199.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ... 21 more 2018-01-16 17:00:13,396 WARN [o.a.c.alerts] (pool-5-thread-7:null) (logid:4f7299f6) AlertType:: 30 | dataCenterId:: 1 | podId:: 1 | clusterId:: null | message:: HA Fencing of host id=1, in dc id=1 performed 2018-01-16 17:00:15,375 DEBUG [c.c.a.t.Request] (pool-2-thread-27:null) (logid:6b21a8c1) Seq 5-9115285645797884785: Sending \{ Cmd , MgmtId: 161334379813, via: 5(hv03.cloud.local), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.CheckOnHostCommand":{"host":{"guid":"598d48ef-158d-3e14-ad68-8d02c9368ddf-LibvirtComputingResource","privateNetwork":{"ip":"172.16.25.101","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:f6","isSecurityGroupEnabled":false},"publicNetwork":\{"ip":"172.16.25.101","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:f6","isSecurityGroupEnabled":false},"storageNetwork1":\{"ip":"172.16.25.101","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:f6","isSecurityGroupEnabled":false}},"wait":20}}] } 2018-01-16 17:00:15,380 DEBUG [c.c.a.t.Request] (pool-2-thread-5:null) (logid:bb993597) Seq 4-6582855280332112812: Sending \{ Cmd , MgmtId: 161334379813, via: 4(hv02.cloud.local), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.CheckOnHostCommand":{"host":{"guid":"6ebb3010-9c49-3a9c-b620-ecbc9731aca2-LibvirtComputingResource","privateNetwork":{"ip":"172.16.25.100","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:8e","isSecurityGroupEnabled":false},"publicNetwork":\{"ip":"172.16.25.100","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:8e","isSecurityGroupEnabled":false},"storageNetwork1":\{"ip":"172.16.25.100","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:8e","isSecurityGroupEnabled":false}},"wait":20}}] } 2018-01-16 17:00:15,423 DEBUG [c.c.a.t.Request] (AgentManager-Handler-4:null) (logid:) Seq 5-9115285645797884785: Processing: \{ Ans: , MgmtId: 161334379813, via: 5, Ver: v1, Flags: 10, [{"com.cloud.agent.api.Answer":{"result":false,"details":"Heart is beating...","wait":0}}] } 2018-01-16 17:00:15,423 DEBUG [c.c.a.t.Request] (pool-2-thread-27:null) (logid:6b21a8c1) Seq 5-9115285645797884785: Received: \{ Ans: , MgmtId: 161334379813, via: 5(hv03.cloud.local), Ver: v1, Flags: 10, { Answer } } 2018-01-16 17:00:15,423 DEBUG [c.c.a.m.AgentManagerImpl] (pool-2-thread-27:null) (logid:6b21a8c1) Details from executing class com.cloud.agent.api.CheckOnHostCommand: Heart is beating... 2018-01-16 17:00:15,427 DEBUG [c.c.a.t.Request] (AgentManager-Handler-6:null) (logid:) Seq 4-6582855280332112812: Processing: \{ Ans: , MgmtId: 161334379813, via: 4, Ver: v1, Flags: 10, [{"com.cloud.agent.api.Answer":{"result":false,"details":"Heart is beating...","wait":0}}] } 2018-01-16 17:00:15,427 DEBUG [c.c.a.t.Request] (pool-2-thread-5:null) (logid:bb993597) Seq 4-6582855280332112812: Received: \{ Ans: , MgmtId: 161334379813, via: 4(hv02.cloud.local), Ver: v1, Flags: 10, { Answer } } 2018-01-16 17:00:15,427 DEBUG [c.c.a.m.AgentManagerImpl] (pool-2-thread-5:null) (logid:bb993597) Details from executing class com.cloud.agent.api.CheckOnHostCommand: Heart is beating... 2018-01-16 17:00:16,217 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-d9c2c841) (logid:1b093681) Begin cleanup expired async-jobs 2018-01-16 17:00:16,218 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-d9c2c841) (logid:1b093681) End cleanup expired async-jobs 2018-01-16 17:00:17,392 WARN [o.a.c.o.PowerOperationTask] (pool-6-thread-29:null) (logid:f9788c38) Out-of-band management background task operation=STATUS for host id=1 failed with: Out-of-band Management action (STATUS) on host (57bf86e0-e1cd-484e-a4f1-78b3ca2da125) failed with error: Get Auth Capabilities error Error issuing Get Channel
[jira] [Created] (CLOUDSTACK-10234) HA fails in cases of PSU failure.
Nux created CLOUDSTACK-10234: Summary: HA fails in cases of PSU failure. Key: CLOUDSTACK-10234 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10234 Project: CloudStack Issue Type: Improvement Security Level: Public (Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.11.0.0 Environment: 4.11 RC1, NFS storage, CentOS 7 management server and hypervisors Reporter: Nux To simulate PSU failure I pulled the power from the server physically, HA fails to do the right thing and move the affected VMs to other HVs. I waited a good while, but alas nothing happened. The VM and VR running on the affected hypervisor were never moved to another one (I have another 2 running). This is what I see in the management server logs: {code:java} Caused by: com.cloud.utils.exception.CloudRuntimeException: Out-of-band Management action (OFF) on host (57bf86e0-e1cd-484e-a4f1-78b3ca2da125) failed with error: Get Auth Capabilities error Error issuing Get Channel Authentication Capabilities request Error: Unable to establish IPMI v2 / RMCP+ session at org.apache.cloudstack.outofbandmanagement.OutOfBandManagementServiceImpl.executePowerOperation(OutOfBandManagementServiceImpl.java:423) at sun.reflect.GeneratedMethodAccessor199.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ... 21 more 2018-01-16 17:00:13,396 WARN [o.a.c.alerts] (pool-5-thread-7:null) (logid:4f7299f6) AlertType:: 30 | dataCenterId:: 1 | podId:: 1 | clusterId:: null | message:: HA Fencing of host id=1, in dc id=1 performed 2018-01-16 17:00:15,375 DEBUG [c.c.a.t.Request] (pool-2-thread-27:null) (logid:6b21a8c1) Seq 5-9115285645797884785: Sending \{ Cmd , MgmtId: 161334379813, via: 5(hv03.cloud.local), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.CheckOnHostCommand":{"host":{"guid":"598d48ef-158d-3e14-ad68-8d02c9368ddf-LibvirtComputingResource","privateNetwork":{"ip":"172.16.25.101","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:f6","isSecurityGroupEnabled":false},"publicNetwork":\{"ip":"172.16.25.101","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:f6","isSecurityGroupEnabled":false},"storageNetwork1":\{"ip":"172.16.25.101","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:f6","isSecurityGroupEnabled":false}},"wait":20}}] } 2018-01-16 17:00:15,380 DEBUG [c.c.a.t.Request] (pool-2-thread-5:null) (logid:bb993597) Seq 4-6582855280332112812: Sending \{ Cmd , MgmtId: 161334379813, via: 4(hv02.cloud.local), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.CheckOnHostCommand":{"host":{"guid":"6ebb3010-9c49-3a9c-b620-ecbc9731aca2-LibvirtComputingResource","privateNetwork":{"ip":"172.16.25.100","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:8e","isSecurityGroupEnabled":false},"publicNetwork":\{"ip":"172.16.25.100","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:8e","isSecurityGroupEnabled":false},"storageNetwork1":\{"ip":"172.16.25.100","netmask":"255.255.255.240","mac":"0c:c4:7a:40:8e:8e","isSecurityGroupEnabled":false}},"wait":20}}] } 2018-01-16 17:00:15,423 DEBUG [c.c.a.t.Request] (AgentManager-Handler-4:null) (logid:) Seq 5-9115285645797884785: Processing: \{ Ans: , MgmtId: 161334379813, via: 5, Ver: v1, Flags: 10, [{"com.cloud.agent.api.Answer":{"result":false,"details":"Heart is beating...","wait":0}}] } 2018-01-16 17:00:15,423 DEBUG [c.c.a.t.Request] (pool-2-thread-27:null) (logid:6b21a8c1) Seq 5-9115285645797884785: Received: \{ Ans: , MgmtId: 161334379813, via: 5(hv03.cloud.local), Ver: v1, Flags: 10, { Answer } } 2018-01-16 17:00:15,423 DEBUG [c.c.a.m.AgentManagerImpl] (pool-2-thread-27:null) (logid:6b21a8c1) Details from executing class com.cloud.agent.api.CheckOnHostCommand: Heart is beating... 2018-01-16 17:00:15,427 DEBUG [c.c.a.t.Request] (AgentManager-Handler-6:null) (logid:) Seq 4-6582855280332112812: Processing: \{ Ans: , MgmtId: 161334379813, via: 4, Ver: v1, Flags: 10, [{"com.cloud.agent.api.Answer":{"result":false,"details":"Heart is beating...","wait":0}}] } 2018-01-16 17:00:15,427 DEBUG [c.c.a.t.Request] (pool-2-thread-5:null) (logid:bb993597) Seq 4-6582855280332112812: Received: \{ Ans: , MgmtId: 161334379813, via: 4(hv02.cloud.local), Ver: v1, Flags: 10, { Answer } } 2018-01-16 17:00:15,427 DEBUG [c.c.a.m.AgentManagerImpl] (pool-2-thread-5:null) (logid:bb993597) Details from executing class com.cloud.agent.api.CheckOnHostCommand: Heart is beating... 2018-01-16 17:00:16,217 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-d9c2c841) (logid:1b093681) Begin cleanup expired async-jobs 2018-01-16 17:00:16,218 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-d9c2c841) (logid:1b093681) End cleanup expired async-jobs 2018-01-16 17:00:17,392 WARN [o.a.c.o.PowerOperationTask]
[jira] [Assigned] (CLOUDSTACK-10233) When installed ACS on Rhel7.4 with libvirt-3.2.0 the nuage-extension in metadata is missing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Maximus reassigned CLOUDSTACK-10233: -- Assignee: Frank Maximus > When installed ACS on Rhel7.4 with libvirt-3.2.0 the nuage-extension in > metadata is missing > --- > > Key: CLOUDSTACK-10233 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10233 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Raf Smeets >Assignee: Frank Maximus >Priority: Critical > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CLOUDSTACK-10233) When installed ACS on Rhel7.4 with libvirt-3.2.0 the nuage-extension in metadata is missing
Raf Smeets created CLOUDSTACK-10233: --- Summary: When installed ACS on Rhel7.4 with libvirt-3.2.0 the nuage-extension in metadata is missing Key: CLOUDSTACK-10233 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10233 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: cloudstack-agent Affects Versions: 4.11.0.0 Environment: Nuage VSP plugin on RHEL 7.4 Reporter: Raf Smeets When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there is an issue with the metadata of the created VM in cloudstack. It leads to password reset failure as the nuage vrs is not allowing passage to DomainRouter. After debugging , it was found that the nuage-extension in metadata was missing. When cloudstack-agent is preparing xml to be sent to openvswitch it contains metadata with nuage-extension block as follows In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without nuage-extension block in metadata as follows: Jan 15 18:17:17 ovs-1 vm-monitor.log: So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (CLOUDSTACK-9775) ListInternalLBVMsCmd shows blank in UI although VM is there via api
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raf Smeets closed CLOUDSTACK-9775. -- Resolution: Cannot Reproduce Cannot reproduce in ACS 4.11, so closing this bug. > ListInternalLBVMsCmd shows blank in UI although VM is there via api > --- > > Key: CLOUDSTACK-9775 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9775 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: UI >Affects Versions: 4.9.0 >Reporter: Raf Smeets >Priority: Major > Attachments: InternalLBVMFail.png > > > ListInternalLBVMsCmd shows blank in the UI although LB VM is there via api > See attached UI screenshot. > {NOFORMAT} > [root@csc-1 ~]# cloudmonkey api listInternalLoadBalancerVMs > zoneid=8f14b344-7080-4d1c-a37d-badbfb2e90c8 listAll=true > count = 3 > internalloadbalancervm: > ++--+---+---+--+-+--+--+--+---+--+---+--+---+-+-++--+--+--+-++--+--+-+---+--+--+--+-+---+--++---+++ > | domain | domainid | guestmacaddress | > linklocalip |zoneid| linklocalmacaddress | >linklocalnetworkid | linklocalnetmask | id >| isredundantrouter | guestnetworkname > | networkdomain |guestnetworkid| > hostname | state | version | role | > serviceofferingid | zonename |podid > | > > > > > nic > > > > > | redundantstate |vpcid | >templateid | requiresupgrade | account >|hostid| name | created > | dns2 | dns1 | vpcname > | hypervisor | guestnetmask | guestipaddress | > serviceofferingname | >
[jira] [Commented] (CLOUDSTACK-9749) cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by password server on lb VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327229#comment-16327229 ] Raf Smeets commented on CLOUDSTACK-9749: I tested the fix via test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py and verified that this fix is working. Test Nuage VSP VPC Internal LB functionality by performing (wget) ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS === ok Above test_05 was failing before and is now passingso LGTM. > cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by > password server on lb VM > -- > > Key: CLOUDSTACK-9749 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9749 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0, 4.9.2.0, 4.8.2.0, 4.11.0.0 >Reporter: Raf Smeets >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.10.0.0 > > Attachments: runinfo.txt > > > cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by > password server on lb VM > Executed test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py > which failed in test_05_nuage_internallb_traffic at the point where it is > checking the lb via wget of file using port 8080. > As port 8080 already is occupied by the password_server, it fails. > I have added the runinfo.txt of the failing test to this bugticket. > Similar issue was reported internally via CLOUD-972. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CLOUDSTACK-9749) cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by password server on lb VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Maximus resolved CLOUDSTACK-9749. --- Resolution: Fixed Fixed in [PR #2409|https://github.com/apache/cloudstack/pull/2409] > cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by > password server on lb VM > -- > > Key: CLOUDSTACK-9749 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9749 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0, 4.9.2.0, 4.8.2.0, 4.11.0.0 >Reporter: Raf Smeets >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.10.0.0 > > Attachments: runinfo.txt > > > cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by > password server on lb VM > Executed test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py > which failed in test_05_nuage_internallb_traffic at the point where it is > checking the lb via wget of file using port 8080. > As port 8080 already is occupied by the password_server, it fails. > I have added the runinfo.txt of the failing test to this bugticket. > Similar issue was reported internally via CLOUD-972. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9749) cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by password server on lb VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327213#comment-16327213 ] ASF GitHub Bot commented on CLOUDSTACK-9749: fmaximus opened a new pull request #2409: CLOUDSTACK-9749: Fix Password server running on internal LB VM URL: https://github.com/apache/cloudstack/pull/2409 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by > password server on lb VM > -- > > Key: CLOUDSTACK-9749 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9749 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.10.0.0, 4.9.2.0, 4.8.2.0, 4.11.0.0 >Reporter: Raf Smeets >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.10.0.0 > > Attachments: runinfo.txt > > > cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by > password server on lb VM > Executed test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py > which failed in test_05_nuage_internallb_traffic at the point where it is > checking the lb via wget of file using port 8080. > As port 8080 already is occupied by the password_server, it fails. > I have added the runinfo.txt of the failing test to this bugticket. > Similar issue was reported internally via CLOUD-972. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10105) Follow maven standard for all modules
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327180#comment-16327180 ] ASF GitHub Bot commented on CLOUDSTACK-10105: - rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-357979560 me too... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Follow maven standard for all modules > - > > Key: CLOUDSTACK-10105 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10105 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Minor > > The goal is to remove the custom module layout used and follow maven standard > structures for all. This will remove one module. It's only a matter of moving > files around to their correct location. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10105) Follow maven standard for all modules
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327178#comment-16327178 ] ASF GitHub Bot commented on CLOUDSTACK-10105: - wido commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-357979285 I would be OK with this as it's indeed a better structure. It might however kill a lot of PRs, but if we want to do this, NOW is the time imho. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Follow maven standard for all modules > - > > Key: CLOUDSTACK-10105 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10105 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Minor > > The goal is to remove the custom module layout used and follow maven standard > structures for all. This will remove one module. It's only a matter of moving > files around to their correct location. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10105) Follow maven standard for all modules
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327146#comment-16327146 ] ASF GitHub Bot commented on CLOUDSTACK-10105: - marcaurele commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-357971633 @wido @PaulAngus @rhtyd @swill @rafaelweingartner @DaanHoogland can we have your voice over this change to move all project to follow maven standards. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Follow maven standard for all modules > - > > Key: CLOUDSTACK-10105 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10105 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Minor > > The goal is to remove the custom module layout used and follow maven standard > structures for all. This will remove one module. It's only a matter of moving > files around to their correct location. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10105) Follow maven standard for all modules
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327011#comment-16327011 ] ASF GitHub Bot commented on CLOUDSTACK-10105: - rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-357927214 @marcaurele I believe it might be a good idea to ask others to look into this one before we start merging again... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Follow maven standard for all modules > - > > Key: CLOUDSTACK-10105 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10105 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Minor > > The goal is to remove the custom module layout used and follow maven standard > structures for all. This will remove one module. It's only a matter of moving > files around to their correct location. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10105) Follow maven standard for all modules
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326988#comment-16326988 ] ASF GitHub Bot commented on CLOUDSTACK-10105: - marcaurele commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-357921462 Rebased to fix all conflicts, and ready for 4.12.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Follow maven standard for all modules > - > > Key: CLOUDSTACK-10105 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10105 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Minor > > The goal is to remove the custom module layout used and follow maven standard > structures for all. This will remove one module. It's only a matter of moving > files around to their correct location. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9663) updateRole should return updated role as json
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326893#comment-16326893 ] ASF GitHub Bot commented on CLOUDSTACK-9663: blueorangutan commented on issue #2406: CLOUDSTACK-9663 URL: https://github.com/apache/cloudstack/pull/2406#issuecomment-357892449 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > updateRole should return updated role as json > - > > Key: CLOUDSTACK-9663 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9663 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Affects Versions: 4.9.0 >Reporter: René Moser >Priority: Trivial > Fix For: Future, 4.11.0.0 > > > updateRole does currently only return success but one would expect it returns > the updated role as json like other update APIs > Acutal results: > {code} > $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test > --region=simulator > { > "success": "true" > } > {code} > expected resutls: > {code} > $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test > --region=simulator > { > "role": { > "id": ... > "description": ... > "name": ... > "type": ... > } > } > {code} > similar to other update api e.g. > http://cloudstack.apache.org/api/apidocs-4.9/apis/updateUser.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9663) updateRole should return updated role as json
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326892#comment-16326892 ] ASF GitHub Bot commented on CLOUDSTACK-9663: DaanHoogland commented on issue #2406: CLOUDSTACK-9663 URL: https://github.com/apache/cloudstack/pull/2406#issuecomment-357892429 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > updateRole should return updated role as json > - > > Key: CLOUDSTACK-9663 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9663 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Affects Versions: 4.9.0 >Reporter: René Moser >Priority: Trivial > Fix For: Future, 4.11.0.0 > > > updateRole does currently only return success but one would expect it returns > the updated role as json like other update APIs > Acutal results: > {code} > $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test > --region=simulator > { > "success": "true" > } > {code} > expected resutls: > {code} > $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test > --region=simulator > { > "role": { > "id": ... > "description": ... > "name": ... > "type": ... > } > } > {code} > similar to other update api e.g. > http://cloudstack.apache.org/api/apidocs-4.9/apis/updateUser.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326886#comment-16326886 ] ASF GitHub Bot commented on CLOUDSTACK-10146: - DaanHoogland commented on a change in pull request #2405: CLOUDSTACK-10146 checksum in java instead of script URL: https://github.com/apache/cloudstack/pull/2405#discussion_r161689898 ## File path: agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java ## @@ -149,36 +154,16 @@ public DirectTemplateInformation getTemplateInformation() { return new DirectTemplateInformation(installPath, size, checksum); } -/** - * Return checksum command from algorithm - */ -private String getChecksumCommandFromAlgorithm(String algorithm) { -if (algorithm.equalsIgnoreCase("MD5")) { -return "md5sum"; -} else if (algorithm.equalsIgnoreCase("SHA-1")) { -return "sha1sum"; -} else if (algorithm.equalsIgnoreCase("SHA-224")) { -return "sha224sum"; -} else if (algorithm.equalsIgnoreCase("SHA-256")) { -return "sha256sum"; -} else if (algorithm.equalsIgnoreCase("SHA-384")) { -return "sha384sum"; -} else if (algorithm.equalsIgnoreCase("SHA-512")) { -return "sha512sum"; -} else { -throw new CloudRuntimeException("Unknown checksum algorithm: " + algorithm); -} -} - @Override public boolean validateChecksum() { if (StringUtils.isNotBlank(checksum)) { -ChecksumValue providedChecksum = new ChecksumValue(checksum); -String algorithm = providedChecksum.getAlgorithm(); -String checksumCommand = "echo '%s %s' | %s -c --quiet"; -String cmd = String.format(checksumCommand, providedChecksum.getChecksum(), downloadedFilePath, getChecksumCommandFromAlgorithm(algorithm)); -int result = Script.runSimpleBashScriptForExitValue(cmd); -return result == 0; +try { +return DigestHelper.check(checksum, new FileInputStream(downloadedFilePath)); +} catch (IOException e) { +throw new CloudRuntimeException("could not check sum for file: " + downloadedFilePath); Review comment: ok, I thought the error is purely the chosen algorithnm so don't include the root cause. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bypass Secondary Storage for KVM templates > -- > > Key: CLOUDSTACK-10146 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)