[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338356#comment-16338356
 ] 

ASF subversion and git services commented on CLOUDSTACK-10255:
--

Commit 22d6718fe3f83d6c3c47734669fe9cde3e6d1a88 in cloudstack's branch 
refs/heads/4.11 from [~fmaximus]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=22d6718 ]

CLOUDSTACK-10255: Fix agent logrotate (#2429)

Renamed cloudstack-agent.logrotate to cloudstack-agent.logrotate.in,
so Ant will run the filterchain while copying.
This made the ant run copy block of cloudstack-agent.logrotate unnecessary,
so this is removed.

> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338355#comment-16338355
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

rhtyd closed pull request #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/agent/conf/cloudstack-agent.logrotate 
b/agent/conf/cloudstack-agent.logrotate.in
similarity index 100%
rename from agent/conf/cloudstack-agent.logrotate
rename to agent/conf/cloudstack-agent.logrotate.in
diff --git a/agent/pom.xml b/agent/pom.xml
index 3ee1c5dbacb..0505752660a 100644
--- a/agent/pom.xml
+++ b/agent/pom.xml
@@ -93,12 +93,6 @@
 
   
 
-
-  
-
-  
-
   
 
   


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338233#comment-16338233
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360275431
 
 
   Trillian test result (tid-2190)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 21245 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2429-t2190-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338127#comment-16338127
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360251196
 
 
   Trillian test result (tid-2188)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36778 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2423-t2188-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 62 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_extract_template | `Failure` | 128.27 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 137.79 | test_volumes.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 278.21 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 277.87 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.83 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10134) Performance improvement for applying port forwarding rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338014#comment-16338014
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10134:
-

DaanHoogland commented on issue #2311: CLOUDSTACK-10134 Optimization of 
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360225127
 
 
   those network tests seem related to the code , @yvsubhash @rhtyd ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Performance improvement for applying port forwarding rules
> --
>
> Key: CLOUDSTACK-10134
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10134
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: subhash yedugundla
>Priority: Major
>
> Repro Steps
> Step to reproduce: 
> 1. Allocate ip address 
> 2. Add PortForwarding rule to the IP address repeatedly 
> 3. Check the time that setting takes
> Time for each rules goes up for every new rule that gets added. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10134) Performance improvement for applying port forwarding rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338011#comment-16338011
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10134:
-

blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of 
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360223732
 
 
   Trillian test result (tid-2189)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 25336 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2311-t2189-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 4.02 | 
test_network.py
   test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 4.30 | 
test_network.py
   test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 5.33 
| test_network.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 326.28 | 
test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Performance improvement for applying port forwarding rules
> --
>
> Key: CLOUDSTACK-10134
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10134
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: subhash yedugundla
>Priority: Major
>
> Repro Steps
> Step to reproduce: 
> 1. Allocate ip address 
> 2. Add PortForwarding rule to the IP address repeatedly 
> 3. Check the time that setting takes
> Time for each rules goes up for every new rule that gets added. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338008#comment-16338008
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

DaanHoogland commented on issue #2430: CLOUDSTACK-10239 default provider if 
needed
URL: https://github.com/apache/cloudstack/pull/2430#issuecomment-360221834
 
 
   @rhtyd it does,
   @marcaurele I think this is in your toko, not? just did some googling, guess 
it is not.
   I am not sure of my solution, it fixes backwards compatibility but I think 
the clean solution it to specify for which domain an ldap server is meant (as 
it can be specified for several domain anyway)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338003#comment-16338003
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

DaanHoogland commented on issue #2430: CLOUDSTACK-10239 default provider if 
needed
URL: https://github.com/apache/cloudstack/pull/2430#issuecomment-360221834
 
 
   @rhtyd it does,
   @marcaurele I think this is in your toko, not?
   I am not sure of my solution, it fixes backwards compatibility but I think 
the clean solution it to specify for which domain an ldap server is meant (as 
it can be specified for several domain anyway)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[Daan Hoogland (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338002#comment-16338002
 ] 

Daan Hoogland commented on CLOUDSTACK-10239:


it seems that the adding of the domain to the LdapCreateAccount API has 
introduced this regression. I made a fallback if the ldap trustmap is not added 
for the specified domain, which is the actual problem. I think adding a domain 
to the configured ldap server specification is the real solution.

 

> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337999#comment-16337999
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360220812
 
 
   @marcaurele can you run test_hostha_simulator.py smoketest against simulator 
in your local environment and see if you can reproduce and fix the failure? You 
can look at Travis log (scroll to the bottom, or see the raw logs), you'll find 
error such as following:
   ```
   Traceback (most recent call last):
 File 
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
 line 531, in test_ha_verify_fsm_available
   self.configureSimulatorHAProviderState(True, True, True, False)
 File 
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
 line 164, in configureSimulatorHAProviderState
   self.assertEqual(response.success, 'true')
   AssertionError: True != 'true'
   ```
   
   I think we'll need to discuss this on dev@, as this change may potentially 
cause regression for API consumers?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337998#comment-16337998
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239 
default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163628911
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ##
 @@ -54,11 +54,11 @@
 @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, required = 
true, description = "type of the ldap name. GROUP or OU")
 private String type;
 
-@Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+@Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, 
required = false, description = "name of the group or OU in LDAP")
 
 Review comment:
   the validation of the field is done deeper in the stack. A check is done to 
see if either ldapdomain or name is filled.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338000#comment-16338000
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239 
default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163628970
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ##
 @@ -54,11 +54,11 @@
 @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, required = 
true, description = "type of the ldap name. GROUP or OU")
 private String type;
 
-@Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+@Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, 
required = false, description = "name of the group or OU in LDAP")
 private String ldapDomain;
 
 @Deprecated
-@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required = 
true, description = "name of the group or OU in LDAP")
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required = 
false, description = "name of the group or OU in LDAP")
 
 Review comment:
   see above


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337996#comment-16337996
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360220812
 
 
   @marcaurele can you run test_hostha_simulator.py smoketest against simulator 
in your local environment and see if you can reproduce and fix the failure? You 
can look at Travis log (scroll to the bottom, or see the raw logs), you'll find 
error such as following:
   ```
   Traceback (most recent call last):
 File 
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
 line 531, in test_ha_verify_fsm_available
   self.configureSimulatorHAProviderState(True, True, True, False)
 File 
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
 line 164, in configureSimulatorHAProviderState
   self.assertEqual(response.success, 'true')
   AssertionError: True != 'true'
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337993#comment-16337993
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360220812
 
 
   @marcaurele can you run test_hostha_simulator.py smoketest against simulator 
in your local environment and see if you can reproduce and fix the failure?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337992#comment-16337992
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239 
default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163628527
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java
 ##
 @@ -80,9 +79,13 @@ private void enableSSL(final Hashtable 
environment) {
 
 private Hashtable getEnvironment(final String principal, 
final String password, final String providerUrl, final boolean isSystemContext, 
Long domainId) {
 final String factory = _ldapConfiguration.getFactory();
-final String url = providerUrl == null ? 
_ldapConfiguration.getProviderUrl(domainId) : providerUrl;
+String url = providerUrl == null ? 
_ldapConfiguration.getProviderUrl(domainId) : providerUrl;
+if (StringUtils.isEmpty(url) && domainId != null) {
 
 Review comment:
   we can but getProviderUrl(domainId) returns "" at least


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337989#comment-16337989
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

rhtyd commented on a change in pull request #2430: CLOUDSTACK-10239 default 
provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163627862
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java
 ##
 @@ -80,9 +79,13 @@ private void enableSSL(final Hashtable 
environment) {
 
 private Hashtable getEnvironment(final String principal, 
final String password, final String providerUrl, final boolean isSystemContext, 
Long domainId) {
 final String factory = _ldapConfiguration.getFactory();
-final String url = providerUrl == null ? 
_ldapConfiguration.getProviderUrl(domainId) : providerUrl;
+String url = providerUrl == null ? 
_ldapConfiguration.getProviderUrl(domainId) : providerUrl;
+if (StringUtils.isEmpty(url) && domainId != null) {
 
 Review comment:
   Can we do a `Strings.isNullOrEmpty()` instead?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337987#comment-16337987
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

rhtyd commented on a change in pull request #2430: CLOUDSTACK-10239 default 
provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163627731
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ##
 @@ -54,11 +54,11 @@
 @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, required = 
true, description = "type of the ldap name. GROUP or OU")
 private String type;
 
-@Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+@Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, 
required = false, description = "name of the group or OU in LDAP")
 private String ldapDomain;
 
 @Deprecated
-@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required = 
true, description = "name of the group or OU in LDAP")
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required = 
false, description = "name of the group or OU in LDAP")
 
 Review comment:
   Same as previous comment ^^


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337988#comment-16337988
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

rhtyd commented on a change in pull request #2430: CLOUDSTACK-10239 default 
provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163627668
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ##
 @@ -54,11 +54,11 @@
 @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, required = 
true, description = "type of the ldap name. GROUP or OU")
 private String type;
 
-@Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+@Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, 
required = false, description = "name of the group or OU in LDAP")
 
 Review comment:
   Was this a regression that was added due to LDAP related enhancements, or 
could this cause issue if the field is made non-mandatory?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337990#comment-16337990
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

rhtyd commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360220197
 
 
   Okay, will move it to 4.11.0 milestone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337983#comment-16337983
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

rhtyd commented on issue #2430: CLOUDSTACK-10239 default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#issuecomment-360219344
 
 
   @DaanHoogland does this PR solve the issue (blocker-ish) shared on users@ 
towards 4.11 RC1?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337977#comment-16337977
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

DaanHoogland commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360218607
 
 
   4.11.0 i concur


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337974#comment-16337974
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10239:
-

DaanHoogland opened a new pull request #2430: CLOUDSTACK-10239 default provider 
if needed
URL: https://github.com/apache/cloudstack/pull/2430
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337866#comment-16337866
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10251:
-

blueorangutan commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for 
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360194044
 
 
   Trillian test result (tid-2187)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29092 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2424-t2187-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.23 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337752#comment-16337752
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

rhtyd commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360169200
 
 
   Since this is packaging related issue, clearly causing failures on 
logrotation we can consider this towards 4.11.0 milestone. /cc @DaanHoogland 
@wido @rafaelweingartner @borisstoyanov and others.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337747#comment-16337747
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

rhtyd commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360168220
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337749#comment-16337749
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360168288
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337721#comment-16337721
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360164947
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1679


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337668#comment-16337668
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360156225
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337664#comment-16337664
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

rhtyd commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360156007
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337599#comment-16337599
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

marcaurele commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360140019
 
 
   @rhtyd I did, and looked inside the related test code to see if any were 
doing any particular checks against a `success` keyword. But I could not find 
any, so my question was where should I look next to find an issue since the 
error aren't very informative on the travis log.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337584#comment-16337584
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360132886
 
 
   @marcaurele if you scroll down to the test results, every test jobs has this 
result table. You want to search for error/exception/failed test cases. From 
the failing job
   https://travis-ci.org/apache/cloudstack/jobs/332676208
   
   I see these failed tests:
   
+-+-++-+
   | test_ha_configure_enabledis | Failure | 1.302  | test_hostha_simulator 
  |
   | able_across_clusterzones| ||   
  |
   
+-+-++-+
   | test_ha_disable_feature_inv | Success | 2.325  | test_hostha_simulator 
  |
   | alid| ||   
  |
   
+-+-++-+
   | test_ha_enable_feature_inva | Success | 3.277  | test_hostha_simulator 
  |
   | lid | ||   
  |
   
+-+-++-+
   | test_ha_list_providers  | Success | 2.232  | test_hostha_simulator 
  |
   
+-+-++-+
   | test_ha_multiple_mgmt_serve | Failure | 0.155  | test_hostha_simulator 
  |
   | r_ownership | ||   
  |
   
+-+-++-+
   | test_ha_verify_fsm_availabl | Failure | 0.185  | test_hostha_simulator 
  |
   | e   | ||   
  |
   
+-+-++-+
   | test_ha_verify_fsm_degraded | Failure | 2.172  | test_hostha_simulator 
  |
   
+-+-++-+
   | test_ha_verify_fsm_fenced   | Failure | 2.130  | test_hostha_simulator 
  |
   
+-+-++-+
   | test_ha_verify_fsm_recoveri | Failure | 1.127  | test_hostha_simulator 
  |
   | ng  | ||   
  |
   
   As a committer, you can actually log into Travis and re-kick them. I'll 
rekick them just in case they were intermittent failures.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337562#comment-16337562
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

marcaurele commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360126226
 
 
   @rhtyd I see the name of the failed tests but there is no hint on where 
exactly it failed. I looked for the word `success` in some tests but couldn't 
find it. Any hint on where to look for?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337510#comment-16337510
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10255:
-

fmaximus opened a new pull request #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429
 
 
   Renamed `cloudstack-agent.logrotate` to `cloudstack-agent.logrotate.in`, 
   so Ant will run the filterchain while copying.
   This made the ant run copy block of `cloudstack-agent.logrotate` unnecessary,
   so this is removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[Frank Maximus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Maximus reassigned CLOUDSTACK-10255:
--

Assignee: Frank Maximus

> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: 
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron 
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under  the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
> copytruncate
> daily
> rotate 5
> compress
> missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337493#comment-16337493
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360112649
 
 
   @marcaurele looks like this will add regression, see Travis failures.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10242) Problem Using Ingress/Egress SG Rules over 4.11 rc Tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337484#comment-16337484
 ] 

ASF subversion and git services commented on CLOUDSTACK-10242:
--

Commit f80f00ebcb6c626a004c2b528b4026710f01e794 in cloudstack's branch 
refs/heads/master from [~widodh]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=f80f00e ]

CLOUDSTACK-10242: Properly parse incoming rules to Sec Group (#2418)

With merge of PR #2028 the separator for lines to the Security Group
Python script changed from : to ; to support IPv6 addresses.

This broke certain situations where rules were parsed improperly. This
commit fixes the issue.

Signed-off-by: Wido den Hollander 
Signed-off-by: Rohit Yadav 

> Problem Using Ingress/Egress SG Rules over 4.11 rc Tests
> 
>
> Key: CLOUDSTACK-10242
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10242
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server
>Affects Versions: 4.11.0.0
> Environment: KVM Host Ubuntu 16.04.3, Management Server Ubuntu 14.04.5
>Reporter: Özhan Rüzgar Karaman
>Assignee: Wido den Hollander
>Priority: Blocker
>
> We noticed that Cloudstack-9853 fix generates some problems on applying SG 
> rules on security_group.py script. We compare the commands which send to 
> script between 4.9.3 and 4.11 versions and we noticed that SG rule delimiter 
> and nicsecips values changed on 4.11 release its examples are below:
> 4.9.3
> /usr/share/cloudstack-common/scripts/vm/network/security_group.py 
> default_network_rules --vmname i-2-573-VM --vmid 573 --vmip 192.168.2.56 
> --vmmac 06:31:56:00:04:09 --vif vnet15 --brname brenp4s0f0-23 --nicsecips 0:
>  
> /usr/share/cloudstack-common/scripts/vm/network/security_group.py 
> add_network_rules --vmname i-2-573-VM --vmid 573 --vmip 192.168.2.56 --sig 
> d60255deb618b7be9f477eed10d65234 --seq 2 --vmmac 06:31:56:00:04:09 --vif 
> vnet15 --brname brenp4s0f0-23 --nicsecips 0: --rules 
> "I:icmp:-1:-1:0.0.0.0/0,NEXT;I:tcp:1:65535:0.0.0.0/0,NEXT;I:udp:1:65535:0.0.0.0/0,NEXT;E:icmp:-1:-1:0.0.0.0/0,NEXT;E:tcp:1:65535:0.0.0.0/0,NEXT;E:udp:1:65535:0.0.0.0/0,NEXT;"
>  
> 4.11.0
> /usr/share/cloudstack-common/scripts/vm/network/security_group.py 
> default_network_rules --vmname i-2-3-VM --vmid 3 --vmip 192.168.18.189 
> --vmmac 1e:00:50:00:00:bc --vif vnet10 --brname breth0-23 --nicsecips 0;
> /usr/share/cloudstack-common/scripts/vm/network/security_group.py 
> add_network_rules --vmname "i-2-3-VM" --vmid "3" --vmip "192.168.18.189" 
> --sig "9b1c4aa31c811204e1dae5310d7711b5" --seq "12" --vmmac 
> "1e:00:50:00:00:bc" --vif "vnet10" --brname "breth0-23" --nicsecips "0:" 
> --rules 
> "I:icmp;-1;-1;0.0.0.0/0,NEXT;I:tcp;1;65535;0.0.0.0/0,NEXT;I:udp;1;65535;0.0.0.0/0,NEXT;E:icmp;-1;-1;0.0.0.0/0,NEXT;E:tcp;1;65535;0.0.0.0/0,NEXT;E:udp;1;65535;0.0.0.0/0,NEXT;"
>  
> This change creates problem on parse_network_rules function in 
> security_group.py. We made this test only on ipv4 enabled environment. So 
> this need to be fixed to make SG operational for 4.11 release.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10245) ResetPassword for guestVm in nuage isolated networks is not working, unable to login with new password

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337482#comment-16337482
 ] 

ASF subversion and git services commented on CLOUDSTACK-10245:
--

Commit 3b23d5af740b57acd7745d4475fb2a5877bbf043 in cloudstack's branch 
refs/heads/master from [~fmaximus]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=3b23d5a ]

CLOUDSTACK-10245: Fix password server regression (#2419)

In case of isolated, both self.config.is_vpc() and self.config.is_router() are 
false,
but self.config.is_dhcp() is true.
Moved the password server logic to the `if has_metadata` block,
as this is valid for all 3 systemvm types.

> ResetPassword for guestVm in nuage isolated networks is not working, unable 
> to login with new password
> --
>
> Key: CLOUDSTACK-10245
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10245
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0, 4.12
>Reporter: Raf Smeets
>Assignee: Frank Maximus
>Priority: Blocker
> Fix For: 4.11.0.0, 4.12
>
>
> ResetPassword functionality for guestVm's in Nuage isolated networks is not 
> working as password_server is not running on VirtualRouter. Unable to login 
> with new password.
> Scenario to reproduce:
>  # Execute ResetPassword on GuestVM
>  # Try to login with new password fails as passwordserver is not running on 
> port 8080 in VR.
> After some further debugging, found that this bug is introduced while fixing 
> CLOUDSTACK-9749 by [https://github.com/apache/cloudstack/pull/2409]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337486#comment-16337486
 ] 

ASF subversion and git services commented on CLOUDSTACK-10252:
--

Commit 61a5a297058ce4478766b36d640f76684e31b9c8 in cloudstack's branch 
refs/heads/master from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=61a5a29 ]

CLOUDSTACK-10252: Delete dnsmasq leases file on restart (#2427)

Delete dnsmasq's leases file when dnsmasq is restarted to avoid it
use old ip-mac-address-vm mapping leases.

Signed-off-by: Rohit Yadav 

> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10236) Unable to login to ACS after upgrading 4.5 -> 4.11

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337487#comment-16337487
 ] 

ASF subversion and git services commented on CLOUDSTACK-10236:
--

Commit 170b6ce20dd4fc2f1fd3ad84833f440d955d2987 in cloudstack's branch 
refs/heads/master from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=170b6ce ]

CLOUDSTACK-10236: Enable dynamic roles for missing props file (#2426)

Automate dynamic roles migration for missing props file

- In case commands.properties file is missing, enables dynamic roles.
- Adds a new -D or --default flag to migrate-dynamicroles.py script
  to simply update the global setting and use the default role-rule
  permissions.
- Add warning message, ask admins to move to dynamic roles during upgrade

Signed-off-by: Rohit Yadav 


> Unable to login to ACS after upgrading 4.5 -> 4.11 
> ---
>
> Key: CLOUDSTACK-10236
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10236
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
>Reporter: Boris Stoyanov
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> I've upgraded my CentOS6 env from 4.5 to 4.11 and ended up not being able to 
> login. I'm getting 'Session expired' message right after I enter my admin 
> username and password. Here's the management log output: 
>  
> {code:java}
> 2018-01-17 13:07:47,383 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Attempting to log in user: 
> admin in domain 1
> 2018-01-17 13:07:47,389 DEBUG [o.a.c.s.a.PBKDF2UserAuthenticator] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Retrieving user: admin
> 2018-01-17 13:07:48,248 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) CIDRs from which account 
> 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed to perform API 
> calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,249 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) User: admin in domain 1 has 
> successfully logged in
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Current user logged in under 
> UTC timezone
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Timezone offset from UTC is: 
> 0.0
> 2018-01-17 13:07:48,267 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) ===END=== 10.1.0.1 – POST
> 2018-01-17 13:07:48,340 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282) (logid:b98a9144) ===START=== 10.1.0.1 – GET 
> command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,349 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,372 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) ===END=== 
> 10.1.0.1 – GET command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,439 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0) (logid:67992211) ===START=== 10.1.0.1 – GET 
> command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,449 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,474 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) ===END=== 
> 10.1.0.1 – GET command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,549 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f) (logid:f73a6f0c) ===START=== 10.1.0.1 – GET 
> command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,556 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,579 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) ===END=== 
> 10.1.0.1 – GET command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,645 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-560f926e) (logid:62a5cb2f) ===START=== 10.1.0.1 – GET 
> command=quotaIsEnabled=json&_=1516194514343
> 2018-01-17 13:07:48,653 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-560f926e ctx-c9a2914a) 

[jira] [Commented] (CLOUDSTACK-10236) Unable to login to ACS after upgrading 4.5 -> 4.11

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337476#comment-16337476
 ] 

ASF subversion and git services commented on CLOUDSTACK-10236:
--

Commit 170b6ce20dd4fc2f1fd3ad84833f440d955d2987 in cloudstack's branch 
refs/heads/4.11 from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=170b6ce ]

CLOUDSTACK-10236: Enable dynamic roles for missing props file (#2426)

Automate dynamic roles migration for missing props file

- In case commands.properties file is missing, enables dynamic roles.
- Adds a new -D or --default flag to migrate-dynamicroles.py script
  to simply update the global setting and use the default role-rule
  permissions.
- Add warning message, ask admins to move to dynamic roles during upgrade

Signed-off-by: Rohit Yadav 


> Unable to login to ACS after upgrading 4.5 -> 4.11 
> ---
>
> Key: CLOUDSTACK-10236
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10236
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
>Reporter: Boris Stoyanov
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> I've upgraded my CentOS6 env from 4.5 to 4.11 and ended up not being able to 
> login. I'm getting 'Session expired' message right after I enter my admin 
> username and password. Here's the management log output: 
>  
> {code:java}
> 2018-01-17 13:07:47,383 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Attempting to log in user: 
> admin in domain 1
> 2018-01-17 13:07:47,389 DEBUG [o.a.c.s.a.PBKDF2UserAuthenticator] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Retrieving user: admin
> 2018-01-17 13:07:48,248 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) CIDRs from which account 
> 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed to perform API 
> calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,249 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) User: admin in domain 1 has 
> successfully logged in
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Current user logged in under 
> UTC timezone
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Timezone offset from UTC is: 
> 0.0
> 2018-01-17 13:07:48,267 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) ===END=== 10.1.0.1 – POST
> 2018-01-17 13:07:48,340 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282) (logid:b98a9144) ===START=== 10.1.0.1 – GET 
> command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,349 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,372 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) ===END=== 
> 10.1.0.1 – GET command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,439 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0) (logid:67992211) ===START=== 10.1.0.1 – GET 
> command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,449 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,474 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) ===END=== 
> 10.1.0.1 – GET command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,549 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f) (logid:f73a6f0c) ===START=== 10.1.0.1 – GET 
> command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,556 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,579 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) ===END=== 
> 10.1.0.1 – GET command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,645 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-560f926e) (logid:62a5cb2f) ===START=== 10.1.0.1 – GET 
> command=quotaIsEnabled=json&_=1516194514343
> 2018-01-17 13:07:48,653 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-560f926e ctx-c9a2914a) 

[jira] [Commented] (CLOUDSTACK-10236) Unable to login to ACS after upgrading 4.5 -> 4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337473#comment-16337473
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10236:
-

rhtyd closed pull request #2426: CLOUDSTACK-10236: Enable dynamic roles for 
missing props file
URL: https://github.com/apache/cloudstack/pull/2426
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java 
b/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
index 53c2340665f..20294d16518 100644
--- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
+++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
@@ -31,6 +31,7 @@
 import org.apache.log4j.Logger;
 
 import com.cloud.hypervisor.Hypervisor;
+import com.cloud.utils.PropertiesUtil;
 import com.cloud.utils.exception.CloudRuntimeException;
 
 public class Upgrade41000to41100 implements DbUpgrade {
@@ -65,10 +66,27 @@ public boolean supportsRollingUpgrade() {
 
 @Override
 public void performDataMigration(Connection conn) {
+checkAndEnableDynamicRoles(conn);
 validateUserDataInBase64(conn);
 updateSystemVmTemplates(conn);
 }
 
+private void checkAndEnableDynamicRoles(final Connection conn) {
+final Map apiMap = 
PropertiesUtil.processConfigFile(new String[] { "commands.properties" });
+if (apiMap == null || apiMap.isEmpty()) {
+if (LOG.isDebugEnabled()) {
+LOG.debug("No commands.properties file was found, enabling 
dynamic roles by setting dynamic.apichecker.enabled to true if not already 
enabled.");
+}
+try (final PreparedStatement updateStatement = 
conn.prepareStatement("INSERT INTO cloud.configuration (category, instance, 
name, default_value, value) VALUES ('Advanced', 'DEFAULT', 
'dynamic.apichecker.enabled', 'false', 'true') ON DUPLICATE KEY UPDATE 
value='true'")) {
+updateStatement.executeUpdate();
+} catch (SQLException e) {
+LOG.error("Failed to set dynamic.apichecker.enabled to true, 
please run migrate-dynamicroles.py script to manually migrate to dynamic 
roles.", e);
+}
+} else {
+LOG.warn("Old commands.properties static checker is deprecated, 
please use migrate-dynamicroles.py to migrate to dynamic roles. Refer 
http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/accounts.html#using-dynamic-roles;);
+}
+}
+
 private void validateUserDataInBase64(Connection conn) {
 try (final PreparedStatement selectStatement = 
conn.prepareStatement("SELECT `id`, `user_data` FROM `cloud`.`user_vm` WHERE 
`user_data` IS NOT NULL;");
  final ResultSet selectResultSet = selectStatement.executeQuery()) 
{
diff --git 
a/plugins/acl/static-role-based/src/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java
 
b/plugins/acl/static-role-based/src/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java
index fc78268fc62..f3dc3a3b8d7 100644
--- 
a/plugins/acl/static-role-based/src/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java
+++ 
b/plugins/acl/static-role-based/src/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java
@@ -39,6 +39,7 @@
 
 // This is the default API access checker that grab's the user's account
 // based on the account type, access is granted
+@Deprecated
 public class StaticRoleBasedAPIAccessChecker extends AdapterBase implements 
APIChecker {
 
 protected static final Logger LOGGER = 
Logger.getLogger(StaticRoleBasedAPIAccessChecker.class);
diff --git a/scripts/util/migrate-dynamicroles.py 
b/scripts/util/migrate-dynamicroles.py
index cbb83f91783..35dfe662513 100755
--- a/scripts/util/migrate-dynamicroles.py
+++ b/scripts/util/migrate-dynamicroles.py
@@ -55,6 +55,14 @@ def migrateApiRolePermissions(apis, conn):
 if (octetKey[role] & int(apis[api])) > 0:
 runSql(conn, "INSERT INTO `cloud`.`role_permissions` (`uuid`, 
`role_id`, `rule`, `permission`, `sort_order`) values (UUID(), %d, '%s', 
'ALLOW', %d);" % (role, api, sortOrder))
 sortOrder += 1
+print("Static role permissions from commands.properties have been migrated 
into the db")
+
+
+def enableDynamicApiChecker(conn):
+runSql(conn, "UPDATE `cloud`.`configuration` SET value='true' where 
name='dynamic.apichecker.enabled'")
+conn.commit()
+conn.close()
+print("Dynamic role based API checker has been enabled!")
 
 
 def main():
@@ -71,6 +79,8 @@ def main():
 help="Host or IP of the MySQL server")
 

[jira] [Commented] (CLOUDSTACK-10236) Unable to login to ACS after upgrading 4.5 -> 4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337472#comment-16337472
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10236:
-

rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for 
missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360111511
 
 
   Thanks, merging this based on code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to login to ACS after upgrading 4.5 -> 4.11 
> ---
>
> Key: CLOUDSTACK-10236
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10236
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
>Reporter: Boris Stoyanov
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> I've upgraded my CentOS6 env from 4.5 to 4.11 and ended up not being able to 
> login. I'm getting 'Session expired' message right after I enter my admin 
> username and password. Here's the management log output: 
>  
> {code:java}
> 2018-01-17 13:07:47,383 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Attempting to log in user: 
> admin in domain 1
> 2018-01-17 13:07:47,389 DEBUG [o.a.c.s.a.PBKDF2UserAuthenticator] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Retrieving user: admin
> 2018-01-17 13:07:48,248 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) CIDRs from which account 
> 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed to perform API 
> calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,249 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) User: admin in domain 1 has 
> successfully logged in
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Current user logged in under 
> UTC timezone
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Timezone offset from UTC is: 
> 0.0
> 2018-01-17 13:07:48,267 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) ===END=== 10.1.0.1 – POST
> 2018-01-17 13:07:48,340 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282) (logid:b98a9144) ===START=== 10.1.0.1 – GET 
> command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,349 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,372 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) ===END=== 
> 10.1.0.1 – GET command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,439 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0) (logid:67992211) ===START=== 10.1.0.1 – GET 
> command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,449 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,474 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) ===END=== 
> 10.1.0.1 – GET command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,549 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f) (logid:f73a6f0c) ===START=== 10.1.0.1 – GET 
> command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,556 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,579 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) ===END=== 
> 10.1.0.1 – GET command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,645 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-560f926e) (logid:62a5cb2f) ===START=== 10.1.0.1 – GET 
> command=quotaIsEnabled=json&_=1516194514343
> 2018-01-17 13:07:48,653 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-560f926e ctx-c9a2914a) (logid:62a5cb2f) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 

[jira] [Commented] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[Daan Hoogland (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337438#comment-16337438
 ] 

Daan Hoogland commented on CLOUDSTACK-10239:


[~jean-francois.nadeau] can you share relevant logs and preferably stack traces?

> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337435#comment-16337435
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on a change in pull request #2425: [CLOUDSTACK-10240] 
ACS cannot migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#discussion_r163481172
 
 

 ##
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
 ##
 @@ -29,14 +29,14 @@
 import org.apache.cloudstack.api.response.ListResponse;
 import org.apache.cloudstack.api.response.StoragePoolResponse;
 import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.log4j.Logger;
 
 import com.cloud.storage.StoragePool;
 import com.cloud.utils.Pair;
 
-@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class,
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class, requestHasSensitiveInfo = false, 
responseHasSensitiveInfo = false)
 public class FindStoragePoolsForMigrationCmd extends BaseListCmd {
-public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmd.class.getName());
+public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmdTest.class.getName());
 
 Review comment:
   this is not the test class!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (CLOUDSTACK-10239) User LDAP authentication not working in UI (but works via API)

[Daan Hoogland (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daan Hoogland reassigned CLOUDSTACK-10239:
--

Assignee: Daan Hoogland

> User LDAP authentication not working in UI (but works via API)
> --
>
> Key: CLOUDSTACK-10239
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10239
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
> Environment: CentOS 7, KVM, MSAD
>Reporter: Jean-Francois Nadeau
>Assignee: Daan Hoogland
>Priority: Major
>
> hi,
> I setup LDAP authentication with the microsoft AD ldap provider and get 
> different behaviors in the UI vs using the API (cs python cli)
> Through the UI,  I can see the list of our AD users using the "Add ldap 
> account" action but selecting a user and adding it returns there are no 
> username by that name:
> INFO  [c.c.a.ApiServer] (qtp510113906-20:ctx-e32d5ff4 ctx-c3c50b46) 
> (logid:89c8c538) No LDAP user exists with the username of 
>  
> Doing the same thing from though CLI works fine:
> $ cs ldapCreateAccount username=markp accounttype=1 account=admin
>  ...
> {
>  "account": "admin", 
>  "accountid": "0683fdb0-fbae-11e7-9574-96a9f76bb706", 
>  "accounttype": 1, 
>  "created": "2018-01-18T19:21:31+", 
>  "domain": "ROOT", 
>  "domainid": "d9bbe213-fbad-11e7-9574-96a9f76bb706", 
> "firstname": "Mark", 
>  "id": "5ed90ce8-5c54-4f72-8579-639947f5c368", 
>  "iscallerchilddomain": false, 
>  "isdefault": false, 
>  "lastname": "p", 
>  "roleid": "f8a368af-fbad-11e7-9574-96a9f76bb706", 
>  "rolename": "Root Admin", 
>  "roletype": "Admin", 
>  "state": "enabled", 
>  "username": "markp", 
>  "usersource": "ldap"
>  }
>  
> Also,  once this user is added,  he can not login in the UI using his LDAP 
> credentials with the same error in the ms logs.  Then,  if i generate keys 
> for that same admin user,  he can use the API without problems.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[Frank Maximus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Maximus updated CLOUDSTACK-10255:
---
Description: 
In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was used.
The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
filtered though, so the file ends up on the host, still containting the 
ReplaceToken.

{noformat:title=KVM Host}You have new mail in /var/spool/mail/root
[root@frank-acs-master ~]# mail
Heirloom Mail version 12.5 7/5/10.  Type ? for help.
"/var/spool/mail/root": 7 messages 7 new
>N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
>'cron.daily' on frank-acs-master"
 N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
& 7
Message  7:
>From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
Return-Path: 
X-Original-To: root
Delivered-To: root@frank-acs-master.localdomain
From: Anacron 
To: root@frank-acs-master.localdomain
Content-Type: text/plain; charset="UTF-8"
Subject: Anacron job 'cron.daily' on frank-acs-master
Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
Status: R

/etc/cron.daily/logrotate:

error: cloudstack-agent:18 lines must begin with a keyword or a filename 
(possibly in double quotes)

& q

[root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
# Licensed to the Apache Software Foundation (ASF) under  the License.

@AGENTLOG@
/var/log/cloudstack/agent/security_group.log
{
copytruncate
daily
rotate 5
compress
missingok
}

{noformat}

  was:
In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was used.
The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
filtered though, so the file ends up on the host, still containting the 
ReplaceToken.

{noformat:title=KVM Host}You have new mail in /var/spool/mail/root
[root@frank-acs-master ~]# mail
Heirloom Mail version 12.5 7/5/10.  Type ? for help.
"/var/spool/mail/root": 7 messages 7 new
>N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
>'cron.daily' on frank-acs-master"
 N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
& 7
Message  7:
>From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
Return-Path: 
X-Original-To: root
Delivered-To: root@frank-acs-master.localdomain
From: Anacron 
To: root@frank-acs-master.localdomain
Content-Type: text/plain; charset="UTF-8"
Subject: Anacron job 'cron.daily' on frank-acs-master
Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
Status: R

/etc/cron.daily/logrotate:

error: cloudstack-agent:18 lines must begin with a keyword or a filename 
(possibly in double quotes)
{noformat}


> cloudstack-agent logrotate is broken
> 
>
> Key: CLOUDSTACK-10255
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>Reporter: Frank Maximus
>Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM 

[jira] [Commented] (CLOUDSTACK-10134) Performance improvement for applying port forwarding rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337407#comment-16337407
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10134:
-

blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of 
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360097926
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Performance improvement for applying port forwarding rules
> --
>
> Key: CLOUDSTACK-10134
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10134
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: subhash yedugundla
>Priority: Major
>
> Repro Steps
> Step to reproduce: 
> 1. Allocate ip address 
> 2. Add PortForwarding rule to the IP address repeatedly 
> 3. Check the time that setting takes
> Time for each rules goes up for every new rule that gets added. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10134) Performance improvement for applying port forwarding rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337403#comment-16337403
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10134:
-

DaanHoogland commented on issue #2311: CLOUDSTACK-10134 Optimization of 
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360097683
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Performance improvement for applying port forwarding rules
> --
>
> Key: CLOUDSTACK-10134
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10134
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: subhash yedugundla
>Priority: Major
>
> Repro Steps
> Step to reproduce: 
> 1. Allocate ip address 
> 2. Add PortForwarding rule to the IP address repeatedly 
> 3. Check the time that setting takes
> Time for each rules goes up for every new rule that gets added. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken

[Frank Maximus (JIRA)]

Frank Maximus created CLOUDSTACK-10255:
--

 Summary: cloudstack-agent logrotate is broken
 Key: CLOUDSTACK-10255
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: cloudstack-agent
Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
Reporter: Frank Maximus


In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was used.
The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
filtered though, so the file ends up on the host, still containting the 
ReplaceToken.

{noformat:title=KVM Host}You have new mail in /var/spool/mail/root
[root@frank-acs-master ~]# mail
Heirloom Mail version 12.5 7/5/10.  Type ? for help.
"/var/spool/mail/root": 7 messages 7 new
>N  1 Anacron   Thu Jan 18 15:36  17/727   "Anacron job 
>'cron.daily' on frank-acs-master"
 N  2 Anacron   Fri Jan 19 03:50  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  3 Anacron   Sat Jan 20 03:30  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  4 Anacron   Sun Jan 21 03:25  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  5 Anacron   Mon Jan 22 03:39  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  6 Anacron   Tue Jan 23 03:10  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  7 Anacron   Wed Jan 24 03:23  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
& 7
Message  7:
>From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
Return-Path: 
X-Original-To: root
Delivered-To: root@frank-acs-master.localdomain
From: Anacron 
To: root@frank-acs-master.localdomain
Content-Type: text/plain; charset="UTF-8"
Subject: Anacron job 'cron.daily' on frank-acs-master
Date: Wed, 24 Jan 2018 03:23:03 + (UTC)
Status: R

/etc/cron.daily/logrotate:

error: cloudstack-agent:18 lines must begin with a keyword or a filename 
(possibly in double quotes)
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337385#comment-16337385
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

greut commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360094250
 
 
   :+1:
   
   @marcaurele which is already the case for any result obtained within a 
`queryAsyncJobResult`. This change only affects the non-async calls.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337357#comment-16337357
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

marcaurele commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360091310
 
 
   It changes the JSON output from: 
   ```json
   {"success": "true"}
   ```
   to 
   ```json
   {"success": true}
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10254) Require checkstyle to verify package names against directory structure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337323#comment-16337323
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10254:
-

marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package 
name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-360086212
 
 
   Having a hard time try to make checkstyle to skip `generated-sources` 
directories (first encounter is in `plugins/network-elements/brocade-vcs` 
project). If anyone has a clue on what is the correct syntax, I'll appreciate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Require checkstyle to verify package names against directory structure
> --
>
> Key: CLOUDSTACK-10254
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10254
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Major
>
> Enforce a new rule for checkstyle to verify that the java file location and 
> its package name match.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10236) Unable to login to ACS after upgrading 4.5 -> 4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337307#comment-16337307
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10236:
-

rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for 
missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360082799
 
 
   We've enough code review and test results. I'll wait for @borisstoyanov 's 
test results, then we may merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to login to ACS after upgrading 4.5 -> 4.11 
> ---
>
> Key: CLOUDSTACK-10236
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10236
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
>Reporter: Boris Stoyanov
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> I've upgraded my CentOS6 env from 4.5 to 4.11 and ended up not being able to 
> login. I'm getting 'Session expired' message right after I enter my admin 
> username and password. Here's the management log output: 
>  
> {code:java}
> 2018-01-17 13:07:47,383 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Attempting to log in user: 
> admin in domain 1
> 2018-01-17 13:07:47,389 DEBUG [o.a.c.s.a.PBKDF2UserAuthenticator] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Retrieving user: admin
> 2018-01-17 13:07:48,248 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) CIDRs from which account 
> 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed to perform API 
> calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,249 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) User: admin in domain 1 has 
> successfully logged in
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Current user logged in under 
> UTC timezone
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Timezone offset from UTC is: 
> 0.0
> 2018-01-17 13:07:48,267 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) ===END=== 10.1.0.1 – POST
> 2018-01-17 13:07:48,340 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282) (logid:b98a9144) ===START=== 10.1.0.1 – GET 
> command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,349 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,372 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) ===END=== 
> 10.1.0.1 – GET command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,439 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0) (logid:67992211) ===START=== 10.1.0.1 – GET 
> command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,449 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,474 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) ===END=== 
> 10.1.0.1 – GET command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,549 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f) (logid:f73a6f0c) ===START=== 10.1.0.1 – GET 
> command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,556 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,579 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) ===END=== 
> 10.1.0.1 – GET command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,645 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-560f926e) (logid:62a5cb2f) ===START=== 10.1.0.1 – GET 
> command=quotaIsEnabled=json&_=1516194514343
> 2018-01-17 13:07:48,653 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-560f926e ctx-c9a2914a) (logid:62a5cb2f) CIDRs from 
> which account 

[jira] [Commented] (CLOUDSTACK-10236) Unable to login to ACS after upgrading 4.5 -> 4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337309#comment-16337309
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10236:
-

rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for 
missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360082799
 
 
   We've enough code review and test results LGTM. I'll wait for @borisstoyanov 
's test results, then we may merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to login to ACS after upgrading 4.5 -> 4.11 
> ---
>
> Key: CLOUDSTACK-10236
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10236
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
>Reporter: Boris Stoyanov
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> I've upgraded my CentOS6 env from 4.5 to 4.11 and ended up not being able to 
> login. I'm getting 'Session expired' message right after I enter my admin 
> username and password. Here's the management log output: 
>  
> {code:java}
> 2018-01-17 13:07:47,383 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Attempting to log in user: 
> admin in domain 1
> 2018-01-17 13:07:47,389 DEBUG [o.a.c.s.a.PBKDF2UserAuthenticator] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Retrieving user: admin
> 2018-01-17 13:07:48,248 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) CIDRs from which account 
> 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed to perform API 
> calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,249 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) User: admin in domain 1 has 
> successfully logged in
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Current user logged in under 
> UTC timezone
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Timezone offset from UTC is: 
> 0.0
> 2018-01-17 13:07:48,267 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) ===END=== 10.1.0.1 – POST
> 2018-01-17 13:07:48,340 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282) (logid:b98a9144) ===START=== 10.1.0.1 – GET 
> command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,349 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,372 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) ===END=== 
> 10.1.0.1 – GET command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,439 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0) (logid:67992211) ===START=== 10.1.0.1 – GET 
> command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,449 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,474 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) ===END=== 
> 10.1.0.1 – GET command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,549 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f) (logid:f73a6f0c) ===START=== 10.1.0.1 – GET 
> command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,556 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,579 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) ===END=== 
> 10.1.0.1 – GET command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,645 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-560f926e) (logid:62a5cb2f) ===START=== 10.1.0.1 – GET 
> command=quotaIsEnabled=json&_=1516194514343
> 2018-01-17 13:07:48,653 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-560f926e ctx-c9a2914a) (logid:62a5cb2f) CIDRs from 
> which account 

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337304#comment-16337304
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

rhtyd commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on 
restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360082506
 
 
   Thanks, merging this based on code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337306#comment-16337306
 ] 

ASF subversion and git services commented on CLOUDSTACK-10252:
--

Commit 61a5a297058ce4478766b36d640f76684e31b9c8 in cloudstack's branch 
refs/heads/4.11 from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=61a5a29 ]

CLOUDSTACK-10252: Delete dnsmasq leases file on restart (#2427)

Delete dnsmasq's leases file when dnsmasq is restarted to avoid it
use old ip-mac-address-vm mapping leases.

Signed-off-by: Rohit Yadav 

> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337305#comment-16337305
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

rhtyd closed pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases file 
on restart
URL: https://github.com/apache/cloudstack/pull/2427
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py 
b/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
index 7aac837cf1b..30fb38e016a 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
@@ -49,15 +49,21 @@ def process(self):
 self.add(self.dbag[item])
 self.write_hosts()
 
-if self.cloud.is_changed():
-self.delete_leases()
-
 self.configure_server()
 
-restart_dnsmasq = self.conf.commit()
-self.cloud.commit()
+restart_dnsmasq = False
+
+if self.conf.commit():
+restart_dnsmasq = True
+
+if self.cloud.commit():
+restart_dnsmasq = True
+
 self.dhcp_opts.commit()
 
+if restart_dnsmasq:
+self.delete_leases()
+
 if not self.cl.is_redundant() or self.cl.is_master():
 if restart_dnsmasq:
 CsHelper.service("dnsmasq", "restart")


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337291#comment-16337291
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

resmo commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on 
restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360077587
 
 
   sounds like a plan. 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337195#comment-16337195
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360072397
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337194#comment-16337194
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

borisstoyanov commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360072178
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337189#comment-16337189
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

blueorangutan commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360070309
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1678


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10134) Performance improvement for applying port forwarding rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337182#comment-16337182
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10134:
-

blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of 
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360067983
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1677


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Performance improvement for applying port forwarding rules
> --
>
> Key: CLOUDSTACK-10134
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10134
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: subhash yedugundla
>Priority: Major
>
> Repro Steps
> Step to reproduce: 
> 1. Allocate ip address 
> 2. Add PortForwarding rule to the IP address repeatedly 
> 3. Check the time that setting takes
> Time for each rules goes up for every new rule that gets added. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337179#comment-16337179
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

DaanHoogland commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases 
file on restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360067539
 
 
   Yes, well that bit of code does dnsmasq's job. I think we should merge this 
and then find a way to call a release on a single lease by mac or ip.
   
   LGTM ^^


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337172#comment-16337172
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360066328
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1676


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337169#comment-16337169
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

resmo commented on a change in pull request #2427: CLOUDSTACK-10252: Delete 
dnsmasq leases file on restart
URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163486340
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
 ##
 @@ -49,15 +49,21 @@ def process(self):
 self.add(self.dbag[item])
 self.write_hosts()
 
-if self.cloud.is_changed():
-self.delete_leases()
-
 self.configure_server()
 
-restart_dnsmasq = self.conf.commit()
-self.cloud.commit()
+restart_dnsmasq = False
+
+if self.conf.commit():
+restart_dnsmasq = True
+
+if self.cloud.commit():
 
 Review comment:
   I missed that. never mind.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337163#comment-16337163
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

rhtyd commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on 
restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360063571
 
 
   @DaanHoogland that's right, the aim of the PR was scoped only to fix the 
blocker. Perhaps for 4.11.1+ we can aim to improve changing the leases file 
instead of removing it, how it used to be done before it was removed:
   
https://github.com/apache/cloudstack/commit/73c0242df355a29ff3134f6288a63dd3f1df#diff-3ab4e2009108bf42111df9efc71f0f03R98


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10236) Unable to login to ACS after upgrading 4.5 -> 4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337152#comment-16337152
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10236:
-

borisstoyanov commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles 
for missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360060946
 
 
   Yes, I'm on it @rhtyd 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to login to ACS after upgrading 4.5 -> 4.11 
> ---
>
> Key: CLOUDSTACK-10236
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10236
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
>Reporter: Boris Stoyanov
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> I've upgraded my CentOS6 env from 4.5 to 4.11 and ended up not being able to 
> login. I'm getting 'Session expired' message right after I enter my admin 
> username and password. Here's the management log output: 
>  
> {code:java}
> 2018-01-17 13:07:47,383 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Attempting to log in user: 
> admin in domain 1
> 2018-01-17 13:07:47,389 DEBUG [o.a.c.s.a.PBKDF2UserAuthenticator] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Retrieving user: admin
> 2018-01-17 13:07:48,248 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) CIDRs from which account 
> 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed to perform API 
> calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,249 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) User: admin in domain 1 has 
> successfully logged in
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Current user logged in under 
> UTC timezone
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Timezone offset from UTC is: 
> 0.0
> 2018-01-17 13:07:48,267 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) ===END=== 10.1.0.1 – POST
> 2018-01-17 13:07:48,340 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282) (logid:b98a9144) ===START=== 10.1.0.1 – GET 
> command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,349 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,372 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) ===END=== 
> 10.1.0.1 – GET command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,439 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0) (logid:67992211) ===START=== 10.1.0.1 – GET 
> command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,449 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,474 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) ===END=== 
> 10.1.0.1 – GET command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,549 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f) (logid:f73a6f0c) ===START=== 10.1.0.1 – GET 
> command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,556 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,579 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) ===END=== 
> 10.1.0.1 – GET command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,645 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-560f926e) (logid:62a5cb2f) ===START=== 10.1.0.1 – GET 
> command=quotaIsEnabled=json&_=1516194514343
> 2018-01-17 13:07:48,653 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-560f926e ctx-c9a2914a) (logid:62a5cb2f) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337149#comment-16337149
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

DaanHoogland commented on a change in pull request #2427: CLOUDSTACK-10252: 
Delete dnsmasq leases file on restart
URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163482774
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
 ##
 @@ -49,15 +49,21 @@ def process(self):
 self.add(self.dbag[item])
 self.write_hosts()
 
-if self.cloud.is_changed():
-self.delete_leases()
-
 self.configure_server()
 
-restart_dnsmasq = self.conf.commit()
-self.cloud.commit()
+restart_dnsmasq = False
+
+if self.conf.commit():
+restart_dnsmasq = True
+
+if self.cloud.commit():
 
 Review comment:
   I see conf.commit and cloud.commit. Those are two different objects, @resmo 
. How is this suspect?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10236) Unable to login to ACS after upgrading 4.5 -> 4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337148#comment-16337148
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10236:
-

rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for 
missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360060400
 
 
   @borisstoyanov can you help with upgrade related testing?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to login to ACS after upgrading 4.5 -> 4.11 
> ---
>
> Key: CLOUDSTACK-10236
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10236
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.11.0.0
>Reporter: Boris Stoyanov
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> I've upgraded my CentOS6 env from 4.5 to 4.11 and ended up not being able to 
> login. I'm getting 'Session expired' message right after I enter my admin 
> username and password. Here's the management log output: 
>  
> {code:java}
> 2018-01-17 13:07:47,383 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Attempting to log in user: 
> admin in domain 1
> 2018-01-17 13:07:47,389 DEBUG [o.a.c.s.a.PBKDF2UserAuthenticator] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Retrieving user: admin
> 2018-01-17 13:07:48,248 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) CIDRs from which account 
> 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed to perform API 
> calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,249 DEBUG [c.c.u.AccountManagerImpl] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) User: admin in domain 1 has 
> successfully logged in
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Current user logged in under 
> UTC timezone
> 2018-01-17 13:07:48,260 INFO [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) Timezone offset from UTC is: 
> 0.0
> 2018-01-17 13:07:48,267 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-404c4037) (logid:2d1dd5ba) ===END=== 10.1.0.1 – POST
> 2018-01-17 13:07:48,340 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282) (logid:b98a9144) ===START=== 10.1.0.1 – GET 
> command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,349 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,372 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-390d3282 ctx-0509900f) (logid:b98a9144) ===END=== 
> 10.1.0.1 – GET command=listCapabilities=json&_=1516194514030
> 2018-01-17 13:07:48,439 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0) (logid:67992211) ===START=== 10.1.0.1 – GET 
> command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,449 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,474 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-495f6fd0 ctx-606dcc84) (logid:67992211) ===END=== 
> 10.1.0.1 – GET command=listZones=json&_=1516194514137
> 2018-01-17 13:07:48,549 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f) (logid:f73a6f0c) ===START=== 10.1.0.1 – GET 
> command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,556 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 0.0.0.0/0,::/0
> 2018-01-17 13:07:48,579 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-16:ctx-f2bcf13f ctx-3e6a3a41) (logid:f73a6f0c) ===END=== 
> 10.1.0.1 – GET command=cloudianIsEnabled=json&_=1516194514249
> 2018-01-17 13:07:48,645 DEBUG [c.c.a.ApiServlet] 
> (qtp1310540333-19:ctx-560f926e) (logid:62a5cb2f) ===START=== 10.1.0.1 – GET 
> command=quotaIsEnabled=json&_=1516194514343
> 2018-01-17 13:07:48,653 DEBUG [c.c.a.ApiServer] 
> (qtp1310540333-19:ctx-560f926e ctx-c9a2914a) (logid:62a5cb2f) CIDRs from 
> which account 'Acct[3daa963c-fb6a-11e7-ae7e-06efa8010701-admin]' is allowed 
> to perform API calls: 

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337147#comment-16337147
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

blueorangutan commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360060204
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10253) JSON response returns boolean as string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337146#comment-16337146
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10253:
-

rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360059991
 
 
   This may cause upgrade API compatibility regressions if response is string 
than boolean (json type), we'll need to test that.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JSON response returns boolean as string
> ---
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a 
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10134) Performance improvement for applying port forwarding rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337144#comment-16337144
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10134:
-

blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of 
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360059686
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Performance improvement for applying port forwarding rules
> --
>
> Key: CLOUDSTACK-10134
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10134
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: subhash yedugundla
>Priority: Major
>
> Repro Steps
> Step to reproduce: 
> 1. Allocate ip address 
> 2. Add PortForwarding rule to the IP address repeatedly 
> 3. Check the time that setting takes
> Time for each rules goes up for every new rule that gets added. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10134) Performance improvement for applying port forwarding rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337143#comment-16337143
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10134:
-

DaanHoogland commented on issue #2311: CLOUDSTACK-10134 Optimization of 
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360059649
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Performance improvement for applying port forwarding rules
> --
>
> Key: CLOUDSTACK-10134
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10134
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: subhash yedugundla
>Priority: Major
>
> Repro Steps
> Step to reproduce: 
> 1. Allocate ip address 
> 2. Add PortForwarding rule to the IP address repeatedly 
> 3. Check the time that setting takes
> Time for each rules goes up for every new rule that gets added. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337131#comment-16337131
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

DaanHoogland commented on a change in pull request #2423: CLOUDSTACK-10250: 
Reinstall VM from bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#discussion_r163480756
 
 

 ##
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##
 @@ -6100,9 +6101,18 @@ public UserVm restoreVMInternal(Account caller, 
UserVmVO vm, Long newTemplateId)
 throw ex;
 }
 }
-TemplateDataStoreVO tmplStore = 
_templateStoreDao.findByTemplateZoneReady(template.getId(), 
vm.getDataCenterId());
-if (tmplStore == null) {
-throw new InvalidParameterValueException("Cannot restore the 
vm as the template " + template.getUuid() + " isn't available in the zone");
+
+TemplateDataStoreVO tmplStore;
 
 Review comment:
   please, extract this bit as a separate private method, i.e. 
checkRestorePossible().


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337129#comment-16337129
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

borisstoyanov commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360057388
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337130#comment-16337130
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360057528
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337128#comment-16337128
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10251:
-

blueorangutan commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for 
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360057311
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337127#comment-16337127
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10251:
-

borisstoyanov commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for 
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360057276
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337126#comment-16337126
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10251:
-

blueorangutan commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for 
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360057153
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1675


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10247) L2 network not shared on projects

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337125#comment-16337125
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10247:
-

DaanHoogland commented on a change in pull request #2420: CLOUDSTACK-10247: L2 
network not shared on projects
URL: https://github.com/apache/cloudstack/pull/2420#discussion_r163479947
 
 

 ##
 File path: server/src/com/cloud/network/NetworkModelImpl.java
 ##
 @@ -1637,7 +1637,8 @@ public void checkNetworkPermissions(Account owner, 
Network network) {
 throw new CloudRuntimeException("cannot check permissions on 
(Network) ");
 }
 // Perform account permission check
-if (network.getGuestType() != Network.GuestType.Shared || 
(network.getGuestType() == Network.GuestType.Shared && network.getAclType() == 
ACLType.Account)) {
+if ((network.getGuestType() != Network.GuestType.Shared && 
network.getGuestType() != GuestType.L2) ||
 
 Review comment:
   Network.GuestType.Shared is used and then GuestType.L2 directly. please 
cleanup the imports and use only one scope for one java class.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> L2 network not shared on projects
> -
>
> Key: CLOUDSTACK-10247
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10247
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> L2 networks are not shared between projects. When trying to deploy a vm 
> assigning a project id, error is logged:
> 2018-01-18 09:04:31,749 INFO  [c.c.a.ApiServer] 
> (qtp1310540333-17:ctx-7ff91c56 ctx-8c37c46b ctx-d58064ad) (logid:74e86028) 
> PermissionDenied: Unable to use network with id= 
> 5bee486a-ff20-4db2-b62e-4b4f3485cfff, permission denied on objs: []



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10128) Template from snapshot not merging vhd files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337118#comment-16337118
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10128:
-

DaanHoogland commented on issue #2402: [CLOUDSTACK-10128] Simplify the search 
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-360055719
 
 
   @rafaelweingartner no extra PR please, we will merge forward 4.11 after 
merge of any fixes


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Template from snapshot not merging vhd files
> 
>
> Key: CLOUDSTACK-10128
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10128
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.10.0.0, 4.9.2.0, 4.5.2.2, 4.9.3.0
> Environment: Production environment running ACS 4.5.2.2, 4.9.2.0, 
> 4.9.3.0
> XenServer 6.5
> Primary Storage NFS and ISCSI
> Fresh install running 4.5.2.2, 4.9.2.0, 4.9.3.0 and 4.10
>Reporter: Marcelo Lima
>Assignee: Rafael Weingärtner
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> If we have two or more snapshots of a ROOT disk and try to create a template 
> from differencial snapshots, CloudStack not merging the vhd files on 
> secondary storage.
> Steps to reproduce
> 1. Create virtual machine - OK
> 2. Create a manual snapshot from ROOT volume - OK
> The vhd of first snapshot (snapshot-base) is stored on secondary storage 
> correctly
> [root@acs01 6]# ls -l 
> /exports/secondary/snapshots/2/6/011a7650-a13f-4332-8c72-2428a002affc.vhd 
> -rw-r--r-- 1 root root 1767191040 Nov  1 12:12 
> /exports/secondary/snapshots/2/6/011a7650-a13f-4332-8c72-2428a002affc.vhd
> [root@acs01 6]# md5sum 
> /exports/secondary/snapshots/2/6/011a7650-a13f-4332-8c72-2428a002affc.vhd 
> 
> 240e5e424552d44b5d297895b064beee  
> /exports/secondary/snapshots/2/6/011a7650-a13f-4332-8c72-2428a002affc.vhd
> 3. Create a template from snapshot-base - OK
> [root@acs01 6]# ls -l 
> /exports/secondary/template/tmpl/2/206/be3311d9-8e59-4240-968d-73d7a6eecfdd.vhd
>  
> -rw-r--r-- 1 root root 1767191040 Nov  1 12:17 
> /exports/secondary/template/tmpl/2/206/be3311d9-8e59-4240-968d-73d7a6eecfdd.vhd
> [root@acs01 6]# md5sum 
> /exports/secondary/template/tmpl/2/206/be3311d9-8e59-4240-968d-73d7a6eecfdd.vhd
>   
> 240e5e424552d44b5d297895b064beee  
> /exports/secondary/template/tmpl/2/206/be3311d9-8e59-4240-968d-73d7a6eecfdd.vhd
> This template from snapshot-base boot normally
> 4. Create new file (1GB) on ROOT volume
> 5. Create new snapshot (snapshot-diff) from ROOT volume - OK
> [root@acs01 6]# ls -l /exports/secondary/snapshots/2/6/ 
> total 2840056
> -rw-r--r-- 1 root root 1767191040 Nov  1 12:12 
> 011a7650-a13f-4332-8c72-2428a002affc.vhd <- snapshot-base
> -rw-r--r-- 1 root root 1141019136 Nov  1 12:21 
> 1503adaa-4f6e-4f9c-8d80-68663baa86b8.vhd <- snapshot-diff
> 6. Create a template from second snapshot - NOK
> [root@acs01 6]# ls -lh 
> /exports/secondary/template/tmpl/2/207/4c5c51a1-fcb4-4cc8-8f97-1664a63af262.vhd
>  
> -rw-r--r-- 1 root root 1141019136 Nov  1 12:30 
> /exports/secondary/template/tmpl/2/207/4c5c51a1-fcb4-4cc8-8f97-1664a63af262.vhd
> CloudStack not merging snapshot-base and snapshot-diff. Template from second 
> snapshot is corrupted because is based just on differential vhd.
> Volume from snapshot work very well
> 1. Create a volume from snapshot-diff - OK
> CloudStack merge two snapshots in one file
> [root@acs01 primary]# ls -l 
> /exports/primary/70f1db23-cc59-4ec7-b8d4-ed036228593b.vhd 
> -rw-r--r-- 1 root root 2843030016 Nov  1 12:34 
> /exports/primary/70f1db23-cc59-4ec7-b8d4-ed036228593b.vhd
> 2. Download the new volume to check vhd on secondary storage
> [root@acs01 9]# ls -l 
> /exports/secondary/volumes/2/9/ec6e0f65-bb71-4c91-bac3-287cde2106b7.vhd 
> -rw-r--r-- 1 root root 2843030016 Nov  1 12:35 
> /exports/secondary/volumes/2/9/ec6e0f65-bb71-4c91-bac3-287cde2106b7.vhd
> We test on 4.5.2.2, 4.9.2.0, 4.9.3.0 and 4.10. XenServer 6.5 with SP1 and 
> XenServer 6.5 with all patches.
> A workaround is create a volume (data-disk) from latest snapshot, create new 
> snapshot from data-disk and convert to template.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (CLOUDSTACK-10254) Require checkstyle to verify package names against directory structure

[JIRA]

Marc-Aurèle Brothier created CLOUDSTACK-10254:
-

 Summary: Require checkstyle to verify package names against 
directory structure
 Key: CLOUDSTACK-10254
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10254
 Project: CloudStack
  Issue Type: Improvement
  Security Level: Public (Anyone can view this level - this is the default.)
Reporter: Marc-Aurèle Brothier
Assignee: Marc-Aurèle Brothier


Enforce a new rule for checkstyle to verify that the java file location and its 
package name match.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337114#comment-16337114
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

rhtyd commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on 
restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360054333
 
 
   @resmo the values from json/dictionary are written on commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337113#comment-16337113
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
-

rhtyd commented on a change in pull request #2427: CLOUDSTACK-10252: Delete 
dnsmasq leases file on restart
URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163477509
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
 ##
 @@ -49,15 +49,21 @@ def process(self):
 self.add(self.dbag[item])
 self.write_hosts()
 
-if self.cloud.is_changed():
-self.delete_leases()
-
 self.configure_server()
 
-restart_dnsmasq = self.conf.commit()
-self.cloud.commit()
+restart_dnsmasq = False
+
+if self.conf.commit():
+restart_dnsmasq = True
+
+if self.cloud.commit():
 
 Review comment:
   @resmo The commit is called on two different files, it's the same old code 
refactored differently.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> -
>
> Key: CLOUDSTACK-10252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
> Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (CLOUDSTACK-10253) JSON response returns boolean as string

[JIRA]

Marc-Aurèle Brothier created CLOUDSTACK-10253:
-

 Summary: JSON response returns boolean as string
 Key: CLOUDSTACK-10253
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: API
Reporter: Marc-Aurèle Brothier
Assignee: Marc-Aurèle Brothier


On the SuccessResponse for async call, the boolean value is returned as a 
quoted boolean string:
{noformat}
{"success": "true"}{noformat}
instead of a JSON boolean:
{noformat}
{"success": true{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (CLOUDSTACK-10245) ResetPassword for guestVm in nuage isolated networks is not working, unable to login with new password

[Raf Smeets (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raf Smeets resolved CLOUDSTACK-10245.
-
   Resolution: Fixed
Fix Version/s: 4.12
   4.11.0.0

Merged into 4.11 , will be closed when merged into master.

> ResetPassword for guestVm in nuage isolated networks is not working, unable 
> to login with new password
> --
>
> Key: CLOUDSTACK-10245
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10245
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0, 4.12
>Reporter: Raf Smeets
>Assignee: Frank Maximus
>Priority: Blocker
> Fix For: 4.11.0.0, 4.12
>
>
> ResetPassword functionality for guestVm's in Nuage isolated networks is not 
> working as password_server is not running on VirtualRouter. Unable to login 
> with new password.
> Scenario to reproduce:
>  # Execute ResetPassword on GuestVM
>  # Try to login with new password fails as passwordserver is not running on 
> port 8080 in VR.
> After some further debugging, found that this bug is introduced while fixing 
> CLOUDSTACK-9749 by [https://github.com/apache/cloudstack/pull/2409]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337100#comment-16337100
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10251:
-

blueorangutan commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for 
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360051197
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337099#comment-16337099
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10251:
-

borisstoyanov commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for 
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360051013
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)