[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309276#comment-16309276
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354956980
 
 
   Test LGTM, the new migration test passes as well. I'll merge this based on 
code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309277#comment-16309277
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd closed pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
 
b/api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
index 651fce87fd3..298d9b043e8 100644
--- 
a/api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
@@ -18,12 +18,14 @@
 
 import org.apache.log4j.Logger;
 
+import org.apache.cloudstack.acl.RoleType;
 import org.apache.cloudstack.acl.SecurityChecker.AccessType;
 import org.apache.cloudstack.api.ACL;
 import org.apache.cloudstack.api.APICommand;
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.ApiErrorCode;
 import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
 import org.apache.cloudstack.api.Parameter;
 import org.apache.cloudstack.api.ResponseObject.ResponseView;
 import org.apache.cloudstack.api.ServerApiException;
@@ -38,12 +40,18 @@
 import com.cloud.user.Account;
 import com.cloud.user.User;
 
-@APICommand(name = "migrateNetwork", description = "moves a network to another 
physical network", responseObject = NetworkResponse.class, responseView = 
ResponseView.Restricted, entityType = {Network.class},
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = MigrateNetworkCmd.APINAME, description = "moves a network 
to another physical network",
+responseObject = NetworkResponse.class,
+responseView = ResponseView.Restricted,
+entityType = {Network.class},
+requestHasSensitiveInfo = false,
+responseHasSensitiveInfo = false,
+since = "4.11.0",
+authorized = {RoleType.Admin})
 public class MigrateNetworkCmd extends BaseAsyncCmd {
 public static final Logger s_logger = 
Logger.getLogger(MigrateNetworkCmd.class.getName());
 
-private static final String s_name = "migratenetworkresponse";
+public static final String APINAME = "migrateNetwork";
 
 /
  API parameters /
@@ -81,7 +89,7 @@ public Boolean getResume() {
 
 @Override
 public String getCommandName() {
-return s_name;
+return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
 }
 
 @Override
diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java 
b/api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
index 6cf115742a8..a5611c67aa4 100644
--- a/api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
@@ -16,34 +16,44 @@
 // under the License.
 package org.apache.cloudstack.api.command.admin.network;
 
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.RoleType;
 import org.apache.cloudstack.acl.SecurityChecker;
 import org.apache.cloudstack.api.ACL;
 import org.apache.cloudstack.api.APICommand;
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.ApiErrorCode;
 import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
 import org.apache.cloudstack.api.Parameter;
 import org.apache.cloudstack.api.ResponseObject;
 import org.apache.cloudstack.api.ServerApiException;
 import org.apache.cloudstack.api.response.VpcOfferingResponse;
 import org.apache.cloudstack.api.response.VpcResponse;
 import org.apache.cloudstack.context.CallContext;
-import org.apache.log4j.Logger;
-
-import java.util.HashMap;
-import java.util.Map;
 
 import com.cloud.event.EventTypes;
 import com.cloud.network.vpc.Vpc;
 import com.cloud.user.Account;
 import com.cloud.user.User;
 
-@APICommand(name = "migrateVPC", description = "moves a vpc to another 
physical network", responseObject = VpcResponse.class, responseView = 
ResponseObject.ResponseView.Restricted, entityType = {Vpc.class},
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = MigrateVPCCmd.APINAME,
+description = "moves a vpc to another physical network",
+responseObject = VpcResponse.class,
+ 

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308879#comment-16308879
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354902410
 
 
   Trillian test result (tid-1969)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38420 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2374-t1969-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_ssvm_internals | `Failure` | 3.68 | test_ssvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307637#comment-16307637
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354697964
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307638#comment-16307638
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354697983
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307530#comment-16307530
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354669841
 
 
   Trillian test result (tid-1963)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29807 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2374-t1963-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_redundant_VPC_default_routes | `Failure` | 873.09 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 352.15 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 393.01 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307420#comment-16307420
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354647227
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307417#comment-16307417
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354647185
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307414#comment-16307414
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354646866
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1533


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307404#comment-16307404
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354645633
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307403#comment-16307403
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354645605
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305453#comment-16305453
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on a change in pull request #2374: CLOUDSTACK-10024: 
Network Migration: Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#discussion_r158944104
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -419,8 +419,8 @@
 "displaytext": "MySharedOffering",
 "guestiptype": "Shared",
 "supportedservices": "Dhcp,Dns,UserData",
-"specifyVlan": "True",
-"specifyIpRanges": "True",
+"specifyVlan": "False",
 
 Review comment:
   @rhtyd this change is exactly the revert you asked for. I think we shd merge 
in this PR as your comment was legitimate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305377#comment-16305377
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-35422
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1518


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305368#comment-16305368
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

fmaximus commented on a change in pull request #2374: CLOUDSTACK-10024: Network 
Migration: Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#discussion_r158933487
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -419,8 +419,8 @@
 "displaytext": "MySharedOffering",
 "guestiptype": "Shared",
 "supportedservices": "Dhcp,Dns,UserData",
-"specifyVlan": "True",
-"specifyIpRanges": "True",
+"specifyVlan": "False",
 
 Review comment:
   This *is* the revert of test data, done in PR #2259


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305305#comment-16305305
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2374: CLOUDSTACK-10024: Network 
Migration: Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#discussion_r158924899
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -419,8 +419,8 @@
 "displaytext": "MySharedOffering",
 "guestiptype": "Shared",
 "supportedservices": "Dhcp,Dns,UserData",
-"specifyVlan": "True",
-"specifyIpRanges": "True",
+"specifyVlan": "False",
 
 Review comment:
   @fmaximus This test data is in use by several test cases, changing the 
values from 'true' to 'false' may cause regressions. Can you change them back, 
and in your tests perhaps change the value to False if necessary?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305296#comment-16305296
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354265497
 
 
   Thanks @fmaximus Trillian uses it's own test_data. I'll move your test data 
changes to 
https://github.com/shapeblue/Trillian/blob/master/Ansible/roles/marvin/templates/test_data.py.j2
 before running the next test round. It is advisable to include test data with 
the test and leave merging changes to the marvin test_data.
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305297#comment-16305297
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354265566
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303789#comment-16303789
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

fmaximus commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353962013
 
 
   @rhtyd Looking at the Trillian logs, the test fails to pick up the VPC 
offering which was added to test_data.py I double-checked, all test_data keys 
are correct. 
   About Travis, we added code in our tests to make sure to skip the tests if 
the hypervisor is not supported.
   Any preference to where we should add the tests in .travis.yml, not to 
exceed the time limits even more.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303658#comment-16303658
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353942196
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1492


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303540#comment-16303540
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353926876
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303538#comment-16303538
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353926773
 
 
   Additional review requested - @borisstoyanov @nvazquez @DaanHoogland @wido 
@rafaelweingartner @marcaurele and others, thanks.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302754#comment-16302754
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353771623
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1472


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302733#comment-16302733
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353769071
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302732#comment-16302732
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353769047
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302386#comment-16302386
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353723200
 
 
   @fmaximus can you add the new marvin test to Travis (see the .travis.yml 
file) if it is hardware/hypervisor agnostic and also check/fix the failure in 
the last run. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302382#comment-16302382
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353722871
 
 
   Trillian test result (tid-1881)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37876 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2374-t1881-kvm-centos7.zip
   Smoke tests completed. 62 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_native_to_native_vpc_migration | `Error` | 0.74 | test_migration.py
   test_01_vpc_privategw_acl | `Failure` | 77.14 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 239.06 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 244.50 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 486.31 | 
test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
353.11 | test_routers_network_ops.py
   test_02_create_template_with_checksum_sha1 | `Error` | 5.35 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.28 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.25 | 
test_templates.py
   test_05_rvpc_multi_tiers | `Failure` | 341.35 | test_vpc_redundant.py
   test_01_vpc_remote_access_vpn | `Failure` | 91.40 | test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301588#comment-16301588
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353624069
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301587#comment-16301587
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353623802
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301585#comment-16301585
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353623553
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1462


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301558#comment-16301558
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353618966
 
 
   @krissterckx sure, already did. I'll help kick some tests now, first 
building packages.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301555#comment-16301555
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353618459
 
 
   @rhtyd as you already saw/reviewed, this is the requested PR 
   
   (sorry saw above comments too late :))


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301553#comment-16301553
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353618459
 
 
   @rhtyd this is the requested PR - pls review;  open to questions/comments.  
Thanks.
   
   Kris


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301548#comment-16301548
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353617977
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301545#comment-16301545
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353617778
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301533#comment-16301533
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

fmaximus opened a new pull request #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374
 
 
   Tackles review comments given on #2259 after the merge.
   
   Co-Authored-By: Raf Smeets 
   Co-Authored-By: Kris Sterckx 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300188#comment-16300188
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353383102
 
 
   @rhtyd thanks for review; will do.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299958#comment-16299958
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on issue #2259: CLOUDSTACK-10024: Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353341524
 
 
   @sgoeminn @krissterckx @fmaximus  kindly send a new PR to fix additional 
refactorations especially around APIs as they go with the release's apidocs. If 
the new APIs are general purpose, please add new marvin tests.
   
   I also see a new regression/failure in `test_internal_lb.py`, please check. 
Given we're weeks away from 4.11 cut/freezing, please ask additional code 
reviews on features by non-colleagues. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299956#comment-16299956
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158267086
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
 ##
 @@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VpcOfferingResponse;
+import org.apache.cloudstack.api.response.VpcResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import com.cloud.event.EventTypes;
+import com.cloud.network.vpc.Vpc;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateVPC", description = "moves a vpc to another 
physical network", responseObject = VpcResponse.class, responseView = 
ResponseObject.ResponseView.Restricted, entityType = {Vpc.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 
 Review comment:
   The API does no define a `since` as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299955#comment-16299955
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158267056
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
 ##
 @@ -0,0 +1,155 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkOfferingResponse;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.network.Network;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateNetwork", description = "moves a network to another 
physical network", responseObject = NetworkResponse.class, responseView = 
ResponseView.Restricted, entityType = {Network.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 
 Review comment:
   The API does no define a `since` as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299954#comment-16299954
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266821
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -1882,6 +1930,70 @@
 "SourceNat": {"SupportedSourceNatTypes": "perzone"}
 }
 },
+# Persistent services supported by the Nuage VSP plugin for Isolated 
networks
+"isolated_network_offering_persistent": {
+"name": 'nuage_marvin',
+"displaytext": 'nuage_marvin',
+"guestiptype": 'Isolated',
+"supportedservices": 
'Dhcp,SourceNat,Connectivity,StaticNat,UserData,Firewall,Dns',
+"traffictype": 'GUEST',
+"availability": 'Optional',
+"ispersistent": 'True',
+"tags": "nuage",
+"serviceProviderList": {
+"Dhcp": 'NuageVsp',
+"StaticNat": 'NuageVsp',
+"SourceNat": 'NuageVsp',
+"Firewall": 'NuageVsp',
+"Connectivity": 'NuageVsp',
+"UserData": 'VirtualRouter',
+"Dns": 'VirtualRouter'
+},
+"serviceCapabilityList": {
+"SourceNat": {"SupportedSourceNatTypes": "perzone"}
+}
+},
+# Purely nuage network offering
+"isolated_network_offering_without_vr": {
+"name": 'nuage_marvin',
+"displaytext": 'nuage_marvin',
+"guestiptype": 'Isolated',
+"supportedservices": 
'Dhcp,SourceNat,Connectivity,StaticNat,Firewall',
+"traffictype": 'GUEST',
+"availabiliy": 'Optional',
+"tags": "nuage",
+"serviceProviderList": {
+"Dhcp": 'NuageVsp',
+"StaticNat": 'NuageVsp',
+"SourceNat": 'NuageVsp',
+"Firewall": 'NuageVsp',
+"Connectivity": 'NuageVsp'
+},
+"serviceCapabilityList": {
+"SourceNat": {"SupportedSourceNatTypes": "perzone"}
+}
+},
+# Purely persistent nuage network offering
+"isolated_network_offering_without_vr_persistent": {
+"name": 'nuage_marvin',
+"displaytext": 'nuage_marvin',
+"guestiptype": 'Isolated',
+"supportedservices": 
'Dhcp,SourceNat,Connectivity,StaticNat,Firewall',
+"traffictype": 'GUEST',
+"availability": 'Optional',
+"tags": "nuage",
+"ispersistent": 'True',
+"serviceProviderList": {
+"Dhcp": 'NuageVsp',
+"StaticNat": 'NuageVsp',
+"SourceNat": 'NuageVsp',
+"Firewall": 'NuageVsp',
+"Connectivity": 'NuageVsp'
+},
+"serviceCapabilityList": {
+"SourceNat": {"SupportedSourceNatTypes": "perzone"}
+}
+},
 
 Review comment:
   If the test data is specific to Nuage specific marvin tests, these can be 
moved as  `Service` in the tests themselves.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299953#comment-16299953
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266701
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -387,9 +407,10 @@
 "displaytext": "MySharedOffering",
 "guestiptype": "Shared",
 "supportedservices": "Dhcp,Dns,UserData",
-"specifyVlan": "False",
-"specifyIpRanges": "False",
+"specifyVlan": "True",
 
 Review comment:
   Changing existing test data may cause failures for other tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299952#comment-16299952
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266530
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReplugNicCommandWrapper.java
 ##
 @@ -0,0 +1,133 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import java.util.List;
+
+import org.apache.log4j.Logger;
+import org.libvirt.Connect;
+import org.libvirt.Domain;
+import org.libvirt.LibvirtException;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.ReplugNicAnswer;
+import com.cloud.agent.api.ReplugNicCommand;
+import com.cloud.agent.api.to.NicTO;
+import com.cloud.exception.InternalErrorException;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.InterfaceDef;
+import com.cloud.hypervisor.kvm.resource.VifDriver;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+
+@ResourceWrapper(handles =  ReplugNicCommand.class)
+public final class LibvirtReplugNicCommandWrapper extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtReplugNicCommandWrapper.class);
+public enum DomainAffect {
+CURRENT(0), LIVE(1), CONFIG(2), BOTH(3);
+
+private int value;
+DomainAffect(int value) {
+this.value = value;
+}
+
+public int getValue() {
+return value;
+}
+}
+
+@Override
+public Answer execute(final ReplugNicCommand command, final 
LibvirtComputingResource libvirtComputingResource) {
+final NicTO nic = command.getNic();
+final String vmName = command.getVmName();
+Domain vm = null;
+try {
+final LibvirtUtilitiesHelper libvirtUtilitiesHelper = 
libvirtComputingResource.getLibvirtUtilitiesHelper();
+final Connect conn = 
libvirtUtilitiesHelper.getConnectionByVmName(vmName);
+vm = libvirtComputingResource.getDomain(conn, vmName);
+
+InterfaceDef oldPluggedNic = 
findPluggedNic(libvirtComputingResource, nic, vmName, conn);
+
+final VifDriver newVifDriver = 
libvirtComputingResource.getVifDriver(nic.getType(), nic.getName());
+final InterfaceDef interfaceDef = newVifDriver.plug(nic, "Other 
PV", oldPluggedNic.getModel().toString());
+
+interfaceDef.setSlot(oldPluggedNic.getSlot());
+interfaceDef.setDevName(oldPluggedNic.getDevName());
+interfaceDef.setLinkStateUp(false);
+
+oldPluggedNic.setSlot(null);
+
+int i = 0;
+do {
+i++;
+s_logger.debug("ReplugNic: Detaching interface" + 
oldPluggedNic + " (Attempt: " + i + ")");
+vm.detachDevice(oldPluggedNic.toString());
+} while (findPluggedNic(libvirtComputingResource, nic, vmName, 
conn) != null && i <= 10);
+
+s_logger.debug("ReplugNic: Attaching interface" + interfaceDef);
+vm.attachDevice(interfaceDef.toString());
+
+interfaceDef.setLinkStateUp(true);
+s_logger.debug("ReplugNic: Updating interface" + interfaceDef);
+vm.updateDeviceFlags(interfaceDef.toString(), 
DomainAffect.LIVE.getValue());
+
+/*
+// Manual replug
 
 Review comment:
   Dead code could be removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: 

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299951#comment-16299951
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266384
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
 ##
 @@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VpcOfferingResponse;
+import org.apache.cloudstack.api.response.VpcResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import com.cloud.event.EventTypes;
+import com.cloud.network.vpc.Vpc;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateVPC", description = "moves a vpc to another 
physical network", responseObject = VpcResponse.class, responseView = 
ResponseObject.ResponseView.Restricted, entityType = {Vpc.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class MigrateVPCCmd extends BaseAsyncCmd {
+public static final Logger s_logger = 
Logger.getLogger(MigrateVPCCmd.class.getName());
+
+private static final String s_name = "migratevpcresponse";
+
+/
+ API parameters /
+/
+@ACL(accessType = SecurityChecker.AccessType.OperateEntry)
+@Parameter(name= ApiConstants.VPC_ID, type=CommandType.UUID, entityType = 
VpcResponse.class,
+required=true, description = "the ID of the vpc")
+protected Long id;
+
+@Parameter(name = ApiConstants.VPC_OFF_ID, type = CommandType.UUID, 
entityType = VpcOfferingResponse.class, required=true, description = "vpc 
offering ID")
+private Long vpcOfferingId;
+
+@Parameter(name = ApiConstants.TIER_NETWORK_OFFERINGS, type = 
CommandType.MAP, description = "network offering ids for each network in the 
vpc. Example: 
tierNetworkOfferings[0].networkId=networkId1[0].networkOfferingId=newNetworkofferingId1[1].networkId=networkId2[1].networkOfferingId=newNetworkofferingId2")
+private Map> tierNetworkOfferings;
+
+@Parameter(name = ApiConstants.RESUME, type = CommandType.BOOLEAN, 
description = "true if previous network migration cmd failed")
+private Boolean resume;
+
+/
+/// Accessors ///
+/
+
+public Long getId() {
+return id;
+}
+
+public Long getVpcOfferingId() {
+return vpcOfferingId;
+}
+
+public Boolean getResume() {
+return resume == null ? false : resume;
+}
+
+public Map getTierNetworkOfferings() {
+HashMap flatMap = new HashMap<>();
+
+if (tierNetworkOfferings == null) {
+return flatMap;
+}
+
+for (HashMap map : tierNetworkOfferings.values()) {
 
 Review comment:
   a putall could be used here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299950#comment-16299950
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266314
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
 ##
 @@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VpcOfferingResponse;
+import org.apache.cloudstack.api.response.VpcResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import com.cloud.event.EventTypes;
+import com.cloud.network.vpc.Vpc;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateVPC", description = "moves a vpc to another 
physical network", responseObject = VpcResponse.class, responseView = 
ResponseObject.ResponseView.Restricted, entityType = {Vpc.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class MigrateVPCCmd extends BaseAsyncCmd {
+public static final Logger s_logger = 
Logger.getLogger(MigrateVPCCmd.class.getName());
+
+private static final String s_name = "migratevpcresponse";
 
 Review comment:
   Same as above, refactor to use APINAME etc patterns as used in recent APIs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299948#comment-16299948
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266143
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
 ##
 @@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VpcOfferingResponse;
+import org.apache.cloudstack.api.response.VpcResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import com.cloud.event.EventTypes;
+import com.cloud.network.vpc.Vpc;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateVPC", description = "moves a vpc to another 
physical network", responseObject = VpcResponse.class, responseView = 
ResponseObject.ResponseView.Restricted, entityType = {Vpc.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 
 Review comment:
   There is no default `authorized` defined, please fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299947#comment-16299947
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266103
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
 ##
 @@ -0,0 +1,155 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkOfferingResponse;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.network.Network;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateNetwork", description = "moves a network to another 
physical network", responseObject = NetworkResponse.class, responseView = 
ResponseView.Restricted, entityType = {Network.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 
 Review comment:
   There is no default `authorized` defined, please fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299946#comment-16299946
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266005
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
 ##
 @@ -0,0 +1,155 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkOfferingResponse;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.network.Network;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateNetwork", description = "moves a network to another 
physical network", responseObject = NetworkResponse.class, responseView = 
ResponseView.Restricted, entityType = {Network.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class MigrateNetworkCmd extends BaseAsyncCmd {
+public static final Logger s_logger = 
Logger.getLogger(MigrateNetworkCmd.class.getName());
+
+private static final String s_name = "migratenetworkresponse";
 
 Review comment:
   Please follow recent API implementation patterns, see *RoleCmd* as an 
example. The API name and response names can be refactored.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299841#comment-16299841
 ] 

ASF subversion and git services commented on CLOUDSTACK-10024:
--

Commit d49765619dae5551e41192c4e00c324e74fa33db in cloudstack's branch 
refs/heads/master from [~sgoeminn]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=d497656 ]

CLOUDSTACK-10024: Network migration support

Co-Authored-By: Frank Maximus frank.maxi...@nuagenetworks.net
Co-Authored-By: Raf Smeets raf.sme...@nuagenetworks.net

New API’s:

* migrateNetwork
* migrateVpc


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299745#comment-16299745
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353300720
 
 
   @borisstoyanov based on these results, are we good to merge ? i have less 
insight in which are known issues.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299501#comment-16299501
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353250736
 
 
   Trillian test result (tid-1847)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34856 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2259-t1847-kvm-centos7.zip
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestDeployVirtioSCSIVM>:teardown | `Error` | 50.73 | 
test_deploy_virtio_scsi_vm.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 255.03 | 
test_internal_lb.py
   test_01_vpc_privategw_acl | `Failure` | 86.85 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 238.53 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 198.16 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 334.25 | 
test_privategw_acl.py
   test_02_create_template_with_checksum_sha1 | `Error` | 5.21 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.22 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.26 | 
test_templates.py
   test_01_vpc_remote_access_vpn | `Error` | 55.90 | test_vpc_vpn.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 202.12 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298691#comment-16298691
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353110179
 
 
   @borisstoyanov , see above post :
   
   Verify Migration for an isolated network nativeOnly ... === TestName: 
test_14_native_to_native_network_migration | Status : SUCCESS ===
   ok
   Verify Migration for a vpc network nativeOnly ... === TestName: 
test_15_native_to_native_vpc_migration | Status : SUCCESS ===
   ok
   
   thank, Kris


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298608#comment-16298608
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

smeetsr commented on issue #2259: CLOUDSTACK-10024: Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353081818
 
 
   Verify Migration for an isolated network without VMs ... === TestName: 
test_01_native_to_nuage_network_migration_novms | Status : SUCCESS ===
   ok
   Verify Migration for an isolated network with stopped VMs ... === TestName: 
test_02_native_to_nuage_network_migration_stoppedvms | Status : SUCCESS ===
   ok
   Verify traffic after Migration of a non-persistent isolated network ... === 
TestName: test_03_migrate_native_nonpersistent_network_to_nuage_traffic | 
Status : FAILED ===
   FAIL due to testbedissue - rerun of this test was fine.
   Verify traffic after Migration of a persistent isolated network ... === 
TestName: test_04_migrate_native_persistentnetwork_to_nuage_traffic | Status : 
SUCCESS ===
   ok
   Verify Nic migration of GuestVm in an isolated network ... === TestName: 
test_05_native_to_nuage_nic_migration | Status : SUCCESS ===
   ok
   Verify Nic migration of GuestVm in a non-persistent isolated network ... === 
TestName: test_06_migrate_native_nonpersistent_nic_to_nuage_traffic | Status : 
SUCCESS ===
   ok
   Verify Nic migration of GuestVm in a persistent isolated network ... === 
TestName: test_07_migrate_native_persistent_nic_to_nuage_traffic | Status : 
SUCCESS ===
   ok
   Verify MultiNic migration of GuestVm with multiple isolated networks ... === 
TestName: test_08_migrate_native_multinic_to_nuage_traffic | Status : SUCCESS 
===
   ok
   Verify StaticNat migration of GuestVm in a persistent isolated network ... 
=== TestName: test_09_migrate_native_persist_staticnat_to_nuage_traffic | 
Status : SUCCESS ===
   ok
   test_10_migrate_native_vpc 
(nuagevsp.test_nuage_network_migration.TestNuageMigration) ... === TestName: 
test_10_migrate_native_vpc | Status : SUCCESS ===
   ok
   Verify StaticNat migration of GuestVm in a vpc network ... === TestName: 
test_11_migrate_native_vpc_staticnat_to_nuage_traffic | Status : SUCCESS ===
   ok
   Verify MultiNic migration of GuestVm in multiple networks ... === TestName: 
test_12_migrate_native_vpc_multinic_to_nuage_traffic | Status : SUCCESS ===
   ok
   Verify migration of GuestVm with ip .2 still works ... === TestName: 
test_13_verify_guestvmip2_when_migrating_to_nuage | Status : SUCCESS ===
   ok
   Verify Migration for an isolated network nativeOnly ... === TestName: 
test_14_native_to_native_network_migration | Status : SUCCESS ===
   ok
   Verify Migration for a vpc network nativeOnly ... === TestName: 
test_15_native_to_native_vpc_migration | Status : SUCCESS ===
   ok
   
   [runinfo.txt](https://github.com/apache/cloudstack/files/1575879/runinfo.txt)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298551#comment-16298551
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353071506
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298548#comment-16298548
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353071314
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298492#comment-16298492
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353061633
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1441


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298432#comment-16298432
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353055186
 
 
   Can you paste some execution logs for the newly added tests, since they 
won't be picked up from the plugin directory. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298430#comment-16298430
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353055095
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298428#comment-16298428
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353054952
 
 
   @krissterckx Yes, that should be fine. Let me run some tests. 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298368#comment-16298368
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353046904
 
 
   Hi @borisstoyanov , see 
https://github.com/nuagenetworks/cloudstack/blob/8dddbb1544cbd34e68e772c294e0e3e287c06f0b/test/integration/plugins/nuagevsp/test_nuage_network_migration.py#L1859
 
   and 
https://github.com/nuagenetworks/cloudstack/blob/7b51b325bbb85a6bb989dd6b18814ceac26da25a/test/integration/plugins/nuagevsp/test_nuage_network_migration.py#L1902
   
   They migrate an isolated network and VPC within a native physical network, 
to a new offering. It is a special case of the migration across physical 
networks, but it comes down to the same behavior : the whole network is 
reimplemented again as the offering is different.  We don't have the 
infrastructure set up for setting up multiple native physical networks, hence 
we took this approach.
   
   Is it ok we left this test under this nuage test module ?  Or would you like 
to see a new native component test.   Let me know what you think , i.e. whether 
what we did is fine or it is not what you had in mind. 
   Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298139#comment-16298139
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353005252
 
 
   @krissterckx sure I can kick the marvin tests, have you managed to add the 
default network provider tests?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298111#comment-16298111
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353003052
 
 
   @borisstoyanov this PR adds MigrateNetworkCmd.class and MigrateVPCCmd.class 
as new commands, which just causes git not to know in which order to add them.
   The problem is, we can keep on rebasing - each time some other commits goes 
in, we possibly need to rebase again :-)  We can/will do that but i also would 
like to see review and Trillian results. Do you prefer us to rebase again first 
?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297424#comment-16297424
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-352885731
 
 
   @borisstoyanov can you reassess/approve and re-kick Trillian please.  We aim 
to merge in this week. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285362#comment-16285362
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

krissterckx commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r155959221
 
 

 ##
 File path: test/integration/plugins/nuagevsp/test_nuage_network_migration.py
 ##
 @@ -0,0 +1,1949 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Network migration test with Nuage VSP SDN plugin
+"""
+# Import Local Modules
+from nuageTestCase import nuageTestCase
+from marvin.lib.base import (Account, Host)
+from marvin.lib.utils import is_server_ssh_ready
+from marvin.cloudstackAPI import updateZone
+
+# Import System Modules
+from nose.plugins.attrib import attr
+import time
+import base64
+import unittest
+import re
+
+
+class TestNuageMigration(nuageTestCase):
+"""Test Native to Nuage Migration
+"""
+
+@classmethod
+def setUpClass(cls):
+super(TestNuageMigration, cls).setUpClass()
+
+if not hasattr(cls.vsp_physical_network, "tags") \
+or cls.vsp_physical_network.tags != 'nuage':
+raise unittest.SkipTest("Require migrateACS configuration - skip")
+
+# create a native vpc offering
+cls.native_vpc_offering = cls.create_VpcOffering(cls.test_data
+ ["vpc_offering"])
+# create a nuage vpc offering
+cls.nuage_vpc_offering = \
+cls.create_VpcOffering(cls.test_data["nuagevsp"]["vpc_offering"])
+
+# tier network offerings
+cls.nuage_vpc_network_offering = \
+cls.create_NetworkOffering(cls.test_data["nuagevsp"]
+   ["vpc_network_offering"])
+cls.native_vpc_network_offering = \
+cls.create_NetworkOffering(cls.test_data
+   ["nw_offering_isolated_vpc"])
+
+# create a Nuage isolated network offering with vr
+cls.nuage_isolated_network_offering = cls.create_NetworkOffering(
+cls.test_data["nuagevsp"]["isolated_network_offering"], True)
+
+# create a Nuage isolated network offering with vr and persistent
+cls.nuage_isolated_network_offering_persistent = \
+cls.create_NetworkOffering(
+cls.test_data["nuagevsp"]
+["isolated_network_offering_persistent"],
+True)
+
+# create a Nuage isolated network offering without vr
+cls.nuage_isolated_network_offering_without_vr = \
+cls.create_NetworkOffering(
+cls.test_data["nuagevsp"]
+["isolated_network_offering_without_vr"],
+True)
+
+# create a Nuage isolated network offering without vr but persistent
+cls.nuage_isolated_network_offering_without_vr_persistent = \
+cls.create_NetworkOffering(
+cls.test_data["nuagevsp"]
+["isolated_network_offering_without_vr_persistent"],
+True)
+
+# create a native isolated network offering
+cls.native_isolated_network_offering = cls.create_NetworkOffering(
+cls.test_data["isolated_network_offering"], True)
+
+# create a native persistent isolated network offering
+cls.native_isolated_network_offering_persistent = \
+cls.create_NetworkOffering(
+cls.test_data["nw_off_isolated_persistent"], True)
+
+# create a native persistent staticNat isolated network offering
+cls.native_isolated_network_staticnat_offering_persistent = \
+cls.create_NetworkOffering(
+cls.test_data["isolated_staticnat_network_offering"], True)
+
+# create a Native shared network offering
+cls.native_shared_network_offering = cls.create_NetworkOffering(
+cls.test_data["shared_network_offering"], False)
+
+# create a Nuage shared network offering
+cls.nuage_shared_network_offering = 

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284812#comment-16284812
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-350481432
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284811#comment-16284811
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-350481259
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283515#comment-16283515
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-350263552
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1355


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283511#comment-16283511
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on issue #2259: CLOUDSTACK-10024: Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-35026
 
 
   @borisstoyanov We already have tests that migrate from Nuage to Native (and 
visa versa). But we will add some new tests which do migration from native 
physical network A to native physical network B. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283499#comment-16283499
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

blueorangutan commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-350259398
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283498#comment-16283498
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-350259316
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283368#comment-16283368
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on issue #2259: CLOUDSTACK-10024: Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-350235693
 
 
   ping @borisstoyanov 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278870#comment-16278870
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-349372219
 
 
   @sgoeminn can you please remind me towards the end of the week, we're 
running out of resources in Trillian and need to prioritize at this moment. If 
we start the smoketests on Fri/Sat, you'll be able to see them on Monday.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278869#comment-16278869
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration 
support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-349372219
 
 
   @sgoeminn can you please remind me towards the end of the week, we're 
running out of resources in Trillian and need to prioritize at this moment 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278692#comment-16278692
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on issue #2259: CLOUDSTACK-10024: Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-349331463
 
 
   @DaanHoogland @borisstoyanov is it possible to run CI against this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272789#comment-16272789
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

smeetsr commented on issue #2259: CLOUDSTACK-10024: Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-348217391
 
 
   Verify Migration for an isolated network without VMs ... === TestName: 
test_01_native_to_nuage_network_migration_novms | Status : SUCCESS ===
   ok
   Verify Migration for an isolated network with stopped VMs ... === TestName: 
test_02_native_to_nuage_network_migration_stoppedvms | Status : SUCCESS ===
   ok
   Verify traffic after Migration of a non-persistent isolated network ... === 
TestName: test_03_migrate_native_nonpersistent_network_to_nuage_traffic | 
Status : SUCCESS ===
   ok
   Verify traffic after Migration of a persistent isolated network ... === 
TestName: test_04_migrate_native_persistentnetwork_to_nuage_traffic | Status : 
SUCCESS ===
   ok
   Verify Nic migration of GuestVm in an isolated network ... === TestName: 
test_05_native_to_nuage_nic_migration | Status : SUCCESS ===
   ok
   Verify Nic migration of GuestVm in a non-persistent isolated network ... === 
TestName: test_06_migrate_native_nonpersistent_nic_to_nuage_traffic | Status : 
SUCCESS ===
   ok
   Verify Nic migration of GuestVm in a persistent isolated network ... === 
TestName: test_07_migrate_native_persistent_nic_to_nuage_traffic | Status : 
SUCCESS ===
   ok
   Verify MultiNic migration of GuestVm with multiple isolated networks ... === 
TestName: test_08_migrate_native_multinic_to_nuage_traffic | Status : SUCCESS 
===
   ok
   Verify StaticNat migration of GuestVm in a persistent isolated network ... 
=== TestName: test_09_migrate_native_persist_staticnat_to_nuage_traffic | 
Status : SUCCESS ===
   ok
   test_10_migrate_native_vpc 
(nuagevsp.test_nuage_network_migration.TestNuageMigration) ... === TestName: 
test_10_migrate_native_vpc | Status : SUCCESS ===
   ok
   Verify StaticNat migration of GuestVm in a vpc network ... === TestName: 
test_11_migrate_native_vpc_staticnat_to_nuage_traffic | Status : SUCCESS ===
   ok
   Verify MultiNic migration of GuestVm in multiple networks ... === TestName: 
test_12_migrate_native_vpc_multinic_to_nuage_traffic | Status : SUCCESS ===
   ok
   Verify migration of GuestVm with ip .2 still works ... === TestName: 
test_13_verify_guestvmip2_when_migrating_to_nuage | Status : SUCCESS ===
   ok
   
   --
   Ran 13 tests in 15064.370s
   
   OK
   [runinfo.txt](https://github.com/apache/cloudstack/files/1518302/runinfo.txt)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216567#comment-16216567
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on issue #2259: CLOUDSTACK-10024: Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-338921135
 
 
   @GabrielBrascher Thanks for reviewing, really appreciate it! We tried to 
address all your comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216563#comment-16216563
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493419
 
 

 ##
 File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 ##
 @@ -3636,6 +3639,36 @@ private void orchestrateMigrateForScale(final String 
vmUuid, final long srcHostI
 }
 }
 
+@Override
+public boolean replugNic(final Network network, final NicTO nic, final 
VirtualMachineTO vm, final ReservationContext context, final DeployDestination 
dest) throws ConcurrentOperationException,
+ResourceUnavailableException, InsufficientCapacityException {
+boolean result = true;
+
+final VMInstanceVO router = _vmDao.findById(vm.getId());
+if (router.getState() == State.Running) {
+try {
+final ReplugNicCommand replugNicCmd = new 
ReplugNicCommand(nic, vm.getName(), vm.getType(), vm.getDetails());
+final Commands cmds = new Commands(Command.OnError.Stop);
+cmds.addCommand("replugnic", replugNicCmd);
+_agentMgr.send(dest.getHost().getId(), cmds);
+final ReplugNicAnswer replugNicAnswer = 
cmds.getAnswer(ReplugNicAnswer.class);
+if (!(replugNicAnswer != null && replugNicAnswer.getResult())) 
{
 
 Review comment:
   Agree, we changed it to (replugNicAnswer == null || 
!replugNicAnswer.getResult()). We have also updated the other places in that 
file where that code was used.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216565#comment-16216565
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493509
 
 

 ##
 File path: engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java
 ##
 @@ -34,5 +34,22 @@
 
 List listBy(long resourceId, ResourceObjectType 
resourceType);
 
+/**
+ * Find a resource tag based on the resourceid, resourcetype and key
+ * @param resourceId
+ * @param resourceType
+ * @param key
+ * @return
+ */
+ResourceTag findByKey(long resourceId, ResourceObjectType resourceType, 
String key);
+
 void updateResourceId(long srcId, long destId, ResourceObjectType 
resourceType);
+
+/**
+ * remove a resource tag based on the resourceid, resourtype and key
+ * @param resourceId
+ * @param resourceType
+ * @param key
 
 Review comment:
   Updated the documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216566#comment-16216566
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493531
 
 

 ##
 File path: server/src/com/cloud/network/NetworkMigrationManager.java
 ##
 @@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network;
+
+import com.cloud.network.vpc.Vpc;
+import com.cloud.offering.NetworkOffering;
+
+/**
+ * The NetworkMigrationManager should be used for migration purpose ONLY.
+ */
+public interface NetworkMigrationManager {
+
+/**
+ * Returns a copy of the provided network.
+ * All nics in the orginal network will be re-assigned to the newly 
created network.
+ * All network details will be copied to the newly created network.
+ * @param network the network to be copied
+ * @param networkOffering the network offering of the network that is 
copied
+ * @return the networkid of the copy
+ */
+long makeCopyOfNetwork(Network network, NetworkOffering networkOffering, 
Long vpcId);
+
+/**
+ * Returns a copy of the provided vpc
+ * All acls rules and public ips will be re-assigned to the newly created 
vpc.
+ * @param vpcId
+ * @param vpcOfferingId
+ * @return
+ */
+Long makeCopyOfVpc(long vpcId, long vpcOfferingId);
+
+/**
+ * Starts the vpc if, the vpc is not already started
+ * @param vpc
+ */
+void startVpc(Vpc vpc);
+
+/**
+ * Upgrade the physical network and the offering of a network.
+ * @param networkId the networkid of the network that needs to be upgraded.
+ * @param newPhysicalNetworkId the id of the new physical network where 
the network should be moved to.
+ * @param networkOfferingId the new network offering.
+ * @return the networkid of the upgraded network
+ */
+Network upgradeNetworkToNewNetworkOffering (long networkId, long 
newPhysicalNetworkId, long networkOfferingId, Long vpcId);
+
+/**
+ * Deletes the copy of a network which was previously created by the 
networkMigrationManager
+ * For deletion of the copy the old UUID of the original network is used 
to assure that plugins, using the UUID, clean up the network correctly.
+ * @param networkCopyId the networkId of the copied network
+ * @param originalNetworkId the networkId of the original network
+ */
+void deleteCopyOfNetwork(long networkCopyId, long originalNetworkId);
+
+/**
+ *
 
 Review comment:
   Updated the documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216564#comment-16216564
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493484
 
 

 ##
 File path: engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java
 ##
 @@ -34,5 +34,22 @@
 
 List listBy(long resourceId, ResourceObjectType 
resourceType);
 
+/**
+ * Find a resource tag based on the resourceid, resourcetype and key
+ * @param resourceId
+ * @param resourceType
+ * @param key
+ * @return
 
 Review comment:
   Updated the documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216561#comment-16216561
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493133
 
 

 ##
 File path: core/src/com/cloud/agent/api/ReplugNicCommand.java
 ##
 @@ -0,0 +1,67 @@
+///
+// Copyright (c) 2016 Nokia
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+///
 
 Review comment:
   That's indeed the wrong license. We changed it to the correct one. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216560#comment-16216560
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493117
 
 

 ##
 File path: core/src/com/cloud/agent/api/ReplugNicAnswer.java
 ##
 @@ -0,0 +1,26 @@
+///
+// Copyright (c) 2016 Nokia
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+///
 
 Review comment:
   That's indeed the wrong license. We changed it to the correct one. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216553#comment-16216553
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492729
 
 

 ##
 File path: api/src/com/cloud/network/NetworkService.java
 ##
 @@ -82,6 +83,28 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId, 
Long zoneId, Long ne
 Network updateGuestNetwork(long networkId, String name, String 
displayText, Account callerAccount, User callerUser, String domainSuffix, Long 
networkOfferingId,
 Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String 
newUUID, boolean updateInSequence, boolean forced);
 
+/**
+ * Migrate a network from one physical network to another physical network
+ * @param networkId
+ * @param networkOfferingId
+ * @param callerAccount
+ * @param callerUser
+ * @param resume
+ * @return
 
 Review comment:
   Updated the documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216558#comment-16216558
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492979
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
 ##
 @@ -0,0 +1,146 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VpcOfferingResponse;
+import org.apache.cloudstack.api.response.VpcResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.network.vpc.Vpc;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateVPC", description = "moves a vpc to another 
physical network", responseObject = VpcResponse.class, responseView = 
ResponseObject.ResponseView.Restricted, entityType = {Vpc.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class MigrateVPCCmd extends BaseAsyncCmd {
+public static final Logger s_logger = 
Logger.getLogger(MigrateVPCCmd.class.getName());
+
+private static final String s_name = "migratevpcresponse";
+
+/
+ API parameters /
+/
+@ACL(accessType = SecurityChecker.AccessType.OperateEntry)
+@Parameter(name= ApiConstants.VPC_ID, type=CommandType.UUID, entityType = 
VpcResponse.class,
+required=true, description = "the ID of the vpc")
+protected Long id;
+
+@Parameter(name = ApiConstants.VPC_OFF_ID, type = CommandType.UUID, 
entityType = VpcOfferingResponse.class, required=true, description = "vpc 
offering ID")
+private Long vpcOfferingId;
+
+@Parameter(name = ApiConstants.TIER_NETWORK_OFFERINGS, type = 
CommandType.MAP, description = "network offering ids for each network in the 
vpc. Example: 
tierNetworkOfferings[0].networkId=networkId1[0].networkOfferingId=newNetworkofferingId1[1].networkId=networkId2[1].networkOfferingId=newNetworkofferingId2")
+private Map> tierNetworkOfferings;
+
+@Parameter(name = ApiConstants.RESUME, type = CommandType.BOOLEAN, 
description = "true if previous network migration cmd failed")
+private Boolean resume;
+
+/
+/// Accessors ///
+/
+
+public Long getId() {
+return id;
+}
+
+public Long getVpcOfferingId() {
+return vpcOfferingId;
+}
+
+public Boolean getResume() {
+return resume == null ? false : resume;
+}
+
+public Map getTierNetworkOfferings() {
+HashMap flatMap = new HashMap<>();
+
+if (tierNetworkOfferings == null) {
+return flatMap;
+}
+
+for (HashMap map : tierNetworkOfferings.values()) {
+ flatMap.put(map.get("networkid"), map.get("networkofferingid"));
+}
+
+return flatMap;
+}
+
+/
+/// API 

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216554#comment-16216554
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492740
 
 

 ##
 File path: api/src/com/cloud/network/NetworkService.java
 ##
 @@ -82,6 +83,28 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId, 
Long zoneId, Long ne
 Network updateGuestNetwork(long networkId, String name, String 
displayText, Account callerAccount, User callerUser, String domainSuffix, Long 
networkOfferingId,
 Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String 
newUUID, boolean updateInSequence, boolean forced);
 
+/**
+ * Migrate a network from one physical network to another physical network
+ * @param networkId
+ * @param networkOfferingId
+ * @param callerAccount
+ * @param callerUser
+ * @param resume
+ * @return
+ */
+Network migrateGuestNetwork(long networkId, long networkOfferingId, 
Account callerAccount, User callerUser, boolean resume);
+
+/**
+ * Migrate a vpc from on physical network to another physical network
+ * @param vpcId
+ * @param vpcNetworkofferingId
+ * @param account
+ * @param callerUser
+ * @param resume
+ * @return
 
 Review comment:
   Updated the documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216557#comment-16216557
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492964
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
 ##
 @@ -0,0 +1,157 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkOfferingResponse;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.network.Network;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateNetwork", description = "moves a network do another 
physical network", responseObject = NetworkResponse.class, responseView = 
ResponseView.Restricted, entityType = {Network.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class MigrateNetworkCmd extends BaseAsyncCmd {
+public static final Logger s_logger = 
Logger.getLogger(MigrateNetworkCmd.class.getName());
+
+private static final String s_name = "migratenetworkresponse";
+
+/
+ API parameters /
+/
+@ACL(accessType = AccessType.OperateEntry)
+@Parameter(name=ApiConstants.NETWORK_ID, type=CommandType.UUID, entityType 
= NetworkResponse.class,
+required=true, description="the ID of the network")
+protected Long id;
+
+@Parameter(name = ApiConstants.NETWORK_OFFERING_ID, type = 
CommandType.UUID, entityType = NetworkOfferingResponse.class, description = 
"network offering ID")
+private Long networkOfferingId;
+
+@Parameter(name = ApiConstants.RESUME, type = CommandType.BOOLEAN, 
description = "true if previous network migration cmd failed")
+private Boolean resume;
+
+/
+/// Accessors ///
+/
+
+public Long getId() {
+return id;
+}
+
+public Long getNetworkOfferingId() {
+return networkOfferingId;
+}
+
+public Boolean getResume() {
+return resume != null ? resume : false;
+}
+
+/
+/// API Implementation///
+/
+
+@Override
+public String getCommandName() {
+return s_name;
+}
+
+@Override
+public long getEntityOwnerId() {
+Network network = _networkService.getNetwork(id);
+if (network == null) {
+throw new InvalidParameterValueException("Networkd id=" + id + " 
doesn't exist");
+} else {
+return _networkService.getNetwork(id).getAccountId();
+}
+}
+
+@Override
+public void execute() throws InsufficientCapacityException, 
ConcurrentOperationException {
 
 Review comment:
   You are right, they are not necessary. We removed them.

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216556#comment-16216556
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492848
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
 ##
 @@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkOfferingResponse;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.network.Network;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateNetwork", description = "moves a network do another 
physical network", responseObject = NetworkResponse.class, responseView = 
ResponseView.Restricted, entityType = {Network.class},
 
 Review comment:
   I fixed the typo.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216552#comment-16216552
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network 
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492712
 
 

 ##
 File path: api/src/com/cloud/network/NetworkService.java
 ##
 @@ -82,6 +83,26 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId, 
Long zoneId, Long ne
 Network updateGuestNetwork(long networkId, String name, String 
displayText, Account callerAccount, User callerUser, String domainSuffix, Long 
networkOfferingId,
 Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String 
newUUID, boolean updateInSequence, boolean forced);
 
+/**
+ * Migrate a network from one physical network to another physical network
+ * @param networkId
+ * @param networkOfferingId
+ * @param callerAccount
+ * @param callerUser
+ * @return
 
 Review comment:
   Updated the documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216068#comment-16216068
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146328468
 
 

 ##
 File path: core/src/com/cloud/agent/api/ReplugNicCommand.java
 ##
 @@ -0,0 +1,67 @@
+///
+// Copyright (c) 2016 Nokia
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+///
 
 Review comment:
   Please, update the licence header.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216062#comment-16216062
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146401454
 
 

 ##
 File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 ##
 @@ -3636,6 +3639,36 @@ private void orchestrateMigrateForScale(final String 
vmUuid, final long srcHostI
 }
 }
 
+@Override
+public boolean replugNic(final Network network, final NicTO nic, final 
VirtualMachineTO vm, final ReservationContext context, final DeployDestination 
dest) throws ConcurrentOperationException,
+ResourceUnavailableException, InsufficientCapacityException {
+boolean result = true;
+
+final VMInstanceVO router = _vmDao.findById(vm.getId());
+if (router.getState() == State.Running) {
+try {
+final ReplugNicCommand replugNicCmd = new 
ReplugNicCommand(nic, vm.getName(), vm.getType(), vm.getDetails());
+final Commands cmds = new Commands(Command.OnError.Stop);
+cmds.addCommand("replugnic", replugNicCmd);
+_agentMgr.send(dest.getHost().getId(), cmds);
+final ReplugNicAnswer replugNicAnswer = 
cmds.getAnswer(ReplugNicAnswer.class);
+if (!(replugNicAnswer != null && replugNicAnswer.getResult())) 
{
 
 Review comment:
   What do you think about changing `(!(replugNicAnswer != null && 
replugNicAnswer.getResult()))` to `(replugNicAnswer == null && 
replugNicAnswer.getResult() == false)`? It is simpler IMHO. Additionally, I am 
wondering why `result` will not be false when `replugNicAnswer.getResult() = 
false`; `replugNicAnswer != null` is sufficient to let `result = true`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216063#comment-16216063
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146415652
 
 

 ##
 File path: engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java
 ##
 @@ -34,5 +34,22 @@
 
 List listBy(long resourceId, ResourceObjectType 
resourceType);
 
+/**
+ * Find a resource tag based on the resourceid, resourcetype and key
+ * @param resourceId
+ * @param resourceType
+ * @param key
+ * @return
+ */
+ResourceTag findByKey(long resourceId, ResourceObjectType resourceType, 
String key);
+
 void updateResourceId(long srcId, long destId, ResourceObjectType 
resourceType);
+
+/**
+ * remove a resource tag based on the resourceid, resourtype and key
+ * @param resourceId
+ * @param resourceType
+ * @param key
 
 Review comment:
   Same here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216057#comment-16216057
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r141427671
 
 

 ##
 File path: api/src/com/cloud/network/NetworkService.java
 ##
 @@ -82,6 +83,26 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId, 
Long zoneId, Long ne
 Network updateGuestNetwork(long networkId, String name, String 
displayText, Account callerAccount, User callerUser, String domainSuffix, Long 
networkOfferingId,
 Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String 
newUUID, boolean updateInSequence, boolean forced);
 
+/**
+ * Migrate a network from one physical network to another physical network
+ * @param networkId
+ * @param networkOfferingId
+ * @param callerAccount
+ * @param callerUser
+ * @return
 
 Review comment:
   Thanks for documenting the code @sgoeminn.
   Please, remove the `@param` and `@return`. I don't see much use of them 
(unless they are detailed). The same goes for method 'migrateVpcNetwork'.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216065#comment-16216065
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146415530
 
 

 ##
 File path: api/src/com/cloud/network/NetworkService.java
 ##
 @@ -82,6 +83,28 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId, 
Long zoneId, Long ne
 Network updateGuestNetwork(long networkId, String name, String 
displayText, Account callerAccount, User callerUser, String domainSuffix, Long 
networkOfferingId,
 Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String 
newUUID, boolean updateInSequence, boolean forced);
 
+/**
+ * Migrate a network from one physical network to another physical network
+ * @param networkId
+ * @param networkOfferingId
+ * @param callerAccount
+ * @param callerUser
+ * @param resume
+ * @return
+ */
+Network migrateGuestNetwork(long networkId, long networkOfferingId, 
Account callerAccount, User callerUser, boolean resume);
+
+/**
+ * Migrate a vpc from on physical network to another physical network
+ * @param vpcId
+ * @param vpcNetworkofferingId
+ * @param account
+ * @param callerUser
+ * @param resume
+ * @return
 
 Review comment:
   Can you please remove the `@param` annotations or provide a description?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216059#comment-16216059
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146328309
 
 

 ##
 File path: core/src/com/cloud/agent/api/ReplugNicAnswer.java
 ##
 @@ -0,0 +1,26 @@
+///
+// Copyright (c) 2016 Nokia
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+///
 
 Review comment:
   Can you please change the licence header?
   
   Expected:
   ```
   // Licensed to the Apache Software Foundation (ASF) under one
   // or more contributor license agreements.  See the NOTICE file
   // distributed with this work for additional information
   // regarding copyright ownership.  The ASF licenses this file
   // to you under the Apache License, Version 2.0 (the
   // "License"); you may not use this file except in compliance
   // with the License.  You may obtain a copy of the License at
   //
   //   http://www.apache.org/licenses/LICENSE-2.0
   //
   // Unless required by applicable law or agreed to in writing,
   // software distributed under the License is distributed on an
   // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   // KIND, either express or implied.  See the License for the
   // specific language governing permissions and limitations
   // under the License.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216067#comment-16216067
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146415623
 
 

 ##
 File path: engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java
 ##
 @@ -34,5 +34,22 @@
 
 List listBy(long resourceId, ResourceObjectType 
resourceType);
 
+/**
+ * Find a resource tag based on the resourceid, resourcetype and key
+ * @param resourceId
+ * @param resourceType
+ * @param key
+ * @return
 
 Review comment:
   Can you please remove the `@param` annotations or provide a description?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216069#comment-16216069
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146415351
 
 

 ##
 File path: api/src/com/cloud/network/NetworkService.java
 ##
 @@ -82,6 +83,28 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId, 
Long zoneId, Long ne
 Network updateGuestNetwork(long networkId, String name, String 
displayText, Account callerAccount, User callerUser, String domainSuffix, Long 
networkOfferingId,
 Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String 
newUUID, boolean updateInSequence, boolean forced);
 
+/**
+ * Migrate a network from one physical network to another physical network
+ * @param networkId
+ * @param networkOfferingId
+ * @param callerAccount
+ * @param callerUser
+ * @param resume
+ * @return
 
 Review comment:
   Thanks for adding Javadoc.
   I like the `@param` when it has a description of the parameter otherwise it 
is better to remove them from the code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216066#comment-16216066
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146418796
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1196,6 +1222,10 @@ private void getPifs() {
 s_logger.debug("done looking for pifs, no more bridges");
 }
 
+boolean isGuestBridge(String bridge) {
 
 Review comment:
   Thanks! Removing the duplicate code is great 
   If you want, you can go a step further creating a test case for 
`isGuestBridge(String bridge)` and `isPublicBridge(String bridge)` ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216061#comment-16216061
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146315585
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
 ##
 @@ -0,0 +1,157 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkOfferingResponse;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.network.Network;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateNetwork", description = "moves a network do another 
physical network", responseObject = NetworkResponse.class, responseView = 
ResponseView.Restricted, entityType = {Network.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class MigrateNetworkCmd extends BaseAsyncCmd {
+public static final Logger s_logger = 
Logger.getLogger(MigrateNetworkCmd.class.getName());
+
+private static final String s_name = "migratenetworkresponse";
+
+/
+ API parameters /
+/
+@ACL(accessType = AccessType.OperateEntry)
+@Parameter(name=ApiConstants.NETWORK_ID, type=CommandType.UUID, entityType 
= NetworkResponse.class,
+required=true, description="the ID of the network")
+protected Long id;
+
+@Parameter(name = ApiConstants.NETWORK_OFFERING_ID, type = 
CommandType.UUID, entityType = NetworkOfferingResponse.class, description = 
"network offering ID")
+private Long networkOfferingId;
+
+@Parameter(name = ApiConstants.RESUME, type = CommandType.BOOLEAN, 
description = "true if previous network migration cmd failed")
+private Boolean resume;
+
+/
+/// Accessors ///
+/
+
+public Long getId() {
+return id;
+}
+
+public Long getNetworkOfferingId() {
+return networkOfferingId;
+}
+
+public Boolean getResume() {
+return resume != null ? resume : false;
+}
+
+/
+/// API Implementation///
+/
+
+@Override
+public String getCommandName() {
+return s_name;
+}
+
+@Override
+public long getEntityOwnerId() {
+Network network = _networkService.getNetwork(id);
+if (network == null) {
+throw new InvalidParameterValueException("Networkd id=" + id + " 
doesn't exist");
+} else {
+return _networkService.getNetwork(id).getAccountId();
+}
+}
+
+@Override
+public void execute() throws InsufficientCapacityException, 
ConcurrentOperationException {
 
 Review comment:
   Sorry if I am missing something here, but I do not see 

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216058#comment-16216058
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146319286
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
 ##
 @@ -0,0 +1,146 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VpcOfferingResponse;
+import org.apache.cloudstack.api.response.VpcResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.network.vpc.Vpc;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateVPC", description = "moves a vpc to another 
physical network", responseObject = VpcResponse.class, responseView = 
ResponseObject.ResponseView.Restricted, entityType = {Vpc.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class MigrateVPCCmd extends BaseAsyncCmd {
+public static final Logger s_logger = 
Logger.getLogger(MigrateVPCCmd.class.getName());
+
+private static final String s_name = "migratevpcresponse";
+
+/
+ API parameters /
+/
+@ACL(accessType = SecurityChecker.AccessType.OperateEntry)
+@Parameter(name= ApiConstants.VPC_ID, type=CommandType.UUID, entityType = 
VpcResponse.class,
+required=true, description = "the ID of the vpc")
+protected Long id;
+
+@Parameter(name = ApiConstants.VPC_OFF_ID, type = CommandType.UUID, 
entityType = VpcOfferingResponse.class, required=true, description = "vpc 
offering ID")
+private Long vpcOfferingId;
+
+@Parameter(name = ApiConstants.TIER_NETWORK_OFFERINGS, type = 
CommandType.MAP, description = "network offering ids for each network in the 
vpc. Example: 
tierNetworkOfferings[0].networkId=networkId1[0].networkOfferingId=newNetworkofferingId1[1].networkId=networkId2[1].networkOfferingId=newNetworkofferingId2")
+private Map> tierNetworkOfferings;
+
+@Parameter(name = ApiConstants.RESUME, type = CommandType.BOOLEAN, 
description = "true if previous network migration cmd failed")
+private Boolean resume;
+
+/
+/// Accessors ///
+/
+
+public Long getId() {
+return id;
+}
+
+public Long getVpcOfferingId() {
+return vpcOfferingId;
+}
+
+public Boolean getResume() {
+return resume == null ? false : resume;
+}
+
+public Map getTierNetworkOfferings() {
+HashMap flatMap = new HashMap<>();
+
+if (tierNetworkOfferings == null) {
+return flatMap;
+}
+
+for (HashMap map : tierNetworkOfferings.values()) {
+ flatMap.put(map.get("networkid"), map.get("networkofferingid"));
+}
+
+return flatMap;
+}
+
+/
+/// API 

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216060#comment-16216060
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r141434102
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
 ##
 @@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkOfferingResponse;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.network.Network;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+
+@APICommand(name = "migrateNetwork", description = "moves a network do another 
physical network", responseObject = NetworkResponse.class, responseView = 
ResponseView.Restricted, entityType = {Network.class},
 
 Review comment:
   description = "moves a network **do** another physical network" -> moves a 
network **to** another


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10024) Physical Networking Migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216064#comment-16216064
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10024:
-

GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: 
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146421388
 
 

 ##
 File path: server/src/com/cloud/network/NetworkMigrationManager.java
 ##
 @@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network;
+
+import com.cloud.network.vpc.Vpc;
+import com.cloud.offering.NetworkOffering;
+
+/**
+ * The NetworkMigrationManager should be used for migration purpose ONLY.
+ */
+public interface NetworkMigrationManager {
+
+/**
+ * Returns a copy of the provided network.
+ * All nics in the orginal network will be re-assigned to the newly 
created network.
+ * All network details will be copied to the newly created network.
+ * @param network the network to be copied
+ * @param networkOffering the network offering of the network that is 
copied
+ * @return the networkid of the copy
+ */
+long makeCopyOfNetwork(Network network, NetworkOffering networkOffering, 
Long vpcId);
+
+/**
+ * Returns a copy of the provided vpc
+ * All acls rules and public ips will be re-assigned to the newly created 
vpc.
+ * @param vpcId
+ * @param vpcOfferingId
+ * @return
+ */
+Long makeCopyOfVpc(long vpcId, long vpcOfferingId);
+
+/**
+ * Starts the vpc if, the vpc is not already started
+ * @param vpc
+ */
+void startVpc(Vpc vpc);
+
+/**
+ * Upgrade the physical network and the offering of a network.
+ * @param networkId the networkid of the network that needs to be upgraded.
+ * @param newPhysicalNetworkId the id of the new physical network where 
the network should be moved to.
+ * @param networkOfferingId the new network offering.
+ * @return the networkid of the upgraded network
+ */
+Network upgradeNetworkToNewNetworkOffering (long networkId, long 
newPhysicalNetworkId, long networkOfferingId, Long vpcId);
+
+/**
+ * Deletes the copy of a network which was previously created by the 
networkMigrationManager
+ * For deletion of the copy the old UUID of the original network is used 
to assure that plugins, using the UUID, clean up the network correctly.
+ * @param networkCopyId the networkId of the copied network
+ * @param originalNetworkId the networkId of the original network
+ */
+void deleteCopyOfNetwork(long networkCopyId, long originalNetworkId);
+
+/**
+ *
 
 Review comment:
   Missing documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Physical Networking Migration
> -
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, KVM, Management Server, VMware
>Reporter: Frank Maximus
>Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network 
> infrastructure
> *In order to* make use of the extra features SDN provides.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)