[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313409#comment-16313409 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - DaanHoogland commented on a change in pull request #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159820728 ## File path: api/src/com/cloud/user/ResourceLimitService.java ## @@ -104,6 +104,14 @@ */ public long findCorrectResourceLimitForDomain(Domain domain, ResourceType type); +/** + * Finds the default resource limit for a specified type. + * + * @param resourceType Review comment: it is self explanatory. no +or- 1 but this tag is not useful This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313410#comment-16313410
]
ASF GitHub Bot commented on CLOUDSTACK-10104:
-
DaanHoogland commented on a change in pull request #2282:
CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve
performance
URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159821325
##
File path: server/src/com/cloud/api/query/QueryManagerImpl.java
##
@@ -1901,9 +1900,10 @@
Long domainId = cmd.getId();
boolean listAll = cmd.listAll();
boolean isRecursive = false;
+Domain domain = null;
if (domainId != null) {
-Domain domain = _domainDao.findById(domainId);
+domain = _domainDao.findById(domainId);
Review comment:
:)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Optimize database transactions in ListDomain API to improve performance
> ---
>
> Key: CLOUDSTACK-10104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Reporter: Pranali Mande
>
> While creating the response object for the 'listDomain' API, several database
> calls are triggered to fetch details like parent domain, project limit, IP
> limit, etc. These database calls are triggered for each record found for in
> the main fetch query, which is causing the response to slow down. The
> database transactions could be optimized to reduce the response time of the
> Listdomain API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313411#comment-16313411 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - DaanHoogland commented on a change in pull request #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159821175 ## File path: server/src/com/cloud/api/query/QueryManagerImpl.java ## @@ -1890,8 +1890,7 @@ respView = ResponseView.Full; } -List domainResponses = ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(), result.first().toArray( -new DomainJoinVO[result.first().size()])); +List domainResponses = ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(), result.first()); Review comment: aren't we changing the API semantics here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313378#comment-16313378 ] ASF subversion and git services commented on CLOUDSTACK-10104: -- Commit 5fad84174a199f798396fcacedae2c56bdcc2bba in cloudstack's branch refs/heads/master from [~pranalim] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=5fad841 ] CLOUDSTACK-10104: Optimize database transactions in ListDomain API to improve performance (#2282) While creating the response object for the 'listDomain' API, several database calls are triggered to fetch details like parent domain, project limit, IP limit, etc. These database calls are triggered for each record found in the main fetch query, which is causing the response to slow down. Fix: The database transactions are reduced to improve response of the Listdomain API > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313376#comment-16313376 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-355596606 Merging this based on code reviews and test results. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313377#comment-16313377
]
ASF GitHub Bot commented on CLOUDSTACK-10104:
-
rhtyd closed pull request #2282: CLOUDSTACK-10104:Optimize database
transactions in ListDomain API to improve performance
URL: https://github.com/apache/cloudstack/pull/2282
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/api/src/com/cloud/user/ResourceLimitService.java
b/api/src/com/cloud/user/ResourceLimitService.java
index 0ec2dc1c758..aee2e1515e5 100644
--- a/api/src/com/cloud/user/ResourceLimitService.java
+++ b/api/src/com/cloud/user/ResourceLimitService.java
@@ -104,6 +104,14 @@
*/
public long findCorrectResourceLimitForDomain(Domain domain, ResourceType
type);
+/**
+ * Finds the default resource limit for a specified type.
+ *
+ * @param resourceType
+ * @return resource limit
+ */
+public long findDefaultResourceLimitForDomain(ResourceType resourceType);
+
/**
* Increments the resource count
*
diff --git a/server/src/com/cloud/api/ApiDBUtils.java
b/server/src/com/cloud/api/ApiDBUtils.java
index 9f67aa748f5..22ed2437d4d 100644
--- a/server/src/com/cloud/api/ApiDBUtils.java
+++ b/server/src/com/cloud/api/ApiDBUtils.java
@@ -867,6 +867,15 @@ public static long findCorrectResourceLimit(Long limit,
long accountId, Resource
return
s_resourceLimitMgr.findCorrectResourceLimitForAccount(accountId, limit, type);
}
+public static long findCorrectResourceLimitForDomain(Long limit,
ResourceType resourceType, long domainId) {
+//-- No limits for Root domain
+if (domainId == Domain.ROOT_DOMAIN) {
+return Resource.RESOURCE_UNLIMITED;
+}
+//--If limit doesn't have a value then fetch default limit from the
configs
+return (limit == null) ?
s_resourceLimitMgr.findDefaultResourceLimitForDomain(resourceType) : limit;
+}
+
public static long getResourceCount(ResourceType type, long accountId) {
AccountVO account = s_accountDao.findById(accountId);
@@ -981,6 +990,10 @@ public static DomainVO findDomainById(Long domainId) {
return s_domainDao.findByIdIncludingRemoved(domainId);
}
+public static DomainJoinVO findDomainJoinVOById(Long domainId) {
+return s_domainJoinDao.findByIdIncludingRemoved(domainId);
+}
+
public static DomainVO findDomainByIdIncludingRemoved(Long domainId) {
return s_domainDao.findByIdIncludingRemoved(domainId);
}
diff --git a/server/src/com/cloud/api/query/QueryManagerImpl.java
b/server/src/com/cloud/api/query/QueryManagerImpl.java
index 2a6919bcf71..1c9890f2269 100644
--- a/server/src/com/cloud/api/query/QueryManagerImpl.java
+++ b/server/src/com/cloud/api/query/QueryManagerImpl.java
@@ -1890,8 +1890,7 @@
respView = ResponseView.Full;
}
-List domainResponses =
ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(),
result.first().toArray(
-new DomainJoinVO[result.first().size()]));
+List domainResponses =
ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(),
result.first());
response.setResponses(domainResponses, result.second());
return response;
}
@@ -1901,9 +1900,10 @@
Long domainId = cmd.getId();
boolean listAll = cmd.listAll();
boolean isRecursive = false;
+Domain domain = null;
if (domainId != null) {
-Domain domain = _domainDao.findById(domainId);
+domain = _domainDao.findById(domainId);
if (domain == null) {
throw new InvalidParameterValueException("Domain id=" +
domainId + " doesn't exist");
}
@@ -1947,7 +1947,10 @@
if (domainId != null) {
if (isRecursive) {
-sc.setParameters("path",
_domainDao.findById(domainId).getPath() + "%");
+if(domain == null){
+domain = _domainDao.findById(domainId);
+}
+sc.setParameters("path", domain.getPath() + "%");
} else {
sc.setParameters("id", domainId);
}
diff --git a/server/src/com/cloud/api/query/ViewResponseHelper.java
b/server/src/com/cloud/api/query/ViewResponseHelper.java
index 11af5a9e760..940ae288c42 100644
--- a/server/src/com/cloud/api/query/ViewResponseHelper.java
+++ b/server/src/com/cloud/api/query/ViewResponseHelper.java
@@ -18,11 +18,16 @@
import java.text.DecimalFormat;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.EnumSet;
+import
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312760#comment-16312760
]
ASF GitHub Bot commented on CLOUDSTACK-10104:
-
yvsubhash commented on a change in pull request #2282:
CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve
performance
URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159397903
##
File path: server/src/com/cloud/api/query/ViewResponseHelper.java
##
@@ -375,14 +380,164 @@ else if (vr.getFormat() == ImageFormat.OVA){
return new ArrayList(vrDataList.values());
}
-public static List createDomainResponse(ResponseView view,
EnumSet details, DomainJoinVO... domains) {
+public static List createDomainResponse(ResponseView view,
EnumSet details, List domains) {
List respList = new ArrayList();
-for (DomainJoinVO vt : domains){
-respList.add(ApiDBUtils.newDomainResponse(view, details, vt));
+//-- Coping the list to keep original order
+List domainsCopy = new ArrayList<>(domains);
+Collections.sort(domainsCopy, DomainJoinVO.domainIdComparator);
+for (DomainJoinVO domainJoinVO : domains){
+//-- Set parent information
+DomainJoinVO parentDomainJoinVO =
searchParentDomainUsingBinary(domainsCopy, domainJoinVO);
+if(parentDomainJoinVO == null && domainJoinVO.getParent() != null)
{
Review comment:
@PranaliM What is the scenario we go in to this case?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Optimize database transactions in ListDomain API to improve performance
> ---
>
> Key: CLOUDSTACK-10104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Reporter: Pranali Mande
>
> While creating the response object for the 'listDomain' API, several database
> calls are triggered to fetch details like parent domain, project limit, IP
> limit, etc. These database calls are triggered for each record found for in
> the main fetch query, which is causing the response to slow down. The
> database transactions could be optimized to reduce the response time of the
> Listdomain API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312758#comment-16312758
]
ASF GitHub Bot commented on CLOUDSTACK-10104:
-
yvsubhash commented on a change in pull request #2282:
CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve
performance
URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159397903
##
File path: server/src/com/cloud/api/query/ViewResponseHelper.java
##
@@ -375,14 +380,164 @@ else if (vr.getFormat() == ImageFormat.OVA){
return new ArrayList(vrDataList.values());
}
-public static List createDomainResponse(ResponseView view,
EnumSet details, DomainJoinVO... domains) {
+public static List createDomainResponse(ResponseView view,
EnumSet details, List domains) {
List respList = new ArrayList();
-for (DomainJoinVO vt : domains){
-respList.add(ApiDBUtils.newDomainResponse(view, details, vt));
+//-- Coping the list to keep original order
+List domainsCopy = new ArrayList<>(domains);
+Collections.sort(domainsCopy, DomainJoinVO.domainIdComparator);
+for (DomainJoinVO domainJoinVO : domains){
+//-- Set parent information
+DomainJoinVO parentDomainJoinVO =
searchParentDomainUsingBinary(domainsCopy, domainJoinVO);
+if(parentDomainJoinVO == null && domainJoinVO.getParent() != null)
{
Review comment:
@PranaliM What is the scenario we go in to this case?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Optimize database transactions in ListDomain API to improve performance
> ---
>
> Key: CLOUDSTACK-10104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Reporter: Pranali Mande
>
> While creating the response object for the 'listDomain' API, several database
> calls are triggered to fetch details like parent domain, project limit, IP
> limit, etc. These database calls are triggered for each record found for in
> the main fetch query, which is causing the response to slow down. The
> database transactions could be optimized to reduce the response time of the
> Listdomain API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312545#comment-16312545 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-355481846 Tests LGTM, the failure is env related. One more code lgtm is needed to get this merged, additional review requested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308676#comment-16308676 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354870130 Trillian test result (tid-1968) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29253 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2282-t1968-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 64 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_network_garbage_collector_nics | `Failure` | 276.42 | test_vpc_redundant.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.26 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307962#comment-16307962 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354757717 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307960#comment-16307960 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354757619 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307948#comment-16307948 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354754082 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1538 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307916#comment-16307916 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354749206 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307917#comment-16307917 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354749075 @PranaliM I'll rekick tests. Additional code review/lgtm is needed as well. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307914#comment-16307914 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354749075 @PranaliM I'll rekick tests. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307702#comment-16307702 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - PranaliM commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354705444 @rhtdy, The failing test case is related to fenced HA when host crashes, and is not related to this change related to ListDomain. So do I have an action item on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305672#comment-16305672 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354341852 Trillian test result (tid-1936) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32835 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2282-t1936-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 65 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_hostha_kvm_host_fencing | `Error` | 658.64 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305282#comment-16305282 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354263667 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305285#comment-16305285 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354263723 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305254#comment-16305254 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354261853 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1509 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305213#comment-16305213 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354257328 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305211#comment-16305211 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354257260 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304658#comment-16304658 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - PranaliM commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354139467 I have fixed the conflicts @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292442#comment-16292442 ] ASF GitHub Bot commented on CLOUDSTACK-10104: - rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-351996324 @PranaliM can you fix conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189386#comment-16189386 ] Pranali Mande commented on CLOUDSTACK-10104: PR : https://github.com/apache/cloudstack/pull/2282 > Optimize database transactions in ListDomain API to improve performance > --- > > Key: CLOUDSTACK-10104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Pranali Mande > > While creating the response object for the 'listDomain' API, several database > calls are triggered to fetch details like parent domain, project limit, IP > limit, etc. These database calls are triggered for each record found for in > the main fetch query, which is causing the response to slow down. The > database transactions could be optimized to reduce the response time of the > Listdomain API -- This message was sent by Atlassian JIRA (v6.4.14#64029)
