[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463718#comment-16463718 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rhtyd commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-386567835 @rafaelweingartner fair enough, but this seems a useful fix for LTS nonetheless. I'll leave the decision of backporting to you on this (and other PRs). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463644#comment-16463644 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-386554881 I do not think so. It seems that no other people had this necessity so far. This PR enables people to use local storage and pre-setup storage at the same time. Moreover, I organized things, and now it is possible to have more than a single local storage per host. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463543#comment-16463543 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rhtyd commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-386533549 @rafaelweingartner I scanned PRs merged on master but not 4.11 and came across this PR, do you think this would be useful for 4.11? If so, can you help create a backport PR for 4.11? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432128#comment-16432128 ] ASF subversion and git services commented on CLOUDSTACK-10226: -- Commit bbc92046655bc528846090eddf1fc38abd2da90a in cloudstack's branch refs/heads/master from [~rafaelweingartner] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=bbc9204 ] [CLOUDSTACK-10226] CloudStack is not importing Local storage properly (#2401) * [CLOUDSTACK-10226] CloudStack is not importing Local storage properly CloudStack is importing as Local storage any XenServer SR that is of type LVM or EXT. This causes a problem when one wants to use both Direct attach storage and local storage. Moreover, CloudStack was not importing all of the local storage that a host has available when local storage is enabled. It was only importing the First SR it sees. To fix the first problem we started ignoring SRs that have the flag shared=true when discovering local storages. SRs configured to be shared are used as direct attached storage, and therefore should not be imported again as local ones. To fix the second problem, we started loading all Local storage and importing them accordingly to ACS. * Cleanups and formatting > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432127#comment-16432127 ] ASF subversion and git services commented on CLOUDSTACK-10226: -- Commit bbc92046655bc528846090eddf1fc38abd2da90a in cloudstack's branch refs/heads/master from [~rafaelweingartner] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=bbc9204 ] [CLOUDSTACK-10226] CloudStack is not importing Local storage properly (#2401) * [CLOUDSTACK-10226] CloudStack is not importing Local storage properly CloudStack is importing as Local storage any XenServer SR that is of type LVM or EXT. This causes a problem when one wants to use both Direct attach storage and local storage. Moreover, CloudStack was not importing all of the local storage that a host has available when local storage is enabled. It was only importing the First SR it sees. To fix the first problem we started ignoring SRs that have the flag shared=true when discovering local storages. SRs configured to be shared are used as direct attached storage, and therefore should not be imported again as local ones. To fix the second problem, we started loading all Local storage and importing them accordingly to ACS. * Cleanups and formatting > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432126#comment-16432126
]
ASF GitHub Bot commented on CLOUDSTACK-10226:
-
rafaelweingartner closed pull request #2401: [CLOUDSTACK-10226] CloudStack is
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
index 19670b2066e..4a9001b27da 100644
---
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
+++
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
@@ -51,8 +51,10 @@
import org.apache.cloudstack.storage.to.TemplateObjectTO;
import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.collections.MapUtils;
import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang3.BooleanUtils;
import org.apache.log4j.Logger;
import org.apache.xmlrpc.XmlRpcException;
import org.joda.time.Duration;
@@ -173,7 +175,7 @@
* used to describe what type of resource a storage device is of
*/
public enum SRType {
-EXT, FILE, ISCSI, ISO, LVM, LVMOHBA, LVMOISCSI,
+EXT, ISO, LVM, LVMOHBA, LVMOISCSI,
/**
* used for resigning metadata (like SR UUID and VDI UUID when a
* particular storage manager is installed on a XenServer host (for
back-end snapshots to work))
@@ -761,11 +763,6 @@ protected VDI cloudVDIcopy(final Connection conn, final
VDI vdi, final SR sr, in
final HashMap vmMetaDatum = new HashMap();
try {
final Map vm_map = VM.getAllRecords(conn); // USE
-// THIS TO
-// GET ALL
-// VMS
-// FROM A
-// CLUSTER
if (vm_map != null) {
for (final VM.Record record : vm_map.values()) {
if (record.isControlDomain || record.isASnapshot ||
record.isATemplate) {
@@ -2274,16 +2271,11 @@ public HostStatsEntry getHostStats(final Connection
conn, final GetHostStatsComm
}
protected HashMap
getHostVmStateReport(final Connection conn) {
-
-// TODO : new VM sync model does not require a cluster-scope report, we
-// need to optimize
-// the report accordingly
final HashMap vmStates = new
HashMap();
Map vm_map = null;
for (int i = 0; i < 2; i++) {
try {
-vm_map = VM.getAllRecords(conn); // USE THIS TO GET ALL VMS
FROM
-// A CLUSTER
+vm_map = VM.getAllRecords(conn);
break;
} catch (final Throwable e) {
s_logger.warn("Unable to get vms", e);
@@ -2652,76 +2644,6 @@ public String getLabel() {
return result;
}
-protected SR getLocalEXTSR(final Connection conn) {
-try {
-final Map map = SR.getAllRecords(conn);
-if (map != null && !map.isEmpty()) {
-for (final Map.Entry entry : map.entrySet()) {
-final SR.Record srRec = entry.getValue();
-if (SRType.FILE.equals(srRec.type) ||
SRType.EXT.equals(srRec.type)) {
-final Set pbds = srRec.PBDs;
-if (pbds == null) {
-continue;
-}
-for (final PBD pbd : pbds) {
-final Host host = pbd.getHost(conn);
-if (!isRefNull(host) &&
host.getUuid(conn).equals(_host.getUuid())) {
-if (!pbd.getCurrentlyAttached(conn)) {
-pbd.plug(conn);
-}
-final SR sr = entry.getKey();
-sr.scan(conn);
-return sr;
-}
-}
-}
-}
-}
-} catch (final XenAPIException e) {
-final String msg = "Unable to get local EXTSR in host:" +
_host.getUuid() + e.toString();
-
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431310#comment-16431310 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-379898361 @borisstoyanov now I believe that the test result is ok. These failures seem to be intermittent, not just here, but in other PRs as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431301#comment-16431301 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-379896164 Trillian test result (tid-2478) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 22757 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2401-t2478-xenserver-71.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 64 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Error` | 9.23 | test_scale_vm.py ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | test_service_offerings.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 518.16 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426599#comment-16426599 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378851349 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426598#comment-16426598 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - borisstoyanov commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378851222 @blueorangutan test centos7 xenserver-71 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426110#comment-16426110 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378729792 @DaanHoogland I do not think @blueorangutan heard your request for testing here... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423186#comment-16423186 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - DaanHoogland commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378059365 I don't think it makes sense but no hurt @blueorangutan centos7 xenserver-71 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423156#comment-16423156 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378050143 @borisstoyanov and @DaanHoogland shall we execute the tests again? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423086#comment-16423086 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - mike-tutkowski commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378034267 I do not see how the VPC issue would be related to the code of this PR either. The PR code LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422235#comment-16422235 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - mike-tutkowski commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377926180 Sorry @DaanHoogland - I didn't seem to get notified when you tagged me. I just noticed this PR when @rafaelweingartner tagged me today. Let me review this PR and think about it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422158#comment-16422158 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377912069 @mike-tutkowski could you share your wisdom with us here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418788#comment-16418788
]
ASF GitHub Bot commented on CLOUDSTACK-10226:
-
rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377205506
@DaanHoogland I checked the error, and I still do not understand how it
could be related to the code of this PR. Here I am only changing how local
storages are detected and loaded to the system. Whereas, the error is related
to redundant VRs in VPCs.
Anyways, I am trying to run the tests locally with simulator, but I am
getting this error:
```
ERROR: do_vpc_test (integration.smoke.test_vpc_redundant.TestVPCRedundancy)
--
TypeError: do_vpc_test() takes exactly 2 arguments (1 given)
>> begin captured stdout << -
=== TestName: do_vpc_test | Status : EXCEPTION ===
```
I am not understanding the cause of that error. This is the command I am
using to execute the test:
`nosetests --with-marvin --marvin-config=/root/marvinCloudStackConfig.cfg
--hypervisor=simulator
/root/cloudstack/test/integration/smoke/test_vpc_redundant.py`
Am I missing something else that is required to run tests?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CloudStack is not importing Local storage properly
> ---
>
> Key: CLOUDSTACK-10226
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: XenServer
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is importing as Local storage any XenServer SR that is of type LVM
> or EXT. This causes a problem when one wants to use both Direct attach
> storage and local storage. Moreover, CloudStack was not importing all of the
> local storage that a host has available when local storage is enabled. It was
> only importing the First SR it sees.
> To fix the first problem we started ignoring SRs that have the flag
> shared=true when discovering local storages. SRs configured to be shared are
> used as direct attached storage, and therefore should not be imported again
> as local ones.
> To fix the second problem, we started loading all Local storage and importing
> them accordingly to ACS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418584#comment-16418584 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - DaanHoogland commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377157866 @rafaelweingartner , i'm cautious here. This one seems consistent. Did you explain the cause of the failure? @mike-tutkowski can you review this (and add yourself to the apache org)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418226#comment-16418226 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377066722 @DaanHoogland I checked this last log result. Can I consider that the tests is successful then? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418225#comment-16418225 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377066408 Trillian test result (tid-2436) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 22786 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2401-t2436-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_network_garbage_collector_nics | `Failure` | 452.86 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417681#comment-16417681 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376947269 I checked the logs. The problems did not seem to be related to the PR. However, it is always good to have the feedback of an expert ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417675#comment-16417675 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376946598 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417674#comment-16417674 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - DaanHoogland commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376946409 I think it is @rafaelweingartner let me rekick anyway, you can download the logs and examine them. @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417663#comment-16417663 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376944918 @DaanHoogland it seems that the tests you executed here were successful (despite the errors presented). Can you confirm it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406758#comment-16406758 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374691568 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1797 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406565#comment-16406565 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374655583 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406563#comment-16406563 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374655519 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405502#comment-16405502 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374391259 Trillian test result (tid-2395) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21881 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2401-t2395-xenserver-71.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 64 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Error` | 10.33 | test_scale_vm.py ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | test_service_offerings.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 507.42 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404956#comment-16404956 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374248526 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404955#comment-16404955 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - DaanHoogland commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374248408 @blueorangutan test centos7 xenserver-71 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404951#comment-16404951 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - DaanHoogland commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374247491 @blueorangutan help This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404953#comment-16404953 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374247738 @DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [additional tests] Mgmt OS options: ['centos6', 'centos7', 'ubuntu'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-65', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1'] Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command. Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland'] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404823#comment-16404823 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374216584 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1792 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404725#comment-16404725 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374194968 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404723#comment-16404723 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-374194761 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320194#comment-16320194 ] ASF GitHub Bot commented on CLOUDSTACK-10226: - rafaelweingartner opened a new pull request #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401 CloudStack is importing as Local storage any XenServer SR that is of type LVM or EXT. This causes a problem when one wants to use both Direct attach storage and local storage. Moreover, CloudStack was not importing all of the local storage that a host has available when local storage is enabled. It was only importing the First SR it sees. To fix the first problem we started ignoring SRs that have the flag shared=true when discovering local storages. SRs configured to be shared are used as direct attached storage, and therefore should not be imported again as local ones. To fix the second problem, we started loading all Local storage and importing them accordingly to ACS. Tip for reviewers: the code changes is mainly in `CitrixResourceBase`, method `initializeLocalSR` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CloudStack is not importing Local storage properly > --- > > Key: CLOUDSTACK-10226 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner > Fix For: 4.12 > > > CloudStack is importing as Local storage any XenServer SR that is of type LVM > or EXT. This causes a problem when one wants to use both Direct attach > storage and local storage. Moreover, CloudStack was not importing all of the > local storage that a host has available when local storage is enabled. It was > only importing the First SR it sees. > To fix the first problem we started ignoring SRs that have the flag > shared=true when discovering local storages. SRs configured to be shared are > used as direct attached storage, and therefore should not be imported again > as local ones. > To fix the second problem, we started loading all Local storage and importing > them accordingly to ACS. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
