[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378737#comment-16378737
 ] 

ASF subversion and git services commented on CLOUDSTACK-10299:
--

Commit 0bb20a7ed27865c01f81bca191e6347c32be9c4c in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=0bb20a7 ]

Merge pull request #2464 from resmo/fix/4.11/CLOUDSTACK-10299

[4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode

> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378736#comment-16378736
 ] 

ASF subversion and git services commented on CLOUDSTACK-10299:
--

Commit bff7c01f19264e85c0da4a79c45f619761cfcc86 in cloudstack's branch 
refs/heads/master from Rene Moser
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=bff7c01 ]

CLOUDSTACK-10299: UI: fix error in network listing in project mode


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378739#comment-16378739
 ] 

ASF subversion and git services commented on CLOUDSTACK-10299:
--

Commit e1b124699337195ebce88aeddcc167b7e1dc2977 in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=e1b1246 ]

Forward merge #2464 merged on '4.11' branch

[4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378738#comment-16378738
 ] 

ASF subversion and git services commented on CLOUDSTACK-10299:
--

Commit 0bb20a7ed27865c01f81bca191e6347c32be9c4c in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=0bb20a7 ]

Merge pull request #2464 from resmo/fix/4.11/CLOUDSTACK-10299

[4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode

> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378724#comment-16378724
 ] 

ASF subversion and git services commented on CLOUDSTACK-10299:
--

Commit 0bb20a7ed27865c01f81bca191e6347c32be9c4c in cloudstack's branch 
refs/heads/4.11 from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=0bb20a7 ]

Merge pull request #2464 from resmo/fix/4.11/CLOUDSTACK-10299

[4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode

> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378721#comment-16378721
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner closed pull request #2464: [4.11] CLOUDSTACK-10299: UI: fix 
error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/scripts/network.js b/ui/scripts/network.js
index 7b9f75e7fda..bcb748d49de 100644
--- a/ui/scripts/network.js
+++ b/ui/scripts/network.js
@@ -86,12 +86,6 @@
 });
 
 } else { //non-portable IP which has only one NIC
-/*
- var nic = $.grep(instance.nic, function(nic) {
- return nic.networkid == network.id;
- })[0];
- */
-
 // Get NIC IPs
 $.ajax({
 url: createURL('listNics'),
@@ -170,12 +164,6 @@
 });
 
 } else { //non-portable IP which has only one NIC
-/*
- var nic = $.grep(instance.nic, function(nic) {
- return nic.networkid == network.id;
- })[0];
- */
-
 // Get NIC IPs
 $.ajax({
 url: createURL('listNics'),
@@ -412,8 +400,6 @@
 $.ajax({
 url: createURL('listRemoteAccessVpns'),
 data: {
-account: g_account,
-domainid: g_domainid,
 listAll: true
 },
 async: false,
@@ -1995,8 +1981,6 @@
 $.ajax({
 url: createURL('listZones'),
 data: dataObj,
-//  id: args.context.networks[0].zoneid
-//},
 async: false,
 success: function(json) {
 zoneObj = 
json.listzonesresponse.zone[0];
@@ -3524,7 +3508,7 @@
 
 var stickyData = 
$.extend(true, {}, args.data.sticky);
 var certificateData = 
$.extend(true, {}, args.data.sslcertificate);
-  
+
 //* create new LB rule > 
Add VMs *
 $.ajax({
 url: 
createURL('createLoadBalancerRule'),
@@ -3537,70 +3521,27 @@
 var lbID = 
data.createloadbalancerruleresponse.id;
 
 var inputData = {
-   id: 
data.createloadbalancerruleresponse.id  
-};
-
+   id: 
data.createloadbalancerruleresponse.id
+};
+
 var selectedVMs = 
args.itemData;
 if (selectedVMs != 
null) {
var 
vmidipmapIndex = 0;
-   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {  
+   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
var 
selectedIPs = selectedVMs[vmIndex]._subselect;
for 
(var ipIndex = 0; ipIndex < selectedIPs.length; ipIndex++) {

inputData['vmidipmap[' + vmidipmapIndex + '].vmid'] = selectedVMs[vmIndex].id;
-   
+

if (args.context.ipAddresses[0].isportable) {
-   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];  
+ 

[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378723#comment-16378723
 ] 

ASF subversion and git services commented on CLOUDSTACK-10299:
--

Commit 0bb20a7ed27865c01f81bca191e6347c32be9c4c in cloudstack's branch 
refs/heads/4.11 from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=0bb20a7 ]

Merge pull request #2464 from resmo/fix/4.11/CLOUDSTACK-10299

[4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode

> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378722#comment-16378722
 ] 

ASF subversion and git services commented on CLOUDSTACK-10299:
--

Commit bff7c01f19264e85c0da4a79c45f619761cfcc86 in cloudstack's branch 
refs/heads/4.11 from Rene Moser
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=bff7c01 ]

CLOUDSTACK-10299: UI: fix error in network listing in project mode


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378720#comment-16378720
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix 
error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-368907829
 
 
   Nothing... I was busy with some other things.
   I am merging this one now


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378629#comment-16378629
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

DaanHoogland commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error 
in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-368890212
 
 
   anything holding you back, @rafaelweingartner ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378595#comment-16378595
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix 
error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-368877782
 
 
   Got it. I think this one is ready to be merged then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378568#comment-16378568
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in 
network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-368872305
 
 
   @rafaelweingartner I couldn't test the view with having existing remote vpns 
configured. But my assumption was that the api is working identically as other 
list apis returning the results of the current owner.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378431#comment-16378431
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix 
error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-368841687
 
 
   There is still one open question of mine there. It is about some parameters 
that were removed. I am asking if that removal can affect the loading of 
information for the default view (view outside of project).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378428#comment-16378428
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

DaanHoogland commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error 
in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-368841137
 
 
   @borisstoyanov @rafaelweingartner is this merge ready?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376669#comment-16376669
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in 
network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-368464113
 
 
   ready for review


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376648#comment-16376648
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in 
network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-368459084
 
 
   Before
   
   
![selection_149](https://user-images.githubusercontent.com/23809/3001-7a44ebee-1ae9-11e8-868f-c3b697ad54f7.png)
   
   After
   
   
![selection_151](https://user-images.githubusercontent.com/23809/3027-8c1a956c-1ae9-11e8-9619-b4fd31d202d9.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371837#comment-16371837
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

borisstoyanov commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error 
in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367427801
 
 
   @resmo both if you have. If no, new stuff is what's interesting :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371390#comment-16371390
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in 
network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367321243
 
 
   @borisstoyanov before or after the patch? I attached the screenshot to the 
issue in jira. Didn't make one after the patch, as you see "nothing". 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371391#comment-16371391
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in 
network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367321243
 
 
   @borisstoyanov before or after the patch? I attached the screenshot to the 
issue in jira. Didn't make one after the patch, as you see "nothing" (no 
error). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371387#comment-16371387
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in 
network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367321243
 
 
   @borisstoyanov before or after the patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371354#comment-16371354
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

blueorangutan commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error 
in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367315632
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1728


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371304#comment-16371304
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner commented on a change in pull request #2464: [4.11] 
CLOUDSTACK-10299: UI: fix error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169619221
 
 

 ##
 File path: ui/scripts/network.js
 ##
 @@ -412,8 +412,6 @@
 $.ajax({
 url: createURL('listRemoteAccessVpns'),
 data: {
-account: g_account,
 
 Review comment:
   Is this call only used in the project view?
   I mean, if I list networks and I am out of the project view, should not ACS 
filter by these data? Or, is it done automatically in the server side when the 
users is logged-in?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371302#comment-16371302
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner commented on a change in pull request #2464: [4.11] 
CLOUDSTACK-10299: UI: fix error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169617944
 
 

 ##
 File path: ui/scripts/network.js
 ##
 @@ -3537,28 +3535,28 @@
 var lbID = 
data.createloadbalancerruleresponse.id;
 
 var inputData = {
-   id: 
data.createloadbalancerruleresponse.id  
-};
-
+   id: 
data.createloadbalancerruleresponse.id
+};
+
 var selectedVMs = 
args.itemData;
 if (selectedVMs != 
null) {
var 
vmidipmapIndex = 0;
-   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {  
+   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
var 
selectedIPs = selectedVMs[vmIndex]._subselect;
for 
(var ipIndex = 0; ipIndex < selectedIPs.length; ipIndex++) {

inputData['vmidipmap[' + vmidipmapIndex + '].vmid'] = selectedVMs[vmIndex].id;
-   
+

if (args.context.ipAddresses[0].isportable) {
-   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];  
+   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];

} else {

inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex];

}
-   
+

vmidipmapIndex++;
-   }   

+   }
}
-   }   
-
+   }
+
 /*$.ajax({
 
 Review comment:
   Great. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371298#comment-16371298
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on a change in pull request #2464: [4.11] CLOUDSTACK-10299: UI: 
fix error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169617346
 
 

 ##
 File path: ui/scripts/network.js
 ##
 @@ -3537,28 +3535,28 @@
 var lbID = 
data.createloadbalancerruleresponse.id;
 
 var inputData = {
-   id: 
data.createloadbalancerruleresponse.id  
-};
-
+   id: 
data.createloadbalancerruleresponse.id
+};
+
 var selectedVMs = 
args.itemData;
 if (selectedVMs != 
null) {
var 
vmidipmapIndex = 0;
-   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {  
+   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
var 
selectedIPs = selectedVMs[vmIndex]._subselect;
for 
(var ipIndex = 0; ipIndex < selectedIPs.length; ipIndex++) {

inputData['vmidipmap[' + vmidipmapIndex + '].vmid'] = selectedVMs[vmIndex].id;
-   
+

if (args.context.ipAddresses[0].isportable) {
-   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];  
+   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];

} else {

inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex];

}
-   
+

vmidipmapIndex++;
-   }   

+   }
}
-   }   
-
+   }
+
 /*$.ajax({
 
 Review comment:
   I see your point. cleaning up commented out code makes sense.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371290#comment-16371290
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner commented on a change in pull request #2464: [4.11] 
CLOUDSTACK-10299: UI: fix error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169616063
 
 

 ##
 File path: ui/scripts/network.js
 ##
 @@ -3537,28 +3535,28 @@
 var lbID = 
data.createloadbalancerruleresponse.id;
 
 var inputData = {
-   id: 
data.createloadbalancerruleresponse.id  
-};
-
+   id: 
data.createloadbalancerruleresponse.id
+};
+
 var selectedVMs = 
args.itemData;
 if (selectedVMs != 
null) {
var 
vmidipmapIndex = 0;
-   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {  
+   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
var 
selectedIPs = selectedVMs[vmIndex]._subselect;
for 
(var ipIndex = 0; ipIndex < selectedIPs.length; ipIndex++) {

inputData['vmidipmap[' + vmidipmapIndex + '].vmid'] = selectedVMs[vmIndex].id;
-   
+

if (args.context.ipAddresses[0].isportable) {
-   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];  
+   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];

} else {

inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex];

}
-   
+

vmidipmapIndex++;
-   }   

+   }
}
-   }   
-
+   }
+
 /*$.ajax({
 
 Review comment:
   Well.. the commented code is not used. So, there is your reason to remove 
it. The less "code" (lines) for our eyes to see, the better.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by 

[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371287#comment-16371287
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

borisstoyanov commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error 
in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367304456
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371288#comment-16371288
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

blueorangutan commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error 
in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367304540
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371016#comment-16371016
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on a change in pull request #2464: [4.11] CLOUDSTACK-10299: UI: 
fix error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169546207
 
 

 ##
 File path: ui/scripts/network.js
 ##
 @@ -3537,28 +3535,28 @@
 var lbID = 
data.createloadbalancerruleresponse.id;
 
 var inputData = {
-   id: 
data.createloadbalancerruleresponse.id  
-};
-
+   id: 
data.createloadbalancerruleresponse.id
+};
+
 var selectedVMs = 
args.itemData;
 if (selectedVMs != 
null) {
var 
vmidipmapIndex = 0;
-   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {  
+   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
var 
selectedIPs = selectedVMs[vmIndex]._subselect;
for 
(var ipIndex = 0; ipIndex < selectedIPs.length; ipIndex++) {

inputData['vmidipmap[' + vmidipmapIndex + '].vmid'] = selectedVMs[vmIndex].id;
-   
+

if (args.context.ipAddresses[0].isportable) {
-   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];  
+   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];

} else {

inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex];

}
-   
+

vmidipmapIndex++;
-   }   

+   }
}
-   }   
-
+   }
+
 /*$.ajax({
 
 Review comment:
   I didn't see a reason why to remove comments, I wanted to fix the issue. 
Whitespace cleanup was made by my editor automatically.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA

[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371015#comment-16371015
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in 
network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367228908
 
 
   @rafaelweingartner changed the base to 4.11


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370754#comment-16370754
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix 
error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367160909
 
 
   @resmo thanks for the contributions, but I have a doubt. You say it (the PR) 
is aimed at 4.11, but you opened a PR against master branch. Which one do you 
want?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370751#comment-16370751
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

rafaelweingartner commented on a change in pull request #2464: [4.11] 
CLOUDSTACK-10299: UI: fix error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169496341
 
 

 ##
 File path: ui/scripts/network.js
 ##
 @@ -3537,28 +3535,28 @@
 var lbID = 
data.createloadbalancerruleresponse.id;
 
 var inputData = {
-   id: 
data.createloadbalancerruleresponse.id  
-};
-
+   id: 
data.createloadbalancerruleresponse.id
+};
+
 var selectedVMs = 
args.itemData;
 if (selectedVMs != 
null) {
var 
vmidipmapIndex = 0;
-   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {  
+   for (var 
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
var 
selectedIPs = selectedVMs[vmIndex]._subselect;
for 
(var ipIndex = 0; ipIndex < selectedIPs.length; ipIndex++) {

inputData['vmidipmap[' + vmidipmapIndex + '].vmid'] = selectedVMs[vmIndex].id;
-   
+

if (args.context.ipAddresses[0].isportable) {
-   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];  
+   
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex].split(',')[1];

} else {

inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] = 
selectedIPs[ipIndex];

}
-   
+

vmidipmapIndex++;
-   }   

+   }
}
-   }   
-
+   }
+
 /*$.ajax({
 
 Review comment:
   You have gone over some commented code. What about removing it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode

2018-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370166#comment-16370166
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10299:
-

resmo opened a new pull request #2464: CLOUDSTACK-10299: UI: fix error in 
network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464
 
 
   Statically passing account (and domainid) results in a conflict when in 
project view because projectid and account can not be used together. 
   
   Removing the 2 params. fixes the issue. (some whitespace fixes along)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Network listing return error in project mode
> 
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.11.0.0
>Reporter: René Moser
>Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>  
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
>  and projectId can't be specified together"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)