[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469009#comment-16469009
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
rhtyd closed pull request #2600: CLOUDSTACK-10362: Change the "getXXX" method
names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
index 0bde79bbd7b..3448698cd37 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
@@ -166,15 +166,15 @@ public String getServiceOfferingName() {
return serviceOfferingName;
}
-public Boolean getOfferHa() {
+public Boolean isOfferHa() {
return offerHa == null ? Boolean.FALSE : offerHa;
}
-public Boolean GetLimitCpuUse() {
+public Boolean isLimitCpuUse() {
return limitCpuUse == null ? Boolean.FALSE : limitCpuUse;
}
-public Boolean getVolatileVm() {
+public Boolean isVolatileVm() {
return isVolatile == null ? Boolean.FALSE : isVolatile;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
index d4f2d5ad611..d5edd301a66 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
@@ -119,7 +119,7 @@ public Long getNetworkId() {
return networkId;
}
-public Boolean getForVirtualNetwork() {
+public Boolean isForVirtualNetwork() {
return forVirtualNetwork;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
index 8606c32a71e..d7761def204 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
@@ -34,7 +34,7 @@
@Override
public void execute(){
-Vpc result = _vpcService.updateVpc(getId(), getVpcName(),
getDisplayText(), getCustomId(), getDisplayVpc());
+Vpc result = _vpcService.updateVpc(getId(), getVpcName(),
getDisplayText(), getCustomId(), isDisplayVpc());
if (result != null) {
VpcResponse response =
_responseGenerator.createVpcResponse(ResponseView.Full, result);
response.setResponseName(getCommandName());
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
index 0a0e7a12076..d590081104a 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
@@ -133,11 +133,11 @@ public Long getAssociatedNetworkId() {
return associatedNetworkId;
}
-public Boolean getIsSourceNat() {
+public Boolean isSourceNat() {
return isSourceNat;
}
-public Boolean getIsStaticNat() {
+public Boolean isStaticNat() {
return isStaticNat;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
index 041d6417044..a61c59734c6 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
@@ -123,11 +123,11 @@ public Long getPhysicalNetworkId() {
return supportedServices;
}
-public Boolean getRestartRequired() {
+public Boolean isRestartRequired() {
return restartRequired;
}
-public Boolean getSpecifyIpRanges() {
+public Boolean isSpecifyIpRanges() {
return specifyIpRanges;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
index 8161fb2564b..7fc54884099
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469010#comment-16469010
]
ASF subversion and git services commented on CLOUDSTACK-10362:
--
Commit 951f73b10749b1d713ab1d740e6667def4bac212 in cloudstack's branch
refs/heads/master from [~BruceKuiLIU]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=951f73b ]
CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX" (#2600)
These Boolean-return methods are named "getXXX", but other Boolean-return
methods are named "isXXX", such as the following two methods. They will return
boolean values, rename them as "isXXX" should be more clear than "getXXX".
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467314#comment-16467314
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
rafaelweingartner commented on issue #2600: CLOUDSTACK-10362: Change the
"getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-387381297
@DaanHoogland so you checked it, and it seems that everything is ok? Is that
it?
If that is the case, I think we proceed as we did with others. Travis and
Jenkins are green.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463927#comment-16463927
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX"
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-386613917
these test resulta are dissappointing so i did a recursive case insensitive
search of the changed method names:
for i in
getOfferHa,isOfferHa,GetLimitCpuUse,isLimitCpuUse,getVolatileVm,isVolatileVm,getForVirtualNetwork,isForVirtualNetwork,getIsSourceNat,isSourceNat,getIsStaticNat,isStaticNat,getRestartRequired,isRestartRequired,getSpecifyIpRanges,isSpecifyIpRanges,getDisplayVm,isDisplayVm,getDisplayVpc,isDisplayVpc,getLocalStorageActive,isLocalStorageActive,getHasEnoughCapacity,hasEnoughCapacity,getSuitableForMigration,isSuitableForMigration,getDefaultUse,isDefaultUse,getForDisplay,isForDisplay,getDestroyed,isDestroyed,getListAll,isListAll,getSparseVolumes,isSparseVolumes,getPasswordEnabled,isPasswordEnabled,getRequiresHVM,isRequiresHVM,getIsPublic,isPublic,getFeatured,isFeatured,getIsExtractable,isExtractable,getBootable,isBootable,getSshKeyEnabled,isSshKeyEnabled
do
grep -ir $i *
done
```
baloujak:pr2600-t2589-kvm-centos7 dahn$ for i in
getOfferHa,isOfferHa,GetLimitCpuUse,isLimitCpuUse,getVolatileVm,isVolatileVm,getForVirtualNetwork,isForVirtualNetwork,getIsSourceNat,isSourceNat,getIsStaticNat,isStaticNat,getRestartRequired,isRestartRequired,getSpecifyIpRanges,isSpecifyIpRanges,getDisplayVm,isDisplayVm,getDisplayVpc,isDisplayVpc,getLocalStorageActive,isLocalStorageActive,getHasEnoughCapacity,hasEnoughCapacity,getSuitableForMigration,isSuitableForMigration,getDefaultUse,isDefaultUse,getForDisplay,isForDisplay,getDestroyed,isDestroyed,getListAll,isListAll,getSparseVolumes,isSparseVolumes,getPasswordEnabled,isPasswordEnabled,getRequiresHVM,isRequiresHVM,getIsPublic,isPublic,getFeatured,isFeatured,getIsExtractable,isExtractable,getBootable,isBootable,getSshKeyEnabled,isSshKeyEnabled
> do
> grep -ir $i *
> done
baloujak:pr2600-t2589-kvm-centos7 dahn$
```
no results are good results. I think we can go agead with this @rhtyd
@rafaelweingartner ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463310#comment-16463310
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
blueorangutan commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX"
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-386494010
Trillian test result (tid-2589)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43342 seconds
Marvin logs:
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2600-t2589-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 393.66 |
test_internal_lb.py
test_01_secured_vm_migration | `Error` | 43.55 | test_vm_life_cycle.py
test_02_not_secured_vm_migration | `Error` | 42.51 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 42.51 |
test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 42.49 |
test_vm_life_cycle.py
test_11_migrate_volume_and_change_offering | `Error` | 129.09 |
test_volumes.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.48 |
test_hostha_kvm.py
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462505#comment-16462505
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
blueorangutan commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX"
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-386310835
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462504#comment-16462504
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX"
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-386310596
@blueorangutan test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460699#comment-16460699
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
blueorangutan commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX"
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-385901557
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1989
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460627#comment-16460627
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
blueorangutan commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX"
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-385889655
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460626#comment-16460626
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX"
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-385889579
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457146#comment-16457146
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on a change in pull request #2600: CLOUDSTACK-10362:
Change the "getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#discussion_r184817312
##
File path:
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java
##
@@ -94,7 +94,7 @@ public String getCommandName() {
return s_name;
}
-public Boolean getListAll() {
+public Boolean isListAll() {
Review comment:
shouldListAll()???
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457145#comment-16457145
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on a change in pull request #2600: CLOUDSTACK-10362:
Change the "getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#discussion_r184817199
##
File path:
api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##
@@ -180,7 +180,7 @@ public void setIsSystemOffering(Boolean isSystem) {
this.isSystem = isSystem;
}
-public Boolean getDefaultUse() {
+public Boolean isDefaultUse() {
Review comment:
isForDefaultUse() ??!?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457144#comment-16457144
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on a change in pull request #2600: CLOUDSTACK-10362:
Change the "getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#discussion_r184816875
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##
@@ -256,7 +256,7 @@ public HypervisorType getHypervisor() {
return HypervisorType.getType(hypervisor);
}
-public Boolean getDisplayVm() {
+public Boolean isDisplayVm() {
Review comment:
this obne is strange. it means to say shouldDisplayVm() but is can live with
it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457147#comment-16457147
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on a change in pull request #2600: CLOUDSTACK-10362:
Change the "getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#discussion_r184816950
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vpc/UpdateVPCCmd.java
##
@@ -73,7 +73,7 @@ public Long getId() {
return id;
}
-public Boolean getDisplayVpc() {
+public Boolean isDisplayVpc() {
Review comment:
same here; shouldDisplayVpc()??
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457148#comment-16457148
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on a change in pull request #2600: CLOUDSTACK-10362:
Change the "getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#discussion_r184817020
##
File path:
api/src/main/java/org/apache/cloudstack/api/response/HostResponse.java
##
@@ -646,11 +646,11 @@ public String getEvents() {
return events;
}
-public Boolean getHasEnoughCapacity() {
+public Boolean hasEnoughCapacity() {
Review comment:
good choice
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457149#comment-16457149
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
DaanHoogland commented on a change in pull request #2600: CLOUDSTACK-10362:
Change the "getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#discussion_r184816875
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##
@@ -256,7 +256,7 @@ public HypervisorType getHypervisor() {
return HypervisorType.getType(hypervisor);
}
-public Boolean getDisplayVm() {
+public Boolean isDisplayVm() {
Review comment:
this one is strange. it means to say shouldDisplayVm() but is can live with
it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454184#comment-16454184
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
BruceKuiLiu opened a new pull request #2600: CLOUDSTACK-10362: Change the
"getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600
These Boolean-return methods are named "getXXX",
but other Boolean-return methods are named "isXXX", such as the following
two methods.
They will return boolean values, rename them as "isXXX" should be more clear
than "getXXX".
api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
```
public Boolean getForVirtualNetwork() {
return forVirtualNetwork;
}
```
api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
```
public Boolean isForVirtualNetwork() {
return forVirtualNetwork;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454057#comment-16454057
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
rafaelweingartner commented on issue #2599: CLOUDSTACK-10362, CLOUDSTACK-10363,
CLOUDSTACK-10364, CLOUDSTACK-10365 Change method names.
URL: https://github.com/apache/cloudstack/pull/2599#issuecomment-384638539
@BruceKuiLiu even though everything seems to be ok here, I actually likes
the three separated PRs. It reduced the scope for reviewers.
If you are going to proceed only with this one, can you please close the
others? The choice is yours.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449730#comment-16449730
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
BruceKuiLiu closed pull request #2600: CLOUDSTACK-10362: Change the "getXXX"
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
index 0bde79bbd7b..3448698cd37 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
@@ -166,15 +166,15 @@ public String getServiceOfferingName() {
return serviceOfferingName;
}
-public Boolean getOfferHa() {
+public Boolean isOfferHa() {
return offerHa == null ? Boolean.FALSE : offerHa;
}
-public Boolean GetLimitCpuUse() {
+public Boolean isLimitCpuUse() {
return limitCpuUse == null ? Boolean.FALSE : limitCpuUse;
}
-public Boolean getVolatileVm() {
+public Boolean isVolatileVm() {
return isVolatile == null ? Boolean.FALSE : isVolatile;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
index d4f2d5ad611..d5edd301a66 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
@@ -119,7 +119,7 @@ public Long getNetworkId() {
return networkId;
}
-public Boolean getForVirtualNetwork() {
+public Boolean isForVirtualNetwork() {
return forVirtualNetwork;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
index 8606c32a71e..d7761def204 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
@@ -34,7 +34,7 @@
@Override
public void execute(){
-Vpc result = _vpcService.updateVpc(getId(), getVpcName(),
getDisplayText(), getCustomId(), getDisplayVpc());
+Vpc result = _vpcService.updateVpc(getId(), getVpcName(),
getDisplayText(), getCustomId(), isDisplayVpc());
if (result != null) {
VpcResponse response =
_responseGenerator.createVpcResponse(ResponseView.Full, result);
response.setResponseName(getCommandName());
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
index 0a0e7a12076..d590081104a 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
@@ -133,11 +133,11 @@ public Long getAssociatedNetworkId() {
return associatedNetworkId;
}
-public Boolean getIsSourceNat() {
+public Boolean isSourceNat() {
return isSourceNat;
}
-public Boolean getIsStaticNat() {
+public Boolean isStaticNat() {
return isStaticNat;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
index 041d6417044..a61c59734c6 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
@@ -123,11 +123,11 @@ public Long getPhysicalNetworkId() {
return supportedServices;
}
-public Boolean getRestartRequired() {
+public Boolean isRestartRequired() {
return restartRequired;
}
-public Boolean getSpecifyIpRanges() {
+public Boolean isSpecifyIpRanges() {
return specifyIpRanges;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
index 8161fb2564b..7fc54884099
[jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449536#comment-16449536
]
ASF GitHub Bot commented on CLOUDSTACK-10362:
-
BruceKuiLiu opened a new pull request #2600: CLOUDSTACK-10362: Change the
"getXXX" method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600
These Boolean-return methods are named "getXXX",
but other Boolean-return methods are named "isXXX", such as the following
two methods.
They will return boolean values, rename them as "isXXX" should be more clear
than "getXXX".
api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
```
public Boolean getForVirtualNetwork() {
return forVirtualNetwork;
}
```
api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
```
public Boolean isForVirtualNetwork() {
return forVirtualNetwork;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -
>
> Key: CLOUDSTACK-10362
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two
> methods.
> They will return boolean values, rename them as "isXXX" should be more clear
> than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
> public Boolean getForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
> public Boolean isForVirtualNetwork() {
> return forVirtualNetwork;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
