[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964207#comment-15964207
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi  Please take care of the code change in the following 
PR as well  as i am closing 
https://github.com/apache/cloudstack/pull/1721

The change is as follows 

  server/src/com/cloud/vm/UserVmManagerImpl.java
 @@ -3242,8 +3242,9 @@ protected UserVm createVirtualMachine(DataCenter 
zone, ServiceOffering serviceOf
  throw new InvalidParameterValueException("Installing from ISO 
requires an ISO that is bootable: " + template.getId());
  }
  
 -// Check templates permissions
 -_accountMgr.checkAccess(owner, AccessType.UseEntry, false, 
template);
 +// Check templates permissions when the create vm is not from 
snapshot
 +if(vmSnapshot == null)
 +_accountMgr.checkAccess(owner, AccessType.UseEntry, false, 
template);
  
  // check if the user data is correct
  validateUserData(userData, httpmethod);



> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695193#comment-15695193
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
Thanks for sharing @sateesh-chodapuneedi 


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692616#comment-15692616
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
Hi @rhtyd, Working on this PR this week, should be able to update and push 
soon.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692516#comment-15692516
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi @yvsubhash ping


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680687#comment-15680687
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi @yvsubhash ping, guys can you rebase and fix conflicts


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629731#comment-15629731
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi can you fix the conflicts and rebase against latest 
master. Thanks.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594081#comment-15594081
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi can you resolve conflicts and rebase against latest 
master, thanks.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503121#comment-15503121
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@jburwell Yes, currently working on breaking the methods into multiple 
smaller units, and adding unit tests. Along with these adding the marvin tests 
from the other PR so that PR contains functional tests as well.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501726#comment-15501726
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi have you @nitt10prashant worked out combining the 
Marvin tests with this PR?  Also, please investigate the Travis CI failures.  
Finally, have you had a chance to address @rhtyd's feedback regarding large 
methods and unit tests?


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454875#comment-15454875
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi please add unit tests to increase code coverage, 
break large methods into smaller reviewable methods. Thanks.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454869#comment-15454869
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1664#discussion_r77140682
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/VMSnapshotTemplatePoolDaoImpl.java ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package com.cloud.storage.dao;
+
+import java.util.List;
+
+import javax.ejb.Local;
+
+import org.apache.log4j.Logger;
+import org.springframework.stereotype.Component;
+
+import 
org.apache.cloudstack.engine.subsystem.api.storage.DataObjectInStore;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine.Event;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine.State;
+
+import com.cloud.storage.VMSnapshotTemplateStoragePoolVO;
+import com.cloud.storage.VMSnapshotTemplateStorageResourceAssoc.Status;
+import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+import com.cloud.utils.db.SearchCriteria.Op;
+import com.cloud.utils.db.UpdateBuilder;
+
+@Component
+@Local(value = {VMSnapshotTemplatePoolDao.class})
--- End diff --

Why do we need `@Local` here, and in general in the PR?


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454862#comment-15454862
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1664#discussion_r77140264
  
--- Diff: 
engine/schema/src/com/cloud/storage/VMSnapshotTemplateStoragePoolVO.java ---
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package com.cloud.storage;
+
+import java.util.Date;
+import java.util.UUID;
+
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.EnumType;
+import javax.persistence.Enumerated;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
+import javax.persistence.Table;
+
+import 
org.apache.cloudstack.engine.subsystem.api.storage.DataObjectInStore;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine.State;
+
+import com.cloud.utils.db.GenericDaoBase;
+
+@Entity
+@Table(name = "vm_snapshot_spool_ref")
+public class VMSnapshotTemplateStoragePoolVO implements 
VMSnapshotTemplateStorageResourceAssoc, DataObjectInStore {
+
+protected VMSnapshotTemplateStoragePoolVO() {
--- End diff --

Why is the constructor protected?


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454864#comment-15454864
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1664#discussion_r77140308
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeFromVmSnapshotCmd.java
 ---
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.volume;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.storage.Volume;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createVolumeFromVmSnapshot", responseObject = 
VolumeResponse.class, description = "Creates a disk volume from a disk volume 
in a VM snapshot. This disk volume must still be attached to a virtual machine 
to make use of it.", responseView = ResponseView.Restricted, entityType = {
+Volume.class, VirtualMachine.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class CreateVolumeFromVmSnapshotCmd extends CreateVolumeCmd {
--- End diff --

Sure, will update the fields.



> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454863#comment-15454863
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1664#discussion_r77140277
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/SeedTemplateFromVmSnapshotCmd.java
 ---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.cloudstack.api.command.admin.template;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.StoragePoolResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.api.response.VmSnapshotTemplateResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+
+import com.cloud.event.EventTypes;
+import com.cloud.user.Account;
+
+@APICommand(name = "seedTemplateFromVmSnapshot", responseObject = 
VmSnapshotTemplateResponse.class, description = "seed template from vm snapshot 
on primary storage",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
--- End diff --

Sure, will update the fields.
Thanks for review.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454857#comment-15454857
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1664#discussion_r77139978
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeFromVmSnapshotCmd.java
 ---
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.volume;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.event.EventTypes;
+import com.cloud.storage.Volume;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createVolumeFromVmSnapshot", responseObject = 
VolumeResponse.class, description = "Creates a disk volume from a disk volume 
in a VM snapshot. This disk volume must still be attached to a virtual machine 
to make use of it.", responseView = ResponseView.Restricted, entityType = {
+Volume.class, VirtualMachine.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class CreateVolumeFromVmSnapshotCmd extends CreateVolumeCmd {
--- End diff --

Add `since` and `authorized` fields here.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454852#comment-15454852
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1664#discussion_r77139536
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/SeedTemplateFromVmSnapshotCmd.java
 ---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.cloudstack.api.command.admin.template;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.StoragePoolResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.api.response.VmSnapshotTemplateResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+
+import com.cloud.event.EventTypes;
+import com.cloud.user.Account;
+
+@APICommand(name = "seedTemplateFromVmSnapshot", responseObject = 
VmSnapshotTemplateResponse.class, description = "seed template from vm snapshot 
on primary storage",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
--- End diff --

Add `since` and `authorized` fields to annotate when the API was added 
(4.10) and who are the default authorized roles.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446715#comment-15446715
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@jburwell I will check with @nitt10prashant on this. Will try to add the 
tests in PR #1417 to this PR.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15444658#comment-15444658
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi @nitt10prashant could you please collapse the test 
case and feature PRs?  It is very difficult to test the feature when the tests 
are in a different branch.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441893#comment-15441893
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
Target this PR to ACS master branch.


> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441886#comment-15441886
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8676:


GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1664

CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor



Currently, ACS provides the ability to deploy a VM from a template or ISO. 
However, ACS does not provide the ability to deploy a VM(s) directly from a VM 
snapshot.

VM snapshots are stored in the primary storage and have a hierarchical or 
parent/child relationship. The requirement would be to provide the ability to 
deploy user instances from selected VM snapshots. Additionally, any VM snapshot 
in the hierarchy can be deployed concurrently.

Even though this can be supported and applicable to all hypervisors, to 
start with this feature is supported only for VMware hypervisor.

Also this feature supports creation of volume from VM snapshots. Details of 
new APIs added as part of this feature can be found in feature specification 
document below.

Feature specification is at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot

There is a separate PR raised by @nitt10prashant  that contains marvin 
tests for this feature.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
deploy-from-snapshot

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1664


commit 9df51faa8a2f0678e7927ac6ef23752b1eae8f71
Author: rahul singal 
Date:   2016-05-09T11:24:53Z

Marvin script for cloudstack-9365

commit bee2bdc299844e081ef30ccc5de0c2e01b2a0581
Author: Will Stevens 
Date:   2016-05-11T06:03:49Z

Merge pull request #1489 from shapeblue/dynamicroles-master

CLOUDSTACK-8562: Dynamic Role-Based API Checker for CloudStack### 
CLOUDSTACK-8562: DB-Backed Dynamic Role Based API Access Checker

This feature allows root administrators to define new roles and associate 
API
permissions to them.

A limited form of role-based access control for the CloudStack management 
server
API is provided through a properties file, commands.properties, embedded in 
the
WAR distribution. Therefore, customizing API permissions requires unpacking 
the
distribution and modifying this file consistently on all servers. The old 
system
also does not permit the specification of additional roles.

FS:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+Role+Based+API+Access+Checker+for+CloudStack

DB-Backed Dynamic Role Based API Access Checker for CloudStack brings 
following
changes, features and use-cases:
- Moves the API access definitions from commands.properties to the mgmt 
server DB
- Allows defining custom roles (such as a read-only ROOT admin) beyond the
  current set of four (4) roles
- All roles will resolve to one of the four known roles types (Admin, 
Resource
  Admin, Domain Admin and User) which maintains this association by 
requiring
  all new defined roles to specify a role type.
- Allows changes to roles and API permissions per role at runtime including 
additions or
  removal of roles and/or modifications of permissions, without the need
  of restarting management server(s)

Upgrade/installation notes:
- The feature will be enabled by default for new installations, existing
  deployments will continue to use the older static role based api access 
checker
  with an option to enable this feature
- During fresh installation or upgrade, the upgrade paths will add four 
default
  roles based on the four default role types
- For ease of migration, at the time of upgrade commands.properties will be 
used
  to add existing set of permissions to the default roles. cloud.account
  will have a new role_id column which will be populated based on default 
roles
  as well

Dynamic-roles migration tool: scripts/util/migrate-dynamicroles.py
- Allows admins to migrate to the dynamic role based checker at a future 
date
- Performs a harder one-way migrate and update
- Migrates rules from existing commands.properties file into db and 
deprecates it
- Enables an internal hidden switch to enable dynamic role based checker 
feature

* pr/1489:
  maven: Fix jstl version usage
  CLOUDSTACK-8562: Deprecate commands.properties
  CLOUDSTACK-8562: DB-Backed 

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[prashant kumar mishra (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292745#comment-15292745
 ] 

prashant kumar mishra commented on CLOUDSTACK-8676:
---

[~sateeshc] any update on this ?

> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[Sateesh Chodapuneedi (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268297#comment-15268297
 ] 

Sateesh Chodapuneedi commented on CLOUDSTACK-8676:
--

[~prashantkm]
I have not yet sent PR for this feature, will be able to send in 2 weeks. Will 
update you once it's ready.
Thanks.

> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[prashant kumar mishra (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261556#comment-15261556
 ] 

prashant kumar mishra commented on CLOUDSTACK-8676:
---

HI Sateesh ,
what is status of this feature ,can you please provide  PR number  .I have 
opened a PR for test code but it is failing due to import error for the API 
seedTemplateFromVmSnapshot ,

test code PR :https://github.com/apache/cloudstack/pull/1417 

> Deploy user instance from vm snapshot for VMware hypervisor
> ---
>
> Key: CLOUDSTACK-8676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: Future
>
>
> Currently, ACS provides the ability to deploy a VM from a template or ISO. 
> However, ACS does not provide the ability to deploy a VM(s) directly from a 
> VM snapshot. 
> VM snapshots are stored in the primary storage and have a hierarchical or 
> parent/child relationship. The requirement would be to provide the ability to 
> deploy user instances from selected VM snapshots. Additionally, any VM 
> snapshot in the hierarchy can be deployed concurrently.  
> Even though this can be  supported and applicable to all hypervisors, to 
> start with this feature is supported only for VMware hypervisor.
> Feature specification is at 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8676) Deploy user instance from vm snapshot for VMware hypervisor

[Sateesh Chodapuneedi (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647697#comment-14647697
 ] 

Sateesh Chodapuneedi commented on CLOUDSTACK-8676:
--

Currently feature is under development at github branch - 
https://github.com/sateesh-chodapuneedi/cloudstack/tree/deploy-from-snapshot

 Deploy user instance from vm snapshot for VMware hypervisor
 ---

 Key: CLOUDSTACK-8676
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8676
 Project: CloudStack
  Issue Type: New Feature
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
  Components: Management Server, VMware
Reporter: Sateesh Chodapuneedi
Assignee: Sateesh Chodapuneedi
 Fix For: 4.6.0


 Currently, ACS provides the ability to deploy a VM from a template or ISO. 
 However, ACS does not provide the ability to deploy a VM(s) directly from a 
 VM snapshot. 
 VM snapshots are stored in the primary storage and have a hierarchical or 
 parent/child relationship. The requirement would be to provide the ability to 
 deploy user instances from selected VM snapshots. Additionally, any VM 
 snapshot in the hierarchy can be deployed concurrently.  
 Even though this can be  supported and applicable to all hypervisors, to 
 start with this feature is supported only for VMware hypervisor.
 Feature specification is at 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)