[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295553#comment-16295553
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


blueorangutan commented on issue #1269: CLOUDSTACK-8867: Added retry logic to 
reconnect to host on connection termination to console
URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-352536305
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1407


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295433#comment-16295433
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


blueorangutan commented on issue #1269: CLOUDSTACK-8867: Added retry logic to 
reconnect to host on connection termination to console
URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-352521873
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295428#comment-16295428
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


rhtyd commented on issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect 
to host on connection termination to console
URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-352521670
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294412#comment-16294412
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


blueorangutan commented on issue #1269: CLOUDSTACK-8867: Added retry logic to 
reconnect to host on connection termination to console
URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-352296301
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1402


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294381#comment-16294381
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


blueorangutan commented on issue #1269: CLOUDSTACK-8867: Added retry logic to 
reconnect to host on connection termination to console
URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-352289033
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294379#comment-16294379
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


rhtyd commented on issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect 
to host on connection termination to console
URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-352288951
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927750#comment-15927750
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
@GabrielBrascher The other method is there for legacy purposes and is no 
longer get used in Cloudstack. This was getting used in 2.x versions for UI. 
Some third party tool might be using it so kept it for that purpose. Mixing 
things will make it more complicated.


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926264#comment-15926264
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user GabrielBrascher commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
Thanks for the response @anshul1886.

I am sorry, but I disagree with you. I think that it gets more stable and 
readable with less duplicated code. In my humble opinion, it is easier to 
document, test, read and debug when we have lots of small methods than few big 
methods.


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902731#comment-15902731
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
@GabrielBrascher @alexandrelimassantana I kept it that way for readability 
as console proxy code is hard to debug.


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896645#comment-15896645
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/1269


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896646#comment-15896646
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


GitHub user anshul1886 reopened a pull request:

https://github.com/apache/cloudstack/pull/1269

CLOUDSTACK-8867: Added retry logic to reconnect to host on connection 
termination to console

It also improves handling of sessions to hypervisor in console proxy

https://issues.apache.org/jira/browse/CLOUDSTACK-8867

To test:
Try on XenServer setup as  frequent disconnections are more common for 
XenServer.
Try random key combinations on VM console and see after fix console access 
denied errors are less frequent.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8867-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1269


commit 79e6d9f3b8bb9ecc9a515c9e1c4a2b6969a8f94e
Author: Anshul Gangwar 
Date:   2015-09-16T04:45:32Z

CLOUDSTACK-8867: Added retry logic to reconnect to host on connection 
termination to console.
It also improves handling of sessions to hypervisor in console proxy




> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889577#comment-15889577
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-547


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889547#comment-15889547
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889542#comment-15889542
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
@blueorangutan package


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889513#comment-15889513
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 406
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failing since 2 runs


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887907#comment-15887907
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
@rhtyd , Rebased against latest master


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305130#comment-15305130
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1269#issuecomment-86696
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 69
 Hypervisor xenserver
 NetworkType Advanced
 Passed=73
 Failed=0
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267055#comment-15267055
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1269#issuecomment-216306144
  
I am missing code reviews on this one...


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266447#comment-15266447
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1269#issuecomment-216212068
  
@anshul1886 please rebase against latest master



> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: Future
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217040#comment-15217040
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1269#issuecomment-203152685
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 145
 Hypervisor xenserver
 NetworkType Advanced
 Passed=103
 Failed=1
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork

 * test_extendPhysicalNetworkVlan Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.1
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095628#comment-15095628
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1269#issuecomment-171172466
  
@GabrielBrascher That block of code is in synchronised block.  


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.1
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090737#comment-15090737
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1269#issuecomment-170268129
  
@anshul1886 could you please create a method (with documentation) for those 
duplicate blocks in ConsoleProxy ( "if(viewer != null && 
!(viewer.getClientHostPort() == param.getClientHostPort())) {...}", lines 
414-419 and 454-458 )?


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.1
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067587#comment-15067587
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/1269

CLOUDSTACK-8867: Added retry logic to reconnect to host on connection 
termination to console

It also improves handling of sessions to hypervisor in console proxy

https://issues.apache.org/jira/browse/CLOUDSTACK-8867


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8867-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1269


commit 0f724d50c147429b800f45e77193a1f845ac80be
Author: Anshul Gangwar 
Date:   2015-09-16T04:45:32Z

CLOUDSTACK-8867: Added retry logic to reconnect to host on connection 
termination to console.
It also improves handling of sessions to hypervisor in console proxy




> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.1
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067580#comment-15067580
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/835#issuecomment-166514436
  
Opening new PR with better handling of sessions.


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.1
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067579#comment-15067579
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/835


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.1
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791785#comment-14791785
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/835#issuecomment-141004854
  
I agree with @DaanHoogland That should be unit tested.


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.0
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746961#comment-14746961
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/835

CLOUDSTACK-8867: Added retry logic to reconnect to host on connection 
termination


Also changed  viewer/console identifier to vm uuid + vnc port to avoid 
using same connection console if vm's inc port is changed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8867

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/835.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #835


commit a2752ac147d38193445332b05c393262368cc54a
Author: Anshul Gangwar 
Date:   2015-09-16T04:45:32Z

CLOUDSTACK-8867: Added retry logic to reconnect to host on connection 
termination
Also changed  viewer/console identifier to vm uuid + vnc port




> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.0
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8867) Improve console proxy experience

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14747059#comment-14747059
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8867:


Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/835#discussion_r39599783
  
--- Diff: 
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java
 ---
@@ -115,7 +115,7 @@ public void setLocale(String locale) {
 
 public String getClientMapKey() {
 if (clientTag != null && !clientTag.isEmpty())
-return clientTag;
+return clientTag + ":" + clientHostPort;
--- End diff --

if this is really how it should be it should be in a unit test


> Improve console proxy experience 
> -
>
> Key: CLOUDSTACK-8867
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8867
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.6.0
>
>
> This bug is to avoid terminate connection errors in VM console in some of 
> following scenarios
> 1. VM reboots
> 2. Some key combinations input



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)