[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672792#comment-15672792
]
ASF subversion and git services commented on CLOUDSTACK-9386:
-
Commit 20b43767d72672119e56b04a2e5c2e6c54e40ad5 in cloudstack's branch
refs/heads/4.9 from [~jburwell]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=20b4376 ]
Merge pull request #1676 from nvazquez/dstemplates49
CLOUDSTACK-9502: DS template copies dont get deleted in VMware ESXi with
multiple clusters and zone wide storage (include CLOUDSTACK-9386 into 4.9
release branch)Include #1560 into 4.9 release branch
* pr/1676:
CLOUDSTACK-9502: DS template copies don’t get deleted in VMware ESXi with
multiple clusters and zone wide storage
Signed-off-by: John Burwell
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672797#comment-15672797
]
ASF subversion and git services commented on CLOUDSTACK-9386:
-
Commit 20b43767d72672119e56b04a2e5c2e6c54e40ad5 in cloudstack's branch
refs/heads/master from [~jburwell]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=20b4376 ]
Merge pull request #1676 from nvazquez/dstemplates49
CLOUDSTACK-9502: DS template copies dont get deleted in VMware ESXi with
multiple clusters and zone wide storage (include CLOUDSTACK-9386 into 4.9
release branch)Include #1560 into 4.9 release branch
* pr/1676:
CLOUDSTACK-9502: DS template copies don’t get deleted in VMware ESXi with
multiple clusters and zone wide storage
Signed-off-by: John Burwell
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503571#comment-15503571
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1560
Thanks @jburwell, I've opened new PR (1676) against 4.9 release branch
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501014#comment-15501014
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@serg38 @nvazquez I just noticed that this bug was merged to master, but it
should also be included in LTS My thinking is that we rollback this commit
from master, re-open this PR against the 4.9 release branch, and then re-merge
it. Does this make sense? If so, @serg38 would you be able to quickly re-test
it against 4.9?
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487127#comment-15487127
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@jburwell someone else already merged ;)
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486808#comment-15486808
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1560
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486806#comment-15486806
]
ASF subversion and git services commented on CLOUDSTACK-9386:
-
Commit f31d2ddce924ec30813171974a43d64e3718d91a in cloudstack's branch
refs/heads/master from [~koushikd]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f31d2dd ]
Merge pull request #1560 from nvazquez/gcbug
CLOUDSTACK-9386: DS template copies dont get deleted in VMware ESXi with
multiple clusters and zone wide storageJIRA TICKET:
https://issues.apache.org/jira/browse/CLOUDSTACK-9386
### Introduction
In some production environments with multiple clusters it was noticed that
unused templates were consuming too much storage. It was discovered that
template cleanup was not deleting marked templates on ESXi.
### Description of the problem
Suppose we have multiple clusters `(c1, c2,...,cN)` on a data center and
template `T` from which we deploy vms on `c1.`
Suppose now that we expunge those vms, and there's no other vm instance from
template `T,` so this was the actual workflow:
1. CloudStack marks template for cleanup after `storage.cleanup.interval`
seconds, by setting `marked_for_gc = 1` on `template_spool_ref` table, for that
template.
2. After another `storage.cleanup.interval` seconds a `DestroyCommand` will be
sent, to delete template from primary storage
3. On `VmwareResource`, command is processed, and it first picks up a random
cluster, say `ci != c1` to look for vm template (using volume's path) and
destroy it. But, as template was on `c1` it cannot be found, so it won't be
deleted. Entry on `template_spool_ref` is deleted but not the actual template
on hypervisor side.
### Proposed solution
We propose a way to attack problem shown in point 3, by not picking up a random
cluster to look for vm but using vSphere data center. This way we make sure vm
template will be deleted in every case, and not depending on random cluster
selection
* pr/1560:
CLOUDSTACK-9386: Find vm on datacenter instead of randomly choosing a cluster
Signed-off-by: Koushik Das
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486804#comment-15486804
]
ASF subversion and git services commented on CLOUDSTACK-9386:
-
Commit 1384d748a7296019f0d8ba2a5fcf4b97090f2e04 in cloudstack's branch
refs/heads/master from [~nvazquez]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1384d74 ]
CLOUDSTACK-9386: Find vm on datacenter instead of randomly choosing a cluster
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486807#comment-15486807
]
ASF subversion and git services commented on CLOUDSTACK-9386:
-
Commit f31d2ddce924ec30813171974a43d64e3718d91a in cloudstack's branch
refs/heads/master from [~koushikd]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f31d2dd ]
Merge pull request #1560 from nvazquez/gcbug
CLOUDSTACK-9386: DS template copies dont get deleted in VMware ESXi with
multiple clusters and zone wide storageJIRA TICKET:
https://issues.apache.org/jira/browse/CLOUDSTACK-9386
### Introduction
In some production environments with multiple clusters it was noticed that
unused templates were consuming too much storage. It was discovered that
template cleanup was not deleting marked templates on ESXi.
### Description of the problem
Suppose we have multiple clusters `(c1, c2,...,cN)` on a data center and
template `T` from which we deploy vms on `c1.`
Suppose now that we expunge those vms, and there's no other vm instance from
template `T,` so this was the actual workflow:
1. CloudStack marks template for cleanup after `storage.cleanup.interval`
seconds, by setting `marked_for_gc = 1` on `template_spool_ref` table, for that
template.
2. After another `storage.cleanup.interval` seconds a `DestroyCommand` will be
sent, to delete template from primary storage
3. On `VmwareResource`, command is processed, and it first picks up a random
cluster, say `ci != c1` to look for vm template (using volume's path) and
destroy it. But, as template was on `c1` it cannot be found, so it won't be
deleted. Entry on `template_spool_ref` is deleted but not the actual template
on hypervisor side.
### Proposed solution
We propose a way to attack problem shown in point 3, by not picking up a random
cluster to look for vm but using vSphere data center. This way we make sure vm
template will be deleted in every case, and not depending on random cluster
selection
* pr/1560:
CLOUDSTACK-9386: Find vm on datacenter instead of randomly choosing a cluster
Signed-off-by: Koushik Das
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486805#comment-15486805
]
ASF subversion and git services commented on CLOUDSTACK-9386:
-
Commit f31d2ddce924ec30813171974a43d64e3718d91a in cloudstack's branch
refs/heads/master from [~koushikd]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f31d2dd ]
Merge pull request #1560 from nvazquez/gcbug
CLOUDSTACK-9386: DS template copies dont get deleted in VMware ESXi with
multiple clusters and zone wide storageJIRA TICKET:
https://issues.apache.org/jira/browse/CLOUDSTACK-9386
### Introduction
In some production environments with multiple clusters it was noticed that
unused templates were consuming too much storage. It was discovered that
template cleanup was not deleting marked templates on ESXi.
### Description of the problem
Suppose we have multiple clusters `(c1, c2,...,cN)` on a data center and
template `T` from which we deploy vms on `c1.`
Suppose now that we expunge those vms, and there's no other vm instance from
template `T,` so this was the actual workflow:
1. CloudStack marks template for cleanup after `storage.cleanup.interval`
seconds, by setting `marked_for_gc = 1` on `template_spool_ref` table, for that
template.
2. After another `storage.cleanup.interval` seconds a `DestroyCommand` will be
sent, to delete template from primary storage
3. On `VmwareResource`, command is processed, and it first picks up a random
cluster, say `ci != c1` to look for vm template (using volume's path) and
destroy it. But, as template was on `c1` it cannot be found, so it won't be
deleted. Entry on `template_spool_ref` is deleted but not the actual template
on hypervisor side.
### Proposed solution
We propose a way to attack problem shown in point 3, by not picking up a random
cluster to look for vm but using vSphere data center. This way we make sure vm
template will be deleted in every case, and not depending on random cluster
selection
* pr/1560:
CLOUDSTACK-9386: Find vm on datacenter instead of randomly choosing a cluster
Signed-off-by: Koushik Das
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486070#comment-15486070
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@serg38 the git-pr script is not working properly for me. I will debug
further tomorrow.
@rafaelweingartner do you mind doing the merge honors?
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485464#comment-15485464
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@serg38 great work.
It seems that we already have reviewed this one, and executed tests.
I will merge this PR tomorrow if no one objects.
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485200#comment-15485200 ] ASF GitHub Bot commented on CLOUDSTACK-9386: Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rafaelweingartner @jburwell @karuturi Integration tests passed after merge conflict resolution test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS === Test Deploy Virtual Machine ... SKIP: Skipping test because suitable hypervisor/host notpresent Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS === Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS === Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS === Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS === Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS === Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS === Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS === Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS === Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS === Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS === Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS === Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS === Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS === Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS === Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS === Update & Test for ISO permissions ... === TestName: test_05_iso_permissions | Status : SUCCESS === Test for copy ISO from one zone to another ... SKIP: Not enough zones available to perform copy template Test delete ISO ... === TestName: test_07_list_default_iso
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482522#comment-15482522
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1560
Great, thanks @jburwell!
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481910#comment-15481910
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@nvazquez this PR has merge conflicts that must be resolved before we can
merge it. @serg38 after @nvazquez has resolved the merge conflicts, could you
please re-execute your tests to ensure that the conflict resolution does not
introduce any issues?
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481906#comment-15481906
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@rafaelweingartner @jburwell This PR seems to be ready for merging as well
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481899#comment-15481899 ] ASF GitHub Bot commented on CLOUDSTACK-9386: Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 LGTM for testing. Re-ran smoke tests: test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === ok test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS === ok Test Deploy Virtual Machine ... SKIP: Skipping test because suitable hypervisor/host notpresent Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS === ok Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS === ok Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS === ok Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS === ok Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS === ok Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS === ok Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS === ok Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS === ok Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS === ok Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === ok Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === ok Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === ok Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS === ok Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS === ok Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS === ok Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS === ok Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS === ok Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS === ok Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS === ok Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS === ok Update & Test for ISO permissions ... === TestName: test_05_iso_permissions | Status : SUCCESS === ok Test for copy ISO from one zone to another ... SKIP: Not enough zo
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458983#comment-15458983 ] ASF GitHub Bot commented on CLOUDSTACK-9386: Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1560 @jburwell @rhtyd I post test results: ``` [root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs/test_volumes_SAGNPP/results.txt test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === ok test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS === ok Test Deploy Virtual Machine ... SKIP: Skipping test because suitable hypervisor/host notpresent Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS === ok Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS === ok Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS === ok Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS === ok Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS === ok Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS === ok Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS === ok Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS === ok Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS === ok Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === ok Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === ok Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === ok Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS === ok Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS === ok Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS === ok Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS === ok Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS === ok Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS === ok Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS === ok Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS === ok Update & Test for ISO permissions ... === TestName: test_05_iso_permission
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456085#comment-15456085
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1560
I rebased master branch, I'll post test results for this PR
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.2.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448040#comment-15448040
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1560
LGTM (code/logic seems alright, did not run any tests).
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.9.1
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447258#comment-15447258
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@rhtyd @jburwell Can this be merged?
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.9.1
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433302#comment-15433302
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1560
LGTM from me here ;)
thanks @serg38 and @nvazquez for the hard work.
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.9.1
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423026#comment-15423026
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@rafaelweingartner @jburwell @rhtyd @koushik-das Can you review this PR?
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.9.1
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408128#comment-15408128
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1560
Hi guys,
This pull request it's been opened for a while, @rafaelweingartner,
@bvbharatk you've reviewed it before, could you give your blessing to this PR?
CC: @swill
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.9.1
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9386) DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325970#comment-15325970
]
ASF GitHub Bot commented on CLOUDSTACK-9386:
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1560
### ACS CI BVT Run
**Sumarry:**
Build Number 185
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
> DS template copies don’t get deleted in VMware ESXi with multiple clusters
> and zone wide storage
>
>
> Key: CLOUDSTACK-9386
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Fix For: 4.9.0
>
>
> h3. Introduction
> In some production environments with multiple clusters it was noticed that
> unused templates were consuming too much storage. It was discovered that
> template cleanup was not deleting marked templates on ESXi.
> h3. Description of the problem
> Suppose we have multiple clusters {{(c1, c2,...,cN)}} on a data center and
> template {{T}} from which we deploy vms on {{c1}}.
> Suppose now that we expunge those vms, and there's no other vm instance from
> template {{T}}, so this was the actual workflow:
> # CloudStack marks template for cleanup after {{storage.cleanup.interval}}
> seconds, by setting {{marked_for_gc = 1}} on {{template_spool_ref}} table,
> for that template.
> # After another {{storage.cleanup.interval}} seconds a {{DestroyCommand}}
> will be sent, to delete template from primary storage
> # On {{VmwareResource}}, command is processed, and it first picks up a random
> cluster, say {{ci != c1}} to look for vm template (using volume's path) and
> destroy it. But, as template was on {{c1}} it cannot be found, so it won't be
> deleted. Entry on {{template_spool_ref}} is deleted but not the actual
> template on hypervisor side.
> h3. Proposed solution
> We propose a way to attack problem shown in point 3, by not picking up a
> random cluster to look for vm but using vSphere data center. This way we make
> sure vm template will be deleted in every case, and not depending on random
> cluster selection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
