[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315354#comment-16315354
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


rhtyd commented on issue #1775: CLOUDSTACK-9606: While IP address is released, 
tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355832401
 
 
   Agree @DaanHoogland I'll move this to 4.12 milestone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315275#comment-16315275
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


DaanHoogland commented on issue #1775: CLOUDSTACK-9606: While IP address is 
released, tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355824250
 
 
   @rhtyd @priyankparihar @syed @rajesh-battala @sarathkouk @borisstoyanov 
   As this PR does not pass it's own test in travis and does not seem to be 
very critical, I suggest we move it to a future release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315206#comment-16315206
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


rhtyd commented on issue #1775: CLOUDSTACK-9606: While IP address is released, 
tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355816469
 
 
   @priyankparihar can you fix the error in the new marvin test, see Travis's 
failed job for details:
   ```
test_25_CLOUDSTACK_9606| exceptions.NameError | 16.268  | test_tags
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314762#comment-16314762
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


priyankparihar opened a new pull request #1775: CLOUDSTACK-9606: While IP 
address is released, tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775
 
 
   For complete description please refer -> 
[CLOUDSTACK-9606](https://issues.apache.org/jira/browse/CLOUDSTACK-9606)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314761#comment-16314761
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


rhtyd closed pull request #1775: CLOUDSTACK-9606: While IP address is released, 
tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/network/IpAddressManagerImpl.java 
b/server/src/com/cloud/network/IpAddressManagerImpl.java
old mode 100644
new mode 100755
index 7961d07fc6c..0cfd9bb4122
--- a/server/src/com/cloud/network/IpAddressManagerImpl.java
+++ b/server/src/com/cloud/network/IpAddressManagerImpl.java
@@ -173,6 +173,8 @@
 import com.cloud.vm.dao.NicSecondaryIpDao;
 import com.cloud.vm.dao.UserVmDao;
 import com.cloud.vm.dao.VMInstanceDao;
+import com.cloud.server.ResourceTag;
+import com.cloud.tags.dao.ResourceTagDao;
 
 public class IpAddressManagerImpl extends ManagerBase implements 
IpAddressManager, Configurable {
 private static final Logger s_logger = 
Logger.getLogger(IpAddressManagerImpl.class);
@@ -288,6 +290,8 @@
 DataCenterIpAddressDao _privateIPAddressDao;
 @Inject
 HostPodDao _hpDao;
+@Inject
+ResourceTagDao _resourceTagDao;
 
 SearchBuilder AssignIpAddressSearch;
 SearchBuilder AssignIpAddressFromPodVlanSearch;
@@ -595,6 +599,10 @@ protected boolean cleanupIpResources(long ipId, long 
userId, Account caller) {
 success = false;
 }
 
+//Remove the tags corresponding to IP.
+if(success) {
+_resourceTagDao.removeByIdAndType(ipId, 
ResourceTag.ResourceObjectType.PublicIpAddress);
+}
 return success;
 }
 
diff --git a/test/integration/component/test_tags.py 
b/test/integration/component/test_tags.py
index f9b0655016d..f9755b882aa 100644
--- a/test/integration/component/test_tags.py
+++ b/test/integration/component/test_tags.py
@@ -2543,3 +2543,163 @@ def test_24_public_IP_tag(self):
 "List tags should return empty response"
 )
 return
+
+@attr(tags=["advanced"], required_hardware="false")
+def test_25_CLOUDSTACK_9606(self):
+""" Test for checking automatic tag removal on released Public IP
+"""
+
+# Validate the following
+# 1. Create a domain and admin account under the new domain.
+# 2. Create  a tag on acquired public IP address using createTags 
API.
+# 3. Release the respective public IP address without deleting 
tags.
+# 4. Verify that tags does not exists on the released public IP.
+
+self.debug("Creating a sub-domain under: %s" % self.domain.name)
+self.child_domain = Domain.create(
+self.apiclient,
+services=self.services["domain"],
+parentdomainid=self.domain.id
+)
+self.child_do_admin = Account.create(
+self.apiclient,
+self.services["account"],
+admin=True,
+domainid=self.child_domain.id
+)
+# Cleanup the resources created at end of test
+self.cleanup.append(self.child_do_admin)
+self.cleanup.append(self.child_domain)
+self.dom_admin_api_client = self.testClient.getUserApiClient(
+UserName=self.child_do_admin.name,
+DomainName=self.child_do_admin.domain
+)
+result = createEnabledNetworkOffering(
+self.apiclient,
+self.services["network_offering"]
+)
+assert result[0] == PASS, \
+"Network offering create/enable failed with error %s" % 
result[2]
+self.network_offering = result[1]
+self.network = Network.create(
+self.dom_admin_api_client,
+self.services["network"],
+networkofferingid=self.network_offering.id,
+accountid=self.child_do_admin.name,
+domainid=self.child_do_admin.domainid,
+zoneid=self.zone.id
+)
+self.debug("Fetching the network details for account: %s" %
+self.child_do_admin.name
+)
+networks = Network.list(
+self.dom_admin_api_client,
+account=self.child_do_admin.name,
+domainid=self.child_do_admin.domainid,
+listall=True
+)
+self.assertEqual(
+isinstance(networks, list),
+True,
+"List networks should not return an empty 

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314760#comment-16314760
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


rhtyd commented on issue #1775: CLOUDSTACK-9606: While IP address is released, 
tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355762259
 
 
   Re-kicking travis by closing and re-opening the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313612#comment-16313612
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is 
released, tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355629383
 
 
   Trillian test result (tid-2019)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39310 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1775-t2019-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
321.76 | test_routers_network_ops.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312534#comment-16312534
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


rhtyd commented on issue #1775: CLOUDSTACK-9606: While IP address is released, 
tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355481364
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312535#comment-16312535
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is 
released, tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355481395
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310980#comment-16310980
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is 
released, tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355224720
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1573


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310865#comment-16310865
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is 
released, tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355211808
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310864#comment-16310864
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


rhtyd commented on issue #1775: CLOUDSTACK-9606: While IP address is released, 
tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355211750
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296334#comment-16296334
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


rhtyd commented on issue #1775: CLOUDSTACK-9606: While IP address is released, 
tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-352658259
 
 
   @priyankparihar can you fix the conflict?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924039#comment-15924039
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user sarathkouk commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
[results.txt](https://github.com/apache/cloudstack/files/841130/results.txt)



> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924035#comment-15924035
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user sarathkouk commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
Here is the test result,
Test for checking automatic tag removal on released Public IP ... === 
TestName: test_25_CLOUDSTACK_9606| Status : SUCCESS ===
ok

--
Ran 1 test in 350.389s

OK



> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923877#comment-15923877
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@priyankparihar thank you for adding this test. Have you run it? Since this 
is not part of the smoketestd can you provide any results. 


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923855#comment-15923855
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@borisstoyanov and @syed Please take a look. Test case is added. If now 
everything looks ok then please provide your LGTM.


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885461#comment-15885461
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885460#comment-15885460
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@blueorangutan test


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885446#comment-15885446
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-540


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885369#comment-15885369
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885368#comment-15885368
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@blueorangutan package


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885365#comment-15885365
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@borisstoyanov please trigger smoke test.


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728161#comment-15728161
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@priyankparihar can you please add marvin tests and rebase against 4.9 so 
we could trigger smoke tests and merge it. 


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715806#comment-15715806
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
Hi @rajesh-battala, 
Changes are included. Thanks for your careful syntax observation. 


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715773#comment-15715773
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
Hi @syed,
>can you please provide a description and steps to reproduce

Please check 
[CLOUDSTACK-9606](https://issues.apache.org/jira/browse/CLOUDSTACK-9606). 


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715119#comment-15715119
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1775#discussion_r90640757
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -281,6 +284,8 @@
 VpcDao _vpcDao;
 SearchBuilder AssignIpAddressSearch;
 SearchBuilder AssignIpAddressFromPodVlanSearch;
+@Inject
+ResourceTagDao _resourceTagDao;
--- End diff --

Move 287,288 after 284.


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715111#comment-15715111
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1775#discussion_r90640403
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -568,6 +573,11 @@ protected boolean cleanupIpResources(long ipId, long 
userId, Account caller) {
 success = false;
 }
 
+//Remove the tags corresponding to IP.
+if(success) {
+_resourceTagDao.removeByIdAndType(ipId, 
ResourceTag.ResourceObjectType.PublicIpAddress);
+}
+
--- End diff --

This extra line can be removed


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715105#comment-15715105
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1775#discussion_r90640201
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -168,6 +168,9 @@
 import com.cloud.vm.dao.NicSecondaryIpDao;
 import com.cloud.vm.dao.UserVmDao;
 import com.cloud.vm.dao.VMInstanceDao;
+import com.cloud.server.ResourceTag;
+import com.cloud.tags.dao.ResourceTagDao;
+
--- End diff --

Remove this extra line


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696042#comment-15696042
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
can you please provide a description and steps to reproduce


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693054#comment-15693054
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1775

CLOUDSTACK-9606: While IP address is released, tag are not deleted.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9606

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 428f9c6acf8eeddca8fc137e7187bef2d773f7f8
Author: Priyank Parihar 
Date:   2016-11-24T11:40:08Z

CLOUDSTACK-9606: While IP address is released, tag are not deleted.




> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)