[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874362#comment-15874362
 ] 

ASF subversion and git services commented on CLOUDSTACK-9618:
-

Commit 3dc0eed71d8c6b39d16b003f779949ba13abdf10 in cloudstack's branch 
refs/heads/master from [~nitinkumar.maharana]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3dc0eed ]

CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" method 
in the drop down list

Added the source method to supported algorithm list in Netscaler element.
Added a validation check.


> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874363#comment-15874363
 ] 

ASF subversion and git services commented on CLOUDSTACK-9618:
-

Commit ca27394da1fdbf2bf543082edb7b8324953c8a04 in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ca27394 ]

Merge pull request #1786 from nitin-maharana/nitin5

CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" method 
in the drop down list.If we create an isolated network with NetScaler published 
service offering for Load balancing service, then the load balancing 
configuration UI does not show "Source" as one of the supported LB methods in 
the drop down list. It only shows "Round-Robin" and "LeastConnection" methods 
in the list. However, It successfully creates LB rule with "Source" as the LB 
method using API.

* pr/1786:
  CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" 
method in the drop down list

Signed-off-by: Rajani Karuturi 


> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874364#comment-15874364
 ] 

ASF subversion and git services commented on CLOUDSTACK-9618:
-

Commit ca27394da1fdbf2bf543082edb7b8324953c8a04 in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ca27394 ]

Merge pull request #1786 from nitin-maharana/nitin5

CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" method 
in the drop down list.If we create an isolated network with NetScaler published 
service offering for Load balancing service, then the load balancing 
configuration UI does not show "Source" as one of the supported LB methods in 
the drop down list. It only shows "Round-Robin" and "LeastConnection" methods 
in the list. However, It successfully creates LB rule with "Source" as the LB 
method using API.

* pr/1786:
  CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" 
method in the drop down list

Signed-off-by: Rajani Karuturi 


> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869306#comment-15869306
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9618:


Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1786
  
LGTM based on code review
@karuturi Since this is a network plugin related fix and requires 
Netscaler, I don't think there is a need to run the BVTs.


> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866499#comment-15866499
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9618:


Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1786
  
ping @sateesh-chodapuneedi @rajesh-battala @karuturi 


> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15787025#comment-15787025
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9618:


Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1786
  
@jburwell : As this is Netscaler specific. Yes, you need a Netscaler to 
verify.


> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741001#comment-15741001
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9618:


Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1786
  
Changed the base branch to 4.9.


> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712456#comment-15712456
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9618:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1786#discussion_r90487461
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
 ---
@@ -260,7 +264,7 @@ public boolean applyLBRules(Network config, 
List rules) throw
 Map lbCapabilities = new HashMap();
 
 // Specifies that the RoundRobin and Leastconn algorithms are 
supported for load balancing rules
-lbCapabilities.put(Capability.SupportedLBAlgorithms, 
"roundrobin,leastconn");
+lbCapabilities.put(Capability.SupportedLBAlgorithms, 
"roundrobin,leastconn,source");
--- End diff --

The list of strings declared on this line must be sync with the list used 
to validate the algorithm on line 237.  Therefore, please consider extracting 
this list to a constant `ImmutableSet`, `SUPPORTED_ALGORITHMS` in order 
to ensure cohesion between declaration and validation.  With this change, the 
validateLBRule can be re-implemented as follows:

```java
public boolean validateLBRule(Network network, LoadBalancingRule rule) {
Preconditions.checkArgument(network != null, "validateLBRule requires a 
non-null network");
Preconditions.checkArgument(rule != null, "validateLBRule requires a 
non-null rule");

return (canHandle(network, Service.Lb)) : 
SUPPORTED_ALGORITHMS.contains(rule.getAlgorithm()) : true;
}
```

This line can be re-implemented as follows:

```java
lbCapabilities.put(Capability.SupportedLBAlgorithms, 
Joiner.on(",").join(SUPPORTED_ALGORITHMS));
```


> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9618) Load Balancer configuration page does not have "Source" method in the drop down list

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695772#comment-15695772
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9618:


GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1786

CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" 
method in the drop down list.

If we create an isolated network with NetScaler published service offering 
for Load balancing service, then the load balancing configuration UI does not 
show "Source" as one of the supported LB methods in the drop down list. It only 
shows "Round-Robin" and "LeastConnection" methods in the list. However, It 
successfully creates LB rule with "Source" as the LB method using API.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1786.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1786


commit 709343a0abf9ee00ef7c5ad6ebc70ff7cf1df57a
Author: Nitin Kumar Maharana 
Date:   2016-11-25T12:37:17Z

CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" 
method in the drop down list

Added the source method to supported algorithm list in Netscaler element.
Added a validation check.




> Load Balancer configuration page does not have "Source" method in the drop 
> down list
> 
>
> Key: CLOUDSTACK-9618
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9618
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nitin Kumar Maharana
>
> If we create an isolated network with NetScaler published service offering 
> for Load balancing service, then the load balancing configuration UI does not 
> show "Source" as one of the supported LB methods in the drop down list. It 
> only shows "Round-Robin" and "LeastConnection" methods in the list. Howerver, 
> It successfully creates LB rule with "Source" as the LB method using API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)