[jira] [Commented] (CLOUDSTACK-9657) Ipset command fails for VM's with long internal name

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017068#comment-16017068
 ] 

ASF subversion and git services commented on CLOUDSTACK-9657:
-

Commit c95b47b7405008650bc4f777f9cc800b299aeef5 in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=c95b47b ]

Merge pull request #1824 from jayapalu/SGipset

CLOUDSTACK-9657: Fixed security group ipset issues with long vm name

> Ipset command fails for VM's with long internal name
> 
>
> Key: CLOUDSTACK-9657
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9657
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.9.1.0
>
>
> ipset rules configuration in security groups is failing for the VM with 
> longer name 
> ipset -N 12345677 nethash
> ipset v6.11: Syntax error: setname '12345677' is 
> longer than 31 characters



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9657) Ipset command fails for VM's with long internal name

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017065#comment-16017065
 ] 

ASF subversion and git services commented on CLOUDSTACK-9657:
-

Commit 1cff18fcfafeec3a6128441c6cb40b9f6bea43b7 in cloudstack's branch 
refs/heads/master from Jayapal
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=1cff18f ]

 CLOUDSTACK-9657: Fixed security group ipset issues with long vm name


> Ipset command fails for VM's with long internal name
> 
>
> Key: CLOUDSTACK-9657
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9657
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.9.1.0
>
>
> ipset rules configuration in security groups is failing for the VM with 
> longer name 
> ipset -N 12345677 nethash
> ipset v6.11: Syntax error: setname '12345677' is 
> longer than 31 characters



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9657) Ipset command fails for VM's with long internal name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887434#comment-15887434
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9657:


Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1824
  
tag:mergeready


> Ipset command fails for VM's with long internal name
> 
>
> Key: CLOUDSTACK-9657
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9657
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.9.1.0
>
>
> ipset rules configuration in security groups is failing for the VM with 
> longer name 
> ipset -N 12345677 nethash
> ipset v6.11: Syntax error: setname '12345677' is 
> longer than 31 characters



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9657) Ipset command fails for VM's with long internal name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882323#comment-15882323
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9657:


Github user kishankavala commented on the issue:

https://github.com/apache/cloudstack/pull/1824
  
Code LGTM


> Ipset command fails for VM's with long internal name
> 
>
> Key: CLOUDSTACK-9657
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9657
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.9.1.0
>
>
> ipset rules configuration in security groups is failing for the VM with 
> longer name 
> ipset -N 12345677 nethash
> ipset v6.11: Syntax error: setname '12345677' is 
> longer than 31 characters



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9657) Ipset command fails for VM's with long internal name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882107#comment-15882107
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9657:


Github user kishankavala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1824#discussion_r101981147
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -232,28 +233,50 @@ def deleteFile(session, args):
 
 return txt
 
+#using all the iptables chain names length to 24 because cleanup_rules 
groups the vm chain excluding -def,-eg
+#to avoid multiple iptables chains for single vm there using length 24
 def chain_name(vm_name):
 if vm_name.startswith('i-') or vm_name.startswith('r-'):
 if vm_name.endswith('untagged'):
 return '-'.join(vm_name.split('-')[:-1])
 if len(vm_name) > 28:
-vm_name = vm_name[0:27]
+vm_name = vm_name[0:24]
 return vm_name
 
 def chain_name_def(vm_name):
+#iptables chain length max is 29 chars
+if len(vm_name) > 28:
--- End diff --

Check should be > 25, "-def" is suffixed


> Ipset command fails for VM's with long internal name
> 
>
> Key: CLOUDSTACK-9657
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9657
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.9.1.0
>
>
> ipset rules configuration in security groups is failing for the VM with 
> longer name 
> ipset -N 12345677 nethash
> ipset v6.11: Syntax error: setname '12345677' is 
> longer than 31 characters



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9657) Ipset command fails for VM's with long internal name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875884#comment-15875884
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9657:


Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1824#discussion_r102192868
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -232,28 +233,50 @@ def deleteFile(session, args):
 
 return txt
 
+#using all the iptables chain names length to 24 because cleanup_rules 
groups the vm chain excluding -def,-eg
+#to avoid multiple iptables chains for single vm there using length 24
 def chain_name(vm_name):
 if vm_name.startswith('i-') or vm_name.startswith('r-'):
 if vm_name.endswith('untagged'):
 return '-'.join(vm_name.split('-')[:-1])
 if len(vm_name) > 28:
--- End diff --

Updated it.


> Ipset command fails for VM's with long internal name
> 
>
> Key: CLOUDSTACK-9657
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9657
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.9.1.0
>
>
> ipset rules configuration in security groups is failing for the VM with 
> longer name 
> ipset -N 12345677 nethash
> ipset v6.11: Syntax error: setname '12345677' is 
> longer than 31 characters



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9657) Ipset command fails for VM's with long internal name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874292#comment-15874292
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9657:


Github user kishankavala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1824#discussion_r101981007
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -232,28 +233,50 @@ def deleteFile(session, args):
 
 return txt
 
+#using all the iptables chain names length to 24 because cleanup_rules 
groups the vm chain excluding -def,-eg
+#to avoid multiple iptables chains for single vm there using length 24
 def chain_name(vm_name):
 if vm_name.startswith('i-') or vm_name.startswith('r-'):
 if vm_name.endswith('untagged'):
 return '-'.join(vm_name.split('-')[:-1])
 if len(vm_name) > 28:
--- End diff --

Check should be > 25


> Ipset command fails for VM's with long internal name
> 
>
> Key: CLOUDSTACK-9657
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9657
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.9.1.0
>
>
> ipset rules configuration in security groups is failing for the VM with 
> longer name 
> ipset -N 12345677 nethash
> ipset v6.11: Syntax error: setname '12345677' is 
> longer than 31 characters



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9657) Ipset command fails for VM's with long internal name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734763#comment-15734763
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9657:


GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1824

CLOUDSTACK-9657: Fixed security group ipset issues with long vm name

ipset set name  max length allowed is  31 char. If the vm name has longer 
name then the trimming of set has done in this fix. Also cleanup of rules are 
taken care.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jayapalu/cloudstack SGipset

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1824


commit 32357d0b7c62bbef983967e3b7b690f9d3d68426
Author: Jayapalu 
Date:   2016-12-08T10:35:21Z

CLOUDSTACK-9657: Fixed security group ipset issues with long vm name




> Ipset command fails for VM's with long internal name
> 
>
> Key: CLOUDSTACK-9657
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9657
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.9.1.0
>
>
> ipset rules configuration in security groups is failing for the VM with 
> longer name 
> ipset -N 12345677 nethash
> ipset v6.11: Syntax error: setname '12345677' is 
> longer than 31 characters



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)