[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879529#comment-15879529
 ] 

ASF subversion and git services commented on CLOUDSTACK-9724:
-

Commit 9efd9059efc1e8d3555fec738668e835a6fc575d in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9efd905 ]

Merge pull request #1885 from Accelerite/vpctier

CLOUDSTACK-9724: Fixed missing additional public ip on tier network wIn VPC 
tier network acquire an ip and configure the PF service on it. VR now will have 
the two ip addresses on the interface.
Now restart the VPC tier network with cleanup option. After router comes up the 
public interface has only one ip (source nat ip)
Fixed the above issue.

* pr/1885:
  CLOUDSTACK-9724: Fixed missing additional public ip on tier network with 
cleanup

Signed-off-by: Rajani Karuturi 


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879525#comment-15879525
 ] 

ASF subversion and git services commented on CLOUDSTACK-9724:
-

Commit ee726af53bb33c5205d481abc3ab78bd2653f1b6 in cloudstack's branch 
refs/heads/master from Jayapal
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ee726af ]

 CLOUDSTACK-9724: Fixed missing additional public ip on tier network with 
cleanup


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879533#comment-15879533
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1885


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879528#comment-15879528
 ] 

ASF subversion and git services commented on CLOUDSTACK-9724:
-

Commit 9efd9059efc1e8d3555fec738668e835a6fc575d in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9efd905 ]

Merge pull request #1885 from Accelerite/vpctier

CLOUDSTACK-9724: Fixed missing additional public ip on tier network wIn VPC 
tier network acquire an ip and configure the PF service on it. VR now will have 
the two ip addresses on the interface.
Now restart the VPC tier network with cleanup option. After router comes up the 
public interface has only one ip (source nat ip)
Fixed the above issue.

* pr/1885:
  CLOUDSTACK-9724: Fixed missing additional public ip on tier network with 
cleanup

Signed-off-by: Rajani Karuturi 


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879202#comment-15879202
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1885
  
tag:mergeready


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874312#comment-15874312
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1885
  
Failed test cases are not related to this PR code changes


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873313#comment-15873313
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1885
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 356
 Hypervisor xenserver
 NetworkType Advanced
 Passed=101
 Failed=2
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_router_dns.py

 * test_router_dns_guestipquery Failing since 2 runs

* test_routers_network_ops.py

 * ContextSuite context=TestRedundantIsolateNetworks>:setup Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865397#comment-15865397
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1885#discussion_r100985099
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, 
boolean postApplyRules, List 0) {
+if (network.getVpcId() != null) {
--- End diff --

Improved. Added more details


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863728#comment-15863728
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1885
  
The issue can be reproduced and fixed by this PR.
LGTM


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863459#comment-15863459
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1885#discussion_r100767709
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, 
boolean postApplyRules, List 0) {
+if (network.getVpcId() != null) {
--- End diff --

@jayapalu Please improve the code comment


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863460#comment-15863460
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1885
  
Code changes LGTM


> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9724) VPC tier network restart with cleanup, missing public ip on VR interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15792637#comment-15792637
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9724:


GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1885

CLOUDSTACK-9724: Fixed missing additional public ip on tier network w…

In VPC tier network acquire an ip and configure the PF service on it. VR 
now will have the two ip addresses on the interface.
Now restart the VPC tier network with cleanup option. After router comes up 
the public interface has only one ip (source nat ip)
Fixed the above issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack vpctier

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1885


commit f678e5d70886b1177b3087e521bfdebb6f945a06
Author: Jayapal 
Date:   2017-01-02T09:02:46Z

CLOUDSTACK-9724: Fixed missing additional public ip on tier network with 
cleanup




> VPC tier network restart with cleanup, missing public ip on VR interface
> 
>
> Key: CLOUDSTACK-9724
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9724
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Jayapal Reddy
>Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> On vpc tier network restart with clean up missing secondary ip addresses on 
> the VR public interface.
> 1. Create a vpc and deploy a vm in tier.
> 2. Acquire a public ip and configure PF rule
> 3. check that the VR interface has two ip addresses.
> 4. Restart the tier network with cleanup.
> 5. After restart in VR interface ip (PF rule configured) is missed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)