date:20160810

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415476#comment-15415476
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
LGTM for code


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9422) Granular VMware vm's creation as full clones on HV

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415471#comment-15415471
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9422:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1602#discussion_r74271023
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageSubsystemCommandHandler.java
 ---
@@ -66,19 +68,28 @@ public 
VmwareStorageSubsystemCommandHandler(StorageProcessor processor, Integer
 this._nfsVersion = nfsVersion;
 }
 
-/**
- * Reconfigure NFS version for storage operations
- * @param nfsVersion NFS version to set
- * @return true if NFS version could be configured, false in other case
- */
-public boolean reconfigureNfsVersion(Integer nfsVersion){
+public boolean 
reconfigureStorageProcessor(EnumMap
 params) {
+VmwareStorageProcessor processor = (VmwareStorageProcessor) 
this.processor;
 try {
-VmwareStorageProcessor processor = (VmwareStorageProcessor) 
this.processor;
-processor.setNfsVersion(nfsVersion);
-this._nfsVersion = nfsVersion;
+for (VmwareStorageProcessorConfigurableFields key : 
params.keySet()){
+switch (key){
+case NFS_VERSION:
+Integer nfsVersion = (Integer) params.get(key);
+processor.setNfsVersion(nfsVersion);
+this._nfsVersion = nfsVersion;
+break;
+case FULL_CLONE_FLAG:
+boolean fullClone = (boolean) params.get(key);
+processor.setFullCloneFlag(fullClone);
+break;
+default:
+String msg = "Unknown reconfigurable field " + 
key.getName() + " for VmwareStorageProcessor";
+throw new IllegalStateException(msg);
+}
+}
 return true;
-} catch (Exception e){
-s_logger.error("Error while reconfiguring NFS version " + 
nfsVersion);
+} catch (IllegalStateException e){
--- End diff --

Per my previous comment, why are we throwing an exception on line 86 and 
catching it here?  Why not log the error and return ``false`` in the 
``default`` case?  Using exceptions flow control is both expensive and an bad 
code smell.


> Granular VMware vm's creation as full clones on HV
> --
>
> Key: CLOUDSTACK-9422
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9422
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VMware
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> h3. Introduction
> For VMware, It is possible to decide creating VMs as full clones on ESX HV, 
> adjusting {{vmware.create.full.clone}} global setting. We would like to 
> introduce this property as a primary storage detail, and use its value 
> instead of global setting's value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9446) Package marvin and integration-tests for making testing easier

2016-08-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415195#comment-15415195
 ] 

ASF subversion and git services commented on CLOUDSTACK-9446:
-

Commit 8808cbeff7dd40c28424c1030b1e86bef521b2cd in cloudstack's branch 
refs/heads/4.6 from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8808cbe ]

CLOUDSTACK-9446: Marvin and integration-tests packages

This introduces two new cloudstack packages: marvin and integration-tests.
The two packages will make it easier for CI systems to install Marvin for a
specific cloudstack release/build and run integration tests that are specific
for that version/build.

- maven: add explicit juniper-contrail-api maven repository
- marvin: build source distribution for both install and package mvn phases

(cherry picked from commit 0d0ad8f5b49ec3a4a6e405eb2aee271ee3956e2e)
Signed-off-by: Rohit Yadav 


> Package marvin and integration-tests for making testing easier
> --
>
> Key: CLOUDSTACK-9446
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9446
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.10.0, 4.9.1
>
>
> CloudStack is tested using deb/rpm packages by CI systems like Trillian, 
> Bubble etc. When we test using packages we don't know exactly which 
> integration tests or marvin to install/run unless the git sha is known. By 
> packaging marvin and integration-tests too, we can make it easier for CI 
> systems and people to install marvin and run tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415324#comment-15415324
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74251739
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String type;
 
-public VirtioSerialDef(String name, String path) {
-_name = name;
-_path = path;
+ChannelType(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return this.type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String type;
+
+ChannelState(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return type;
+}
+}
+
+private String name;
+private String path;
+private ChannelType type;
+private ChannelState state;
+
+public ChannelDef(String name, ChannelType type) {
+this.name = name;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, String path) {
+this.name = name;
+this.path = path;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, ChannelState 
state) {
+this.name = name;
+this.state = state;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, ChannelState 
state, String path) {
+this.name = name;
+this.path = path;
+this.state = state;
+this.type = type;
+}
+
+public ChannelType getChannelType() {
+return type;
+}
+
+public ChannelState getChannelState() {
+return state;
+}
+
+public String getName() {
+return name;
+}
+
+public String getPath() {
+return path;
 }
 
 @Override
 public String toString() {
 StringBuilder virtioSerialBuilder = new StringBuilder();
-if (_path == null) {
-_path = "/var/lib/libvirt/qemu";
+virtioSerialBuilder.append("\n");
+if (path == null) {
+virtioSerialBuilder.append("\n");
+} else {
+virtioSerialBuilder.append("\n");
 }
-virtioSerialBuilder.append("\n");
-virtioSerialBuilder.append("\n");
-virtioSerialBuilder.append("\n");
 virtioSerialBuilder.append("\n");
+if (state == null) {
+virtioSerialBuilder.append("\n");
+} else {
+virtioSerialBuilder.append("\n");
+}
--- End diff --

See previously recommended refactoring for source mode as this ``if`` 
condition appears to follow the same pattern.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
>

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415316#comment-15415316
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74250378
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String type;
 
-public VirtioSerialDef(String name, String path) {
-_name = name;
-_path = path;
+ChannelType(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return this.type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String type;
+
+ChannelState(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return type;
+}
+}
+
+private String name;
+private String path;
+private ChannelType type;
+private ChannelState state;
--- End diff --

These attributes are not modified by the class.  Why not declare them as 
``final``?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9402) Nuage VSP Plugin : Support for underlay features (Source & Static NAT to underlay) including Marvin test coverage on master

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415231#comment-15415231
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9402:


Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1580
  
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$

@remibergsma  Our Marvin test code is now truly PEP8 & PyFlakes compliant. 
Moreover, we have extended our custom base class 
"test/integration/plugins/nuagevsp/nuageTestCase.py" support for optimal 
creation of cloudstack objects at setUpClass level in order to re-use/test them 
across different testcases. Thus, conserving test resources (i.e. reduced test 
created objects and time).  

Note: We have updated with these changes our other outstanding PRs as well. 

Let me know, if you have any other questions for me.

Thank you for your valuable review and suggestions !!


> Nuage VSP Plugin : Support for underlay features (Source & Static NAT to 
> underlay) including Marvin test coverage on master
> ---
>
> Key: CLOUDSTACK-9402
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9402
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Affects Versions: 4.10.0
>Reporter: Mani Prashanth Varma Manthena
>Assignee: Nick Livens
>
> Support for underlay features (Source & Static NAT to underlay) with Nuage 
> VSP SDN Plugin including Marvin test coverage for corresponding Source & 
> Static NAT features on master. Moreover, our Marvin tests are written in such 
> a way that they can validate our supported feature set with both Nuage VSP 
> SDN platform's overlay and underlay infra.
> PR contents:
> 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 3) Marvin test coverage for Source & Static NAT to underlay on master with 
> Nuage VSP SDN Plugin.
> 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 5) PEP8 & PyFlakes compliance with our Marvin test code.
> Our Marvin test code PEP8 & PyFlakes compliance:
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
> CloudStack$
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
> CloudStack$
> Validations:
> 1) Underlay infra (Source & Static NAT to underlay)
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> plugins/nuagevsp/test_nuage_source_nat.py
> Test results:
> Test Nuage VSP Isolated networks with different combinations of Source NAT 
> service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks 
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Source NAT service 
> providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : 
> SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for Isolated network by performing 
> (wget) traffic tests to the ... === TestName: 
> test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for VPC network by performing (wget) 
> traffic tests to the Internet ... === TestName: 
> test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with different Egress 
> Firewall/Network ACL rules by performing (wget) ... === TestName: 
> test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with VM NIC operations by performing 
> (wget) traffic tests to the ... === TestName: 
> test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with VM migration by performing 
> (wget) traffic tests to the Internet ... === TestName: 
> test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with network restarts by performing 
> (wget) traffic tests to the ... === TestName: 
> test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS ===
> ok
> --
> Ran 8 tests in 13360.858s
> OK
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> plugins/nuagevsp/test_nuage_static_nat.py
> Test results:
> Test Nuage VSP Public IP Range creation

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415308#comment-15415308
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74249341
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 ---
@@ -171,6 +174,25 @@ public boolean parseDomainXML(String domXML) {
 interfaces.add(def);
 }
 
+NodeList ports = devices.getElementsByTagName("channel");
+for (int i = 0; i < ports.getLength(); i++) {
+Element channel = (Element)ports.item(i);
+
+String type = channel.getAttribute("type");
+String path = getAttrValue("source", "path", channel);
+String name = getAttrValue("target", "name", channel);
+String state = getAttrValue("target", "state", channel);
+
+ChannelDef def = null;
+if (Strings.isNullOrEmpty(state)) {
+def = new ChannelDef(name, 
ChannelDef.ChannelType.valueOf(type.toUpperCase()), path);
+} else {
+def = new ChannelDef(name, 
ChannelDef.ChannelType.valueOf(type.toUpperCase()), 
ChannelDef.ChannelState.valueOf(state.toUpperCase()), path);
--- End diff --

What if ``state`` is ``null``?  While it likely shouldn't happen, malformed 
XML could cause an NPE which will not be helpful to operators or developers 
trying to debug the issue.  Consider adding a 
``checkState(StringUtils.isNoneBlank(state), "")`` on line 185.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415301#comment-15415301
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74248622
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -244,6 +245,7 @@
 protected long _diskActivityCheckFileSizeMin = 10485760; // 10MB
 protected int _diskActivityCheckTimeoutSeconds = 120; // 120s
 protected long _diskActivityInactiveThresholdMilliseconds = 3; // 
30s
+protected String _qemuSocketsPath;
--- End diff --

Why not represent this value as a ``File`` instead of a ``String``?  The 
``File`` class provides semantics for path construction, as well as, providing 
stronger type information.  Also, why is it declared ``protected`` and not 
``private``?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415311#comment-15415311
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74250104
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
--- End diff --

Do you design this class for inheritance?  If not, declare it ``final``?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415298#comment-15415298
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74248311
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1978,11 +1986,16 @@ So if getMinSpeed() returns null we fall back to 
getSpeed().
 final SerialDef serial = new SerialDef("pty", null, (short)0);
 devices.addDevice(serial);
 
+/* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
 if (vmTO.getType() != VirtualMachine.Type.User) {
-final VirtioSerialDef vserial = new 
VirtioSerialDef(vmTO.getName(), null);
-devices.addDevice(vserial);
+devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
+  _qemuSocketsPath + "/" + vmTO.getName() + 
".agent"));
 }
 
+/* Add a VirtIO channel for the Qemu Guest Agent tools */
+devices.addDevice(new ChannelDef("org.qemu.guest_agent.0", 
ChannelDef.ChannelType.UNIX,
--- End diff --

The ``org.qemu.guest_agent.0`` value is used in multiple places and appears 
to be a magic value.  Please consider extracting to a constant and/or a 
parameter passed into the method if this value could change based on context.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415310#comment-15415310
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74249850
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 ---
@@ -234,6 +256,10 @@ public Integer getVncPort() {
 return diskDefs;
 }
 
+public List getChannels() {
+return channels;
--- End diff --

Please make a defensive copy of the list before returning to avoid 
side-effects on this class by potential mutations of the list by the caller.  
Ideally, return it as a ``Collections.unmodifiableList(channels)``.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9403) Nuage VSP Plugin : Support for SharedNetwork fuctionality including Marvin test coverage

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415331#comment-15415331
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9403:


Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py
CloudStack$


> Nuage VSP Plugin : Support for SharedNetwork fuctionality including Marvin 
> test coverage
> 
>
> Key: CLOUDSTACK-9403
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9403
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Reporter: Rahul Singal
>Assignee: Nick Livens
>
> This is first phase of support of Shared Network in cloudstack through 
> NuageVsp Network Plugin. A shared network is a type of virtual network that 
> is shared between multiple accounts i.e. a shared network can be accessed by 
> virtual machines that belong to many different accounts. This basic 
> functionality will be supported with the below common use case:
> - shared network can be used for monitoring purposes. A shared network can be 
> assigned to a domain and can be used for monitoring VMs  belonging to all 
> accounts in that domain.
> - Public accessible of shared Network.
> With the current implementation with NuageVsp plugin, It support over-lapping 
> of Ip address, Public Access and also adding Ip ranges in shared Network.
> In VSD, it is implemented in below manner:
> - In order to have tenant isolation for shared networks, we will have to 
> create a Shared L3 Subnet for each shared network, and instantiate it across 
> the relevant enterprises. A shared network will only exist under an 
> enterprise when it is needed, so when the first VM is spinned under that ACS 
> domain inside that shared network.
> - For public shared Network it will also create a floating ip subnet pool in 
> VSD along with all the things mentioned in above point.
> PR contents:
> 1) Support for shared networks with tenant isolation on master with Nuage VSP 
> SDN Plugin.
> 2) Support of shared network with publicly accessible ip ranges.  
> 2) Marvin test coverage for shared networks on master with Nuage VSP SDN 
> Plugin.
> 3) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 4) PEP8 & PyFlakes compliance with our Marvin test code.
> Test Results are:-
> Valiate that ROOT admin is NOT able to deploy a VM for a user in ROOT domain 
> in a shared network with ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_ROOTuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is NOT able to deploy a VM for a admin user in a 
> shared network with ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_differentdomain | 
> Status : SUCCESS ===
> ok
> Valiate that ROOT admin is NOT able to deploy a VM for admin user in the same 
> domain but in a ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_domainadminuser | 
> Status : SUCCESS ===
> ok
> Valiate that ROOT admin is NOT able to deploy a VM for user in the same 
> domain but in a different ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_domainuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is able to deploy a VM for regular user in a shared 
> network with scope=account ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_user | Status : SUCCESS 
> ===
> ok
> Valiate that ROOT admin is able to deploy a VM for user in ROOT domain in a 
> shared network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_ROOTuser | Status : SUCCESS 
> ===
> ok
> Valiate that ROOT admin is able to deploy a VM for a domain admin users in a 
> shared network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_domainadminuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is able to deploy a VM for other users in a shared 
> network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_domainuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is able to deploy a VM for admin user in a domain in 
> a shared network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainadminuser | Status 
> : SUCCESS ===
> ok
> Valiate that ROOT admin is able to deploy a VM for any user in a subdomain in 
> a shared network with scope=all ... ===

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415294#comment-15415294
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74247733
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -768,6 +770,12 @@ public boolean configure(final String name, final 
Map params) th
 _localStoragePath = "/var/lib/libvirt/images/";
 }
 
+/* Directory to use for Qemu sockets like for the Qemu Guest Agent 
*/
+_qemuSocketsPath = (String)params.get("qemu.sockets.path");
+if (Strings.isNullOrEmpty(_qemuSocketsPath)) {
--- End diff --

One issue we have found with ``Strings.isNullOrEmpty`` is that it does do a 
``trim`` when checking for an empty string.  Therefore, a string containing one 
or more strings is considered non-empty.  Therefore, consider using 
``StringUtils.isNoneBlank`` if a string containing only whitespace would be a a 
problem.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415317#comment-15415317
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74250473
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String type;
 
-public VirtioSerialDef(String name, String path) {
-_name = name;
-_path = path;
+ChannelType(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return this.type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String type;
+
+ChannelState(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return type;
+}
+}
+
+private String name;
+private String path;
--- End diff --

Does the ``path`` attribute represent a file path?  If so, why not 
represent it as a ``File``?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9321) Multiple Internal LB rules (more than one Internal LB rule with same source IP address) are not getting resolved in the corresponding InternalLbVm instance's hapro

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415256#comment-15415256
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9321:


Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1577
  
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py
CloudStack$


> Multiple Internal LB rules (more than one Internal LB rule with same source 
> IP address) are not getting resolved in the corresponding InternalLbVm 
> instance's haproxy.cfg file
> --
>
> Key: CLOUDSTACK-9321
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9321
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, Network Controller
>Reporter: Mani Prashanth Varma Manthena
>Assignee: Nick Livens
>Priority: Critical
> Fix For: 4.9.1
>
>
> Multiple Internal LB rules (more than one Internal LB rule with same source 
> IP address) are not getting resolved in the corresponding InternalLbVm 
> instance's haproxy.cfg file. Moreover, each time a new Internal LB rule is 
> added to the corresponding InternalLbVm instance, it replaces the existing 
> one. Thus, traffic corresponding to these un-resolved (old) Internal LB rules 
> are getting dropped by the InternalLbVm instance.
> PR contents:
> 1) Fix for this bug.
> 2) Marvin test coverage for Internal LB feature on master with native ACS 
> setup (component directory) including validations for this bug fix.
> 3) Enhancements on our exiting Internal LB Marvin test code (nuagevsp plugins 
> directory) to validate this bug fix.
> 4) PEP8 & PyFlakes compliance with the added Marvin test code.
> Added Marvin test code PEP8 & PyFlakes compliance:
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 
> test/integration/component/test_vpc_network_internal_lbrules.py
> CloudStack$
> CloudStack$ pyflakes 
> test/integration/component/test_vpc_network_internal_lbrules.py
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
> CloudStack$
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
> CloudStack$
> Validations:
> 1) Made sure that we didn't break any Public LB (VpcVirtualRouter) 
> functionality.
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> test/integration/component/test_vpc_network_lbrules.py
> Test results:
> Test case no 210 and 227: List Load Balancing Rules belonging to a VPC ... 
> === TestName: test_01_VPC_LBRulesListing | Status : SUCCESS ===
> ok
> Test Create LB rules for 1 network which is part of a two/multiple virtual 
> networks of a ... === TestName: test_02_VPC_CreateLBRuleInMultipleNetworks | 
> Status : SUCCESS ===
> ok
> Test case no 222 : Create LB rules for a two/multiple virtual networks of a 
> ... === TestName: test_03_VPC_CreateLBRuleInMultipleNetworksVRStoppedState | 
> Status : SUCCESS ===
> ok
> Test case no 222 : Create LB rules for a two/multiple virtual networks of a 
> ... === TestName: test_04_VPC_CreateLBRuleInMultipleNetworksVRStoppedState | 
> Status : SUCCESS ===
> ok
> Test case no 214 : Delete few(not all) LB rules for a single virtual network 
> of a ... === TestName: test_05_VPC_CreateAndDeleteLBRule | Status : SUCCESS 
> ===
> ok
> Test Delete few(not all) LB rules for a single virtual network of ... === 
> TestName: test_06_VPC_CreateAndDeleteLBRuleVRStopppedState | Status : SUCCESS 
> ===
> ok
> Test Delete all LB rules for a single virtual network of a ... === TestName: 
> test_07_VPC_CreateAndDeleteAllLBRule | Status : SUCCESS ===
> ok
> Test Delete all LB rules for a single virtual network of a ... === TestName: 
> test_08_VPC_CreateAndDeleteAllLBRuleVRStoppedState | Status : SUCCESS ===
> ok
> Test User should not be allowed to create a LB rule for a VM that belongs to 
> a different VPC. ... === TestName: test_09_VPC_LBRuleCreateFailMultipleVPC | 
> Status : SUCCESS ===
> ok
> Test User should not be allowed to create a LB rule for a VM that does not 
> belong to any VPC. ... === TestName: 
> test_10_VPC_FailedToCreateLBRuleNonVPCNetwork | Status : SUCCESS ===
> ok
> Test case no 217 and 236: User should not be allowed to create a LB rule for 
> a ... === TestName: test_11_VPC_LBRuleCreateNotAllowed | Status : SUCCESS ===
> ok
> Test User should not be allowed to create a LB rule on an Ipaddress that 
> Source Nat enabled. ... === TestName:

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415302#comment-15415302
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74248818
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 ---
@@ -171,6 +174,25 @@ public boolean parseDomainXML(String domXML) {
 interfaces.add(def);
 }
 
+NodeList ports = devices.getElementsByTagName("channel");
+for (int i = 0; i < ports.getLength(); i++) {
+Element channel = (Element)ports.item(i);
+
+String type = channel.getAttribute("type");
+String path = getAttrValue("source", "path", channel);
+String name = getAttrValue("target", "name", channel);
+String state = getAttrValue("target", "state", channel);
+
+ChannelDef def = null;
+if (Strings.isNullOrEmpty(state)) {
--- End diff --

Please see previous comment about whitespace sensitivity in 
``String.isNullorEmpty``.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415312#comment-15415312
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74250260
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String type;
 
-public VirtioSerialDef(String name, String path) {
-_name = name;
-_path = path;
+ChannelType(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return this.type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String type;
+
+ChannelState(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return type;
+}
+}
+
+private String name;
+private String path;
+private ChannelType type;
+private ChannelState state;
+
+public ChannelDef(String name, ChannelType type) {
+this.name = name;
+this.type = type;
--- End diff --

Why not delegate to ``this(String name, ChannelType type, ChannelState 
state, String path)``?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415315#comment-15415315
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74250288
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String type;
 
-public VirtioSerialDef(String name, String path) {
-_name = name;
-_path = path;
+ChannelType(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return this.type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String type;
+
+ChannelState(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return type;
+}
+}
+
+private String name;
+private String path;
+private ChannelType type;
+private ChannelState state;
+
+public ChannelDef(String name, ChannelType type) {
+this.name = name;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, String path) {
+this.name = name;
+this.path = path;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, ChannelState 
state) {
--- End diff --

Why not delegate to ``this(String name, ChannelType type, ChannelState 
state, String path)``?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415314#comment-15415314
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74250269
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String type;
 
-public VirtioSerialDef(String name, String path) {
-_name = name;
-_path = path;
+ChannelType(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return this.type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String type;
+
+ChannelState(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return type;
+}
+}
+
+private String name;
+private String path;
+private ChannelType type;
+private ChannelState state;
+
+public ChannelDef(String name, ChannelType type) {
+this.name = name;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, String path) {
--- End diff --

Why not delegate to ``this(String name, ChannelType type, ChannelState 
state, String path)``?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415321#comment-15415321
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74251286
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String type;
 
-public VirtioSerialDef(String name, String path) {
-_name = name;
-_path = path;
+ChannelType(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return this.type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String type;
+
+ChannelState(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return type;
+}
+}
+
+private String name;
+private String path;
+private ChannelType type;
+private ChannelState state;
+
+public ChannelDef(String name, ChannelType type) {
+this.name = name;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, String path) {
+this.name = name;
+this.path = path;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, ChannelState 
state) {
+this.name = name;
+this.state = state;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, ChannelState 
state, String path) {
+this.name = name;
+this.path = path;
+this.state = state;
+this.type = type;
+}
+
+public ChannelType getChannelType() {
+return type;
+}
+
+public ChannelState getChannelState() {
+return state;
+}
+
+public String getName() {
+return name;
+}
+
+public String getPath() {
+return path;
 }
 
 @Override
 public String toString() {
 StringBuilder virtioSerialBuilder = new StringBuilder();
-if (_path == null) {
-_path = "/var/lib/libvirt/qemu";
+virtioSerialBuilder.append("\n");
+if (path == null) {
+virtioSerialBuilder.append("\n");
+} else {
+virtioSerialBuilder.append("\n");
--- End diff --

``");
virtioSerialBuilder.append(System.lineSeparator());
```


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415318#comment-15415318
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74250773
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
-private String _path;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String type;
 
-public VirtioSerialDef(String name, String path) {
-_name = name;
-_path = path;
+ChannelType(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return this.type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String type;
+
+ChannelState(String type) {
+this.type = type;
+}
+
+@Override
+public String toString() {
+return type;
+}
+}
+
+private String name;
+private String path;
+private ChannelType type;
+private ChannelState state;
+
+public ChannelDef(String name, ChannelType type) {
+this.name = name;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, String path) {
+this.name = name;
+this.path = path;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, ChannelState 
state) {
+this.name = name;
+this.state = state;
+this.type = type;
+}
+
+public ChannelDef(String name, ChannelType type, ChannelState 
state, String path) {
+this.name = name;
+this.path = path;
+this.state = state;
+this.type = type;
+}
+
+public ChannelType getChannelType() {
+return type;
+}
+
+public ChannelState getChannelState() {
+return state;
+}
+
+public String getName() {
+return name;
+}
+
+public String getPath() {
+return path;
 }
 
 @Override
 public String toString() {
 StringBuilder virtioSerialBuilder = new StringBuilder();
-if (_path == null) {
-_path = "/var/lib/libvirt/qemu";
+virtioSerialBuilder.append("\n");
--- End diff --

Please use ``System.lineseparator()`` instead of ``\n`` for proper platform 
independence.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9446) Package marvin and integration-tests for making testing easier

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415198#comment-15415198
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9446:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1612
  
Just to note here for future reference: this PR was backported to 4.5 and 
4.6 branches as well.


> Package marvin and integration-tests for making testing easier
> --
>
> Key: CLOUDSTACK-9446
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9446
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.10.0, 4.9.1
>
>
> CloudStack is tested using deb/rpm packages by CI systems like Trillian, 
> Bubble etc. When we test using packages we don't know exactly which 
> integration tests or marvin to install/run unless the git sha is known. By 
> packaging marvin and integration-tests too, we can make it easier for CI 
> systems and people to install marvin and run tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415305#comment-15415305
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r74249185
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 ---
@@ -171,6 +174,25 @@ public boolean parseDomainXML(String domXML) {
 interfaces.add(def);
 }
 
+NodeList ports = devices.getElementsByTagName("channel");
+for (int i = 0; i < ports.getLength(); i++) {
+Element channel = (Element)ports.item(i);
+
+String type = channel.getAttribute("type");
+String path = getAttrValue("source", "path", channel);
+String name = getAttrValue("target", "name", channel);
+String state = getAttrValue("target", "state", channel);
+
+ChannelDef def = null;
+if (Strings.isNullOrEmpty(state)) {
+def = new ChannelDef(name, 
ChannelDef.ChannelType.valueOf(type.toUpperCase()), path);
--- End diff --

What if ``type`` is ``null``?  While it likely shouldn't happen, malformed 
XML could cause an NPE.  Consider adding a 
``checkState(StringUtils.isNoneBlank(type), "")`` on line 185.


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9422) Granular VMware vm's creation as full clones on HV

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415716#comment-15415716
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9422:


Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1602#discussion_r74301008
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageSubsystemCommandHandler.java
 ---
@@ -66,19 +68,28 @@ public 
VmwareStorageSubsystemCommandHandler(StorageProcessor processor, Integer
 this._nfsVersion = nfsVersion;
 }
 
-/**
- * Reconfigure NFS version for storage operations
- * @param nfsVersion NFS version to set
- * @return true if NFS version could be configured, false in other case
- */
-public boolean reconfigureNfsVersion(Integer nfsVersion){
+public boolean 
reconfigureStorageProcessor(EnumMap
 params) {
+VmwareStorageProcessor processor = (VmwareStorageProcessor) 
this.processor;
 try {
-VmwareStorageProcessor processor = (VmwareStorageProcessor) 
this.processor;
-processor.setNfsVersion(nfsVersion);
-this._nfsVersion = nfsVersion;
+for (VmwareStorageProcessorConfigurableFields key : 
params.keySet()){
+switch (key){
+case NFS_VERSION:
+Integer nfsVersion = (Integer) params.get(key);
+processor.setNfsVersion(nfsVersion);
+this._nfsVersion = nfsVersion;
+break;
+case FULL_CLONE_FLAG:
+boolean fullClone = (boolean) params.get(key);
+processor.setFullCloneFlag(fullClone);
+break;
+default:
+String msg = "Unknown reconfigurable field " + 
key.getName() + " for VmwareStorageProcessor";
+throw new IllegalStateException(msg);
+}
+}
 return true;
-} catch (Exception e){
-s_logger.error("Error while reconfiguring NFS version " + 
nfsVersion);
+} catch (IllegalStateException e){
--- End diff --

Ok, thanks


> Granular VMware vm's creation as full clones on HV
> --
>
> Key: CLOUDSTACK-9422
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9422
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VMware
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> h3. Introduction
> For VMware, It is possible to decide creating VMs as full clones on ESX HV, 
> adjusting {{vmware.create.full.clone}} global setting. We would like to 
> introduce this property as a primary storage detail, and use its value 
> instead of global setting's value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9438) Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415974#comment-15415974
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9438:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@blueorangutan test


> Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI
> ---
>
> Key: CLOUDSTACK-9438
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9438
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> h3. Introduction
> From [9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] it was 
> possible to configure NFS version for secondary storage mount. 
> However, changing NFS version requires inserting an new detail on 
> {{image_store_details}} table, with {{name = 'nfs.version'}} and {{value = 
> X}} where X is desired NFS version, and then restarting management server for 
> changes to take effect.
> Our improvement aims to make NFS version changeable from UI, instead of 
> previously described workflow.
> h3. Proposed solution
> Basically, NFS version is defined as an image store ConfigKey, this implied:
> * Adding a new Config scope: *ImageStore*
> * Make {{ImageStoreDetailsDao}} class to extend {{ResourceDetailsDaoBase}} 
> and {{ImageStoreDetailVO}} implement {{ResourceDetail}}
> * Insert {{'display'}} column on {{image_store_details}} table
> * Extending {{ListCfgsCmd}} and {{UpdateCfgCmd}} to support *ImageStore* 
> scope, which implied:
> ** Injecting {{ImageStoreDetailsDao}} and {{ImageStoreDao}} on 
> {{ConfigurationManagerImpl}} class, on {{cloud-server}} module.
> h4. Important
> It is important to mention that {{ImageStoreDaoImpl}} and 
> {{ImageStoreDetailsDaoImpl}} classes were moved from {{cloud-engine-storage}} 
> to {{cloud-engine-schema}} module in order to Spring find those beans to 
> inject on {{ConfigurationManagerImpl}} in {{cloud-server}} module.
> We had this maven dependencies between modules:
> * {{cloud-server --> cloud-engine-schema}}
> * {{cloud-engine-storage --> cloud-secondary-storage --> cloud-server}}
> As {{ImageStoreDaoImpl}} and {{ImageStoreDetailsDaoImpl}} were defined in 
> {{cloud-engine-storage}}, and they needed in {{cloud-server}} module, to be 
> injected on {{ConfigurationManagerImpl}}, if we added dependency from 
> {{cloud-server}} to {{cloud-engine-storage}} we would introduce a dependency 
> cycle. To avoid this cycle, we moved those classes to {{cloud-engine-schema}} 
> module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9403) Nuage VSP Plugin : Support for SharedNetwork fuctionality including Marvin test coverage

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414786#comment-15414786
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9403:


GitHub user nlivens reopened a pull request:

https://github.com/apache/cloudstack/pull/1579

CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin

This is first phase of support of Shared Network in cloudstack through 
NuageVsp Network Plugin. A shared network is a type of virtual network that is 
shared between multiple accounts i.e. a shared network can be accessed by 
virtual machines that belong to many different accounts. This basic 
functionality will be supported with the below common use case:
- shared network can be used for monitoring purposes. A shared network can 
be assigned to a domain and can be used for monitoring VMs belonging to all 
accounts in that domain.

With the current implementation with NuageVsp plugin, Each shared network 
needs its unique IP address range, and can not overlap with another shared 
network. 
In VSD, it is implemented in below manner:
- In order to have tenant isolation for shared networks, we will have to 
create a Shared L3 Subnet for each shared network, and instantiate it across 
the relevant enterprises. A shared network will only exist under an enterprise 
when it is needed, so when the first VM is spinned under that ACS domain inside 
that shared network.

PR contents:
1) Support for shared networks with tenant isolation on master with Nuage 
VSP SDN Plugin.
2) Marvin test coverage for shared networks on master with Nuage VSP SDN 
Plugin.
3) Enhancements on our exiting Marvin test code (nuagevsp plugins 
directory).
4) PEP8 & PyFlakes compliance with our Marvin test code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nlivens/cloudstack nuage_vsp_shared_networks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1579.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1579


commit f316851375678b048e95d082a9df7035c7de0fa9
Author: Eric Waegeman 
Date:   2016-05-26T09:37:52Z

CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin

commit b10af67fef96607f7bf4defc8ccdb5e679f9fdc2
Author: Rahul Singal 
Date:   2016-07-01T13:22:50Z

CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp

commit b6b9589a6b452a1aec7185d26662f24554adf938
Author: Nick Livens 
Date:   2016-04-28T14:24:50Z

CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin

commit 09ee14e3917c69dfcbd5cf182ba44e77f2a31007
Author: rahul singal 
Date:   2016-06-01T15:31:24Z

CLOUDSTACK-9403 : Marvin tests for shared networks verification with 
NuageVsp

commit 9b4af844ff2d2ce008b7b8ec315754c2d9712964
Author: Nick Livens 
Date:   2016-07-01T14:14:55Z

CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin

commit 381b1ea79abe5712a346bf917326344abfa7a571
Author: Rahul Singal 
Date:   2016-07-01T14:20:58Z

CLOUDSTACK-9403 : Marvin tests for shared networks verification with 
NuageVsp

Phase 2: Public Access




> Nuage VSP Plugin : Support for SharedNetwork fuctionality including Marvin 
> test coverage
> 
>
> Key: CLOUDSTACK-9403
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9403
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Reporter: Rahul Singal
>Assignee: Nick Livens
>
> This is first phase of support of Shared Network in cloudstack through 
> NuageVsp Network Plugin. A shared network is a type of virtual network that 
> is shared between multiple accounts i.e. a shared network can be accessed by 
> virtual machines that belong to many different accounts. This basic 
> functionality will be supported with the below common use case:
> - shared network can be used for monitoring purposes. A shared network can be 
> assigned to a domain and can be used for monitoring VMs  belonging to all 
> accounts in that domain.
> - Public accessible of shared Network.
> With the current implementation with NuageVsp plugin, It support over-lapping 
> of Ip address, Public Access and also adding Ip ranges in shared Network.
> In VSD, it is implemented in below manner:
> - In order to have tenant

[jira] [Commented] (CLOUDSTACK-9403) Nuage VSP Plugin : Support for SharedNetwork fuctionality including Marvin test coverage

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414785#comment-15414785
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9403:


Github user nlivens closed the pull request at:

https://github.com/apache/cloudstack/pull/1579


> Nuage VSP Plugin : Support for SharedNetwork fuctionality including Marvin 
> test coverage
> 
>
> Key: CLOUDSTACK-9403
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9403
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Reporter: Rahul Singal
>Assignee: Nick Livens
>
> This is first phase of support of Shared Network in cloudstack through 
> NuageVsp Network Plugin. A shared network is a type of virtual network that 
> is shared between multiple accounts i.e. a shared network can be accessed by 
> virtual machines that belong to many different accounts. This basic 
> functionality will be supported with the below common use case:
> - shared network can be used for monitoring purposes. A shared network can be 
> assigned to a domain and can be used for monitoring VMs  belonging to all 
> accounts in that domain.
> - Public accessible of shared Network.
> With the current implementation with NuageVsp plugin, It support over-lapping 
> of Ip address, Public Access and also adding Ip ranges in shared Network.
> In VSD, it is implemented in below manner:
> - In order to have tenant isolation for shared networks, we will have to 
> create a Shared L3 Subnet for each shared network, and instantiate it across 
> the relevant enterprises. A shared network will only exist under an 
> enterprise when it is needed, so when the first VM is spinned under that ACS 
> domain inside that shared network.
> - For public shared Network it will also create a floating ip subnet pool in 
> VSD along with all the things mentioned in above point.
> PR contents:
> 1) Support for shared networks with tenant isolation on master with Nuage VSP 
> SDN Plugin.
> 2) Support of shared network with publicly accessible ip ranges.  
> 2) Marvin test coverage for shared networks on master with Nuage VSP SDN 
> Plugin.
> 3) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 4) PEP8 & PyFlakes compliance with our Marvin test code.
> Test Results are:-
> Valiate that ROOT admin is NOT able to deploy a VM for a user in ROOT domain 
> in a shared network with ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_ROOTuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is NOT able to deploy a VM for a admin user in a 
> shared network with ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_differentdomain | 
> Status : SUCCESS ===
> ok
> Valiate that ROOT admin is NOT able to deploy a VM for admin user in the same 
> domain but in a ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_domainadminuser | 
> Status : SUCCESS ===
> ok
> Valiate that ROOT admin is NOT able to deploy a VM for user in the same 
> domain but in a different ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_domainuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is able to deploy a VM for regular user in a shared 
> network with scope=account ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_account_user | Status : SUCCESS 
> ===
> ok
> Valiate that ROOT admin is able to deploy a VM for user in ROOT domain in a 
> shared network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_ROOTuser | Status : SUCCESS 
> ===
> ok
> Valiate that ROOT admin is able to deploy a VM for a domain admin users in a 
> shared network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_domainadminuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is able to deploy a VM for other users in a shared 
> network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_domainuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is able to deploy a VM for admin user in a domain in 
> a shared network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainadminuser | Status 
> : SUCCESS ===
> ok
> Valiate that ROOT admin is able to deploy a VM for any user in a subdomain in 
> a shared network with scope=all ... === TestName: 
> test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainuser | Status : 
> SUCCESS ===
> ok
> Valiate that ROOT admin is NOT able to deploy a VM for parent domain admin 
> user in a shared network with scope=domain

[jira] [Commented] (CLOUDSTACK-9402) Nuage VSP Plugin : Support for underlay features (Source & Static NAT to underlay) including Marvin test coverage on master

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414784#comment-15414784
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9402:


GitHub user nlivens reopened a pull request:

https://github.com/apache/cloudstack/pull/1580

CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to 
underlay) in Nuage VSP plugin

Support for underlay features (Source & Static NAT to underlay) with Nuage 
VSP SDN Plugin including Marvin test coverage for corresponding Source & Static 
NAT features on master. Moreover, our Marvin tests are written in such a way 
that they can validate our supported feature set with both Nuage VSP SDN 
platform's overlay and underlay infra.

PR contents:
1) Support for Source NAT to underlay feature on master with Nuage VSP SDN 
Plugin.
2) Support for Static NAT to underlay feature on master with Nuage VSP SDN 
Plugin.
3) Marvin test coverage for Source & Static NAT to underlay on master with 
Nuage VSP SDN Plugin.
4) Enhancements on our exiting Marvin test code (nuagevsp plugins 
directory).
5) PEP8 & PyFlakes compliance with our Marvin test code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1580


commit e5fd206e7e090121798c80745df4629f890e3234
Author: Eric Waegeman 
Date:   2016-05-26T09:37:52Z

CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin

commit ec7b6a5f887555e513b1d1d9c5e469eb079d721a
Author: Prashanth Manthena 
Date:   2016-05-26T10:48:02Z

CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including 
PAT/FIP2UL features with NuageVsp

commit be8ae9376664925255595a50f5c4574c4abb7179
Author: Nick Livens 
Date:   2016-06-15T09:04:21Z

CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to 
underlay) in Nuage VSP plugin

commit a2e1999bbacf3e00570bd51492b05cda8ca81c7d
Author: Rahul Singal 
Date:   2016-07-01T13:22:50Z

CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp




> Nuage VSP Plugin : Support for underlay features (Source & Static NAT to 
> underlay) including Marvin test coverage on master
> ---
>
> Key: CLOUDSTACK-9402
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9402
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Affects Versions: 4.10.0
>Reporter: Mani Prashanth Varma Manthena
>Assignee: Nick Livens
>
> Support for underlay features (Source & Static NAT to underlay) with Nuage 
> VSP SDN Plugin including Marvin test coverage for corresponding Source & 
> Static NAT features on master. Moreover, our Marvin tests are written in such 
> a way that they can validate our supported feature set with both Nuage VSP 
> SDN platform's overlay and underlay infra.
> PR contents:
> 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 3) Marvin test coverage for Source & Static NAT to underlay on master with 
> Nuage VSP SDN Plugin.
> 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 5) PEP8 & PyFlakes compliance with our Marvin test code.
> Our Marvin test code PEP8 & PyFlakes compliance:
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
> CloudStack$
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
> CloudStack$
> Validations:
> 1) Underlay infra (Source & Static NAT to underlay)
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> plugins/nuagevsp/test_nuage_source_nat.py
> Test results:
> Test Nuage VSP Isolated networks with different combinations of Source NAT 
> service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks 
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Source NAT service 
> providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : 
> SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for Isolated network by performing 
> (wget) traffic tests to the ...

[jira] [Commented] (CLOUDSTACK-9402) Nuage VSP Plugin : Support for underlay features (Source & Static NAT to underlay) including Marvin test coverage on master

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414783#comment-15414783
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9402:


Github user nlivens closed the pull request at:

https://github.com/apache/cloudstack/pull/1580


> Nuage VSP Plugin : Support for underlay features (Source & Static NAT to 
> underlay) including Marvin test coverage on master
> ---
>
> Key: CLOUDSTACK-9402
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9402
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Affects Versions: 4.10.0
>Reporter: Mani Prashanth Varma Manthena
>Assignee: Nick Livens
>
> Support for underlay features (Source & Static NAT to underlay) with Nuage 
> VSP SDN Plugin including Marvin test coverage for corresponding Source & 
> Static NAT features on master. Moreover, our Marvin tests are written in such 
> a way that they can validate our supported feature set with both Nuage VSP 
> SDN platform's overlay and underlay infra.
> PR contents:
> 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 3) Marvin test coverage for Source & Static NAT to underlay on master with 
> Nuage VSP SDN Plugin.
> 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 5) PEP8 & PyFlakes compliance with our Marvin test code.
> Our Marvin test code PEP8 & PyFlakes compliance:
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
> CloudStack$
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
> CloudStack$
> Validations:
> 1) Underlay infra (Source & Static NAT to underlay)
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> plugins/nuagevsp/test_nuage_source_nat.py
> Test results:
> Test Nuage VSP Isolated networks with different combinations of Source NAT 
> service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks 
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Source NAT service 
> providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : 
> SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for Isolated network by performing 
> (wget) traffic tests to the ... === TestName: 
> test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for VPC network by performing (wget) 
> traffic tests to the Internet ... === TestName: 
> test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with different Egress 
> Firewall/Network ACL rules by performing (wget) ... === TestName: 
> test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with VM NIC operations by performing 
> (wget) traffic tests to the ... === TestName: 
> test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with VM migration by performing 
> (wget) traffic tests to the Internet ... === TestName: 
> test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with network restarts by performing 
> (wget) traffic tests to the ... === TestName: 
> test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS ===
> ok
> --
> Ran 8 tests in 13360.858s
> OK
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> plugins/nuagevsp/test_nuage_static_nat.py
> Test results:
> Test Nuage VSP Public IP Range creation and deletion ... === TestName: 
> test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
> ok
> Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range 
> creation and deletion ... === TestName: 
> test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
> ok
> Test Nuage VSP Isolated networks with different combinations of Static NAT 
> service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks 
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Static NAT service 
> providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : 
> SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality for Isolated network by performing 
> (wget) traffic tests to the ... === TestName: 
>

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414832#comment-15414832
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@rhtyd Yes, we could not add the port to SSVMs right now and thus skip the 
Agent inside the SSVM.

That way only Instances will get the Socket and we can use it.

We can add it to the SSVM later, that would be a very simple PR.

Would that be a easier route to get this in?


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9379) Support nested virtualization at VM level on VMware Hypervisor

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415999#comment-15415999
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9379:


Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@nvazquez long time we don’t do this ;)

First of all, your PR explanation is great. The code is very well 
documented and explained and with test cases (very good ones). Congratulations. 
I really like your work. 

I have some suggestions for you, though.

I think that the method “enableNestedVirtualization” could return a 
Boolean. I see no need to transform the Boolean in a String there; It seems 
better to use Boolean.toString(bool) at line 376. Moreover, when reading the 
method “enableNestedVirtualization”, I felt like it was going to enable 
something on the VM, which is not the case. This looks more a “should”, “can”, 
“has” type of method. I mean, it is a method that checks if something has 
to/should/can be done; in this case, the enabling of nested virtualization. 
Therefore, I think names such as “canUseNestedVirtualization”, “should 
enableNestedVirtualization”, “hasToEnableNestedVirtualization” seem more 
appropriate.

I also think that the code has room for improvements. First, to reduce the 
cyclomatic complexity, you can invert the first if, which become something like 
this:
```
if (globalNestedV == null || globalNestedVPerVM == null) {
return false;
}
```
Then, the other conditional can be further improved. It is a bit 
complicated. Something like this would have the same result:
```
if (globalNVPVM) {
return (localNestedV == null && globalNV) || 
BooleanUtils.toBoolean(localNestedV);
}
  return globalNV;
```

On method “configNestedVirtualization”, I would just suggest using the word 
“configure” instead of “config”. At least for me, when I read config, I think 
configuration and not configure (this is a very personal opinion, so if you are 
ok with config, be my guest). A method, for me, means an action that is 
executed, so it seems a better fit the word “configure” (verb).

The method “testConfigNestedVirtualization”, I think it should check if the 
“VmDetailConstants.NESTED_VIRTUALIZATION_FLAG” flag (parameter) is being loaded 
properly from the “vmDetails”. I also suggest you using the “inOrder” to verify 
the calls in order. If the order of the calls changes, the behavior of the 
method changes too, right?

About the method “enableNestedVirtualizationBaseTest”, I think it could be 
a little bit more self-explaining, such as: 
executeAndVerifyTest.

And finally, about the others test methods, I think instead of TFT, TFN, 
and others at the end, I think if you were a bit more literal, and 
self-explaining, it would be better. For instance, the test method 
“testEnableNestedVirtualizationCaseTFF”, in a more detailed version, could be 
read as 
“testEnableNestedVirtualizationCaseGlobalNvTrueGlobalNvPvFalseLocalVmfalse”. I 
know it is a huge method name, but I think it facilitates for newcomers and 
also for the @nvazquez of the future ;)


> Support nested virtualization at VM level on VMware Hypervisor
> --
>
> Key: CLOUDSTACK-9379
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9379
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VMware
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> h2. Introduction
> It is desired to support nested virtualization at VM level for VMware 
> hypervisor. Current behaviour supports enabling/desabling global nested 
> virtualization by modifying global config {{'vmware.nested.virtualization'}}. 
> It is wished to improve this feature, having control at VM level instead of a 
> global control only.
> h2. Proposal
> A new global configuration is added, to enable/disable VM nested 
> virtualization control: {{'vmware.nested.virtualization.perVM'}}. Default 
> value=false
> h2. Behaviour
> After a vm deployment or start command, vm params include 
> {{nestedVirtualizationFlag}} key and its value is:
> * true -> nested virtualization enabled
> * false -> nested virtualization disabled
> We will determinate nested virtualization enabled/disabled by examining:
> * (1) global configuration {{'vmware.nested.virtualization'}} value
> * (2) global configuration {{'vmware.nested.virtualization.perVM'}} value
> * (3) {{'nestedVirtualizationFlag'}} value in {{user_vm_details}} if present, 
> null if not.
> Using this 3 values, there are different use cases:
> # (1) = TRUE, (2) = TRUE,

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414943#comment-15414943
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
Do we seriously want to write code that still works on CentOS 6 or systems 
without Python 2.7?

Looking at the Python website: 
https://docs.python.org/2/library/optparse.html

Deprecated since version 2.7: The optparse module is deprecated and 
will not be developed further; development will continue with the argparse 
module.

I wouldn't call this a blocker at all. CentOS 6 is pre-historic and we 
can't go back to using a old module like OptParse.

Sorry, -1 for me on this one.


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414964#comment-15414964
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user sverrirab commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
The updated script that now depends on python 2.7 (or python 2.6 + argparse 
I assume) is replacing the perl installation requirement that was there before. 
 Would it not be the correct solution to require python 2.7 to be installed?  
If the hosts are dedicated KVM hosts that should be relatively low risk?


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414976#comment-15414976
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
CentOS6 default/epel repos don't have python 2.7 :) There are large 
installations running old code, old hardware, old kernels/OSs; they will get 
upgraded over time, but they need to be supported for the time being. Lastly, I 
could make the same argument for our usage of Java6/7, why aren't we running 
Java8. Java7 has eoled, but most of us I know are still using it in production.


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414977#comment-15414977
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
Packaging result: ✖centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1633
Job ID-73


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9402) Nuage VSP Plugin : Support for underlay features (Source & Static NAT to underlay) including Marvin test coverage on master

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414998#comment-15414998
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9402:


Github user nlivens closed the pull request at:

https://github.com/apache/cloudstack/pull/1580


> Nuage VSP Plugin : Support for underlay features (Source & Static NAT to 
> underlay) including Marvin test coverage on master
> ---
>
> Key: CLOUDSTACK-9402
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9402
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Affects Versions: 4.10.0
>Reporter: Mani Prashanth Varma Manthena
>Assignee: Nick Livens
>
> Support for underlay features (Source & Static NAT to underlay) with Nuage 
> VSP SDN Plugin including Marvin test coverage for corresponding Source & 
> Static NAT features on master. Moreover, our Marvin tests are written in such 
> a way that they can validate our supported feature set with both Nuage VSP 
> SDN platform's overlay and underlay infra.
> PR contents:
> 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 3) Marvin test coverage for Source & Static NAT to underlay on master with 
> Nuage VSP SDN Plugin.
> 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 5) PEP8 & PyFlakes compliance with our Marvin test code.
> Our Marvin test code PEP8 & PyFlakes compliance:
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
> CloudStack$
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
> CloudStack$
> Validations:
> 1) Underlay infra (Source & Static NAT to underlay)
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> plugins/nuagevsp/test_nuage_source_nat.py
> Test results:
> Test Nuage VSP Isolated networks with different combinations of Source NAT 
> service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks 
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Source NAT service 
> providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : 
> SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for Isolated network by performing 
> (wget) traffic tests to the ... === TestName: 
> test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for VPC network by performing (wget) 
> traffic tests to the Internet ... === TestName: 
> test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with different Egress 
> Firewall/Network ACL rules by performing (wget) ... === TestName: 
> test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with VM NIC operations by performing 
> (wget) traffic tests to the ... === TestName: 
> test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with VM migration by performing 
> (wget) traffic tests to the Internet ... === TestName: 
> test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with network restarts by performing 
> (wget) traffic tests to the ... === TestName: 
> test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS ===
> ok
> --
> Ran 8 tests in 13360.858s
> OK
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> plugins/nuagevsp/test_nuage_static_nat.py
> Test results:
> Test Nuage VSP Public IP Range creation and deletion ... === TestName: 
> test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
> ok
> Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range 
> creation and deletion ... === TestName: 
> test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
> ok
> Test Nuage VSP Isolated networks with different combinations of Static NAT 
> service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks 
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Static NAT service 
> providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : 
> SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality for Isolated network by performing 
> (wget) traffic tests to the ... === TestName: 
>

[jira] [Commented] (CLOUDSTACK-9402) Nuage VSP Plugin : Support for underlay features (Source & Static NAT to underlay) including Marvin test coverage on master

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414999#comment-15414999
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9402:


GitHub user nlivens reopened a pull request:

https://github.com/apache/cloudstack/pull/1580

CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to 
underlay) in Nuage VSP plugin

Support for underlay features (Source & Static NAT to underlay) with Nuage 
VSP SDN Plugin including Marvin test coverage for corresponding Source & Static 
NAT features on master. Moreover, our Marvin tests are written in such a way 
that they can validate our supported feature set with both Nuage VSP SDN 
platform's overlay and underlay infra.

PR contents:
1) Support for Source NAT to underlay feature on master with Nuage VSP SDN 
Plugin.
2) Support for Static NAT to underlay feature on master with Nuage VSP SDN 
Plugin.
3) Marvin test coverage for Source & Static NAT to underlay on master with 
Nuage VSP SDN Plugin.
4) Enhancements on our exiting Marvin test code (nuagevsp plugins 
directory).
5) PEP8 & PyFlakes compliance with our Marvin test code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1580


commit e5fd206e7e090121798c80745df4629f890e3234
Author: Eric Waegeman 
Date:   2016-05-26T09:37:52Z

CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin

commit ec7b6a5f887555e513b1d1d9c5e469eb079d721a
Author: Prashanth Manthena 
Date:   2016-05-26T10:48:02Z

CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including 
PAT/FIP2UL features with NuageVsp

commit be8ae9376664925255595a50f5c4574c4abb7179
Author: Nick Livens 
Date:   2016-06-15T09:04:21Z

CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to 
underlay) in Nuage VSP plugin

commit a2e1999bbacf3e00570bd51492b05cda8ca81c7d
Author: Rahul Singal 
Date:   2016-07-01T13:22:50Z

CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp




> Nuage VSP Plugin : Support for underlay features (Source & Static NAT to 
> underlay) including Marvin test coverage on master
> ---
>
> Key: CLOUDSTACK-9402
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9402
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Affects Versions: 4.10.0
>Reporter: Mani Prashanth Varma Manthena
>Assignee: Nick Livens
>
> Support for underlay features (Source & Static NAT to underlay) with Nuage 
> VSP SDN Plugin including Marvin test coverage for corresponding Source & 
> Static NAT features on master. Moreover, our Marvin tests are written in such 
> a way that they can validate our supported feature set with both Nuage VSP 
> SDN platform's overlay and underlay infra.
> PR contents:
> 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN 
> Plugin.
> 3) Marvin test coverage for Source & Static NAT to underlay on master with 
> Nuage VSP SDN Plugin.
> 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 5) PEP8 & PyFlakes compliance with our Marvin test code.
> Our Marvin test code PEP8 & PyFlakes compliance:
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
> CloudStack$
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
> CloudStack$
> Validations:
> 1) Underlay infra (Source & Static NAT to underlay)
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg 
> plugins/nuagevsp/test_nuage_source_nat.py
> Test results:
> Test Nuage VSP Isolated networks with different combinations of Source NAT 
> service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks 
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Source NAT service 
> providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : 
> SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for Isolated network by performing 
> (wget) traffic tests to the ...

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415001#comment-15415001
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1633


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread Rohit Yadav (JIRA)

Rohit Yadav created CLOUDSTACK-9452:
---

 Summary: CentOS6 kvm hosts stop working after upgrade
 Key: CLOUDSTACK-9452
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
Reporter: Rohit Yadav
Assignee: Rohit Yadav
Priority: Blocker


Recently patchviasocket script was rewritten in python from perl, but it uses 
argparse causing failures on centos6 hosts with python 2.6 which may not have 
it pre-installed. The fix would be to use optparse etc. instaed of argparse as 
it's introduced only in python 2.7.

Error log;
DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
(logid:005ad4fd) Executing: 
/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
r-148-VM -p %t  
   
emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=

 
169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc

 
IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
(logid:005ad4fd) Exit value is 1
DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
(logid:005ad4fd) Traceback (most recent call last):  File 
"/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc

 hviasocket.py", line 25, in import 
argparseImportError: No module named argparse
DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
(logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
"/usr/share/cloudstack-common/scripts/vm/hype   
  
rvisor/kvm/patchviasocket.py", line 25, in import 
argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414939#comment-15414939
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
@karuturi @jburwell @wido @sverrirab please review, it's a blocker for kvm 
centos6 hosts without argparse/python2.7 installed.

I could run an existing test: (gave same results before and after the 
change)
$ python ./scripts/vm/hypervisor/kvm/test_patchviasocket.py
ERROR: unable to connect to /tmp/tmpDuudOL.sck - Permission denied
.ERROR: unable to open /tmp/tmpoEzOGN.sck - Permission denied
.ERROR: ssh public key not found on host at must-not-exist
.ERROR: unable to connect to /tmp/tmpm2rGlP.sck - Connection refused
.ERROR: must-not-exist socket not found
..
--
Ran 6 tests in 1.633s

OK


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414983#comment-15414983
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user sverrirab commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
adding the python-argparse dependency is fine by me.  I have not tested 
that combination though.


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414979#comment-15414979
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
@wido @sverrirab will adding python-argparse as a dependency be an 
acceptable solution to the problem? this package is available on el6, but 
python 2.7 is not available (without using one of the 3rd party repositories).


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9438) Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414993#comment-15414993
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9438:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
Packaging result: ✔centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1615
Job ID-74


> Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI
> ---
>
> Key: CLOUDSTACK-9438
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9438
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> h3. Introduction
> From [9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] it was 
> possible to configure NFS version for secondary storage mount. 
> However, changing NFS version requires inserting an new detail on 
> {{image_store_details}} table, with {{name = 'nfs.version'}} and {{value = 
> X}} where X is desired NFS version, and then restarting management server for 
> changes to take effect.
> Our improvement aims to make NFS version changeable from UI, instead of 
> previously described workflow.
> h3. Proposed solution
> Basically, NFS version is defined as an image store ConfigKey, this implied:
> * Adding a new Config scope: *ImageStore*
> * Make {{ImageStoreDetailsDao}} class to extend {{ResourceDetailsDaoBase}} 
> and {{ImageStoreDetailVO}} implement {{ResourceDetail}}
> * Insert {{'display'}} column on {{image_store_details}} table
> * Extending {{ListCfgsCmd}} and {{UpdateCfgCmd}} to support *ImageStore* 
> scope, which implied:
> ** Injecting {{ImageStoreDetailsDao}} and {{ImageStoreDao}} on 
> {{ConfigurationManagerImpl}} class, on {{cloud-server}} module.
> h4. Important
> It is important to mention that {{ImageStoreDaoImpl}} and 
> {{ImageStoreDetailsDaoImpl}} classes were moved from {{cloud-engine-storage}} 
> to {{cloud-engine-schema}} module in order to Spring find those beans to 
> inject on {{ConfigurationManagerImpl}} in {{cloud-server}} module.
> We had this maven dependencies between modules:
> * {{cloud-server --> cloud-engine-schema}}
> * {{cloud-engine-storage --> cloud-secondary-storage --> cloud-server}}
> As {{ImageStoreDaoImpl}} and {{ImageStoreDetailsDaoImpl}} were defined in 
> {{cloud-engine-storage}}, and they needed in {{cloud-server}} module, to be 
> injected on {{ConfigurationManagerImpl}}, if we added dependency from 
> {{cloud-server}} to {{cloud-engine-storage}} we would introduce a dependency 
> cycle. To avoid this cycle, we moved those classes to {{cloud-engine-schema}} 
> module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414935#comment-15414935
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1633

CLOUDSTACK-9452: use optparse instead of argparse in patchviasocket

Use optparse that is supported by python 2.3+, instead of argparse that is
supported by python 2.7+. On KVM hosts which don't have python-argparse pkg
installed, the patchviasocket script will break. This fixes so that 
patchviasocket
would work on CentOS6 KVM hosts, or KVM hosts without python 2.7/argparse in
general.

The patchviasocket script was rewritten as a Python script from PR #1533

@blueorangutan package

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack patchviasocket-49-py26fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1633


commit bfbf9f45ad8ca7247fb96005d47afeb7131ba216
Author: Rohit Yadav 
Date:   2016-08-10T08:43:40Z

CLOUDSTACK-9452: use optparse instead of argparse in patchviasocket

Use optparse that is supported by python 2.3+, instead of argparse that is
supported by python 2.7+. On KVM hosts which don't have python-argparse pkg
installed, the patchviasocket script will break. This fixes so that 
patchviasocket
would work on CentOS6 KVM hosts, or KVM hosts without python 2.7/argparse in
general.

The patchviasocket script was rewritten as a Python script from PR #1533

Signed-off-by: Rohit Yadav 




> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414936#comment-15414936
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9438) Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414948#comment-15414948
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9438:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


> Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI
> ---
>
> Key: CLOUDSTACK-9438
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9438
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> h3. Introduction
> From [9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] it was 
> possible to configure NFS version for secondary storage mount. 
> However, changing NFS version requires inserting an new detail on 
> {{image_store_details}} table, with {{name = 'nfs.version'}} and {{value = 
> X}} where X is desired NFS version, and then restarting management server for 
> changes to take effect.
> Our improvement aims to make NFS version changeable from UI, instead of 
> previously described workflow.
> h3. Proposed solution
> Basically, NFS version is defined as an image store ConfigKey, this implied:
> * Adding a new Config scope: *ImageStore*
> * Make {{ImageStoreDetailsDao}} class to extend {{ResourceDetailsDaoBase}} 
> and {{ImageStoreDetailVO}} implement {{ResourceDetail}}
> * Insert {{'display'}} column on {{image_store_details}} table
> * Extending {{ListCfgsCmd}} and {{UpdateCfgCmd}} to support *ImageStore* 
> scope, which implied:
> ** Injecting {{ImageStoreDetailsDao}} and {{ImageStoreDao}} on 
> {{ConfigurationManagerImpl}} class, on {{cloud-server}} module.
> h4. Important
> It is important to mention that {{ImageStoreDaoImpl}} and 
> {{ImageStoreDetailsDaoImpl}} classes were moved from {{cloud-engine-storage}} 
> to {{cloud-engine-schema}} module in order to Spring find those beans to 
> inject on {{ConfigurationManagerImpl}} in {{cloud-server}} module.
> We had this maven dependencies between modules:
> * {{cloud-server --> cloud-engine-schema}}
> * {{cloud-engine-storage --> cloud-secondary-storage --> cloud-server}}
> As {{ImageStoreDaoImpl}} and {{ImageStoreDetailsDaoImpl}} were defined in 
> {{cloud-engine-storage}}, and they needed in {{cloud-server}} module, to be 
> injected on {{ConfigurationManagerImpl}}, if we added dependency from 
> {{cloud-server}} to {{cloud-engine-storage}} we would introduce a dependency 
> cycle. To avoid this cycle, we moved those classes to {{cloud-engine-schema}} 
> module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9438) Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414947#comment-15414947
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9438:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@blueorangutan package

@jburwell @nvazquez since a new code commit was made, we need to call 
package before we could kick in tests.


> Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI
> ---
>
> Key: CLOUDSTACK-9438
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9438
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> h3. Introduction
> From [9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] it was 
> possible to configure NFS version for secondary storage mount. 
> However, changing NFS version requires inserting an new detail on 
> {{image_store_details}} table, with {{name = 'nfs.version'}} and {{value = 
> X}} where X is desired NFS version, and then restarting management server for 
> changes to take effect.
> Our improvement aims to make NFS version changeable from UI, instead of 
> previously described workflow.
> h3. Proposed solution
> Basically, NFS version is defined as an image store ConfigKey, this implied:
> * Adding a new Config scope: *ImageStore*
> * Make {{ImageStoreDetailsDao}} class to extend {{ResourceDetailsDaoBase}} 
> and {{ImageStoreDetailVO}} implement {{ResourceDetail}}
> * Insert {{'display'}} column on {{image_store_details}} table
> * Extending {{ListCfgsCmd}} and {{UpdateCfgCmd}} to support *ImageStore* 
> scope, which implied:
> ** Injecting {{ImageStoreDetailsDao}} and {{ImageStoreDao}} on 
> {{ConfigurationManagerImpl}} class, on {{cloud-server}} module.
> h4. Important
> It is important to mention that {{ImageStoreDaoImpl}} and 
> {{ImageStoreDetailsDaoImpl}} classes were moved from {{cloud-engine-storage}} 
> to {{cloud-engine-schema}} module in order to Spring find those beans to 
> inject on {{ConfigurationManagerImpl}} in {{cloud-server}} module.
> We had this maven dependencies between modules:
> * {{cloud-server --> cloud-engine-schema}}
> * {{cloud-engine-storage --> cloud-secondary-storage --> cloud-server}}
> As {{ImageStoreDaoImpl}} and {{ImageStoreDetailsDaoImpl}} were defined in 
> {{cloud-engine-storage}}, and they needed in {{cloud-server}} module, to be 
> injected on {{ConfigurationManagerImpl}}, if we added dependency from 
> {{cloud-server}} to {{cloud-engine-storage}} we would introduce a dependency 
> cycle. To avoid this cycle, we moved those classes to {{cloud-engine-schema}} 
> module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414959#comment-15414959
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
@wido I'm sorry we will need to support CentOS6 kvm hosts, just because you 
don't use it does not mean we should not support for people. It is a valid 
`blocker` as the KVM CentOS6 hosts have stopped working from deploying VMs.

`optparse` is deprecated which does not mean that it will fail or won't be 
available. We can have another way of fixing this: (1) revert #1533, (2) add a 
package dependency `python-argparse` on (at least centos6) rpms to ensure that 
argparse will be available on centos6/7 hosts. Which way should we go, if not 
the way PR fixes it?


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414969#comment-15414969
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user sverrirab commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
The reason for my suggestion is that I don't think anyone should be running 
python 2.6 in production.   The last update for it was in 2008 so I would 
consider it risky at this point.


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415004#comment-15415004
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9401) Nuage VSP Plugin : Support for InternalDns including Marvin test coverage

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415134#comment-15415134
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9401:


Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1578
  
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py
CloudStack$


> Nuage VSP Plugin : Support for InternalDns including Marvin test coverage
> -
>
> Key: CLOUDSTACK-9401
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9401
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation, Network Controller
>Reporter: Rahul Singal
>Assignee: Nick Livens
>
> Supporting Internal Dns by using Dns service provider as Virtual Router but 
> Dhcp provider will be NuageVsp. The idea is here is to keep using Internal 
> Dns service of cloudstack when network provider is some other vendor.
> A sample network offering will be like below one:-
> Service   Provider
> DHCP NuageVsp
> DNSVirtualRouter/VpcVirtualRouter
> UserDataVirtualRouter/VpcVirtualRouter
> Virtual Networking   NuageVsp
> SourceNat   NuageVsp
> StaticNat NuageVsp
> NetworkAcl/FirewallNuageVsp
> Testrun:-
> Verify InternalDns on Isolated Network ... === TestName: 
> test_01_Isolated_Network_with_zone | Status : SUCCESS ===
> ok
> Verify InternalDns on Isolated Network with ping by hostname ... === 
> TestName: test_02_Isolated_Network | Status : SUCCESS ===
> ok
> Verify update NetworkDomain for InternalDns on Isolated Network ... === 
> TestName: test_03_Update_Network_with_Domain | Status : SUCCESS ===
> ok
> Verify update NetworkDomain for InternalDns on Isolated Network with ping VM 
> ... === TestName: test_04_Update_Network_with_Domain | Status : SUCCESS ===
> ok
> Verify InternalDns on VPC Network ... === TestName: 
> test_05_VPC_Network_With_InternalDns | Status : SUCCESS ===
> ok
> Verify InternalDns on VPC Network by ping with hostname ... === TestName: 
> test_06_VPC_Network_With_InternalDns | Status : SUCCESS ===
> ok
> --
> Ran 6 tests in 5736.562s
> OK
> cloudstack$ pep8 --max-line-length=150 test_internal_dns.py
> cloudstack$  pyflakes test_internal_dns.py
> cloudstack$



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9438) Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414945#comment-15414945
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9438:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@jburwell the test pipeline had issues, I'll rekick it once I can get the 
issues sorted. For now, only package works without any issues. We also 
found/fixed a blocker that failed all of our kvm environments #1633 


> Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI
> ---
>
> Key: CLOUDSTACK-9438
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9438
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> h3. Introduction
> From [9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] it was 
> possible to configure NFS version for secondary storage mount. 
> However, changing NFS version requires inserting an new detail on 
> {{image_store_details}} table, with {{name = 'nfs.version'}} and {{value = 
> X}} where X is desired NFS version, and then restarting management server for 
> changes to take effect.
> Our improvement aims to make NFS version changeable from UI, instead of 
> previously described workflow.
> h3. Proposed solution
> Basically, NFS version is defined as an image store ConfigKey, this implied:
> * Adding a new Config scope: *ImageStore*
> * Make {{ImageStoreDetailsDao}} class to extend {{ResourceDetailsDaoBase}} 
> and {{ImageStoreDetailVO}} implement {{ResourceDetail}}
> * Insert {{'display'}} column on {{image_store_details}} table
> * Extending {{ListCfgsCmd}} and {{UpdateCfgCmd}} to support *ImageStore* 
> scope, which implied:
> ** Injecting {{ImageStoreDetailsDao}} and {{ImageStoreDao}} on 
> {{ConfigurationManagerImpl}} class, on {{cloud-server}} module.
> h4. Important
> It is important to mention that {{ImageStoreDaoImpl}} and 
> {{ImageStoreDetailsDaoImpl}} classes were moved from {{cloud-engine-storage}} 
> to {{cloud-engine-schema}} module in order to Spring find those beans to 
> inject on {{ConfigurationManagerImpl}} in {{cloud-server}} module.
> We had this maven dependencies between modules:
> * {{cloud-server --> cloud-engine-schema}}
> * {{cloud-engine-storage --> cloud-secondary-storage --> cloud-server}}
> As {{ImageStoreDaoImpl}} and {{ImageStoreDetailsDaoImpl}} were defined in 
> {{cloud-engine-storage}}, and they needed in {{cloud-server}} module, to be 
> injected on {{ConfigurationManagerImpl}}, if we added dependency from 
> {{cloud-server}} to {{cloud-engine-storage}} we would introduce a dependency 
> cycle. To avoid this cycle, we moved those classes to {{cloud-engine-schema}} 
> module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414951#comment-15414951
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8715:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@wido thanks, @PaulAngus found an issue with the kvm patchviasocket script 
and I've sent a fix #1533 
I was not sure what was causing the failure and saw this PR which looked 
promising. Let's get it in master and for master we can rebuild a new systemvm 
template (for kvm only?). /cc @jburwell @karuturi 


> Add support for qemu-guest-agent to libvirt provider
> 
>
> Key: CLOUDSTACK-8715
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Sten Spans
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, qemu, systemvm
> Fix For: Future
>
>
> The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite 
> a lot of useful functionality, which can only be provided by having an agent 
> on the VM. This includes things like freezing/thawing filesystems (for 
> backups), reading files on the guest, listing interfaces / ip addresses, etc.
> This feature has been requested by users, but is currently not implemented.
> http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent
> The first change needed is to add the following to the XML generated for KVM 
> virtual machines,:
> 
>   
>   
> 
> This provides the communication channel between libvirt and the agent on the 
> host. All in all a pretty simple change to LibvirtComputingResource.java / 
> LibvirtVMDef.java
> Secondly the qemu-guest-agent package needs to be added to the systemvm 
> template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414996#comment-15414996
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
@rhtyd I'm fine with adding it as a dependency.

Perception is different here I think. My personal opinion is that nobody 
should be running CentOS 6 with CloudStack in production just as much as you 
shouldn't use Ubuntu 12.04 anymore for CloudStack.

I'm against writing code which brings in legacy instead of removing it.


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415006#comment-15415006
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1634

[blocker] CLOUDSTACK-9452: add python-argparse dependency on el6,7 rpms

The patchviasocket script was rewritten in Python from PR #1533 and made
assumptions that Python 2.7 would be available. In case of CentOS, python 
2.7
may not be available or installed. This change ensures that python-argparse
is installed which is used by this script.

/cc @wido @sverrirab @karuturi @jburwell 

@blueorangutan package

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack patchviasocket-49-py26fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1634


commit 50e1d16e1e4aac43e1bed59516a374190e2f8ce3
Author: Rohit Yadav 
Date:   2016-08-10T08:43:40Z

CLOUDSTACK-9452: add python-argparse dependency on el6,7 rpms

The patchviasocket script was rewritten in Python from PR #1533 and made
assumptions that Python 2.7 would be available. In case of CentOS, python 
2.7
may not be available or installed. This change ensures that python-argparse
is installed which is used by this script.

Signed-off-by: Rohit Yadav 




> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415035#comment-15415035
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1633
  
Packaging result: ✔centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1633
Job ID-75


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415010#comment-15415010
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415026#comment-15415026
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user sverrirab commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
+1 from me (for what it's worth)


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9452) CentOS6 kvm hosts stop working after upgrade

2016-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415053#comment-15415053
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9452:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
Packaging result: ✔centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1634
Job ID-77


> CentOS6 kvm hosts stop working after upgrade
> 
>
> Key: CLOUDSTACK-9452
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9452
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Blocker
>
> Recently patchviasocket script was rewritten in python from perl, but it uses 
> argparse causing failures on centos6 hosts with python 2.6 which may not have 
> it pre-installed. The fix would be to use optparse etc. instaed of argparse 
> as it's introduced only in python 2.7.
> Error log;
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Executing: 
> /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patchviasocket.py -n 
> r-148-VM -p %t
>  
> emplate=domP%name=r-148-VM%eth2ip=10.1.34.18%eth2mask=255.255.224.0%gateway=10.1.63.254%eth0ip=10.1.1.1%eth0mask=255.255.255.0%domain=cs2cloud.internal%cidrsize=24%dhcprange=10.1.1.1%eth1ip=
>   
>    
> 169.254.1.214%eth1mask=255.255.0.0%type=router%disable_rp_filter=true%dns1=8.8.8.8%dns2=8.8.4.4%baremetalnotificationsecuritykey=4XFrHwfZgVr6DrJhgoBuNgbc5Vk7ACm90TW3GgYk9-O7TgNY9LXn_FNcm9Sdc
>   
>    
> IEnwSTktEx3K_a7ng2K4fpyUg%baremetalnotificationapikey=k3ja_d3xCTT78-ow30eah6TCvqYB3IIXYtKeaDJ4_TMdD7BbZbHhp07dVKXPiM5ee3xFn2wqSIxuX5LsObQYDg%host=10.2.3.61%port=8080
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Exit value is 1
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/patc  
>   
>  hviasocket.py", line 25, in import 
> argparseImportError: No module named argparse
> DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3 
> (logid:005ad4fd) passcmd failed:Traceback (most recent call last):  File 
> "/usr/share/cloudstack-common/scripts/vm/hype 
>   
>   rvisor/kvm/patchviasocket.py", line 25, in import 
> argparseImportError: No module named argparse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CLOUDSTACK-9453) Optimizing Marvin

2016-08-10 Thread Abhinandan Prateek (JIRA)

Abhinandan Prateek created CLOUDSTACK-9453:
--

 Summary: Optimizing Marvin
 Key: CLOUDSTACK-9453
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9453
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: marvin
Affects Versions: Future
Reporter: Abhinandan Prateek
Assignee: Abhinandan Prateek
 Fix For: Future


Currently running all Marvin tests can take upto 4 days. The tests are not 
optimized for nested cloud setup where most of the test automation runs. There 
are some simple things that can be done to optimize the runs:
1. Have smaller default template: If we install macchinina template by default 
and use it where there is no specific dependency on OS, then it will result in 
speeding up many of Marvin tests.
2. Most of the tests have template names hard-coded. It will be a good idea to 
allow some form of configuration so that test writers can use templates that 
better suit their test scenario.
3. Some test timeouts are unnecessary long and a failure can be deducted much 
early on instead of undergoing several long timeouts.
4. Ability to tune service offerings to better suit marvin environments.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9446) Package marvin and integration-tests for making testing easier

2016-08-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415191#comment-15415191
 ] 

ASF subversion and git services commented on CLOUDSTACK-9446:
-

Commit 2c5adb80853b9df8f6d970fd857e2b3c0693bdbf in cloudstack's branch 
refs/heads/4.5 from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2c5adb8 ]

CLOUDSTACK-9446: Marvin and integration-tests packages

This introduces two new cloudstack packages: marvin and integration-tests.
The two packages will make it easier for CI systems to install Marvin for a
specific cloudstack release/build and run integration tests that are specific
for that version/build.

- maven: add explicit juniper-contrail-api maven repository
- marvin: build source distribution for both install and package mvn phases

(cherry picked from commit 0d0ad8f5b49ec3a4a6e405eb2aee271ee3956e2e)
Signed-off-by: Rohit Yadav 


> Package marvin and integration-tests for making testing easier
> --
>
> Key: CLOUDSTACK-9446
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9446
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.10.0, 4.9.1
>
>
> CloudStack is tested using deb/rpm packages by CI systems like Trillian, 
> Bubble etc. When we test using packages we don't know exactly which 
> integration tests or marvin to install/run unless the git sha is known. By 
> packaging marvin and integration-tests too, we can make it easier for CI 
> systems and people to install marvin and run tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

61 matches

Mail list logo