[jira] Created: (LANG-508) Validate: add message parameter construction via elllipsis notation to speed up processing

2009-06-07 Thread Mark Struberg (JIRA)
Validate: add message parameter construction via elllipsis notation to speed up 
processing
--

 Key: LANG-508
 URL: https://issues.apache.org/jira/browse/LANG-508
 Project: Commons Lang
  Issue Type: Improvement
Affects Versions: 2.4
Reporter: Mark Struberg
 Fix For: 3.0


Currently passing verbose message strings to a log of commons.lang.Validate 
functions costs a lot of performance.

A typical usecase currently is:

{noformat}
Validate.isTrue (argInt1.intValue  argInt2.intValue, param2 actually is  + 
argInt2 +  but must larger than param1  + argInt1 + !);
{noformat}
So all the string operations get executed regardless if the validation fails or 
not.

This can be made perform much better by moving all the string operations inside 
the respective validation function and execute it only if the validation fails:
{noformat}
Validate.isTrue(argInt1.intValue  argInt2.intValue, param2 actually is {1} 
but must larger than param1 {0} !, argInt1, argInt2);
{noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (LANG-508) Validate: add message parameter construction via elllipsis notation to speed up processing

2009-06-07 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/LANG-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg updated LANG-508:
---

Attachment: LANG-508.patch

Patch which introduces new variants of all validate functions in the form of 
e.g.

{noformat}
public static void notNull(Object object, Object... msgObjects);
{noformat}

The commit is also available my github repo:

http://github.com/struberg/commons-lang/commit/ed8515f63290eba6e38ff5b79772e87b27dde32b

TBD: need to cleanup my JUnit tests, then I'll add those too soon

 Validate: add message parameter construction via elllipsis notation to speed 
 up processing
 --

 Key: LANG-508
 URL: https://issues.apache.org/jira/browse/LANG-508
 Project: Commons Lang
  Issue Type: Improvement
Affects Versions: 2.4
Reporter: Mark Struberg
 Fix For: 3.0

 Attachments: LANG-508.patch


 Currently passing verbose message strings to a log of commons.lang.Validate 
 functions costs a lot of performance.
 A typical usecase currently is:
 {noformat}
 Validate.isTrue (argInt1.intValue  argInt2.intValue, param2 actually is  + 
 argInt2 +  but must larger than param1  + argInt1 + !);
 {noformat}
 So all the string operations get executed regardless if the validation fails 
 or not.
 This can be made perform much better by moving all the string operations 
 inside the respective validation function and execute it only if the 
 validation fails:
 {noformat}
 Validate.isTrue(argInt1.intValue  argInt2.intValue, param2 actually is {1} 
 but must larger than param1 {0} !, argInt1, argInt2);
 {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.