[GitHub] commons-lang pull request: Lang 1134
Github user britter commented on the pull request: https://github.com/apache/commons-lang/pull/87#issuecomment-102938179 Very nice, I'll have a look later this week! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (POOL-294) Typo in documentation
Oleksandra created POOL-294: --- Summary: Typo in documentation Key: POOL-294 URL: https://issues.apache.org/jira/browse/POOL-294 Project: Commons Pool Issue Type: Bug Affects Versions: 2.0 Reporter: Oleksandra Priority: Trivial Fix For: 2.0 https://commons.apache.org/proper/commons-pool/api-2.0/org/apache/commons/pool2/impl/GenericKeyedObjectPoolConfig.html There is a typo in description of DEFAULT_MAX_IDLE_PER_KEY. It is said, that The default value for the minIdlePerKey configuration attribute. but probably it should be a default value for MAX(!)IdlePerKey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1014) Adding unwrap and unwrapFull methods to StringUtils
[ https://issues.apache.org/jira/browse/LANG-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14548424#comment-14548424 ] Sebb commented on LANG-1014: I still cannot see when one might want to use these methods. There's no point adding these methods and maintaining them unless they are actually going to be needed. What sort of application has strings that actually need unwrapping? Adding unwrap and unwrapFull methods to StringUtils --- Key: LANG-1014 URL: https://issues.apache.org/jira/browse/LANG-1014 Project: Commons Lang Issue Type: New Feature Components: lang.* Reporter: Thiago Andrade Assignee: Benedikt Ritter Labels: github Fix For: Review Patch, Discussion Placeholder ticket for github PR 25: https://github.com/apache/commons-lang/pull/25 Adding the following methods from StringUtils: {code:java} public static String unwrap(String str, char unwrapChar) public static String unwrapFull(String str, char unwrapChar) public static String unwrap(String str, String unwrapStr) public static String unwrapFull(String str, String unwrapStr) public static String unwrap(String str, String unwrapLeft, String unwrapRight) public static String unwrapFull(String str, String unwrapLeft, String unwrapRight) {code} These methods unwraps (fully or not) the string parameter. See pull request for usage examples. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LANG-1014) Adding unwrap and unwrapFull methods to StringUtils
[ https://issues.apache.org/jira/browse/LANG-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated LANG-1014: --- Fix Version/s: Discussion Adding unwrap and unwrapFull methods to StringUtils --- Key: LANG-1014 URL: https://issues.apache.org/jira/browse/LANG-1014 Project: Commons Lang Issue Type: New Feature Components: lang.* Reporter: Thiago Andrade Assignee: Benedikt Ritter Labels: github Fix For: Review Patch, Discussion Placeholder ticket for github PR 25: https://github.com/apache/commons-lang/pull/25 Adding the following methods from StringUtils: {code:java} public static String unwrap(String str, char unwrapChar) public static String unwrapFull(String str, char unwrapChar) public static String unwrap(String str, String unwrapStr) public static String unwrapFull(String str, String unwrapStr) public static String unwrap(String str, String unwrapLeft, String unwrapRight) public static String unwrapFull(String str, String unwrapLeft, String unwrapRight) {code} These methods unwraps (fully or not) the string parameter. See pull request for usage examples. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DBUTILS-105) Add Named Parameter Support
[ https://issues.apache.org/jira/browse/DBUTILS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14548482#comment-14548482 ] Danny Purcell commented on DBUTILS-105: --- What is needed to get this released? Add Named Parameter Support --- Key: DBUTILS-105 URL: https://issues.apache.org/jira/browse/DBUTILS-105 Project: Commons DbUtils Issue Type: Improvement Affects Versions: 2.0 Reporter: William R. Speirs Assignee: William R. Speirs Priority: Minor It's 2013 (don't read before 2013) and we should have the ability to used named params instead of just position params. Because Oracle uses colon for something or another, we should handle both #param and :param. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DBUTILS-105) Add Named Parameter Support
[ https://issues.apache.org/jira/browse/DBUTILS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14548553#comment-14548553 ] William R. Speirs commented on DBUTILS-105: --- Someone to shepherd it through the release process and the group to accept a 2.0 release. I've made these changes (and more) here: https://github.com/wspeirs/sop4j-dbutils You can access this package via Maven: http://mvnrepository.com/artifact/com.sop4j/dbutils/2.2 Add Named Parameter Support --- Key: DBUTILS-105 URL: https://issues.apache.org/jira/browse/DBUTILS-105 Project: Commons DbUtils Issue Type: Improvement Affects Versions: 2.0 Reporter: William R. Speirs Assignee: William R. Speirs Priority: Minor It's 2013 (don't read before 2013) and we should have the ability to used named params instead of just position params. Because Oracle uses colon for something or another, we should handle both #param and :param. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (EMAIL-152) Make javamail implementation dependency optional
[ https://issues.apache.org/jira/browse/EMAIL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Neidhart updated EMAIL-152: -- Fix Version/s: (was: 1.4) Make javamail implementation dependency optional Key: EMAIL-152 URL: https://issues.apache.org/jira/browse/EMAIL-152 Project: Commons Email Issue Type: Improvement Affects Versions: 1.3 Reporter: Thomas Neidhart Currently, commons-email has a transitive dependency to the reference implementation of javamail. This can lead to problems when trying to use another implementation (e.g. geronimo or gnu) at runtime, as one has to exclude dependencies. So I propose to change the dependencies as follows: * use an optional compile time dependency to the latest javamail api: {noformat} dependency groupIdjavax.mail/groupId artifactIdjavax.mail-api/artifactId version1.4.5/version scopecompile/scope optionaltrue/optional /dependency {noformat} * add an optional runtime dependency to the javamail reference impl {noformat} dependency groupIdcom.sun.mail/groupId artifactIdjavax.mail/artifactId version1.5.2/version scoperuntime/scope optionaltrue/optional /dependency {noformat} that way both dependencies are not transitive, thus project including commons-email have the opportunity to chose their javamail implementation. geronimo implementation: {noformat} dependency groupIdorg.apache.geronimo.javamail/groupId artifactIdgeronimo-javamail_1.4_mail/artifactId version1.8.3/version /dependency {noformat} or the oracle reference impl, as outlined above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] commons-lang pull request: Lang 1134
Github user Lady-Stardust commented on the pull request: https://github.com/apache/commons-lang/pull/87#issuecomment-103178381 I don't want to be listed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (DBUTILS-105) Add Named Parameter Support
[ https://issues.apache.org/jira/browse/DBUTILS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14548575#comment-14548575 ] Benedikt Ritter commented on DBUTILS-105: - bq. I've made these changes (and more) here: https://github.com/wspeirs/sop4j-dbutils which we still would like to see as additions in the 2.0 branch ;-) Add Named Parameter Support --- Key: DBUTILS-105 URL: https://issues.apache.org/jira/browse/DBUTILS-105 Project: Commons DbUtils Issue Type: Improvement Affects Versions: 2.0 Reporter: William R. Speirs Assignee: William R. Speirs Priority: Minor It's 2013 (don't read before 2013) and we should have the ability to used named params instead of just position params. Because Oracle uses colon for something or another, we should handle both #param and :param. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (IMAGING-171) MicrosoftTagTest rewrite image exif fails in some environments
[ https://issues.apache.org/jira/browse/IMAGING-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated IMAGING-171: Summary: MicrosoftTagTest rewrite image exif fails in some environments (was: MicrosoftTagTest rewrite image exif fails) MicrosoftTagTest rewrite image exif fails in some environments -- Key: IMAGING-171 URL: https://issues.apache.org/jira/browse/IMAGING-171 Project: Commons Imaging Issue Type: Bug Components: Format: TIFF Affects Versions: 1.0 Environment: Ubuntu 14.04 64-bit, Java 1.8.0_20 Reporter: Jan Helbich Priority: Minor Fix For: Patch Needed The MicrosoftTagTest test fails on testRewrite() method when supposedly rewritten MicrosoftTagConstants#EXIF_TAG_XPTITLE tag was already defined in another directory. The problem seems to be that the new value is written into the Exif directory, but the original one is in Root, which is evaluated first while checking test results. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (IMAGING-171) MicrosoftTagTest rewrite image exif fails in some environments
[ https://issues.apache.org/jira/browse/IMAGING-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter resolved IMAGING-171. - Resolution: Fixed Fix Version/s: (was: Patch Needed) 1.0 Assignee: Benedikt Ritter {code} $ svn ci -m IMAGING-171: MicrosoftTagTest rewrite image exif fails in some environments. This also closes #17 from github. Thanks to Jan Helbich. Sendingsrc/changes/changes.xml Sending src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MicrosoftTagTest.java Transmitting file data .. Committed revision 1680075. {code} Thank you! I've removed some tab characters. Please use only spaces for indentation next time. MicrosoftTagTest rewrite image exif fails in some environments -- Key: IMAGING-171 URL: https://issues.apache.org/jira/browse/IMAGING-171 Project: Commons Imaging Issue Type: Bug Components: Format: TIFF Affects Versions: 1.0 Environment: Ubuntu 14.04 64-bit, Java 1.8.0_20 Reporter: Jan Helbich Assignee: Benedikt Ritter Priority: Minor Fix For: 1.0 The MicrosoftTagTest test fails on testRewrite() method when supposedly rewritten MicrosoftTagConstants#EXIF_TAG_XPTITLE tag was already defined in another directory. The problem seems to be that the new value is written into the Exif directory, but the original one is in Root, which is evaluated first while checking test results. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (POOL-296) Update asm-util from 5.0.3 to 5.0.4
[ https://issues.apache.org/jira/browse/POOL-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed POOL-296. - Resolution: Fixed Update asm-util from 5.0.3 to 5.0.4 --- Key: POOL-296 URL: https://issues.apache.org/jira/browse/POOL-296 Project: Commons Pool Issue Type: Bug Affects Versions: 2.3 Environment: Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T04:57:37-07:00) Maven home: C:\Java\apache-maven-3.3.3 Java version: 1.7.0_79, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_79\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary Gregory Fix For: 2.4 Update asm-util from 5.0.3 to 5.0.4 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (POOL-295) Update tests from JUnit 4.11 to 4.12
[ https://issues.apache.org/jira/browse/POOL-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed POOL-295. - Resolution: Fixed Update tests from JUnit 4.11 to 4.12 Key: POOL-295 URL: https://issues.apache.org/jira/browse/POOL-295 Project: Commons Pool Issue Type: Bug Affects Versions: 2.3 Environment: Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T04:57:37-07:00) Maven home: C:\Java\apache-maven-3.3.3 Java version: 1.7.0_79, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_79\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary Gregory Fix For: 2.4 Update tests from JUnit 4.11 to 4.12. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (POOL-296) Update asm-util from 5.0.3 to 5.0.4
Gary Gregory created POOL-296: - Summary: Update asm-util from 5.0.3 to 5.0.4 Key: POOL-296 URL: https://issues.apache.org/jira/browse/POOL-296 Project: Commons Pool Issue Type: Bug Affects Versions: 2.3 Environment: Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T04:57:37-07:00) Maven home: C:\Java\apache-maven-3.3.3 Java version: 1.7.0_79, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_79\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary Gregory Fix For: 2.4 Update asm-util from 5.0.3 to 5.0.4 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DBCP-439) Update tests from JUnit 4.11 to 4.12
Gary Gregory created DBCP-439: - Summary: Update tests from JUnit 4.11 to 4.12 Key: DBCP-439 URL: https://issues.apache.org/jira/browse/DBCP-439 Project: Commons Dbcp Issue Type: Task Affects Versions: 2.1 Reporter: Gary Gregory Fix For: 2.1.1 Update tests from JUnit 4.11 to 4.12 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (POOL-295) Update tests from JUnit 4.11 to 4.12
Gary Gregory created POOL-295: - Summary: Update tests from JUnit 4.11 to 4.12 Key: POOL-295 URL: https://issues.apache.org/jira/browse/POOL-295 Project: Commons Pool Issue Type: Bug Affects Versions: 2.3 Environment: Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T04:57:37-07:00) Maven home: C:\Java\apache-maven-3.3.3 Java version: 1.7.0_79, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_79\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary Gregory Fix For: 2.4 Update tests from JUnit 4.11 to 4.12. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (DBCP-439) Update tests from JUnit 4.11 to 4.12
[ https://issues.apache.org/jira/browse/DBCP-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed DBCP-439. - Resolution: Fixed Update tests from JUnit 4.11 to 4.12 Key: DBCP-439 URL: https://issues.apache.org/jira/browse/DBCP-439 Project: Commons Dbcp Issue Type: Task Affects Versions: 2.1 Reporter: Gary Gregory Fix For: 2.1.1 Update tests from JUnit 4.11 to 4.12 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (DBCP-440) Update tests from Jacoco 0.7.2 to 0.7.4
[ https://issues.apache.org/jira/browse/DBCP-440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed DBCP-440. - Resolution: Fixed Update tests from Jacoco 0.7.2 to 0.7.4 --- Key: DBCP-440 URL: https://issues.apache.org/jira/browse/DBCP-440 Project: Commons Dbcp Issue Type: Task Affects Versions: 2.1 Environment: Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: C:\Java\apache-maven-3.2.5 Java version: 1.7.0_79, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_79\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary Gregory Fix For: 2.1.1 Update tests from Jacoco 0.7.2 to 0.7.4. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DBCP-440) Update tests from Jacoco 0.7.2 to 0.7.4
Gary Gregory created DBCP-440: - Summary: Update tests from Jacoco 0.7.2 to 0.7.4 Key: DBCP-440 URL: https://issues.apache.org/jira/browse/DBCP-440 Project: Commons Dbcp Issue Type: Task Affects Versions: 2.1 Environment: Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: C:\Java\apache-maven-3.2.5 Java version: 1.7.0_79, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_79\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary Gregory Fix For: 2.1.1 Update tests from Jacoco 0.7.2 to 0.7.4. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LANG-1115) Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils
[ https://issues.apache.org/jira/browse/LANG-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated LANG-1115: -- Fix Version/s: 3.5 Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils - Key: LANG-1115 URL: https://issues.apache.org/jira/browse/LANG-1115 Project: Commons Lang Issue Type: Improvement Components: lang.reflect.* Reporter: Joe Ferner Priority: Minor Fix For: Review Patch, 3.5 Attachments: LANG-1115.patch Currently when calling methods such as MethodUtils.getMatchingAccessibleMethod variable arguments are not supported. It would be nice if by calling getMatchingAccessibleMethod with arguments that the java compiler would normally match with a vararg method would be matched. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1115) Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils
[ https://issues.apache.org/jira/browse/LANG-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547608#comment-14547608 ] Benedikt Ritter commented on LANG-1115: --- [~jimlloyd-sf], thank you! I will have a look later this week. Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils - Key: LANG-1115 URL: https://issues.apache.org/jira/browse/LANG-1115 Project: Commons Lang Issue Type: Improvement Components: lang.reflect.* Reporter: Joe Ferner Priority: Minor Fix For: Review Patch, 3.5 Attachments: LANG-1115.patch Currently when calling methods such as MethodUtils.getMatchingAccessibleMethod variable arguments are not supported. It would be nice if by calling getMatchingAccessibleMethod with arguments that the java compiler would normally match with a vararg method would be matched. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LANG-1134) New methods for lang3.Validate
[ https://issues.apache.org/jira/browse/LANG-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated LANG-1134: -- Fix Version/s: (was: Patch Needed) 3.5 Review Patch New methods for lang3.Validate -- Key: LANG-1134 URL: https://issues.apache.org/jira/browse/LANG-1134 Project: Commons Lang Issue Type: Improvement Components: lang.* Affects Versions: 3.4 Reporter: Stardust Priority: Minor Fix For: Review Patch, 3.5 These are suggestions for new methods for the Validate class. h1. Floating point values h2. notNaN(value) Throws an exception if value != value . {code}double value; value = Double.NaN; Validate.notNaN(value);// Throws exception value = 1.0; Validate.notNaN(value);// Validates value = Double.POSITIVE_INFINITY; Validate.notNaN(value);// Validates{code} h2. finite(value) Validates that the argument contains a numeric value (not NaN or infinite). {code}double value; value = Double.NaN; Validate.finite(value);// Throws exception value = Double.POSITIVE_INFINITY; Validate.finite(value);// Throws exception value = 1.0; Validate.finite(value);// Validates{code} h1. Integers and floats The following methods are overloaded to accept both integers and floating point values. h2. greater(reference, value), greaterOrEqual(reference, value) Ensures the argument is greater than (or equal to) a given value. {code}double value; value = 0.0; Validate.greater(0.0, value);// Throws exception Validate.greaterOrEqual(0.0, value); // Validates value = Double.POSITIVE_INFINITY; Validate.greater(0.0, value);// Validates value = Double.NaN; Validate.greater(0.0, value);// Throws exception{code} h2. smaller(reference, value), smallerOrEqual(reference, value) Ensures the argument is smaller than (or equal to) a given value. Does the opposite of greater(), see example above. h2. different(reference, value) Ensures the argument is not equal to a given value. A typical use case would be to accept only non-zero values. {code}double value; value = 0.0; Validate.different(0.0, value);// Throws exception Validate.different(1.0, value);// Validates value = Double.NaN; Validate.different(0.0, value);// Validates{code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1124) Add split by length methods in StringUtils
[ https://issues.apache.org/jira/browse/LANG-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547613#comment-14547613 ] ASF GitHub Bot commented on LANG-1124: -- Github user britter commented on the pull request: https://github.com/apache/commons-lang/pull/75#issuecomment-102940510 @rikles thank you for your thorough feedback. Give me some time to go through your comments. I'll have time to have a look later this week. Add split by length methods in StringUtils -- Key: LANG-1124 URL: https://issues.apache.org/jira/browse/LANG-1124 Project: Commons Lang Issue Type: New Feature Components: lang.* Reporter: Loic Guibert Add methods to split a String by fixed lengths : {code:java} public static String[] splitByLength(String str, int ... lengths); public static String[] splitByLengthRepeatedly(String str, int ... lengths); {code} Detail : {code:java} /** * pSplit a String into an array, using an array of fixed string lengths./p * * pIf not null String input, the returned array size is same as the input lengths array./p * * pA null input String returns {@code null}. * A {@code null} or empty input lengths array returns an empty array. * A {@code 0} in the input lengths array results in en empty string./p * * pExtra characters are ignored (ie String length greater than sum of split lengths). * All empty substrings other than zero length requested, are returned {@code null}./p * * pre * StringUtils.splitByLength(null, *) = null * StringUtils.splitByLength(abc)= [] * StringUtils.splitByLength(abc, null) = [] * StringUtils.splitByLength(abc, [])= [] * StringUtils.splitByLength(, 2, 4, 1) = [null, null, null] * * StringUtils.splitByLength(abcdefg, 2, 4, 1) = [ab, cdef, g] * StringUtils.splitByLength(abcdefghij, 2, 4, 1) = [ab, cdef, g] * StringUtils.splitByLength(abcdefg, 2, 4, 5) = [ab, cdef, g] * StringUtils.splitByLength(abcdef, 2, 4, 1) = [ab, cdef, null] * * StringUtils.splitByLength( abcdef, 2, 4, 1) = [ a, bcde, f] * StringUtils.splitByLength(abcdef , 2, 4, 1) = [ab, cdef, ] * StringUtils.splitByLength(abcdefg, 2, 4, 0, 1) = [ab, cdef, , g] * StringUtils.splitByLength(abcdefg, -1) = {@link IllegalArgumentException} * /pre * * @param str the String to parse, may be null * @param lengths the string lengths where to cut, may be null, must not be negative * @return an array of splitted Strings, {@code null} if null String input * @throws IllegalArgumentException * if one of the lengths is negative */ public static String[] splitByLength(String str, int ... lengths); /** * pSplit a String into an array, using an array of fixed string lengths repeated as * many times as necessary to reach the String end./p * * pIf not null String input, the returned array size is a multiple of the input lengths array./p * * pA null input String returns {@code null}. * A {@code null} or empty input lengths array returns an empty array. * A {@code 0} in the input lengths array results in en empty string./p * * pAll empty substrings other than zero length requested and following substrings, * are returned {@code null}./p * * pre * StringUtils.splitByLengthRepeated(null, *) = null * StringUtils.splitByLengthRepeated(abc)= [] * StringUtils.splitByLengthRepeated(abc, null) = [] * StringUtils.splitByLengthRepeated(abc, [])= [] * StringUtils.splitByLengthRepeated(, 2, 4, 1) = [null, null, null] * * StringUtils.splitByLengthRepeated(abcdefghij, 2, 3) = [ab, cde, fg, hij] * StringUtils.splitByLengthRepeated(abcdefgh, 2, 3) = [ab, cde, fg, h] * StringUtils.splitByLengthRepeated(abcdefg, 2, 3)= [ab, cde, fg, null] * * StringUtils.splitByLengthRepeated( abcdef, 2, 3)= [ a, bcd, ef, null] * StringUtils.splitByLengthRepeated(abcdef , 2, 3)= [ab, cde, f , null] * StringUtils.splitByLengthRepeated(abcdef, 2, 3, 0, 1) = [ab, cde, , f] * StringUtils.splitByLengthRepeated(abcdefg, 2, 3, 0, 1) = [ab, cde, , f, * g, null, null, null] * StringUtils.splitByLengthRepeated(abcdefgh, 2, 0, 1, 0) = [ab, , c, , * de, , f, , * gh, , null, null] * StringUtils.splitByLengthRepeated(abcdefg, 2, 0, 1, 0) = [ab, , c, , * de, , f, , * g, null, null, null] * StringUtils.splitByLengthRepeated(abcdefg, -1) = {@link
[GitHub] commons-lang pull request: LANG-1124: Add StringUtils split by len...
Github user britter commented on the pull request: https://github.com/apache/commons-lang/pull/75#issuecomment-102940510 @rikles thank you for your thorough feedback. Give me some time to go through your comments. I'll have time to have a look later this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request: Lang 1134
Github user britter commented on the pull request: https://github.com/apache/commons-lang/pull/87#issuecomment-102938770 @Lady-Stardust, what is the name you want to be listed with in [changes.xml](https://github.com/apache/commons-lang/blob/master/src/changes/changes.xml)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---