[jira] [Commented] (BEANUTILS-500) Upgrade commons-collections to 4

[Melloware (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEANUTILS-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159249#comment-16159249
 ] 

Melloware commented on BEANUTILS-500:
-

Definitely would love this change as my project only dependency on the regular 
commons collections is BeanUtils.  Once it is switched all of mine will be on 
Collections4 and I can remove old Collections from my WAR.  Right now I need 
both collections with BeanUtils 1.9.3

> Upgrade commons-collections to 4
> 
>
> Key: BEANUTILS-500
> URL: https://issues.apache.org/jira/browse/BEANUTILS-500
> Project: Commons BeanUtils
>  Issue Type: Improvement
>  Components: Bean / Property Utils
>Affects Versions: 2.0
>Reporter: Dave Brosius
>Priority: Minor
> Fix For: 2.0
>
> Attachments: BEANUTILS-500.txt
>
>
> uptake commons-collections4.
> The main difference is the removal of 'FastHashMap', and replacement with 
> ConcurrentHashMap.
> There are a few breaking changes for deprecated methods that return a 
> FastHashMap, that are exposed.
> I made them package private, and undeprecated them, thus 2.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LANG-1348) StackOverflowError on TypeUtils.toString(...) for a generic return type of Enum.valueOf

[Pascal Schumacher (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher updated LANG-1348:

Priority: Major  (was: Critical)

> StackOverflowError on TypeUtils.toString(...) for a generic return type of 
> Enum.valueOf
> ---
>
> Key: LANG-1348
> URL: https://issues.apache.org/jira/browse/LANG-1348
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.reflect.*
>Affects Versions: 3.6
> Environment: Java 8 update 144
>Reporter: Dmitry Ovchinnikov
>
> The following code
> {code:java}
> final Method method = Enum.class.getMethod("valueOf", Class.class, 
> String.class);
> final String typeText = TypeUtils.toString(method.getGenericReturnType());
> {code}
> throws the following
> {code:none}
> Exception in thread "main" java.lang.StackOverflowError
>   at 
> sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.getRawType(ParameterizedTypeImpl.java:126)
>   at 
> sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.getRawType(ParameterizedTypeImpl.java:40)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.parameterizedTypeToString(TypeUtils.java:1790)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1666)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1846)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1846)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.parameterizedTypeToString(TypeUtils.java:1803)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1666)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1846)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1846)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.parameterizedTypeToString(TypeUtils.java:1803)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1666)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1846)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1846)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.parameterizedTypeToString(TypeUtils.java:1803)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1666)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1846)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
>   at 
> org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LANG-1295) ArrayUtils.toArray(T... items) has unsafe use of varargs

[Pascal Schumacher (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher updated LANG-1295:

Priority: Major  (was: Critical)

> ArrayUtils.toArray(T... items) has unsafe use of varargs
> 
>
> Key: LANG-1295
> URL: https://issues.apache.org/jira/browse/LANG-1295
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.*
>Affects Versions: 3.5
>Reporter: Duncan Jones
>
> {{ArrayUtils.toArray(T... items)}} is marked as {{@SafeVarargs}}, but I 
> suspect the use of the varargs is unsafe.
> An example, drawn heavily from [this StackOverflow 
> answer|http://stackoverflow.com/a/14252221/474189], demonstrates this:
> {code:java}
> static  T[] arrayOfTwo(T a, T b) {
> return ArrayUtils.toArray(a, b);
> }
> @Test
> public void testBadVarArgs() throws Exception {
> @SuppressWarnings("unused") // Need to assign to trigger exception
> String[] result = arrayOfTwo("foo", "bar");
> }
> {code}
> the above code throws an exception: {{java.lang.ClassCastException: 
> [Ljava.lang.Object; cannot be cast to [Ljava.lang.String;}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LANG-1296) ArrayUtils.addAll() has unsafe use of varargs

[Pascal Schumacher (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher updated LANG-1296:

Priority: Major  (was: Critical)

> ArrayUtils.addAll() has unsafe use of varargs
> -
>
> Key: LANG-1296
> URL: https://issues.apache.org/jira/browse/LANG-1296
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.*
>Affects Versions: 3.5
>Reporter: Duncan Jones
>
> {{ArrayUtils.addAll()}} is marked as {{@SafeVarargs}}, but I suspect the use 
> of the varargs is unsafe.
> An example, drawn heavily from [this StackOverflow 
> answer|http://stackoverflow.com/a/14252221/474189], demonstrates this:
> {code:java}
> static  T[] arrayOfTwo(T a, T b) {
>return ArrayUtils.addAll(null, a, b);
> }
> @Test
> public void testBadVarArgs() throws Exception {
>@SuppressWarnings("unused") // Need to assign to trigger exception
>String[] result = arrayOfTwo("foo", "bar");
> }
> {code}
> the above code throws an exception: {{java.lang.ClassCastException: 
> [Ljava.lang.Object; cannot be cast to [Ljava.lang.String;}}.
> Here, the {{null}} input array causes the method to return a clone of the 
> vararg array. This is what triggers the problem.
> I faced a similar issue when adding the {{ArrayUtils.insert(...)}} methods 
> and I solved it by returning {{null}} if the input array is {{null}}. We 
> can't do this here without breaking behaviour.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (LANG-1349) EqualsBuilder#isRegistered: swappedPair construction bug

[Pascal Schumacher (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher resolved LANG-1349.
-
   Resolution: Fixed
 Assignee: Pascal Schumacher
Fix Version/s: 3.7

> EqualsBuilder#isRegistered: swappedPair construction bug
> 
>
> Key: LANG-1349
> URL: https://issues.apache.org/jira/browse/LANG-1349
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.builder.*
>Affects Versions: 3.6
>Reporter: Pascal Schumacher
>Assignee: Pascal Schumacher
> Fix For: 3.7
>
>
> See
> https://stackoverflow.com/questions/45603317/org-apache-commons-lang3-builder-equalsbuilder
> and
> https://github.com/apache/commons-lang/pull/282
> for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/282
  
I added a test. Thanks for the pull request! :+1: 


---

[GitHub] commons-lang pull request #282: SwappedPair constructed as Pair.of(rhs,lhs)

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/282


---

[GitHub] commons-lang pull request #284: remove redundant modifiers (support recent c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/284


---

[GitHub] commons-lang issue #284: remove redundant modifiers (support recent checksty...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/284
  
Thanks! :+1:


---

[jira] [Created] (IO-549) Make ByteArrayOutputStream.toBufferedInputStream public to avoid a buffer copy

[Rob Reeves (JIRA)]

Rob Reeves created IO-549:
-

 Summary: Make ByteArrayOutputStream.toBufferedInputStream public 
to avoid a buffer copy
 Key: IO-549
 URL: https://issues.apache.org/jira/browse/IO-549
 Project: Commons IO
  Issue Type: Improvement
  Components: Streams/Writers
Affects Versions: 2.5
Reporter: Rob Reeves
Priority: Minor


I'm working on a project where I need to aggregate a lot of data in memory. To 
do this I'm using GzipOutputStream backed by 
org.apache.commons.io.output.ByteArrayOutputStream. After the aggregation is 
done I eventually will read the data back out. I'm trying to avoid byte[] 
buffer copies to reduce the memory usage. 
ByteArrayOutputStream.toBufferedInputStream seems like the perfect way to do 
this, but it's a private method. I would only call it after I'm done writing to 
the ByteArrayOutputStream object. Is there any reason I shouldn't use this 
method? Could it be made public? Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

[kinow]

Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/285
  
>Does it really generates a site for the current branch?

It should. That is one step in the release process. Probably due to the 
site using another configuration (under the reporting tag).


https://github.com/osiegmar/commons-lang/blob/01a820275fc7bd66cb699dd081a432c7dde2645e/pom.xml#L711

Could you update the pull request with your original change duplicated in 
that portion, please?


---

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

[osiegmar]

Github user osiegmar commented on the issue:

https://github.com/apache/commons-lang/pull/285
  
I haven't checked the configuration of the maven site plugin in detail. 
Does it really generates a site for the current branch? I doubt that, as I've 
seen subversion commands in the config...

Anyway, to run checkstyle, just invoke `mvn clean checkstyle:check`.



---

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

[kinow]

Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/285
  
Not sure. Here's what I just tried.

```
$ git reset --hard
$ git status 
On branch pr/285

$ vim checkstyle.xml
$ # removed  line
$ mvn clean site
```

And then opening the Checkstyle report (via 
file:///home/.../commons-lang/target/site/index.html) there are no warnings or 
error in the checkstyle page.

Are you able to spot which step I am missing to reproduce it?


---

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

[osiegmar]

Github user osiegmar commented on the issue:

https://github.com/apache/commons-lang/pull/285
  
Removing the SuppressionFilter results in thousands of errors. Maybe you 
have a stale checkstyle cache file `target/cachefile`?


---

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

[kinow]

Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/285
  
Checked out pull request branch, built with the change, got no checkstyle 
errors. Then removed the suppression (without re-adding the previous value in 
pom.xml) and also got the same result, without any errors. Maybe it is aware 
that the suppression file must be ignored?

+1 for the change. Will wait for others to review :+1: 

Documentation about the SuppressionFilter module.

http://checkstyle.sourceforge.net/config_filters.html#SuppressionFilter

Thank you for your contribution @osiegmar 


---

[jira] [Commented] (LANG-1340) Add IBM Java 8 CI checks for Commons Lang

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158351#comment-16158351
 ] 

ASF GitHub Bot commented on LANG-1340:
--

Github user ameyjadiye closed the pull request at:

https://github.com/apache/commons-lang/pull/271


> Add IBM Java 8 CI checks for Commons Lang
> -
>
> Key: LANG-1340
> URL: https://issues.apache.org/jira/browse/LANG-1340
> Project: Commons Lang
>  Issue Type: Improvement
>Reporter: Amey Jadiye
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LANG-1340) Add IBM Java 8 CI checks for Commons Lang

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158350#comment-16158350
 ] 

ASF GitHub Bot commented on LANG-1340:
--

Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-lang/pull/271
  
No need of this since we will be following travis for its simplicity 


> Add IBM Java 8 CI checks for Commons Lang
> -
>
> Key: LANG-1340
> URL: https://issues.apache.org/jira/browse/LANG-1340
> Project: Commons Lang
>  Issue Type: Improvement
>Reporter: Amey Jadiye
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang issue #271: LANG-1340: Add ibmjdk8 support for travis-ci

[ameyjadiye]

Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-lang/pull/271
  
No need of this since we will be following travis for its simplicity 


---

[GitHub] commons-lang pull request #271: LANG-1340: Add ibmjdk8 support for travis-ci

[ameyjadiye]

Github user ameyjadiye closed the pull request at:

https://github.com/apache/commons-lang/pull/271


---

[jira] [Closed] (LANG-1340) Add IBM Java 8 CI checks for Commons Lang

[Amey Jadiye (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Jadiye closed LANG-1340.
-
Resolution: Unresolved

> Add IBM Java 8 CI checks for Commons Lang
> -
>
> Key: LANG-1340
> URL: https://issues.apache.org/jira/browse/LANG-1340
> Project: Commons Lang
>  Issue Type: Improvement
>Reporter: Amey Jadiye
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/285
  

[![Coverage 
Status](https://coveralls.io/builds/13181719/badge)](https://coveralls.io/builds/13181719)

Coverage remained the same at 95.194% when pulling 
**01a820275fc7bd66cb699dd081a432c7dde2645e on 
osiegmar:portable-checkstyle-config** into 
**cc94767e7eabdfcf9d1cab1d8d1d8556864394c6 on apache:master**.



---

[GitHub] commons-lang issue #284: remove redundant modifiers (support recent checksty...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/284
  

[![Coverage 
Status](https://coveralls.io/builds/13181677/badge)](https://coveralls.io/builds/13181677)

Coverage remained the same at 95.194% when pulling 
**ed12b7e727ffda8fcbae1a25f074986faa24a569 on 
osiegmar:remove-redundant-modifiers** into 
**cc94767e7eabdfcf9d1cab1d8d1d8556864394c6 on apache:master**.



---

[GitHub] commons-lang pull request #285: make checkstyle config more portable (no mav...

[osiegmar]

GitHub user osiegmar opened a pull request:

https://github.com/apache/commons-lang/pull/285

make checkstyle config more portable (no maven coupling)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/osiegmar/commons-lang 
portable-checkstyle-config

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #285


commit 01a820275fc7bd66cb699dd081a432c7dde2645e
Author: Oliver Siegmar 
Date:   2017-09-08T08:39:40Z

make checkstyle config more portable (no maven coupling)




---

[GitHub] commons-lang pull request #284: remove redundant modifiers (support recent c...

[osiegmar]

GitHub user osiegmar opened a pull request:

https://github.com/apache/commons-lang/pull/284

remove redundant modifiers (support recent checkstyle versions)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/osiegmar/commons-lang 
remove-redundant-modifiers

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #284


commit ed12b7e727ffda8fcbae1a25f074986faa24a569
Author: Oliver Siegmar 
Date:   2017-09-08T08:36:07Z

remove redundant modifiers (support recent checkstyle versions)




---