[jira] [Commented] (BEANUTILS-500) Upgrade commons-collections to 4

2017-09-09 Thread Melloware (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEANUTILS-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159988#comment-16159988
 ] 

Melloware commented on BEANUTILS-500:
-

After applying this patch to trunk I get 7 failing unit tests...

Failed tests:
  Jira61TestCase.testIssue_BEANUTILS_61_PropertyUtils_getProperty_Mapped:360 
mappedReadOnly Threw exception: java.lang.NoSuchMethodException: Unknown 
property 'mappedReadOnly'+ on bean class 'class 
org.apache.commons.beanutils.WrapDynaBean'
  Jira61TestCase.testIssue_BEANUTILS_61_PropertyUtils_setProperty_Mapped:387 
mappedReadOnly Threw exception: java.lang.NoSuchMethodException: Unknown 
property 'mappedReadOnly' on bean class 'class 
org.apache.commons.beanutils.WrapDynaBean'
  MemoryLeakTestCase.testConvertUtilsBean_converters_memoryLeak:389 
ConvertUtilsBean is holding a reference to the classLoader expected null, but 
was:
  MemoryLeakTestCase.testLocaleConvertUtilsBean_converters_memoryLeak:437 
LocaleConvertUtilsBean is holding a reference to the classLoader expected null, 
but was:
  MemoryLeakTestCase.testPropertyUtilsBean_descriptorsCache_memoryLeak:91 
PropertyUtilsBean is holding a reference to the classLoader expected null, but 
was:
  
MemoryLeakTestCase.testPropertyUtilsBean_mappedDescriptorsCache_memoryLeak:144 
PropertyUtilsBean is holding a reference to the classLoader expected null, but 
was:
  MemoryLeakTestCase.testWrapDynaClass_dynaClasses_memoryLeak:341 WrapDynaClass 
is holding a reference to the classLoader expected null, but 
was:

Tests run: 1291, Failures: 7, Errors: 0, Skipped: 3

> Upgrade commons-collections to 4
> 
>
> Key: BEANUTILS-500
> URL: https://issues.apache.org/jira/browse/BEANUTILS-500
> Project: Commons BeanUtils
>  Issue Type: Improvement
>  Components: Bean / Property Utils
>Affects Versions: 2.0
>Reporter: Dave Brosius
>Priority: Minor
> Fix For: 2.0
>
> Attachments: BEANUTILS-500.txt
>
>
> uptake commons-collections4.
> The main difference is the removal of 'FastHashMap', and replacement with 
> ConcurrentHashMap.
> There are a few breaking changes for deprecated methods that return a 
> FastHashMap, that are exposed.
> I made them package private, and undeprecated them, thus 2.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEANUTILS-475) beanutils could use commons-collections4 instead of commons-collections 3

2017-09-09 Thread Melloware (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEANUTILS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159984#comment-16159984
 ] 

Melloware commented on BEANUTILS-475:
-

Patch provided in https://issues.apache.org/jira/browse/BEANUTILS-500

> beanutils could use commons-collections4 instead of commons-collections 3
> -
>
> Key: BEANUTILS-475
> URL: https://issues.apache.org/jira/browse/BEANUTILS-475
> Project: Commons BeanUtils
>  Issue Type: Bug
>Reporter: Thibault Kruse
>Priority: Minor
> Fix For: 2.0
>
>
> just curious.
> collections4 seems to be out since 2013, maybe could be advertized more 
> inside apache



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang pull request #285: make checkstyle config more portable (no mav...

2017-09-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/285


---

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

2017-09-09 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/285
  
Thank you for updating the pull request.

Tested locally. Using the changes in the pull request I get the same result 
as we get when the settings are in the Maven settings.

Commenting out the suppression filter in the checkstyle configuration, the 
report in the web site now gives me **2828** errors. So the suppression filter 
is working indeed.

Looks good to me, merging it now.


---

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

2017-09-09 Thread osiegmar 
Github user osiegmar commented on the issue:

https://github.com/apache/commons-lang/pull/285
  
> Could you update the pull request with your original change duplicated in 
that portion, please?

Done. Thanks for pointing that out!



---

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

2017-09-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/285
  

[![Coverage 
Status](https://coveralls.io/builds/13196430/badge)](https://coveralls.io/builds/13196430)

Coverage remained the same at 95.201% when pulling 
**67830fe24964b0164d0212cbb4f018f15608ff37 on 
osiegmar:portable-checkstyle-config** into 
**fdf05fa29babe21e64f9a5b268dc8406d449d4f1 on apache:master**.



---

[GitHub] commons-lang issue #285: make checkstyle config more portable (no maven coup...

2017-09-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/285
  

[![Coverage 
Status](https://coveralls.io/builds/13196392/badge)](https://coveralls.io/builds/13196392)

Coverage decreased (-0.001%) to 95.2% when pulling 
**8b21045bac1d5148ea18650313a32bed3a0e167a on 
osiegmar:portable-checkstyle-config** into 
**fdf05fa29babe21e64f9a5b268dc8406d449d4f1 on apache:master**.



---